{"id":15910,"url":"https://patchwork.libcamera.org/api/patches/15910/?format=json","web_url":"https://patchwork.libcamera.org/patch/15910/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220516141022.96327-5-tomi.valkeinen@ideasonboard.com>","date":"2022-05-16T14:10:12","name":"[libcamera-devel,04/14] py: unittests: fix selector fd use","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5061c8ec01915fdaf1f8755c7b70770e5a94ba55","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15910/mbox/","series":[{"id":3113,"url":"https://patchwork.libcamera.org/api/series/3113/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3113","date":"2022-05-16T14:10:08","name":"Misc Python bindings patches","version":1,"mbox":"https://patchwork.libcamera.org/series/3113/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15910/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15910/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3CAF0C326C\n\tfor ;\n\tMon, 16 May 2022 14:10:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8FF796566B;\n\tMon, 16 May 2022 16:10:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C6E3B61FB8\n\tfor ;\n\tMon, 16 May 2022 16:10:49 +0200 (CEST)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A1F659D;\n\tMon, 16 May 2022 16:10:49 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652710255;\n\tbh=o2UDMjgVn8X2IEOwsdsfRezjLPYp3RRR5wcuF29R+tQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=EjShfc5ppFmJbnKThM4ndl7h1WgSJG80fBg6Hj6r4djEZeqts/743CmaguEtSHPCw\n\t+9qOLjBcWAO/teJl/3fsF25lUMhgrh0PgL9G+8Ssiz/UV51G9ti6rxkOTjERPF7sm/\n\t3U6J5MKSQ+hHYMTV7t2zXuHIRDAZlKHUIqbBRA37Y87Lt0FdsXrvtv6abzxgLJ+QYO\n\toPudYsjP6C17SjxIjaRismqzOw6tDCnGRoBUjg5Q/zZuBz7+AqckHs0pxr7jgBaYme\n\tn36U9vh3+HzfTbN6GJNqpiJ6ZtWfhLPiOhHWCyQNkp13Tza5R2IhAIwQTI929UfLaq\n\t/mRPTj82j3nQg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652710249;\n\tbh=o2UDMjgVn8X2IEOwsdsfRezjLPYp3RRR5wcuF29R+tQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QrNIjQ7+QEiCsCWspbKL44ZXl53XE0Qo8YbLQ/N6qxvVZqWLZSpxKFf1VfeepEViG\n\t2nhpdXWrtajkbV4LdD7M8pRT40GjYqtg7vNruHGgfdxDcNUI4r72CErVoGw1afgQ38\n\tI0YFyBWjBcgSf76d47qDSWBgC1197vVJUFyILaHo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QrNIjQ7+\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Mon, 16 May 2022 17:10:12 +0300","Message-Id":"<20220516141022.96327-5-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>","References":"<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 04/14] py: unittests: fix selector fd use","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"pyright complains about passing fileobj to os.read. Indeed, the\nparameter should be an int, but I guess fileobj gets automatically\nconverted. In any case, using the fd is better.\n\nSigned-off-by: Tomi Valkeinen \n---\n test/py/unittests.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/test/py/unittests.py b/test/py/unittests.py\nindex cbc00ff3..9326358d 100755\n--- a/test/py/unittests.py\n+++ b/test/py/unittests.py\n@@ -262,8 +262,8 @@ class SimpleCaptureMethods(CameraTesterBase):\n running = True\n while running:\n events = sel.select()\n- for key, mask in events:\n- os.read(key.fileobj, 8)\n+ for key, _ in events:\n+ os.read(key.fd, 8)\n \n ready_reqs = cm.get_ready_requests()\n \n","prefixes":["libcamera-devel","04/14"]}