[{"id":22963,"web_url":"https://patchwork.libcamera.org/comment/22963/","msgid":"","date":"2022-05-17T08:16:27","subject":"Re: [libcamera-devel] [PATCH 03/14] py: pymain: fix indent","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Mon, May 16, 2022 at 05:10:11PM +0300, Tomi Valkeinen wrote:\n> Fix two minor mis-indents.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/libcamera/pymain.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/py/libcamera/pymain.cpp b/src/py/libcamera/pymain.cpp\n> index fb89975c..af22205e 100644\n> --- a/src/py/libcamera/pymain.cpp\n> +++ b/src/py/libcamera/pymain.cpp\n> @@ -394,7 +394,7 @@ PYBIND11_MODULE(_libcamera, m)\n> \tpyStreamConfiguration\n> \t\t.def(\"__str__\", &StreamConfiguration::toString)\n> \t\t.def_property_readonly(\"stream\", &StreamConfiguration::stream,\n> -\t\t py::return_value_policy::reference_internal)\n> +\t\t\t\t py::return_value_policy::reference_internal)\n> \t\t.def_property(\n> \t\t\t\"size\",\n> \t\t\t[](StreamConfiguration &self) {\n> @@ -416,7 +416,7 @@ PYBIND11_MODULE(_libcamera, m)\n> \t\t.def_readwrite(\"frame_size\", &StreamConfiguration::frameSize)\n> \t\t.def_readwrite(\"buffer_count\", &StreamConfiguration::bufferCount)\n> \t\t.def_property_readonly(\"formats\", &StreamConfiguration::formats,\n> -\t\t py::return_value_policy::reference_internal)\n> +\t\t\t\t py::return_value_policy::reference_internal)\n> \t\t.def_readwrite(\"color_space\", &StreamConfiguration::colorSpace);\n> \n> \tpyStreamFormats","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3D590C3256\n\tfor ;\n\tTue, 17 May 2022 08:16:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F083F6565A;\n\tTue, 17 May 2022 10:16:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E10B760420\n\tfor ;\n\tTue, 17 May 2022 10:16:34 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 635D348F;\n\tTue, 17 May 2022 10:16:34 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652775395;\n\tbh=GOFm/viAn4lQWD0I2VVUhTj/HKfKWqy5tqio7U8j9Gg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=f3OjhckqJ1OPHr/tBSxemf48AWcj2fHY6HKfW5hxJIkelAdr9BVxUqRSgxdQfNeIN\n\te6bjuQ2gIk+7gGki+JXBXlF0OyLHriM8kx0VIA9UWeMFRq/ZzAQH7Z4T3P6YuWQGB+\n\tuoaGMGtO27ODB8hwTbBurhWgh2p03VVn+aWkP/EcfYx3CVUFM1yYqKzBuEnLG1y47J\n\tsPxQBAGz9zxHdraEVPUm2xihdupUKFZYtMFVIPSAle7fvTo5uZo0mEEogih7y59Xn9\n\t95spxKgpTjh9A2rIjdo/PAw0uoMny+p2F8oqClJIAtqS2X1T6HjFBWsg+/PAn5Wwd3\n\tGrP6Y5lRM3Jyg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652775394;\n\tbh=GOFm/viAn4lQWD0I2VVUhTj/HKfKWqy5tqio7U8j9Gg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PN00hFYzrVcUebznZ+8l8/KR3xM8F44AzjsfEuMfMkjS4KpCZQQ7LlrgwvJ3iH9/Z\n\tkSQVx7bcQyVz/U66DLe5z/f6SAF0BvruUwgZyibK4xs05z73e3SqVbxLRY2J33SVYd\n\tpAk8IQhBoRvMoTUjp6e/lQyNb6xU2XBI1GR1H/ps="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PN00hFYz\"; dkim-atps=neutral","Date":"Tue, 17 May 2022 11:16:27 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>\n\t<20220516141022.96327-4-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220516141022.96327-4-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 03/14] py: pymain: fix indent","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]