[{"id":22961,"web_url":"https://patchwork.libcamera.org/comment/22961/","msgid":"","date":"2022-05-17T08:10:12","subject":"Re: [libcamera-devel] [PATCH 01/14] py: meson: fix comment about\n\tstubs","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Mon, May 16, 2022 at 05:10:09PM +0300, Tomi Valkeinen wrote:\n> At least pyright seems to be able to use the stubs from the\n> libcamera-stubs directory, so no need to copy the generated files.\n> Adjust the comment accordingly.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/libcamera/meson.build | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index 0cd7c75b..38f619d0 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -63,4 +63,3 @@ install_data(['__init__.py'], install_dir : destdir)\n> # \\todo Generate stubs when building. See https://peps.python.org/pep-0484/#stub-files\n> # Note: Depends on pybind11-stubgen. To generate pylibcamera stubs:\n> # $ PYTHONPATH=build/src/py pybind11-stubgen --no-setup-py -o build/src/py libcamera\n> -# $ mv build/src/py/libcamera-stubs/* build/src/py/libcamera/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 422EAC0F2A\n\tfor ;\n\tTue, 17 May 2022 08:10:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 869286565A;\n\tTue, 17 May 2022 10:10:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B10D60420\n\tfor ;\n\tTue, 17 May 2022 10:10:19 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 901A648F;\n\tTue, 17 May 2022 10:10:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652775020;\n\tbh=R50qRutriX0n9tf5QPZNQAZftOT9he7IbRBfY2xFt00=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=GUyY+RTdVPis6jBYaU7DxsJKBp+GpcJqCxgfbtvvBw9EEbj3Sl/Fuur7hhrxX02E6\n\tP+brcTUDneig2Zgg3TMWqG+5FMKJRYbhdCpnQpLf8qYhWWLSfwT50ZJ4va2xqfMdNx\n\tdfylJIoryg9exeUNmWWrNwo+aeQUsMVjiNv9CFQ28BCQpJbH897vKwyJT/Yg0TNHFE\n\tTEOfmA55N/ggOlV18qaAZca63oF47HSDO7XwBulegj4YUvItBUWiwyEh9Atb4jzLqK\n\tMd3lvnbLvi0JPeGL86dQHC8FW/ZOWtjdLkqVUXEBd+PYdqTA5mZf7fh0+VdzHTPp1Z\n\tfo2VEurzA0u4Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652775018;\n\tbh=R50qRutriX0n9tf5QPZNQAZftOT9he7IbRBfY2xFt00=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VbmDogmWLqN96/MkfCyJVSZrsBzzkrkuPSCJj7c8RcnvkZOiyL4iRzx5a1keMOHGI\n\t3EEY5pvN9AmmhMfcB/r6dLqsaN7QJk2pkNmUTU5jYd/FFz5ja6TAqk1G+t+TlT9F9g\n\tfSk69wbDZzKoH0cEjtBj2Qi9KjXcT4svhAEXvC1Y="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VbmDogmW\"; dkim-atps=neutral","Date":"Tue, 17 May 2022 11:10:12 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>\n\t<20220516141022.96327-2-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220516141022.96327-2-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 01/14] py: meson: fix comment about\n\tstubs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]