{"id":15893,"url":"https://patchwork.libcamera.org/api/patches/15893/?format=json","web_url":"https://patchwork.libcamera.org/patch/15893/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220511092848.24067-1-tomi.valkeinen@ideasonboard.com>","date":"2022-05-11T09:28:48","name":"[libcamera-devel,v2] py: meson: use files() for custom_target input files","commit_ref":"ed3a440177bef2be8aa079f6915939be7a223125","pull_url":null,"state":"accepted","archived":false,"hash":"319d5fb4647010eb0ccc01afb263d542994d45e9","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15893/mbox/","series":[{"id":3109,"url":"https://patchwork.libcamera.org/api/series/3109/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3109","date":"2022-05-11T09:28:48","name":"[libcamera-devel,v2] py: meson: use files() for custom_target input files","version":2,"mbox":"https://patchwork.libcamera.org/series/3109/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15893/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15893/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BEFAAC0F2A\n\tfor ;\n\tWed, 11 May 2022 09:28:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1597E65659;\n\tWed, 11 May 2022 11:28:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA4806150F\n\tfor ;\n\tWed, 11 May 2022 11:28:55 +0200 (CEST)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 04124824;\n\tWed, 11 May 2022 11:28:54 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652261337;\n\tbh=oNGCLHgnl/f8hSG6NOhfcLzbxKYOM3o/h4XfqB+/ISE=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=G4phPpSVAJqxZYpT4rYVSbUdEqQntftnWY74F73oSqbuYkbdKFBrNmP3go40JzXn4\n\tL/mksJrrodDRZiSyi461pqOR+hVIris7MIm3pTssO5pCFZQeod8raAVYvlyuNpSHJ/\n\t404uGvOjYAOUPJ7KoX1ECn5MLVyuIsKRJ6Edqbyot+RjX4SoZDqJc4iEqbABOhRMiz\n\tH7ax2WYbs4NfaYrXNM05RllgtPPKbwdNZG8GSF3F+qZ68I/DjJQa2L89CgJF4vAo1J\n\twvLq/wKgp/qhOuHHmHW5Z074jr1oewz1hlyLoS7ITrX9oq4y9Iuy5TvmjaOg1SgGzR\n\tSM44BcxPPtYtQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652261335;\n\tbh=oNGCLHgnl/f8hSG6NOhfcLzbxKYOM3o/h4XfqB+/ISE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=keyX3ribh9VjAYItZiXgPdGYpfN0GugDQJXEGscT3mPqrHWkegg3ZdxBJVrWMPpM0\n\tx0aqtvzwdlrLrhg9/I2/yVQtU+PfekaIc2fgyPjbIKSNmwF+w7spsCI2sYdDo3VNHZ\n\t8yL60adSIssDDcnU8A+0T3gylcRTa+axh9l0plS4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"keyX3rib\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\tLaurent Pinchart ","Date":"Wed, 11 May 2022 12:28:48 +0300","Message-Id":"<20220511092848.24067-1-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2] py: meson: use files() for\n\tcustom_target input files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use files() for the input files for the custom_target(). I believe the\ncurrent code works, but perhaps it is safer to use files() here.\n\nSigned-off-by: Tomi Valkeinen \nReviewed-by: Laurent Pinchart \n---\n\nv2: Pass an array to files() as used elsewhere\n\n src/py/libcamera/meson.build | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\nindex 0cd7c75b..c169b0c8 100644\n--- a/src/py/libcamera/meson.build\n+++ b/src/py/libcamera/meson.build\n@@ -17,10 +17,10 @@ pycamera_sources = files([\n 'pymain.cpp',\n ])\n \n-gen_input_files = [\n- meson.project_source_root() / 'src' / 'libcamera' / 'control_ids.yaml',\n+gen_input_files = files([\n+ '../../libcamera/control_ids.yaml',\n 'pyenums_generated.cpp.in',\n-]\n+])\n \n gen_py_control_enums = files('gen-py-control-enums.py')\n \n","prefixes":["libcamera-devel","v2"]}