[{"id":22949,"web_url":"https://patchwork.libcamera.org/comment/22949/","msgid":"","date":"2022-05-11T09:06:05","subject":"Re: [libcamera-devel] [PATCH] py: meson: use files() for\n\tcustom_target input files","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Wed, May 11, 2022 at 11:23:46AM +0300, Tomi Valkeinen wrote:\n> Use files() for the input files for the custom_target(). I believe the\n> current code works, but perhaps it is safer to use files() here.\n\nAnd I think it's more in line with the meson recommendations.\n\n> Signed-off-by: Tomi Valkeinen \n> ---\n> src/py/libcamera/meson.build | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index 0cd7c75b..3f7ddf1d 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -17,10 +17,10 @@ pycamera_sources = files([\n> 'pymain.cpp',\n> ])\n> \n> -gen_input_files = [\n> - meson.project_source_root() / 'src' / 'libcamera' / 'control_ids.yaml',\n> +gen_input_files = files(\n> + '../../libcamera/control_ids.yaml',\n> 'pyenums_generated.cpp.in',\n> -]\n> +)\n\nInteresting, I didn't know files() could take a list of files, as\nopposed to an array. We always write\n\ngen_input_files = files([\n '../../libcamera/control_ids.yaml',\n 'pyenums_generated.cpp.in',\n])\n\nI'd do the same here for consistency, and remove the [] in a global\npatch separately if desired. Is that OK with you ?\n\nReviewed-by: Laurent Pinchart \n\n> \n> gen_py_control_enums = files('gen-py-control-enums.py')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16956C0F2A\n\tfor ;\n\tWed, 11 May 2022 09:06:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9100665657;\n\tWed, 11 May 2022 11:06:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C25E6150F\n\tfor ;\n\tWed, 11 May 2022 11:06:13 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 336B7824;\n\tWed, 11 May 2022 11:06:12 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652259974;\n\tbh=QOk0fX3IPAqhdaaby8rFDDoEqM37EljgtBtfaagU2/k=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=NJ5GPHcHxXS8cU3oLlKK5AoKisZbtFhtgJo100HcTxoa0mMbJnv+YjBGUhiNNHTa1\n\tx2phe8ty2/zEeZ0pMQl68ce2ZVhBcFyzAxlOLg1wPLPuNOckoHztWd1aKi7Xwej4zw\n\tko8b/Y3NwDgMHWzye/xav8D71Zj/nn2I06dr7s/LmtQX0BaNE+90Su8n77q/rXcBmG\n\tWbCxu/tO1bwHe5QJdG42L8G87NrcUgKZbbEPXXaDX/TcSV/oDe0m+6hrVvxCtkv9RG\n\tk+52o8V6l0/yLeFWPgozDAdawoZ5P1Q2rM3+2XYIovz3mj1egNJ/ku3ib9TQCxTTvd\n\tCuj4Os9jEBBkg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652259972;\n\tbh=QOk0fX3IPAqhdaaby8rFDDoEqM37EljgtBtfaagU2/k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MjDk806KIP1ReBdeXCDdlTrwgqXhPoHJANizT05Dzne1SLzCR1rFcNmolBlnUsBME\n\t0aC5YVpxJ/KtDN6pZGwyPlknFjEIH+qmysWv/3V4FM1v00mmanZ1D/CMxXBWYCfMK1\n\tjGBaWzQrc/19+igKmX91yuKMY7cQwwKBWAbc+46M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MjDk806K\"; dkim-atps=neutral","Date":"Wed, 11 May 2022 12:06:05 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220511082346.18972-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220511082346.18972-1-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] py: meson: use files() for\n\tcustom_target input files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22950,"web_url":"https://patchwork.libcamera.org/comment/22950/","msgid":"<9a35b87e-730b-7e86-4220-6ed9ce563526@ideasonboard.com>","date":"2022-05-11T09:25:02","subject":"Re: [libcamera-devel] [PATCH] py: meson: use files() for\n\tcustom_target input files","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"content":"On 11/05/2022 12:06, Laurent Pinchart wrote:\n> Hi Tomi,\n> \n> Thank you for the patch.\n> \n> On Wed, May 11, 2022 at 11:23:46AM +0300, Tomi Valkeinen wrote:\n>> Use files() for the input files for the custom_target(). I believe the\n>> current code works, but perhaps it is safer to use files() here.\n> \n> And I think it's more in line with the meson recommendations.\n> \n>> Signed-off-by: Tomi Valkeinen \n>> ---\n>> src/py/libcamera/meson.build | 6 +++---\n>> 1 file changed, 3 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n>> index 0cd7c75b..3f7ddf1d 100644\n>> --- a/src/py/libcamera/meson.build\n>> +++ b/src/py/libcamera/meson.build\n>> @@ -17,10 +17,10 @@ pycamera_sources = files([\n>> 'pymain.cpp',\n>> ])\n>> \n>> -gen_input_files = [\n>> - meson.project_source_root() / 'src' / 'libcamera' / 'control_ids.yaml',\n>> +gen_input_files = files(\n>> + '../../libcamera/control_ids.yaml',\n>> 'pyenums_generated.cpp.in',\n>> -]\n>> +)\n> \n> Interesting, I didn't know files() could take a list of files, as\n> opposed to an array. We always write\n> \n> gen_input_files = files([\n> '../../libcamera/control_ids.yaml',\n> 'pyenums_generated.cpp.in',\n> ])\n> \n> I'd do the same here for consistency, and remove the [] in a global\n> patch separately if desired. Is that OK with you ?\n\nIt is used without an array in include/libcamera/meson.build and \nsrc/libcamera/meson.build. I think I used one of those as a reference, \nand didn't even notice the array use elsewhere.\n\nMeson docs do not even mention that files() can take an array. But I can \nadd the array, it's used in that way also a bit above when defining the \nsource files.\n\nAs a side note, using files() feels a bit silly to me. Afaics the point \nof files() is to create a file object when you want to use those files \nin some other meson build file, i.e. you want to \"export\" the file to \nother meson files. Here the list of files is \"private\" to this \nparticular meson build file.\n\nUsing files() for local source files does not provide any value that I \ncan see.\n\nAnd if we use files() for the sources, shouldn't we also use files() for \nthe output for the custom_target()?\n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18E6EC3256\n\tfor ;\n\tWed, 11 May 2022 09:25:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56C1A65657;\n\tWed, 11 May 2022 11:25:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8BAA66150F\n\tfor ;\n\tWed, 11 May 2022 11:25:06 +0200 (CEST)","from [192.168.1.111] (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE5CF824;\n\tWed, 11 May 2022 11:25:05 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652261108;\n\tbh=eNpd7oTA+yCq8B30m6/7qiGKbO2zNRZsWM0LTTObUWw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ivXb5Zmd1ECKVRsOjuBhutN1ZWQTaPX1VGI/lOunCVzyLp1j55ukaoumPlfEJ/yTL\n\tDylD0oLE6nNP5k9GLg9I1NYCoSs/WC2EZIPtG/VhrccIqA1ySP7K9g03zStuz0HIaC\n\tnKi7STSSwfPjvX6Pj4C7IRnOXsuKpgOxjatx7uyluTDq8Gs7Fd/7oxE9cwII8Z8zZ7\n\t+l+XQ5yYk0bs4lxKLSTkKCOpC3SgU/vaXbPFFxkXdtQgXTZYNg79ukB58UkY0PCNRi\n\tbF+GKyX5OMx4NUViWOCQGzODdvXnCSkglvnDoA6QKOhj9UeQh20LEyojsl35SFbGre\n\t2NNIXyTYN/eYw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652261106;\n\tbh=eNpd7oTA+yCq8B30m6/7qiGKbO2zNRZsWM0LTTObUWw=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=bmY+lbELWOcRFNgUQioy2HoRVOsTGi0z/+H8UWQ19zqhigUy18dT+0OrP5wflXgxE\n\tz7xDyw3Qc7DvFCbX4WFj7xEj5bOE/WLS5ADkP88IbAusOR6Z0p139Hs+WKttK7E9ve\n\twfU3+1Z5yFIMlQSNcZqd/8s6M31dNZlk7dba2ie0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"bmY+lbEL\"; dkim-atps=neutral","Message-ID":"<9a35b87e-730b-7e86-4220-6ed9ce563526@ideasonboard.com>","Date":"Wed, 11 May 2022 12:25:02 +0300","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.8.0","Content-Language":"en-US","To":"Laurent Pinchart ","References":"<20220511082346.18972-1-tomi.valkeinen@ideasonboard.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] py: meson: use files() for\n\tcustom_target input files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22951,"web_url":"https://patchwork.libcamera.org/comment/22951/","msgid":"","date":"2022-05-11T09:40:24","subject":"Re: [libcamera-devel] [PATCH] py: meson: use files() for\n\tcustom_target input files","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nOn Wed, May 11, 2022 at 12:25:02PM +0300, Tomi Valkeinen wrote:\n> On 11/05/2022 12:06, Laurent Pinchart wrote:\n> > On Wed, May 11, 2022 at 11:23:46AM +0300, Tomi Valkeinen wrote:\n> >> Use files() for the input files for the custom_target(). I believe the\n> >> current code works, but perhaps it is safer to use files() here.\n> > \n> > And I think it's more in line with the meson recommendations.\n> > \n> >> Signed-off-by: Tomi Valkeinen \n> >> ---\n> >> src/py/libcamera/meson.build | 6 +++---\n> >> 1 file changed, 3 insertions(+), 3 deletions(-)\n> >>\n> >> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> >> index 0cd7c75b..3f7ddf1d 100644\n> >> --- a/src/py/libcamera/meson.build\n> >> +++ b/src/py/libcamera/meson.build\n> >> @@ -17,10 +17,10 @@ pycamera_sources = files([\n> >> 'pymain.cpp',\n> >> ])\n> >> \n> >> -gen_input_files = [\n> >> - meson.project_source_root() / 'src' / 'libcamera' / 'control_ids.yaml',\n> >> +gen_input_files = files(\n> >> + '../../libcamera/control_ids.yaml',\n> >> 'pyenums_generated.cpp.in',\n> >> -]\n> >> +)\n> > \n> > Interesting, I didn't know files() could take a list of files, as\n> > opposed to an array. We always write\n> > \n> > gen_input_files = files([\n> > '../../libcamera/control_ids.yaml',\n> > 'pyenums_generated.cpp.in',\n> > ])\n> > \n> > I'd do the same here for consistency, and remove the [] in a global\n> > patch separately if desired. Is that OK with you ?\n> \n> It is used without an array in include/libcamera/meson.build and \n> src/libcamera/meson.build. I think I used one of those as a reference, \n> and didn't even notice the array use elsewhere.\n\nAh OK I haven't noticed that. We can mass-patch all the meson.build\nfiles if desired.\n\n> Meson docs do not even mention that files() can take an array. But I can \n> add the array, it's used in that way also a bit above when defining the \n> source files.\n> \n> As a side note, using files() feels a bit silly to me. Afaics the point \n> of files() is to create a file object when you want to use those files \n> in some other meson build file, i.e. you want to \"export\" the file to \n> other meson files. Here the list of files is \"private\" to this \n> particular meson build file.\n> \n> Using files() for local source files does not provide any value that I \n> can see.\n> \n> And if we use files() for the sources, shouldn't we also use files() for \n> the output for the custom_target()?\n\nMy understanding is that files() help doing the right thing for input\nfiles as it removes the need to think about source vs. build\ndirectories. For outputs that won't work, your file object will\nreference a location in the source directory as far as I can tell, while\nthe output is meant to be written to the build directory. I'm not even\nsure if the custom_target() function accepts a file object for the\noutput.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52DCEC3256\n\tfor ;\n\tWed, 11 May 2022 09:40:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9CA8065659;\n\tWed, 11 May 2022 11:40:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 676C36150F\n\tfor ;\n\tWed, 11 May 2022 11:40:31 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A6C6E824;\n\tWed, 11 May 2022 11:40:30 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652262032;\n\tbh=i7kAPWAo8I+CJ7CFzwB8tE3Woz5jZGLkUYetmSsTbJU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vJbXGE2GabXXRAH6D1nJifGjitnRee7fiBqg2T4rEggFu60bZQHOWezBX0JfYc7IU\n\ttZ5a9kJrEpKowA1kr8Hzj1/q8GyxNdSuMxpvDGcom+xIkJmZp3RhYdJcOBX3+wKmlt\n\tlIKKNpKCK7JHQvlO/kZR6yo9a8eA1FzLxjDiUUm3TY//lVddED7O+8d+3nSN1nAwcz\n\tmEfUUcMtV/gy49Hb/NLQo0ikP72xNdQo/j38EvP4lIXoqhKIa1t7dXe0itv59jhZ9K\n\tXWZlPxhe8WbxD0hmksJMrZKq3VB38XGyv8uYEDvls+qjbbvqsxFoGoNqdwcXLgOBu6\n\ttGdZCOAfQq5uA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652262030;\n\tbh=i7kAPWAo8I+CJ7CFzwB8tE3Woz5jZGLkUYetmSsTbJU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bASQRpmzV49AHkzfKZHtW6lmdBnnSCrjTb/TiZeCGAfpUTvIefaJbsMRvkusOendn\n\tyGFJWvLzzn7xjX25BquZLRdCvfy8MgcVk+QPVdRvZlVKPqaYyHUK/Esgco5y7Pbgld\n\tnsPEvjSytwuh0JSVqREvuIyH7MmKHROn2aLjuQ6Y="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"bASQRpmz\"; dkim-atps=neutral","Date":"Wed, 11 May 2022 12:40:24 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220511082346.18972-1-tomi.valkeinen@ideasonboard.com>\n\t\n\t<9a35b87e-730b-7e86-4220-6ed9ce563526@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<9a35b87e-730b-7e86-4220-6ed9ce563526@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] py: meson: use files() for\n\tcustom_target input files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]