{"id":15891,"url":"https://patchwork.libcamera.org/api/patches/15891/?format=json","web_url":"https://patchwork.libcamera.org/patch/15891/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220510152107.610191-1-kieran.bingham@ideasonboard.com>","date":"2022-05-10T15:21:07","name":"[libcamera-devel] py: Fix gen-py-control-enums.py reference","commit_ref":"226563607ea888c0af49bf3cdc7b3654d6a50089","pull_url":null,"state":"accepted","archived":false,"hash":"db16e15b639d81727c3b7b2621f9c9da698f3733","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15891/mbox/","series":[{"id":3107,"url":"https://patchwork.libcamera.org/api/series/3107/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3107","date":"2022-05-10T15:21:07","name":"[libcamera-devel] py: Fix gen-py-control-enums.py reference","version":1,"mbox":"https://patchwork.libcamera.org/series/3107/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15891/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15891/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B4C3C0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 May 2022 15:20:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4EEDE65644;\n\tTue, 10 May 2022 17:20:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7CA2565643\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 May 2022 17:20:51 +0200 (CEST)","from Q.ksquared.org.uk.beta.tailscale.net (unknown\n\t[178.237.134.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E3E0FB60;\n\tTue, 10 May 2022 17:20:50 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652196053;\n\tbh=fGW9/Aota6yAIbCDUREzw832s3s32H+mmiPLm2ILMV8=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=K5nEqkC55ARzHwZMZVuB8YokKXk8eEAngHuhTCN2vlVmLEqmU24YFRGJNp9pKEZtM\n\tZIMT7i/Hb3m5JgrmSZlnXCAJpo1NwfPLvtyie5I4lnmwKGmzvc9sNqIDWLRBP/4ds1\n\tGFwtvMqxA5NeuezIiEaO2odndMRTiAt6dv8TLBc7Inu44RgRCTBot5V9R4Fx0hRNHo\n\tgut/4m4xJU/GsdX8AXaXZqJGhvbKh4EaPBsbar2DuBqCD3hoVtLQO8o8MXQZEDekss\n\tig4WY0Pb2l+OiAp3P633pQ/pIAWeUcKKpAUqtpW/Eguz6d1MVC6n2dA/MsXKCxeKg3\n\tYO/632kTr+2eA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652196051;\n\tbh=fGW9/Aota6yAIbCDUREzw832s3s32H+mmiPLm2ILMV8=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=DUJ5XC3saWL+rpIXC/iE9GyepsnbmkT7CdZnjsR2E8mBJJwdGqhEbsycnffGt+iEQ\n\tfJnMf0huLCBvmmGykdd+PRY1u+8L0FuShedQoy4s8lNh9WDhzLs6rV9MPWIKrK1Gg1\n\tdTJm8yKHtI+tinTn3D0ODKMm4V7wAHcb7j25CD90="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DUJ5XC3s\"; dkim-atps=neutral","To":"libcamera devel <libcamera-devel@lists.libcamera.org>","Date":"Tue, 10 May 2022 17:21:07 +0200","Message-Id":"<20220510152107.610191-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] py: Fix gen-py-control-enums.py reference","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Scripts should be referenced using the meson files() directive to ensure\nthe location is correctly identified with the relevant paths. This\nprevents compilation failures if the working directory does not match\nthe source tree.\n\nFixes: 6e92cb9dc49e (\"py: Generate control enums from yaml\")\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\nIt seems in my testing, that this occurs on meson 57 and below, but\nwasn't reproduced on meson 58. This fixes the issue anyway, and ensures\nwe are consistent in our usage of scripts internally.\n---\n src/py/libcamera/meson.build | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\nindex 842db1ed3ddd..0cd7c75bb86c 100644\n--- a/src/py/libcamera/meson.build\n+++ b/src/py/libcamera/meson.build\n@@ -22,10 +22,12 @@ gen_input_files = [\n     'pyenums_generated.cpp.in',\n ]\n \n+gen_py_control_enums = files('gen-py-control-enums.py')\n+\n generated_sources = custom_target('py_gen_controls',\n                                   input : gen_input_files,\n                                   output : ['pyenums_generated.cpp'],\n-                                  command : ['gen-py-control-enums.py', '-o', '@OUTPUT@', '@INPUT@'])\n+                                  command : [gen_py_control_enums, '-o', '@OUTPUT@', '@INPUT@'])\n \n pycamera_sources += generated_sources\n \n","prefixes":["libcamera-devel"]}