{"id":15875,"url":"https://patchwork.libcamera.org/api/patches/15875/?format=json","web_url":"https://patchwork.libcamera.org/patch/15875/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220510115147.19360-36-laurent.pinchart@ideasonboard.com>","date":"2022-05-10T11:51:32","name":"[libcamera-devel,35/50] staging: media: imx: imx7-media-csi: Drop IC support from imx7_csi_try_colorimetry()","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"88975968386ef4765c00882809ed6b77ee4e5340","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15875/mbox/","series":[{"id":3106,"url":"https://patchwork.libcamera.org/api/series/3106/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3106","date":"2022-05-10T11:50:57","name":"staging: media: imx: Prepare destaging of imx7-media-csi","version":1,"mbox":"https://patchwork.libcamera.org/series/3106/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15875/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15875/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65235C3256\n\tfor ;\n\tTue, 10 May 2022 11:52:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EBC4365656;\n\tTue, 10 May 2022 13:52:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1D4065694\n\tfor ;\n\tTue, 10 May 2022 13:52:26 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 16269824;\n\tTue, 10 May 2022 13:52:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652183556;\n\tbh=d3QEcEuWK6z6oOc1biYGe9+5VTFDc2s4Kpf0jtO3sqk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2WdwD/YX9bkY6KmHG6FFpv4EjTjClarLTGOjgCkQZQnNooVH2H5kb8B6cqPSc3DoG\n\ttCj1yUvwbJAFCaOm3vLvg7LT2zN2ADrgmHgOM968GTCal0QLp7FsMHqFiggCY7KaLQ\n\tTObt/K/i5PBSxdOG1ys1V9fGLVlZ8m0BFWOMX4jriAAwG4u/7Kjr6u4rH6mAYxyc+6\n\t6CfvRhxoQwfNjDHlsrBjuAETqzevD54jnEP+od0oJigeVx1yymawKXIZmPvI25wuxs\n\tRxg6m+lkCuHZ2WlpcXmakr3WjDNPPkIGlca7r+ddYcGkP7ChEiy1Q90l8FyT0+bmXA\n\tqrUtFik+LIPQA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652183546;\n\tbh=d3QEcEuWK6z6oOc1biYGe9+5VTFDc2s4Kpf0jtO3sqk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=BFlvTIi1siMuhiKaocaeuj7uU0fbSPJy0kI41rmfTtqu5xnT+eTbT/8F7YvtkEEbb\n\tuM1AmVxakjmJ7QA3437wut9F3REFWxzPX3jDDDLpFg2AIfSz983SS5X1bCBPJAABPp\n\tR9DimFqgGNbNm0OkG7GFwbto9N4/wgRRdLuX4D1U="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"BFlvTIi1\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 10 May 2022 14:51:32 +0300","Message-Id":"<20220510115147.19360-36-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>","References":"<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 35/50] staging: media: imx:\n\timx7-media-csi: Drop IC support from imx7_csi_try_colorimetry()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Martin Kepplinger , kernel@pengutronix.de,\n\tDorota Czaplejewicz ,\n\tAlexander Stein ,\n\tRui Miguel Silva ,\n\tPhilipp Zabel , \n\tSteve Longerbeam ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The imx7_csi_try_colorimetry() function supports the unrelated image\nconverter hardware as it originates from shared helpers. Drop that.\n\nSigned-off-by: Laurent Pinchart \n---\n drivers/staging/media/imx/imx7-media-csi.c | 22 +++++-----------------\n 1 file changed, 5 insertions(+), 17 deletions(-)","diff":"diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c\nindex b8ce4fd7c55d..c8ff259452b1 100644\n--- a/drivers/staging/media/imx/imx7-media-csi.c\n+++ b/drivers/staging/media/imx/imx7-media-csi.c\n@@ -2031,13 +2031,8 @@ static int imx7_csi_get_fmt(struct v4l2_subdev *sd,\n * parameters based on the colorspace if they are uninitialized.\n *\n * tryfmt->code must be set on entry.\n- *\n- * If this format is destined to be routed through the Image Converter,\n- * Y`CbCr encoding must be fixed. The IC supports only BT.601 Y`CbCr\n- * or Rec.709 Y`CbCr encoding.\n */\n-static void imx7_csi_try_colorimetry(struct v4l2_mbus_framefmt *tryfmt,\n-\t\t\t\t bool ic_route)\n+static void imx7_csi_try_colorimetry(struct v4l2_mbus_framefmt *tryfmt)\n {\n \tconst struct imx7_csi_pixfmt *cc;\n \tbool is_rgb = false;\n@@ -2069,16 +2064,9 @@ static void imx7_csi_try_colorimetry(struct v4l2_mbus_framefmt *tryfmt,\n \t\ttryfmt->xfer_func =\n \t\t\tV4L2_MAP_XFER_FUNC_DEFAULT(tryfmt->colorspace);\n \n-\tif (ic_route) {\n-\t\tif (tryfmt->ycbcr_enc != V4L2_YCBCR_ENC_601 &&\n-\t\t tryfmt->ycbcr_enc != V4L2_YCBCR_ENC_709)\n-\t\t\ttryfmt->ycbcr_enc = V4L2_YCBCR_ENC_601;\n-\t} else {\n-\t\tif (tryfmt->ycbcr_enc == V4L2_YCBCR_ENC_DEFAULT) {\n-\t\t\ttryfmt->ycbcr_enc =\n-\t\t\t\tV4L2_MAP_YCBCR_ENC_DEFAULT(tryfmt->colorspace);\n-\t\t}\n-\t}\n+\tif (tryfmt->ycbcr_enc == V4L2_YCBCR_ENC_DEFAULT)\n+\t\ttryfmt->ycbcr_enc =\n+\t\t\tV4L2_MAP_YCBCR_ENC_DEFAULT(tryfmt->colorspace);\n \n \tif (tryfmt->quantization == V4L2_QUANTIZATION_DEFAULT)\n \t\ttryfmt->quantization =\n@@ -2135,7 +2123,7 @@ static int imx7_csi_try_fmt(struct imx7_csi *csi,\n \t\treturn -EINVAL;\n \t}\n \n-\timx7_csi_try_colorimetry(&sdformat->format, false);\n+\timx7_csi_try_colorimetry(&sdformat->format);\n \n \treturn 0;\n }\n","prefixes":["libcamera-devel","35/50"]}