{"id":15853,"url":"https://patchwork.libcamera.org/api/patches/15853/?format=json","web_url":"https://patchwork.libcamera.org/patch/15853/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220510115147.19360-14-laurent.pinchart@ideasonboard.com>","date":"2022-05-10T11:51:10","name":"[libcamera-devel,13/50] staging: media: imx: imx7-media-csi: Drop unused controls support","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"8fe32610a975ca958429af70a20e0702b84d6b97","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15853/mbox/","series":[{"id":3106,"url":"https://patchwork.libcamera.org/api/series/3106/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3106","date":"2022-05-10T11:50:57","name":"staging: media: imx: Prepare destaging of imx7-media-csi","version":1,"mbox":"https://patchwork.libcamera.org/series/3106/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15853/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15853/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00F04C326E\n\tfor ;\n\tTue, 10 May 2022 11:52:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8373965648;\n\tTue, 10 May 2022 13:52:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F8A365652\n\tfor ;\n\tTue, 10 May 2022 13:52:08 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7643BB60;\n\tTue, 10 May 2022 13:52:07 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652183534;\n\tbh=qW8IIw68EVP3AedmAhYt7206Mi7WCoyGyeEfwRlV45Q=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Sdw6BkLxotAXBeXfPDpMb4k4mPTX7ytDe12WEVZail927FqpNucaWP92ArmuDfYOz\n\tONpTPOAI62sLVpXEAyEPOsw30OHTf8PrTQYyvrNWmzA5KnrTMSXS4GxDrYYn+IQprA\n\tn+KQ/TTDoBMnJcSmacWElnswZyrbBaq69y/1xuindo+jUDhLp+zDTUljaExbeqGXtk\n\tM3UpkUBkE++905aLjIpCHTXxWnvUplg/PTvlCBxIykGYGWkKXnzszrg4c/3mhq+Y52\n\tylYjIa2eAz7WiFsMPohZDzY0KYlKMDX2Ty7cdbcFJgY+XPgJ2dV1jL+56CK73hDNvU\n\tWj6jMwb4+MjsQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652183528;\n\tbh=qW8IIw68EVP3AedmAhYt7206Mi7WCoyGyeEfwRlV45Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=B8lcUAqKsG2NeKYC5Cy4qpZLC2vGhYWtXULY2aMWPaqTFyOMpMMh5nyYUtFzyfx1G\n\tvDD5K7JfOJlwhW7h0hx1jFgIuaoSXOQ/048CqevtOTJYfGiRdLJ1gbFKVDT2k0WqXK\n\tvFjkIYUKvpof1nThhhnVfzDtOscQxRnbPDCLsvI0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"B8lcUAqK\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 10 May 2022 14:51:10 +0300","Message-Id":"<20220510115147.19360-14-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>","References":"<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 13/50] staging: media: imx:\n\timx7-media-csi: Drop unused controls support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Martin Kepplinger , kernel@pengutronix.de,\n\tDorota Czaplejewicz ,\n\tAlexander Stein ,\n\tRui Miguel Silva ,\n\tPhilipp Zabel , \n\tSteve Longerbeam ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Drop the unused control handler from the driver.\n\nSigned-off-by: Laurent Pinchart \n---\n drivers/staging/media/imx/imx7-media-csi.c | 15 +--------------\n 1 file changed, 1 insertion(+), 14 deletions(-)","diff":"diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c\nindex 2e314ce961dc..499bb74ad6f3 100644\n--- a/drivers/staging/media/imx/imx7-media-csi.c\n+++ b/drivers/staging/media/imx/imx7-media-csi.c\n@@ -21,7 +21,6 @@\n #include \n #include \n \n-#include \n #include \n #include \n #include \n@@ -744,8 +743,6 @@ struct capture_priv {\n \tstruct vb2_queue q;\t\t\t/* The videobuf2 queue */\n \tstruct list_head ready_q;\t\t/* List of queued buffers */\n \tspinlock_t q_lock;\t\t\t/* Protect ready_q */\n-\n-\tstruct v4l2_ctrl_handler ctrl_hdlr;\t/* Controls inherited from subdevs */\n };\n \n #define to_capture_priv(v) container_of(v, struct capture_priv, vdev)\n@@ -1382,13 +1379,6 @@ imx7_media_capture_device_init(struct device *dev, struct v4l2_subdev *src_sd,\n \treturn &priv->vdev;\n }\n \n-static void imx7_media_capture_device_remove(struct imx_media_video_dev *vdev)\n-{\n-\tstruct capture_priv *priv = to_capture_priv(vdev);\n-\n-\tv4l2_ctrl_handler_free(&priv->ctrl_hdlr);\n-}\n-\n /* -----------------------------------------------------------------------------\n * V4L2 Subdev Operations\n */\n@@ -1730,7 +1720,7 @@ static int imx7_csi_registered(struct v4l2_subdev *sd)\n \tret = imx7_media_capture_device_register(csi->vdev,\n \t\t\t\t\t\t MEDIA_LNK_FL_IMMUTABLE);\n \tif (ret)\n-\t\tgoto err_remove;\n+\t\treturn ret;\n \n \tret = v4l2_device_register_subdev_nodes(&csi->imxmd->v4l2_dev);\n \tif (ret)\n@@ -1744,8 +1734,6 @@ static int imx7_csi_registered(struct v4l2_subdev *sd)\n \n err_unreg:\n \timx7_media_capture_device_unregister(csi->vdev);\n-err_remove:\n-\timx7_media_capture_device_remove(csi->vdev);\n \treturn ret;\n }\n \n@@ -1754,7 +1742,6 @@ static void imx7_csi_unregistered(struct v4l2_subdev *sd)\n \tstruct imx7_csi *csi = v4l2_get_subdevdata(sd);\n \n \timx7_media_capture_device_unregister(csi->vdev);\n-\timx7_media_capture_device_remove(csi->vdev);\n }\n \n static const struct v4l2_subdev_video_ops imx7_csi_video_ops = {\n","prefixes":["libcamera-devel","13/50"]}