[{"id":2126,"web_url":"https://patchwork.libcamera.org/comment/2126/","msgid":"<20190702142618.GB5033@pendragon.ideasonboard.com>","date":"2019-07-02T14:26:18","subject":"Re: [libcamera-devel] [PATCH 3/4] qcam: Add the version string to\n\tthe title","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Jul 02, 2019 at 12:48:40PM +0100, Kieran Bingham wrote:\n> Provide the version string reported by the libcamera library on the qcam\n> test utility.\n> \n> This helps confirm the exact version of the library that is being used\n> while testing.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/qcam/main_window.cpp | 8 ++++++++\n> src/qcam/main_window.h | 2 ++\n> 2 files changed, 10 insertions(+)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 16b123132dd9..61d7aa9469f0 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -14,6 +14,7 @@\n> #include \n> \n> #include \n> +#include \n> \n> #include \"main_window.h\"\n> #include \"viewfinder.h\"\n> @@ -25,6 +26,7 @@ MainWindow::MainWindow(const OptionsParser::Options &options)\n> {\n> \tint ret;\n> \n> +\tsetWindowTitle();\n\nJust inline the call here directly. There's also no need for the\nQMainWindow:: prefix.\n\n\tQString version = QString::fromStdString(libcamera::version));\n\tsetWindowTitle(\"QCam - \" + version);\n\n> \tviewfinder_ = new ViewFinder(this);\n> \tsetCentralWidget(viewfinder_);\n> \tviewfinder_->setFixedSize(500, 500);\n> @@ -50,6 +52,12 @@ MainWindow::~MainWindow()\n> \tCameraManager::instance()->stop();\n> }\n> \n> +void MainWindow::setWindowTitle()\n> +{\n> +\tQMainWindow::setWindowTitle(\"QCam : \"\n> +\t\t+ QString::fromStdString(libcamera::version.toString()));\n> +}\n> +\n> int MainWindow::openCamera()\n> {\n> \tCameraManager *cm = CameraManager::instance();\n> diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n> index fe565cbcb460..b30a86768efc 100644\n> --- a/src/qcam/main_window.h\n> +++ b/src/qcam/main_window.h\n> @@ -33,6 +33,8 @@ public:\n> \t~MainWindow();\n> \n> private:\n> +\tvoid setWindowTitle();\n> +\n> \tint openCamera();\n> \n> \tint startCapture();","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D76560B10\n\tfor ;\n\tTue, 2 Jul 2019 16:26:38 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB018524;\n\tTue, 2 Jul 2019 16:26:37 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562077598;\n\tbh=4k/QMH4wqI6RO6fdwIAIdLek8KsEuKLcOI5oClRCaWE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gI+ilwYYtrqwBVMsww4FQOopt/fkSxDsFSyIoaphgwpqlpquGYWnWKoonztY3pHnX\n\tiah/xTc/toYTsYKZQ2b/KLL+n/bJM3fSD9ghJBVkBd5CNWC4N6rggk1VLYmqOBCRnM\n\tWNAYL9H/rADk7acXrVISLKoMJ8OGDupPmJ9/8XLM=","Date":"Tue, 2 Jul 2019 17:26:18 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190702142618.GB5033@pendragon.ideasonboard.com>","References":"<20190702114841.19101-1-kieran.bingham@ideasonboard.com>\n\t<20190702114841.19101-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190702114841.19101-3-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 3/4] qcam: Add the version string to\n\tthe title","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Jul 2019 14:26:38 -0000"}},{"id":2130,"web_url":"https://patchwork.libcamera.org/comment/2130/","msgid":"<1cd80dbe-2841-a039-8366-d32dedcb4827@ideasonboard.com>","date":"2019-07-03T10:48:33","subject":"Re: [libcamera-devel] [PATCH 3/4] qcam: Add the version string to\n\tthe title","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 02/07/2019 15:26, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Tue, Jul 02, 2019 at 12:48:40PM +0100, Kieran Bingham wrote:\n>> Provide the version string reported by the libcamera library on the qcam\n>> test utility.\n>>\n>> This helps confirm the exact version of the library that is being used\n>> while testing.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/qcam/main_window.cpp | 8 ++++++++\n>> src/qcam/main_window.h | 2 ++\n>> 2 files changed, 10 insertions(+)\n>>\n>> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n>> index 16b123132dd9..61d7aa9469f0 100644\n>> --- a/src/qcam/main_window.cpp\n>> +++ b/src/qcam/main_window.cpp\n>> @@ -14,6 +14,7 @@\n>> #include \n>> \n>> #include \n>> +#include \n>> \n>> #include \"main_window.h\"\n>> #include \"viewfinder.h\"\n>> @@ -25,6 +26,7 @@ MainWindow::MainWindow(const OptionsParser::Options &options)\n>> {\n>> \tint ret;\n>> \n>> +\tsetWindowTitle();\n> \n> Just inline the call here directly. There's also no need for the\n> QMainWindow:: prefix.\n> \n> \tQString version = QString::fromStdString(libcamera::version));\n> \tsetWindowTitle(\"QCam - \" + version);\n\n\nYes, this is an artifact of me swapping the order of the patches. I\noriginally had the FPS calculation first, so I already had the function\ncall.\n\nIn fact, perhaps instead I should create the constant title string once\nand store it in MainWindow class.\n\nI'll rework it a little and clean up.\n\n--\nKieran\n\n> \n>> \tviewfinder_ = new ViewFinder(this);\n>> \tsetCentralWidget(viewfinder_);\n>> \tviewfinder_->setFixedSize(500, 500);\n>> @@ -50,6 +52,12 @@ MainWindow::~MainWindow()\n>> \tCameraManager::instance()->stop();\n>> }\n>> \n>> +void MainWindow::setWindowTitle()\n>> +{\n>> +\tQMainWindow::setWindowTitle(\"QCam : \"\n>> +\t\t+ QString::fromStdString(libcamera::version.toString()));\n>> +}\n>> +\n>> int MainWindow::openCamera()\n>> {\n>> \tCameraManager *cm = CameraManager::instance();\n>> diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n>> index fe565cbcb460..b30a86768efc 100644\n>> --- a/src/qcam/main_window.h\n>> +++ b/src/qcam/main_window.h\n>> @@ -33,6 +33,8 @@ public:\n>> \t~MainWindow();\n>> \n>> private:\n>> +\tvoid setWindowTitle();\n>> +\n>> \tint openCamera();\n>> \n>> \tint startCapture();\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D333360B2D\n\tfor ;\n\tWed, 3 Jul 2019 12:48:36 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 66E0324B;\n\tWed, 3 Jul 2019 12:48:36 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562150916;\n\tbh=ndi+OjapCX6NVhPf0RkeJ9XvQHZlvMbnXKbudsNzPtI=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=DKIXyN7wLm8b7GKQGasPjh2iWp7Z0MmaJVcGzre0zj7N7GLO7IaRMdeZWNZEj1Fpw\n\tmIONuBYvsWblbP3a9huungOMOydu9piLzgXTeGWnKtUp6eeiruvHFo6eTWDlS9T3m7\n\tyOvhIo6v4SDE0v7dw6j7dI8kVUgYZS3bZ+V4aRso=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"LibCamera Devel ","References":"<20190702114841.19101-1-kieran.bingham@ideasonboard.com>\n\t<20190702114841.19101-3-kieran.bingham@ideasonboard.com>\n\t<20190702142618.GB5033@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<1cd80dbe-2841-a039-8366-d32dedcb4827@ideasonboard.com>","Date":"Wed, 3 Jul 2019 11:48:33 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.1","MIME-Version":"1.0","In-Reply-To":"<20190702142618.GB5033@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 3/4] qcam: Add the version string to\n\tthe title","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 03 Jul 2019 10:48:37 -0000"}}]