[{"id":22904,"web_url":"https://patchwork.libcamera.org/comment/22904/","msgid":"<049cfa02-eb88-2e4f-2c98-18ddb52b5bf4@ideasonboard.com>","date":"2022-05-08T03:32:28","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Demote noisy\n\tmessage to Debug","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 5/7/22 19:00, Laurent Pinchart via libcamera-devel wrote:\n> The message that prints all controls in a request in\n> IPARPi::queueRequest() is noisy. Demote it from Info to Debug.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 5efd051bdd13..05dc626aa90b 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -632,9 +632,9 @@ void IPARPi::queueRequest(const ControlList &controls)\n> \tlibcameraMetadata_.clear();\n> \n> \tfor (auto const &ctrl : controls) {\n> -\t\tLOG(IPARPI, Info) << \"Request ctrl: \"\n> -\t\t\t\t << controls::controls.at(ctrl.first)->name()\n> -\t\t\t\t << \" = \" << ctrl.second.toString();\n> +\t\tLOG(IPARPI, Debug) << \"Request ctrl: \"\n> +\t\t\t\t << controls::controls.at(ctrl.first)->name()\n> +\t\t\t\t << \" = \" << ctrl.second.toString();\n\n\nMakes sense,\n\nReviewed-by: Umang Jain \n\n> \n> \t\tswitch (ctrl.first) {\n> \t\tcase controls::AE_ENABLE: {\n>\n> base-commit: 1e4c4ad5f78ad7abc73854646f6e9902dc3c1925","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BF433C0F2A\n\tfor ;\n\tSun, 8 May 2022 03:32:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ECF9765646;\n\tSun, 8 May 2022 05:32:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED6566150E\n\tfor ;\n\tSun, 8 May 2022 05:32:34 +0200 (CEST)","from [192.168.1.106] (unknown [103.251.226.1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9DE47492;\n\tSun, 8 May 2022 05:32:33 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651980757;\n\tbh=c+2iKlIIMKRLExZm48AaZutVBmUTscV4AYN/Cd/Hyso=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=IcsQATUQyQilCyBc/n2JTzrk+L3jBaklNUCD7i9qweKghmWGYlcV6AfWc2cREgwYT\n\tzwNVzUM+d8kTaVt3ParZyVrUxMdlTYcw4jmhr0YTKnR57oz2s3ioig5p6qikB5HoJs\n\tK9aD23bKwInAUEdPFK4gH8MWun8YG0Uu0TcRGMfsSIEvg4fSPowvLoJNfSf5ty3+zA\n\tkJTD4GisdYkR1JnFg5WktU05LkK3cOfuedRj0Hn6009SZzDRxPmBGbKKMHaRLi3EUx\n\tI8p+If9t/Lf3OzqEB7CtExRAsrE9DiwbXSuCRsPO2/BgnjEKd1gkew45zjL23EudlQ\n\tQWcHGcfbLEAQg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651980754;\n\tbh=c+2iKlIIMKRLExZm48AaZutVBmUTscV4AYN/Cd/Hyso=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=ZAJhm3A7Xmro0vjsnLhakQbEXNCtjH300F+OsKsCtCgeSP9SC93kFHxX11OQNXba5\n\t1EAOfi/l295kZM00NcAjloMz+QvtrmNLod1OoGUL543rDQmhNqicdNfHG3crSVPOF3\n\tv39gjl+GWKLNwYdoryDVW24SXN49d7eo/n/ZN9oM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ZAJhm3A7\"; dkim-atps=neutral","Message-ID":"<049cfa02-eb88-2e4f-2c98-18ddb52b5bf4@ideasonboard.com>","Date":"Sun, 8 May 2022 09:02:28 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220507133039.30327-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220507133039.30327-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Demote noisy\n\tmessage to Debug","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22905,"web_url":"https://patchwork.libcamera.org/comment/22905/","msgid":"","date":"2022-05-09T07:22:10","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Demote noisy\n\tmessage to Debug","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nThank you for your patch.\n\nOn Sat, 7 May 2022 at 14:30, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> The message that prints all controls in a request in\n> IPARPi::queueRequest() is noisy. Demote it from Info to Debug.\n>\n> Signed-off-by: Laurent Pinchart \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp\n> b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 5efd051bdd13..05dc626aa90b 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -632,9 +632,9 @@ void IPARPi::queueRequest(const ControlList &controls)\n> libcameraMetadata_.clear();\n>\n> for (auto const &ctrl : controls) {\n> - LOG(IPARPI, Info) << \"Request ctrl: \"\n> - << controls::controls.at\n> (ctrl.first)->name()\n> - << \" = \" << ctrl.second.toString();\n> + LOG(IPARPI, Debug) << \"Request ctrl: \"\n> + << controls::controls.at\n> (ctrl.first)->name()\n> + << \" = \" << ctrl.second.toString();\n>\n> switch (ctrl.first) {\n> case controls::AE_ENABLE: {\n>\n> base-commit: 1e4c4ad5f78ad7abc73854646f6e9902dc3c1925\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CFF8C3256\n\tfor ;\n\tMon, 9 May 2022 07:22:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 81C7365646;\n\tMon, 9 May 2022 09:22:29 +0200 (CEST)","from mail-lf1-x133.google.com (mail-lf1-x133.google.com\n\t[IPv6:2a00:1450:4864:20::133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 606766563F\n\tfor ;\n\tMon, 9 May 2022 09:22:27 +0200 (CEST)","by mail-lf1-x133.google.com with SMTP id p10so22219912lfa.12\n\tfor ;\n\tMon, 09 May 2022 00:22:27 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652080949;\n\tbh=OY3DSn/5d6UJHdeVavQhF4ttHzPFEJ1b+2M0lzaM34M=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JL3ZGyAwObO0YyRKt7Qm/TGgMPDPwTo9/zFmWrTlaRLdyhuqWdZR10JShTydNIEMn\n\tTcJBputbufGdsYhostiuONMQHMWbDI/X2MeSxCF+R2ymzfW9tUuMWasX6vkPfktzGh\n\tONaGVqq/r6wPOOy3FfW9V3Qzernl3m1lUTx5hrDYtegTkDMhvz0uu8CA6X/GdyVquy\n\tc+OUpFO2JO8Gsb0KSfy6e/xRrf6wvd/udJuLsQO5KEdtAmEF2pkBSkz2z88aV2bs+j\n\txscmfbhE4903fy2X5pvBDiv2iohx2lgkV/aA5OERCMsaLyWpW00GqjrfLhvzj5uw7R\n\trBtXYSAgJFtdw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=ZOjlYBvBRAzhdrqUpCBpIU0QL7S8WnJOKawK+RIgDuY=;\n\tb=neybGWuW+ujghCmMF/MMLVF7eIhrd4XRt277CQ+mPtPPEJCO59NvJJStGiWRrV7sos\n\tZf5YZSJbsmFz/3hIB8bwiRMQXXER29hcywe8z68Ap1oh32Ihmku1yNkBtxjrK56dJpr+\n\tEX0KR+Jjeo57krmi3xwtuPSfsE0rJSybqG80h+MeZLvoDchOpxfKKxo3uC7++PtRAhkb\n\tuGGL5QGo1kUYv/KHUrCzl3Q5SuD8KOSRvQTbXaChikOr3pu6+qZilz5mmuoFhx1tRRnd\n\twiFpM9nFqghSVxiH8s4LdoW/PoeY029inuaD4V2XzESwpQNbNLj8nWsH4wcJDVjGDOUL\n\tSW5w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"neybGWuW\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=ZOjlYBvBRAzhdrqUpCBpIU0QL7S8WnJOKawK+RIgDuY=;\n\tb=hF3nVP2817YzYEzOz8X/TLVLvYl4WO8CYe7iI1K2+pbTxzijOrGuNMPkTmNPZTdoc5\n\tY9py+gInQrmCN0n9wFyyx3ohJ3fGPixGUcPwalLsxe+AVPYlRJGhaZk91VbPWQWbqysk\n\t6FAEfDrzEHNYWNeVTuJAur/NZGEoU6D8PZuveH3dqagUSKiwTrvZYX7cUdMstAKPHq/k\n\tLJJNx52FgkQ+fLW9f4XPUq0K/wsQMOjpL+9ohEOk8FbSSzC6vaHmD+j6gqGb5SBaQs14\n\tFC1hTI7PGj7OZAlHJsGEMFTk8I+2GlMmWsKieS8mpIPhfcAh/r1SE+f1EuNfK/prYxAK\n\tZPeQ==","X-Gm-Message-State":"AOAM531sv+sCNp0spmlmcA4TkDGnhFSuVCkH0xPSgKU3eb8MtaNmEJSI\n\t31yuNxiJZ7sBig5RDrpbhYvAI2vS2EeW2eUx7bzXrg==","X-Google-Smtp-Source":"ABdhPJw4K+YVsdzFVxNNT596qkw8m12j0HgaHjRl/mV4ScBk7d154qq51gfW7GJKAxENQAE50Anb6xK+kaIiMzYuUQk=","X-Received":"by 2002:a05:6512:370a:b0:472:5a8:5859 with SMTP id\n\tz10-20020a056512370a00b0047205a85859mr11683724lfr.363.1652080946515;\n\tMon, 09 May 2022 00:22:26 -0700 (PDT)","MIME-Version":"1.0","References":"<20220507133039.30327-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220507133039.30327-1-laurent.pinchart@ideasonboard.com>","Date":"Mon, 9 May 2022 08:22:10 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000f5247705de8f112a\"","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Demote noisy\n\tmessage to Debug","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]