{"id":15823,"url":"https://patchwork.libcamera.org/api/patches/15823/?format=json","web_url":"https://patchwork.libcamera.org/patch/15823/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220507101152.31412-4-tomi.valkeinen@ideasonboard.com>","date":"2022-05-07T10:11:48","name":"[libcamera-devel,v9,3/7] meson: add 'check: true' for run_command() calls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"cdb69f9272df6fd08df3f4abe357abac571b8b75","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15823/mbox/","series":[{"id":3100,"url":"https://patchwork.libcamera.org/api/series/3100/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3100","date":"2022-05-07T10:11:45","name":"Python bindings","version":9,"mbox":"https://patchwork.libcamera.org/series/3100/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15823/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15823/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8CE65C3256\n\tfor ;\n\tSat, 7 May 2022 10:12:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D990C6564F;\n\tSat, 7 May 2022 12:12:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA0A365644\n\tfor ;\n\tSat, 7 May 2022 12:12:16 +0200 (CEST)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 23F7855A;\n\tSat, 7 May 2022 12:12:16 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651918339;\n\tbh=O45OCn0MzoZDSEqbqEq61DIKMlzSOl/dIVbUpTmGN3U=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=o7YohZRB6/qTm/59DmDlrC/QNBF9h8Xrzl4U7s+30K63Esq9KQVXojUXEO3BQyRY+\n\tUsNDFnTTo/pWB21NSgHEvZVvjNMcleUvq755y+olp/ZfC6oNtDMa2dWWQBLtVbT9nu\n\t1Tj/b/0I03CN2y1xtAHX3usoXPgDfllGTcbRZXs3kYsfNJtD6m4zmtzSb3WpH40T27\n\tR3eW1vpgDZbYbQdGci6mLll1O588cblSxFhzjnFMbe12T1Cce4z9YvL76ZXFmi+33i\n\t+hE8PlEPA3Ww5MQneSaF0251EQ9NFeaWh+6S+I/wBQhpvG6Sv3nskfqkt46aXYm+Hl\n\t8GXKyZvAKWxuw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651918336;\n\tbh=O45OCn0MzoZDSEqbqEq61DIKMlzSOl/dIVbUpTmGN3U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=s0qbYWIBtNvy5QyOie5JivZjQwh6pDz3TNevgKCzv2zRQownBPDaz6AZf5KU1Exgt\n\tl8iz9FGt4JHHMiwCe4C/VTrnJsQ9NlmHntejstTisY1a6ZvFSAzAGTHIn/ich2+0rr\n\tZkEwwIXKzKJkSl0yBfZdncTMSiMC9zQHS7NNCV38="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"s0qbYWIB\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Sat, 7 May 2022 13:11:48 +0300","Message-Id":"<20220507101152.31412-4-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220507101152.31412-1-tomi.valkeinen@ideasonboard.com>","References":"<20220507101152.31412-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v9 3/7] meson: add 'check: true' for\n\trun_command() calls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add 'check: true' to all run_command() calls as suggested in\nhttps://github.com/mesonbuild/meson/issues/9300 to get rid of meson\nwarning \"You should add the boolean check kwarg to the run_command\ncall.\"\n\nThis makes meson fail if the executed command fails, which makes sense.\n\nSigned-off-by: Tomi Valkeinen \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n meson.build | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)","diff":"diff --git a/meson.build b/meson.build\nindex 10ad8c5c..0124e7d3 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -18,7 +18,8 @@ project('libcamera', 'c', 'cpp',\n # libcamera_git_version.\n libcamera_git_version = run_command('utils/gen-version.sh',\n meson.project_build_root(),\n- meson.project_source_root()).stdout().strip()\n+ meson.project_source_root(),\n+ check: true).stdout().strip()\n if libcamera_git_version == ''\n libcamera_git_version = meson.project_version()\n endif\n@@ -148,7 +149,7 @@ subdir('test')\n \n if not meson.is_cross_build()\n kernel_version_req = '>= 5.0.0'\n- kernel_version = run_command('uname', '-r').stdout().strip()\n+ kernel_version = run_command('uname', '-r', check: true).stdout().strip()\n if not kernel_version.version_compare(kernel_version_req)\n warning('The current running kernel version @0@ is too old to run libcamera.'\n .format(kernel_version))\n@@ -160,7 +161,8 @@ endif\n # Create a symlink from the build root to the source root. This is used when\n # running libcamera from the build directory to locate resources in the source\n # directory (such as IPA configuration files).\n-run_command('ln', '-fsT', meson.project_source_root(), meson.project_build_root() / 'source')\n+run_command('ln', '-fsT', meson.project_source_root(), meson.project_build_root() / 'source',\n+ check: true)\n \n configure_file(output : 'config.h', configuration : config_h)\n \n","prefixes":["libcamera-devel","v9","3/7"]}