[{"id":22869,"web_url":"https://patchwork.libcamera.org/comment/22869/","msgid":"","date":"2022-05-05T18:02:45","subject":"Re: [libcamera-devel] [PATCH v7 11/13] py: support controls in the\n\tstart method","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi and David,\n\nThank you for the patch.\n\nOn Thu, May 05, 2022 at 01:41:02PM +0300, Tomi Valkeinen wrote:\n> From: David Plowman \n> \n> Libcamera has for a while allowed controls to be set in the camera's\n\ns/Libcamera/libcamera/\n\n> start method. The Python bindings need to permit this too.\n> \n> Signed-off-by: David Plowman \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/libcamera/pymain.cpp | 25 ++++++++++++++++++++++---\n> 1 file changed, 22 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/py/libcamera/pymain.cpp b/src/py/libcamera/pymain.cpp\n> index c442ad50..6375e326 100644\n> --- a/src/py/libcamera/pymain.cpp\n> +++ b/src/py/libcamera/pymain.cpp\n> @@ -250,15 +250,34 @@ PYBIND11_MODULE(_libcamera, m)\n> \t\t.def_property_readonly(\"id\", &Camera::id)\n> \t\t.def(\"acquire\", &Camera::acquire)\n> \t\t.def(\"release\", &Camera::release)\n> -\t\t.def(\"start\", [](Camera &self) {\n> +\t\t.def(\"start\", [](Camera &self, py::dict controls) {\n> \t\t\tself.requestCompleted.connect(handleRequestCompleted);\n> \n> -\t\t\tint ret = self.start();\n> +\t\t\tconst ControlInfoMap &controlMap = self.controls();\n> +\t\t\tControlList controlList(controlMap);\n> +\t\t\tfor (const auto& [hkey, hval]: controls) {\n> +\t\t\t\tauto key = hkey.cast();\n> +\n> +\t\t\t\tauto it = find_if(controlMap.begin(), controlMap.end(),\n> +\t\t\t\t\t\t [&key](const auto &kvp) {\n> +\t\t\t\t\t\t\t return kvp.first->name() == key; });\n> +\n> +\t\t\t\tif (it == controlMap.end())\n> +\t\t\t\t\tthrow runtime_error(\"Control \" + key + \" not found\");\n> +\n> +\t\t\t\tconst auto &id = it->first;\n> +\t\t\t\tauto obj = py::cast(hval);\n> +\n> +\t\t\t\tcontrolList.set(id->id(), PyToControlValue(obj, id->type()));\n> +\t\t\t}\n> +\n> +\t\t\tint ret = self.start(&controlList);\n> \t\t\tif (ret)\n> \t\t\t\tself.requestCompleted.disconnect(handleRequestCompleted);\n> \n> \t\t\treturn ret;\n> -\t\t})\n> +\t\t},\n> +\t\tpy::arg(\"controls\") = py::dict())\n> \n> \t\t.def(\"stop\", [](Camera &self) {\n> \t\t\tint ret = self.stop();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EBB90C3256\n\tfor ;\n\tThu, 5 May 2022 18:02:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A87E360424;\n\tThu, 5 May 2022 20:02:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56F1E603AB\n\tfor ;\n\tThu, 5 May 2022 20:02:49 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E5C91492;\n\tThu, 5 May 2022 20:02:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651773770;\n\tbh=FAD1Y/N4UICSvkvYAew1IJNNppYJq58zK7HpJDr+38g=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=fbPgtZHeSa1skfQHV8GwCxMpn64UVP3FRWLM6BlThMaoUuEngE6lGZIEBfBMaOrpZ\n\tCVaiY2ENhYoQo7//c6uyJeu48EYMnyttG1Thw8ccqpkpZ0L9/uOk/qS9Dbilf1QVZB\n\tbrYFUqLNDOyfWF94V9cBvkOsOUITSgk+maAZyavuuY/2QL0RzWRLTNlcUtMIJtcsQf\n\tF2Gf0MiQPqq3sUGoAZ6c2s/mOf94Q1UXywvuNDiHd6Cse/fkmKpWcADD9Q0CC+8pkZ\n\tb6FnvO75DLpu2RQmz/bx/7HIAz7W7FOObO/IgDvzKlknDKwXwG0H8mA5JWznKhujhi\n\tyXqkzOETPFqGw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651773769;\n\tbh=FAD1Y/N4UICSvkvYAew1IJNNppYJq58zK7HpJDr+38g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DRytR2QawsedKF6bKpGxv+7KTkAcSQKHKiClP1x8ebfP0bNdRRtzyNU3vCIjKZFQ5\n\tWT3C3dZTo73naCgwHcKeVbRcRAFOYqVzwSNBaHY62ruVcIiNQADOpBBFIigcEInLjo\n\tcN3eMMe2lEv7xRUfiB/kW/XRlSaa9OtYNTaBEvN8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DRytR2Qa\"; dkim-atps=neutral","Date":"Thu, 5 May 2022 21:02:45 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220505104104.70841-1-tomi.valkeinen@ideasonboard.com>\n\t<20220505104104.70841-12-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220505104104.70841-12-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v7 11/13] py: support controls in the\n\tstart method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]