[{"id":22854,"web_url":"https://patchwork.libcamera.org/comment/22854/","msgid":"<165175402809.1217485.5442746798446918748@Monstersaurus>","date":"2022-05-05T12:33:48","subject":"Re: [libcamera-devel] [PATCH v7 03/13] meson: add 'check: true' for\n\trun_command() calls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Tomi Valkeinen (2022-05-05 11:40:54)\n> Add 'check: true' to all run_command() calls as suggested in\n> https://github.com/mesonbuild/meson/issues/9300 to get rid of meson\n> warning \"You should add the boolean check kwarg to the run_command\n> call.\"\n> \n> This makes meson fail if the executed command fails, which makes sense.\n> \n> Signed-off-by: Tomi Valkeinen \n> ---\n> meson.build | 8 +++++---\n> 1 file changed, 5 insertions(+), 3 deletions(-)\n> \n> diff --git a/meson.build b/meson.build\n> index 10ad8c5c..0124e7d3 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -18,7 +18,8 @@ project('libcamera', 'c', 'cpp',\n> # libcamera_git_version.\n> libcamera_git_version = run_command('utils/gen-version.sh',\n> meson.project_build_root(),\n> - meson.project_source_root()).stdout().strip()\n> + meson.project_source_root(),\n> + check: true).stdout().strip()\n> if libcamera_git_version == ''\n\nI think I recall on ChromeOS builds - there was something about the\nbuild occuring in a different tree location - and it affected this\nsomehow.\n\nSo ... I would say 'Yes, I agree with this change' - but it will need\nspecific testing to make sure we don't break chrome builds.\n\n(That's part of my integration tests anyway, but just highlighting here)\n\nSo assuming we don't break a build : \n\nReviewed-by: Kieran Bingham \n\n\n> libcamera_git_version = meson.project_version()\n> endif\n> @@ -148,7 +149,7 @@ subdir('test')\n> \n> if not meson.is_cross_build()\n> kernel_version_req = '>= 5.0.0'\n> - kernel_version = run_command('uname', '-r').stdout().strip()\n> + kernel_version = run_command('uname', '-r', check: true).stdout().strip()\n> if not kernel_version.version_compare(kernel_version_req)\n> warning('The current running kernel version @0@ is too old to run libcamera.'\n> .format(kernel_version))\n> @@ -160,7 +161,8 @@ endif\n> # Create a symlink from the build root to the source root. This is used when\n> # running libcamera from the build directory to locate resources in the source\n> # directory (such as IPA configuration files).\n> -run_command('ln', '-fsT', meson.project_source_root(), meson.project_build_root() / 'source')\n> +run_command('ln', '-fsT', meson.project_source_root(), meson.project_build_root() / 'source',\n> + check: true)\n> \n> configure_file(output : 'config.h', configuration : config_h)\n> \n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92252C0F2A\n\tfor ;\n\tThu, 5 May 2022 12:33:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F007660424;\n\tThu, 5 May 2022 14:33:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 102C0603AB\n\tfor ;\n\tThu, 5 May 2022 14:33:51 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8336F4A8;\n\tThu, 5 May 2022 14:33:50 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651754032;\n\tbh=480hIHVqAnELywOISW0C/UlKlyGUNHl3G931ZkSTol8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=a6n7VhHTFcJDtMsnO87H8fmLT21Cx9ENFblZwBZtkP/OHjs3CdB8ol9OunXzl5cIF\n\tgChIMl3ouqbmburj2IK7o/wGUwGM8Nv8hWf6zXMawmr2Zq0o4PoURc5cKNnBlLcUqP\n\tJYPJLeDklnfzV3AsMwAFx63RO/rBC3uCinZky6H3E3+hm4PeMIdMWEJIiFuDnoLJ+2\n\tYQsjknCZjd0Vp4iMFNzpBWPNC4qN7seJB/PO4PchZTdFZp2PuI7Nh8CqqyTz8pcDJC\n\tMI9j6VIjpTnjYLUU/nc4+9npBdGXlJ8nQ7PGa09PPhl93c59Ezawvkk7T+Io3h2u4s\n\tkbl7iFy0YwH+g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651754030;\n\tbh=480hIHVqAnELywOISW0C/UlKlyGUNHl3G931ZkSTol8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=YSmhGj+64AVO6pMzuEp25hcPSuUm/MyxSK2SdQ+NGrYUpf/lJi7j+VhLbJqvz8JX+\n\tIWEOw5ArLBXw02UgGQpfd1kRS3nlZ8Dsy8kXdozviC5sz+CXMwLA1i6XtCNvw0CQhg\n\teT0/g3ZMGrexLICZ7/1Pka4lkjwykhNLVxG0S6Pc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YSmhGj+6\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220505104104.70841-4-tomi.valkeinen@ideasonboard.com>","References":"<20220505104104.70841-1-tomi.valkeinen@ideasonboard.com>\n\t<20220505104104.70841-4-tomi.valkeinen@ideasonboard.com>","To":"David Plowman ,\n\tJacopo Mondi ,\n\tLaurent Pinchart ,\n\tTomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 05 May 2022 13:33:48 +0100","Message-ID":"<165175402809.1217485.5442746798446918748@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v7 03/13] meson: add 'check: true' for\n\trun_command() calls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22855,"web_url":"https://patchwork.libcamera.org/comment/22855/","msgid":"<30a4963e-c152-218d-6d4d-4de709465ae4@ideasonboard.com>","date":"2022-05-05T12:48:11","subject":"Re: [libcamera-devel] [PATCH v7 03/13] meson: add 'check: true' for\n\trun_command() calls","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"content":"On 05/05/2022 15:33, Kieran Bingham wrote:\n> Quoting Tomi Valkeinen (2022-05-05 11:40:54)\n>> Add 'check: true' to all run_command() calls as suggested in\n>> https://github.com/mesonbuild/meson/issues/9300 to get rid of meson\n>> warning \"You should add the boolean check kwarg to the run_command\n>> call.\"\n>>\n>> This makes meson fail if the executed command fails, which makes sense.\n>>\n>> Signed-off-by: Tomi Valkeinen \n>> ---\n>> meson.build | 8 +++++---\n>> 1 file changed, 5 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/meson.build b/meson.build\n>> index 10ad8c5c..0124e7d3 100644\n>> --- a/meson.build\n>> +++ b/meson.build\n>> @@ -18,7 +18,8 @@ project('libcamera', 'c', 'cpp',\n>> # libcamera_git_version.\n>> libcamera_git_version = run_command('utils/gen-version.sh',\n>> meson.project_build_root(),\n>> - meson.project_source_root()).stdout().strip()\n>> + meson.project_source_root(),\n>> + check: true).stdout().strip()\n>> if libcamera_git_version == ''\n> \n> I think I recall on ChromeOS builds - there was something about the\n> build occuring in a different tree location - and it affected this\n> somehow.\n> \n> So ... I would say 'Yes, I agree with this change' - but it will need\n> specific testing to make sure we don't break chrome builds.\n> \n> (That's part of my integration tests anyway, but just highlighting here)\n> \n> So assuming we don't break a build :\n> \n> Reviewed-by: Kieran Bingham \n\nThanks! Btw, feel free to pick these three first patches separately if \nthey look fine.\n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 192C9C3256\n\tfor ;\n\tThu, 5 May 2022 12:48:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 77EE260424;\n\tThu, 5 May 2022 14:48:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7310F603AB\n\tfor ;\n\tThu, 5 May 2022 14:48:15 +0200 (CEST)","from [192.168.1.111] (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5637A492;\n\tThu, 5 May 2022 14:48:14 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651754897;\n\tbh=a7USu+jH2ozOZlGqdHbcPPVIT+GmiS1g68N5c9TudOI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=BauAGASZchuB2wuyx/3pTNKZDfnP7PimSyICPSC6g34kM3WYlBANs6rQO1CpOJ9AV\n\tLGr9WIfkx04/FKLWq6n9CvxGBCMDsYgJCKcZfeD7Bt0A1qFxmw8Sq6MXqnKmyY82Wy\n\tIZqQ8x4iC6sAxSk3WKWpd2ESEGLNGhMWK+h1fuw3b+nEQouLCdlT4GHz94CXuO71KW\n\tmi6YCUx1pGcO7HvCwxSrvXMertaCI8FesnQ6QRMM8UUU1dCMSzsXe1BGyFXo1c1aPI\n\t7LPENzDd3OI53b1AIoVtVHqbDl02EfEto6A/AtfHTdzIlFd9G1A2OAMfIY5r/Uw6yV\n\tUgDS60yWGNJmA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651754894;\n\tbh=a7USu+jH2ozOZlGqdHbcPPVIT+GmiS1g68N5c9TudOI=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=VnZHYHuxOc+fbBe4CYnjNzFA8r0aWiMEgvd2arotTCL7UnHfOujqrwbzFSjVthEfb\n\tjGB4BBLVMD9aqN+hmUWFOWhIoTrgVxemVNh27eZuez3UJU8Jcajzqid0UaFff5eAlX\n\txqPTPbP8c7ltQgfEZaRyxD9zJL1j7ieXA9vKEKsY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VnZHYHux\"; dkim-atps=neutral","Message-ID":"<30a4963e-c152-218d-6d4d-4de709465ae4@ideasonboard.com>","Date":"Thu, 5 May 2022 15:48:11 +0300","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.8.0","Content-Language":"en-US","To":"Kieran Bingham ,\n\tDavid Plowman ,\n\tJacopo Mondi ,\n\tLaurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220505104104.70841-1-tomi.valkeinen@ideasonboard.com>\n\t<20220505104104.70841-4-tomi.valkeinen@ideasonboard.com>\n\t<165175402809.1217485.5442746798446918748@Monstersaurus>","In-Reply-To":"<165175402809.1217485.5442746798446918748@Monstersaurus>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v7 03/13] meson: add 'check: true' for\n\trun_command() calls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22862,"web_url":"https://patchwork.libcamera.org/comment/22862/","msgid":"","date":"2022-05-05T15:54:14","subject":"Re: [libcamera-devel] [PATCH v7 03/13] meson: add 'check: true' for\n\trun_command() calls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, May 05, 2022 at 01:33:48PM +0100, Kieran Bingham wrote:\n> Quoting Tomi Valkeinen (2022-05-05 11:40:54)\n> > Add 'check: true' to all run_command() calls as suggested in\n> > https://github.com/mesonbuild/meson/issues/9300 to get rid of meson\n> > warning \"You should add the boolean check kwarg to the run_command\n> > call.\"\n> > \n> > This makes meson fail if the executed command fails, which makes sense.\n> > \n> > Signed-off-by: Tomi Valkeinen \n> > ---\n> > meson.build | 8 +++++---\n> > 1 file changed, 5 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/meson.build b/meson.build\n> > index 10ad8c5c..0124e7d3 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -18,7 +18,8 @@ project('libcamera', 'c', 'cpp',\n> > # libcamera_git_version.\n> > libcamera_git_version = run_command('utils/gen-version.sh',\n> > meson.project_build_root(),\n> > - meson.project_source_root()).stdout().strip()\n> > + meson.project_source_root(),\n> > + check: true).stdout().strip()\n> > if libcamera_git_version == ''\n> \n> I think I recall on ChromeOS builds - there was something about the\n> build occuring in a different tree location - and it affected this\n> somehow.\n> \n> So ... I would say 'Yes, I agree with this change' - but it will need\n> specific testing to make sure we don't break chrome builds.\n> \n> (That's part of my integration tests anyway, but just highlighting here)\n\nCan you test both the regular ebuild and the live ebuild (with cros\nworkon) ?\n\n> So assuming we don't break a build : \n> \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\nAs Tomi mentioned in another e-mail, could you already push patches\n01/13 to 03/13 after running your integrations tests ?\n\n> > libcamera_git_version = meson.project_version()\n> > endif\n> > @@ -148,7 +149,7 @@ subdir('test')\n> > \n> > if not meson.is_cross_build()\n> > kernel_version_req = '>= 5.0.0'\n> > - kernel_version = run_command('uname', '-r').stdout().strip()\n> > + kernel_version = run_command('uname', '-r', check: true).stdout().strip()\n> > if not kernel_version.version_compare(kernel_version_req)\n> > warning('The current running kernel version @0@ is too old to run libcamera.'\n> > .format(kernel_version))\n> > @@ -160,7 +161,8 @@ endif\n> > # Create a symlink from the build root to the source root. This is used when\n> > # running libcamera from the build directory to locate resources in the source\n> > # directory (such as IPA configuration files).\n> > -run_command('ln', '-fsT', meson.project_source_root(), meson.project_build_root() / 'source')\n> > +run_command('ln', '-fsT', meson.project_source_root(), meson.project_build_root() / 'source',\n> > + check: true)\n> > \n> > configure_file(output : 'config.h', configuration : config_h)\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7EDB9C0F2A\n\tfor ;\n\tThu, 5 May 2022 15:54:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D386865643;\n\tThu, 5 May 2022 17:54:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66B92603AB\n\tfor ;\n\tThu, 5 May 2022 17:54:18 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF43D492;\n\tThu, 5 May 2022 17:54:17 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651766059;\n\tbh=WmuByygTNtLAJNS8iCYdAaauWoRM8f7K1UI/YeH4ZoE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=4c8UzI50nlQWJ0f1LVyRWTxlZfPxYdCpVNkRgcDShXttssGlKh9YEEwskZQfXbXEa\n\tohK+GEcHkBdOdBmUGfeOYmnvZq2O4Ceg5bcudx13KquvoMxzX7Uzn8iZ3fgAc4NXDi\n\txNTsnwEI+Gcw+OCNQBpzC2ZNGfWPHcgNzZ2WwRcIkS/BDMSPMew3RtcyuFiHyL9OfA\n\tSHwMJtPklsfB7htl5wrhv2gbRdiDmGj9+gidNRKkwnMb6WhtzWZiApOnVCA0hmI9TP\n\tCBNY3FvdL/nVoZ+u2W6xE1Th2Wbk1QXlExRT6BeXGH976cmMP6eyb8Gaba51ziA2W4\n\tLWOkVn1sa3QOA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651766057;\n\tbh=WmuByygTNtLAJNS8iCYdAaauWoRM8f7K1UI/YeH4ZoE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Z3yby58rK2K/2QatWdLCiovhuR+xJbGaoO0CZr0xtPDvrQ9JP5Nf49W/I17mk6U28\n\tBy0ThI3oPFqZ3G1pmjj5QG3/8N5XFsQ7T23EPwbryioh7Mxx+7bmths+sAdxEUhe4J\n\tYXtXbHVY9Lw5sJ3P2OMcVyZ/JdeSOUZ3gbIs79wY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Z3yby58r\"; dkim-atps=neutral","Date":"Thu, 5 May 2022 18:54:14 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220505104104.70841-1-tomi.valkeinen@ideasonboard.com>\n\t<20220505104104.70841-4-tomi.valkeinen@ideasonboard.com>\n\t<165175402809.1217485.5442746798446918748@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<165175402809.1217485.5442746798446918748@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v7 03/13] meson: add 'check: true' for\n\trun_command() calls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]