[{"id":22852,"web_url":"https://patchwork.libcamera.org/comment/22852/","msgid":"<165175380662.1217485.8825438208806094208@Monstersaurus>","date":"2022-05-05T12:30:06","subject":"Re: [libcamera-devel] [PATCH v7 01/13] meson: require meson 0.56+","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Tomi Valkeinen (2022-05-05 11:40:52)\n> Ubuntu 22.04 LTS has been released with meson 0.61.2, and it is easy to\n> install a recent version of meson with python-pip, so let's update the\n> required meson version to get rid of the Android compilation\n> limitation.\n> \n> Additionally, going to meson 0.55 gives the ability to have patch files\n> for git-wraps which is useful for Python bindings.\n> \n> 0.56 brings meson.project_source_root() and meson.project_build_root(),\n> allowing us to get rid of the deprecated meson.source_root() and\n> meson.build_root().\n> \n> So, let's update the required meson version to 0.56.\n> \n\nSounds good to me!\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Tomi Valkeinen \n> ---\n> README.rst | 4 +---\n> meson.build | 6 +-----\n> 2 files changed, 2 insertions(+), 8 deletions(-)\n> \n> diff --git a/README.rst b/README.rst\n> index aae6b79f..ae5ede17 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -47,9 +47,7 @@ A C++ toolchain: [required]\n> Either {g++, clang}\n> \n> Meson Build system: [required]\n> - meson (>= 0.53) ninja-build pkg-config\n> -\n> - meson (>= 0.55) is required for building Android (-Dandroid=enabled)\n> + meson (>= 0.56) ninja-build pkg-config\n> \n> If your distribution doesn't provide a recent enough version of meson,\n> you can install or upgrade it using pip3.\n> diff --git a/meson.build b/meson.build\n> index 29d8542d..b892ba84 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -1,11 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> project('libcamera', 'c', 'cpp',\n> - # Use of the Android component requires meson 0.55, but Ubuntu 20.04 LTS\n> - # ships meson 0.53. Improve the Ubuntu experience at the expense of\n> - # Android as the former is a much more common use case than the latter at\n> - # this point. This should be fixed after Ubuntu releases 22.04 LTS.\n> - meson_version : '>= 0.53',\n> + meson_version : '>= 0.56',\n> version : '0.0.0',\n> default_options : [\n> 'werror=true',\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7C4C2C3256\n\tfor ;\n\tThu, 5 May 2022 12:30:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BDDE665643;\n\tThu, 5 May 2022 14:30:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F876603AB\n\tfor ;\n\tThu, 5 May 2022 14:30:10 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BCD694A8;\n\tThu, 5 May 2022 14:30:09 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651753811;\n\tbh=K/roIuz38MdTQ8iAGO57Phi8QgzmWOvFM0IS2tnRYaI=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=12fPwr5OCC290et5yizHqdRqQqGell6pIBdHKJ91DyqNDp7l7dS+mf7kOzovUun5Z\n\twzh+bZa0Lgwa7uFA/PvdhRelm/bQ+LvdejxDLDDt9T1vxwK6VfhRuCEEVCVA4+Iot7\n\tRPVvWqOdpFTQrn4Bh3X1/3SBpmpYwqdYDesAfSFAJqcqUQsqZeB2+lp+dPdcshA+le\n\tz5II0UhEhsj8wr46aghorY1Hg4aQiJ07ZP18UadxD6rklQC82IVEKvhxncuY8TQQ/t\n\tlxt7pM+6p1Rt1FNJU2F8eWxphJsLdId7gOAoe3oR+CDWn2rSYaHauhFtHCFJoCvMOV\n\taFeqL7JpOzdmA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651753809;\n\tbh=K/roIuz38MdTQ8iAGO57Phi8QgzmWOvFM0IS2tnRYaI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=TNIOSgSZFhduW/aOlOIQPQlmGVtNV4yu8HYWftPc5VKgm1p3b+Waoj7L1UtMDN3E7\n\tc0bh0QvbKo/isfY58kctO/TGbW1dYfhbfKQOv78JLLUWTjr13wim6sBE4XCYDDkVke\n\tB1ICL+2HNw9yVpYqmXA5ud5EWqycjxzo0qdX9x0M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"TNIOSgSZ\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220505104104.70841-2-tomi.valkeinen@ideasonboard.com>","References":"<20220505104104.70841-1-tomi.valkeinen@ideasonboard.com>\n\t<20220505104104.70841-2-tomi.valkeinen@ideasonboard.com>","To":"David Plowman ,\n\tJacopo Mondi ,\n\tLaurent Pinchart ,\n\tTomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 05 May 2022 13:30:06 +0100","Message-ID":"<165175380662.1217485.8825438208806094208@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v7 01/13] meson: require meson 0.56+","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22860,"web_url":"https://patchwork.libcamera.org/comment/22860/","msgid":"","date":"2022-05-05T14:31:54","subject":"Re: [libcamera-devel] [PATCH v7 01/13] meson: require meson 0.56+","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, May 05, 2022 at 01:30:06PM +0100, Kieran Bingham wrote:\n> Quoting Tomi Valkeinen (2022-05-05 11:40:52)\n> > Ubuntu 22.04 LTS has been released with meson 0.61.2, and it is easy to\n> > install a recent version of meson with python-pip, so let's update the\n> > required meson version to get rid of the Android compilation\n> > limitation.\n> > \n> > Additionally, going to meson 0.55 gives the ability to have patch files\n> > for git-wraps which is useful for Python bindings.\n> > \n> > 0.56 brings meson.project_source_root() and meson.project_build_root(),\n> > allowing us to get rid of the deprecated meson.source_root() and\n> > meson.build_root().\n> > \n> > So, let's update the required meson version to 0.56.\n> \n> Sounds good to me!\n> \n> Reviewed-by: Kieran Bingham \n\nDebian stable ships 0.56.2, so this looks good to me.\n\nReviewed-by: Laurent Pinchart \n\n> > Signed-off-by: Tomi Valkeinen \n> > ---\n> > README.rst | 4 +---\n> > meson.build | 6 +-----\n> > 2 files changed, 2 insertions(+), 8 deletions(-)\n> > \n> > diff --git a/README.rst b/README.rst\n> > index aae6b79f..ae5ede17 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -47,9 +47,7 @@ A C++ toolchain: [required]\n> > Either {g++, clang}\n> > \n> > Meson Build system: [required]\n> > - meson (>= 0.53) ninja-build pkg-config\n> > -\n> > - meson (>= 0.55) is required for building Android (-Dandroid=enabled)\n> > + meson (>= 0.56) ninja-build pkg-config\n> > \n> > If your distribution doesn't provide a recent enough version of meson,\n> > you can install or upgrade it using pip3.\n> > diff --git a/meson.build b/meson.build\n> > index 29d8542d..b892ba84 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -1,11 +1,7 @@\n> > # SPDX-License-Identifier: CC0-1.0\n> > \n> > project('libcamera', 'c', 'cpp',\n> > - # Use of the Android component requires meson 0.55, but Ubuntu 20.04 LTS\n> > - # ships meson 0.53. Improve the Ubuntu experience at the expense of\n> > - # Android as the former is a much more common use case than the latter at\n> > - # this point. This should be fixed after Ubuntu releases 22.04 LTS.\n> > - meson_version : '>= 0.53',\n> > + meson_version : '>= 0.56',\n> > version : '0.0.0',\n> > default_options : [\n> > 'werror=true',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 916D1C0F2A\n\tfor ;\n\tThu, 5 May 2022 14:32:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E73F465643;\n\tThu, 5 May 2022 16:32:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 306B4603AB\n\tfor ;\n\tThu, 5 May 2022 16:31:59 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6AAAD492;\n\tThu, 5 May 2022 16:31:58 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651761120;\n\tbh=q7qrpwW4BYDTL8RS5pk+cCzuO5TsJ4yaKGLUaO7Qqw4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=QTWjT590hbXfDsBy3js5w5pyBU1wTpieR68qWawagdF73a+8U6CEF7Ib6lLwRTyTT\n\tSGsxU0447SZ6xe4DQGwJ3lev8vIF2EgpQk4jbRCWBSqv7UUONYcnL1fqnFzTtFuvqp\n\toq/T8kevj2EOrdhFtyQ9CNuaVYIaHlEF2UXcCm+/eHhURZ4nrYKIJhKXZgLf+MoQkj\n\tHZpTOy5UkKEb614b2HfJHTrvxb3exowELqv9JF9xjgaS/Rdb4qWf+xkc95ME7knoV5\n\tpPFF24/qyCnm4iZhHkMvMhYxARFEy+hTGjoERhaVAoAAApVFU9nkJIw5WV0NAyhNr/\n\tEUaqXWVhm3Oiw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651761118;\n\tbh=q7qrpwW4BYDTL8RS5pk+cCzuO5TsJ4yaKGLUaO7Qqw4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ftHgx3bv/xN5znFteEG2zEAucJELpnu7PAeOlFMc/XGhlzttKK40LCAlY697nLcLY\n\tXlwxe6aQXYVylfN13LbRRLdVN0wVywlwvHQSthIq0w8Lsmjqly8uF3AydWOjvvxzZk\n\tA8S/hWI51iw7AS67GRAMHhRT8NhkbeeZWHP2esd0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ftHgx3bv\"; dkim-atps=neutral","Date":"Thu, 5 May 2022 17:31:54 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220505104104.70841-1-tomi.valkeinen@ideasonboard.com>\n\t<20220505104104.70841-2-tomi.valkeinen@ideasonboard.com>\n\t<165175380662.1217485.8825438208806094208@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<165175380662.1217485.8825438208806094208@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v7 01/13] meson: require meson 0.56+","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]