[{"id":22878,"web_url":"https://patchwork.libcamera.org/comment/22878/","msgid":"<20220506120424.qjhfminkgwefcmc2@uno.localdomain>","date":"2022-05-06T12:04:24","subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: formats: Add YVU422\n\tpixel format","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Wed, May 04, 2022 at 04:15:54PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The YVU422 pixel format is defined in both DRM and V4L2. libcamera\n> already supports YUV422, add support for the opposite chroma order.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/formats.cpp | 13 +++++++++++++\n> src/libcamera/formats.yaml | 2 ++\n> src/libcamera/v4l2_pixelformat.cpp | 2 ++\n> 3 files changed, 17 insertions(+)\n>\n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index afcaabc519f7..c5cca37b02c2 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -469,6 +469,19 @@ const std::map pixelFormatInfo{\n> \t\t.pixelsPerGroup = 2,\n> \t\t.planes = {{ { 2, 1 }, { 1, 1 }, { 1, 1 } }},\n> \t} },\n> +\t{ formats::YVU422, {\n> +\t\t.name = \"YVU422\",\n> +\t\t.format = formats::YVU422,\n> +\t\t.v4l2Formats = {\n> +\t\t\t.single = V4L2PixelFormat(),\n> +\t\t\t.multi = V4L2PixelFormat(V4L2_PIX_FMT_YVU422M),\n> +\t\t},\n> +\t\t.bitsPerPixel = 16,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 2,\n> +\t\t.planes = {{ { 2, 1 }, { 1, 1 }, { 1, 1 } }},\n> +\t} },\n>\n> \t/* Greyscale formats. */\n> \t{ formats::R8, {\n> diff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\n> index 1f3f043302c3..0b527dbefe32 100644\n> --- a/src/libcamera/formats.yaml\n> +++ b/src/libcamera/formats.yaml\n> @@ -69,6 +69,8 @@ formats:\n> fourcc: DRM_FORMAT_YVU420\n> - YUV422:\n> fourcc: DRM_FORMAT_YUV422\n> + - YVU422:\n> + fourcc: DRM_FORMAT_YVU422\n>\n> - MJPEG:\n> fourcc: DRM_FORMAT_MJPEG\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 1dd93baa7a64..818bd1037e14 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -113,6 +113,8 @@ const std::map vpf2pf{\n> \t\t{ formats::YUV422, \"Planar YUV 4:2:2\" } },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV422M),\n> \t\t{ formats::YUV422, \"Planar YUV 4:2:2 (N-C)\" } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV422M),\n\nThis should probably be V4L2_PIX_FMT_YVU422M\n\n> +\t\t{ formats::YVU422, \"Planar YVU 4:2:2 (N-C)\" } },\n>\n> \t/* Greyscale formats. */\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_GREY),\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E924AC0F2A\n\tfor ;\n\tFri, 6 May 2022 12:04:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 183D465646;\n\tFri, 6 May 2022 14:04:28 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A83B4604A3\n\tfor ;\n\tFri, 6 May 2022 14:04:26 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 1728E20010;\n\tFri, 6 May 2022 12:04:25 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651838668;\n\tbh=RsRY5jNaNk/Ze4Xcl2ikh8VOEz++oeQAb4G7yzhrRp4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=BSohTTtIHJ+s0XG4hsdOaKg1Jp7DLxJCX3bYPh+bxacCS0/0K3iDavIL4TW1/jH0+\n\tlf93HDVqTc6rMj/IjBvH1Hm+e8akmkYIOAhcjn8IdOab3WmNsn2TEYnnmTSMW5FORy\n\tEeTE4ASpl9RZ9xiJagkR4ISic2eszj8t5JBV8nxcZdtRtVRP1XV8TwMePHQi+ji/ge\n\tXVC5lq+bAPI8yXGWP3BYRRa/xSOtj6Bn63i7BM0A+wewj/f1zlLGovsC1jHDoWTaEh\n\tHCM3EfsdZYFj0vI5SFAN7Zt1H4jkpFjmR6FKpZ7Lp1lrA+SJd9EYM4ShP30InElc/D\n\tdsc02pZv3xZsA==","Date":"Fri, 6 May 2022 14:04:24 +0200","To":"Laurent Pinchart ","Message-ID":"<20220506120424.qjhfminkgwefcmc2@uno.localdomain>","References":"<20220504131558.9498-1-laurent.pinchart@ideasonboard.com>\n\t<20220504131558.9498-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220504131558.9498-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: formats: Add YVU422\n\tpixel format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]