[{"id":22830,"web_url":"https://patchwork.libcamera.org/comment/22830/","msgid":"<20220504071142.dnk5ksak6nbunikj@uno.localdomain>","date":"2022-05-04T07:11:42","subject":"Re: [libcamera-devel] [PATCH 2/3] Documentation: fix typos","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Quentin\n\nOn Tue, May 03, 2022 at 06:30:37PM +0200, Quentin Schulz via libcamera-devel wrote:\n> From: Quentin Schulz \n>\n> A few typos made it to the docs, so let's fix them.\n>\n> Cc: Quentin Schulz \n> Signed-off-by: Quentin Schulz \n> ---\n> Documentation/guides/introduction.rst | 2 +-\n> Documentation/guides/pipeline-handler.rst | 28 +++++++++++------------\n> 2 files changed, 15 insertions(+), 15 deletions(-)\n>\n> diff --git a/Documentation/guides/introduction.rst b/Documentation/guides/introduction.rst\n> index d080679f..07f66881 100644\n> --- a/Documentation/guides/introduction.rst\n> +++ b/Documentation/guides/introduction.rst\n> @@ -221,7 +221,7 @@ Camera Device\n> of producing one or more image streams, and provides the API to interact with\n> the underlying device.\n>\n> - If a system has multiple instances of the same hardware attached, each has it's\n> + If a system has multiple instances of the same hardware attached, each has its\n\nack\n\n> own instance of the camera class.\n>\n> The API exposes full control of the device to upper layers of libcamera through\n> diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> index a7208f57..989b0163 100644\n> --- a/Documentation/guides/pipeline-handler.rst\n> +++ b/Documentation/guides/pipeline-handler.rst\n> @@ -75,7 +75,7 @@ Prerequisite knowledge: libcamera architecture\n> ----------------------------------------------\n>\n> A pipeline handler makes use of the following libcamera classes to realize the\n> -functionalities descibed above. Below is a brief overview of each of those:\n> +functionalities described above. Below is a brief overview of each of those:\n\nack\n\n>\n> .. TODO: (All) Convert to sphinx refs\n> .. TODO: (MediaDevice) Reference to the Media Device API (possibly with versioning requirements)\n> @@ -405,7 +405,7 @@ Creating camera devices\n> If the pipeline handler successfully matches with the system it is running on,\n> it can proceed to initialization, by creating all the required instances of the\n> ``V4L2VideoDevice``, ``V4L2Subdevice`` and ``CameraSensor`` hardware abstraction\n> -classes. If the Pipeline handler supports an ISP, it can then also Initialise\n> +classes. If the Pipeline handler supports an ISP, it can then also initialise\n> the IPA module before proceeding to the creation of the Camera devices.\n>\n> An image ``Stream`` represents a sequence of images and data of known size and\n> @@ -687,8 +687,8 @@ and validated to adjust it to a supported configuration. This may involve\n> adjusting the formats or image sizes or alignments for example to match the\n> capabilities of the device.\n>\n> -Applications may choose to repeat validation stages, adjusting paramters until a\n> -set of validated StreamConfigurations are returned that is acceptable for the\n> +Applications may choose to repeat validation stages, adjusting parameters until\n> +a set of validated StreamConfigurations are returned that is acceptable for the\n\nack\n\n> applications needs. When the pipeline handler receives a valid camera\n> configuration it can use the image stream configurations to apply settings to\n> the hardware devices.\n> @@ -765,11 +765,11 @@ example (with only one stream), the pipeline handler always returns the same\n> configuration, inferred from the underlying V4L2VideoDevice.\n>\n> How it does this is shown below, but examination of the more full-featured\n> -pipelines for IPU3, RKISP1 and RaspberryPi are recommend to explore more\n> +pipelines for IPU3, RKISP1 and RaspberryPi are recommended to explore more\n\nack\n\n> complex examples.\n>\n> To generate a ``StreamConfiguration``, you need a list of pixel formats and\n> -frame sizes which supported outputs of the stream. You can fetch a map of the\n> +frame sizes supported by outputs of the stream. You can fetch a map of the\n\nI think what was meant is\n\nTo generate a ``StreamConfiguration``, you need a list of pixel formats and\nframe sizes which are supported as outputs of the stream. You can fetch a map of the\n\n\n> ``V4LPixelFormat`` and ``SizeRange`` supported by the underlying output device,\n> but the pipeline handler needs to convert this to a ``libcamera::PixelFormat``\n> type to pass to applications. We do this here using ``std::transform`` to\n> @@ -811,9 +811,9 @@ Continue adding the following code to support this:\n> StreamConfiguration cfg(formats);\n>\n> As well as a list of supported StreamFormats, the StreamConfiguration is also\n> -expected to provide an initialised default configuration. This may be arbitrary,\n> -but depending on use case you may which to select an output that matches the\n> -Sensor output, or prefer a pixelformat which might provide higher performance on\n> +expected to provide an initialised default configuration. This may be arbitrary,\n\nack\n\n> +but depending on use case you may wish to select an output that matches the\n\n'wish' or either simply 'want'\n\n> +Sensor output, or prefer a pixelFormat which might provide higher performance on\n\nI would rather use ``PixelFormat`` as the term indicates a libcamera\na type\n\n> the hardware. The bufferCount represents the number of buffers required to\n> support functional continuous processing on this stream.\n>\n> @@ -826,7 +826,7 @@ support functional continuous processing on this stream.\n> Finally add each ``StreamConfiguration`` generated to the\n> ``CameraConfiguration``, and ensure that it has been validated before returning\n> it to the application. With only a single supported stream, this code adds only\n> -a single StreamConfiguration however a StreamConfiguration should be added for\n> +a single StreamConfiguration. However a StreamConfiguration should be added for\n> each supported role in a device that can handle more streams.\n\nack\n\n>\n> Add the following code to complete the implementation of\n> @@ -841,7 +841,7 @@ Add the following code to complete the implementation of\n> return config;\n>\n> To validate a camera configuration, a pipeline handler must implement the\n> -`CameraConfiguration::validate()`_ function in it's derived class to inspect all\n> +`CameraConfiguration::validate()`_ function in its derived class to inspect all\n\nack\n\n> the stream configuration associated to it, make any adjustments required to make\n> the configuration valid, and return the validation status.\n>\n> @@ -1372,9 +1372,9 @@ classes documentation.\n> .. _libcamera Signal and Slot: http://libcamera.org/api-html/classlibcamera_1_1Signal.html#details\n>\n> In order to notify applications about the availability of new frames and data,\n> -the ``Camera`` device exposes two ``Signals`` which applications can connect to\n> -be notified of frame completion events. The ``bufferComplete`` signal serves to\n> -report to applications the completion event of a single ``Stream`` part of a\n> +the ``Camera`` device exposes two ``Signals`` to which applications can connect\n\nnot sure the 'to' is required. Native speakers ?\n\nHowever, all minor comments, if you agree they can be addressed when\napplying\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> +to be notified of frame completion events. The ``bufferComplete`` signal serves\n> +to report to applications the completion event of a single ``Stream`` part of a\n> ``Request``, while the ``requestComplete`` signal notifies the completion of all\n> the ``Streams`` and data submitted as part of a request. This mechanism allows\n> implementation of partial request completion, which allows an application to\n> --\n> 2.35.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 925D0C0F2A\n\tfor ;\n\tWed, 4 May 2022 07:11:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E16C865641;\n\tWed, 4 May 2022 09:11:45 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::222])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 89315604A3\n\tfor ;\n\tWed, 4 May 2022 09:11:44 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id EF4BE4000C;\n\tWed, 4 May 2022 07:11:43 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651648305;\n\tbh=k69/duwinTXtFr6BzpZ9Y7/9lFTj6V27yvM8WNck1VE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=L72IWtS5bke1hMdOMXbjgXVQ9JY0onbEjpMz3eIyYKRZbAFBxeaNmMxM4Sldo8y6W\n\tyBciCQb/Yl+2EacASIaMC6Q/9oGi/83LPd+HDeuejSv+Axma9sm8Qv8ZaByry5l/p3\n\ttGc+cVIxK/XgPIulDNIFgKXJo7/ZuEgFwmh0m7UwA5FKU+eOZ9tnkrpOxUX1HUjuv7\n\tYwF71Fdv4AaXPYaeOa51JJsS+MyC4luPvVmoXid8Hcwibt5BqEUiwufaxICTudg0iO\n\tOuNR/SaUHgOuVgF3diqbQJcNOX5e9Zkv8HtbELKZ+bD0lQIx9h3jb4F89M5KVINi8z\n\tOOoVmr7cUNzZg==","Date":"Wed, 4 May 2022 09:11:42 +0200","To":"Quentin Schulz ","Message-ID":"<20220504071142.dnk5ksak6nbunikj@uno.localdomain>","References":"<20220503163038.1174462-1-foss+libcamera@0leil.net>\n\t<20220503163038.1174462-2-foss+libcamera@0leil.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220503163038.1174462-2-foss+libcamera@0leil.net>","Subject":"Re: [libcamera-devel] [PATCH 2/3] Documentation: fix typos","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22841,"web_url":"https://patchwork.libcamera.org/comment/22841/","msgid":"","date":"2022-05-04T09:20:35","subject":"Re: [libcamera-devel] [PATCH 2/3] Documentation: fix typos","submitter":{"id":121,"url":"https://patchwork.libcamera.org/api/people/121/","name":"Quentin Schulz","email":"quentin.schulz@theobroma-systems.com"},"content":"Hi Jacopo,\n\nOn 5/4/22 09:11, Jacopo Mondi via libcamera-devel wrote:\n> Hi Quentin\n> \n> On Tue, May 03, 2022 at 06:30:37PM +0200, Quentin Schulz via libcamera-devel wrote:\n>> From: Quentin Schulz \n>>\n>> A few typos made it to the docs, so let's fix them.\n>>\n>> Cc: Quentin Schulz \n>> Signed-off-by: Quentin Schulz \n>> ---\n>> Documentation/guides/introduction.rst | 2 +-\n>> Documentation/guides/pipeline-handler.rst | 28 +++++++++++------------\n>> 2 files changed, 15 insertions(+), 15 deletions(-)\n>>\n>> diff --git a/Documentation/guides/introduction.rst b/Documentation/guides/introduction.rst\n>> index d080679f..07f66881 100644\n>> --- a/Documentation/guides/introduction.rst\n>> +++ b/Documentation/guides/introduction.rst\n>> @@ -221,7 +221,7 @@ Camera Device\n>> of producing one or more image streams, and provides the API to interact with\n>> the underlying device.\n>>\n>> - If a system has multiple instances of the same hardware attached, each has it's\n>> + If a system has multiple instances of the same hardware attached, each has its\n> \n> ack\n> \n>> own instance of the camera class.\n>>\n>> The API exposes full control of the device to upper layers of libcamera through\n>> diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n>> index a7208f57..989b0163 100644\n>> --- a/Documentation/guides/pipeline-handler.rst\n>> +++ b/Documentation/guides/pipeline-handler.rst\n>> @@ -75,7 +75,7 @@ Prerequisite knowledge: libcamera architecture\n>> ----------------------------------------------\n>>\n>> A pipeline handler makes use of the following libcamera classes to realize the\n>> -functionalities descibed above. Below is a brief overview of each of those:\n>> +functionalities described above. Below is a brief overview of each of those:\n> \n> ack\n> \n>>\n>> .. TODO: (All) Convert to sphinx refs\n>> .. TODO: (MediaDevice) Reference to the Media Device API (possibly with versioning requirements)\n>> @@ -405,7 +405,7 @@ Creating camera devices\n>> If the pipeline handler successfully matches with the system it is running on,\n>> it can proceed to initialization, by creating all the required instances of the\n>> ``V4L2VideoDevice``, ``V4L2Subdevice`` and ``CameraSensor`` hardware abstraction\n>> -classes. If the Pipeline handler supports an ISP, it can then also Initialise\n>> +classes. If the Pipeline handler supports an ISP, it can then also initialise\n>> the IPA module before proceeding to the creation of the Camera devices.\n>>\n>> An image ``Stream`` represents a sequence of images and data of known size and\n>> @@ -687,8 +687,8 @@ and validated to adjust it to a supported configuration. This may involve\n>> adjusting the formats or image sizes or alignments for example to match the\n>> capabilities of the device.\n>>\n>> -Applications may choose to repeat validation stages, adjusting paramters until a\n>> -set of validated StreamConfigurations are returned that is acceptable for the\n>> +Applications may choose to repeat validation stages, adjusting parameters until\n>> +a set of validated StreamConfigurations are returned that is acceptable for the\n> \n> ack\n> \n>> applications needs. When the pipeline handler receives a valid camera\n>> configuration it can use the image stream configurations to apply settings to\n>> the hardware devices.\n>> @@ -765,11 +765,11 @@ example (with only one stream), the pipeline handler always returns the same\n>> configuration, inferred from the underlying V4L2VideoDevice.\n>>\n>> How it does this is shown below, but examination of the more full-featured\n>> -pipelines for IPU3, RKISP1 and RaspberryPi are recommend to explore more\n>> +pipelines for IPU3, RKISP1 and RaspberryPi are recommended to explore more\n> \n> ack\n> \n>> complex examples.\n>>\n>> To generate a ``StreamConfiguration``, you need a list of pixel formats and\n>> -frame sizes which supported outputs of the stream. You can fetch a map of the\n>> +frame sizes supported by outputs of the stream. You can fetch a map of the\n> \n> I think what was meant is\n> \n> To generate a ``StreamConfiguration``, you need a list of pixel formats and\n> frame sizes which are supported as outputs of the stream. You can fetch a map of the\n> \n\nThanks, forgot to say I wasn't so sure about this one.\n\n> \n>> ``V4LPixelFormat`` and ``SizeRange`` supported by the underlying output device,\n>> but the pipeline handler needs to convert this to a ``libcamera::PixelFormat``\n>> type to pass to applications. We do this here using ``std::transform`` to\n>> @@ -811,9 +811,9 @@ Continue adding the following code to support this:\n>> StreamConfiguration cfg(formats);\n>>\n>> As well as a list of supported StreamFormats, the StreamConfiguration is also\n>> -expected to provide an initialised default configuration. This may be arbitrary,\n>> -but depending on use case you may which to select an output that matches the\n>> -Sensor output, or prefer a pixelformat which might provide higher performance on\n>> +expected to provide an initialised default configuration. This may be arbitrary,\n> \n> ack\n> \n>> +but depending on use case you may wish to select an output that matches the\n> \n> 'wish' or either simply 'want'\n> \n\nI modified which to wish. I'm not sure what you're suggesting now, can \nyou rephrase please?\n\n>> +Sensor output, or prefer a pixelFormat which might provide higher performance on\n> \n> I would rather use ``PixelFormat`` as the term indicates a libcamera\n> a type\n> \n\nThis shouldn't have made it to this patch since it's not a typo. I agree \nit should be ``PixelFormat``, but in another patch :)\n\n>> the hardware. The bufferCount represents the number of buffers required to\n>> support functional continuous processing on this stream.\n>>\n>> @@ -826,7 +826,7 @@ support functional continuous processing on this stream.\n>> Finally add each ``StreamConfiguration`` generated to the\n>> ``CameraConfiguration``, and ensure that it has been validated before returning\n>> it to the application. With only a single supported stream, this code adds only\n>> -a single StreamConfiguration however a StreamConfiguration should be added for\n>> +a single StreamConfiguration. However a StreamConfiguration should be added for\n>> each supported role in a device that can handle more streams.\n> \n> ack\n> \n>>\n>> Add the following code to complete the implementation of\n>> @@ -841,7 +841,7 @@ Add the following code to complete the implementation of\n>> return config;\n>>\n>> To validate a camera configuration, a pipeline handler must implement the\n>> -`CameraConfiguration::validate()`_ function in it's derived class to inspect all\n>> +`CameraConfiguration::validate()`_ function in its derived class to inspect all\n> \n> ack\n> \n>> the stream configuration associated to it, make any adjustments required to make\n>> the configuration valid, and return the validation status.\n>>\n>> @@ -1372,9 +1372,9 @@ classes documentation.\n>> .. _libcamera Signal and Slot: https://urldefense.proofpoint.com/v2/url?u=http-3A__libcamera.org_api-2Dhtml_classlibcamera-5F1-5F1Signal.html-23details&d=DwIBaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=UuonJkXB_70e1fcxpurWu4hQTzDeWE6U6W9UL1EHr9qbGUgawljHRfFpkA5uNBfm&s=X1c_zR2f-F9tgcfNiPaaDtoXYWJxBqZcVR4j550QSlc&e=\n>>\n>> In order to notify applications about the availability of new frames and data,\n>> -the ``Camera`` device exposes two ``Signals`` which applications can connect to\n>> -be notified of frame completion events. The ``bufferComplete`` signal serves to\n>> -report to applications the completion event of a single ``Stream`` part of a\n>> +the ``Camera`` device exposes two ``Signals`` to which applications can connect\n> \n> not sure the 'to' is required. Native speakers ?\n> \n\nIt sounded wrong this way to me (not native speaker here :) ).\n\nI had:\nthe camera device exposes two Signals which applications can connect to \nto be notified\nor\nthe camera device exposes two Signals to which applications can connect \nto be notified\n\nEither way, can't argue if it's already proper English with current \nstate of the docs :)\n\n> However, all minor comments, if you agree they can be addressed when\n> applying\n> \n\nI don't mind sending a v2, up to you.\n\nCheers,\nQuentin","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D392C3256\n\tfor ;\n\tWed, 4 May 2022 09:20:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C555765646;\n\tWed, 4 May 2022 11:20:40 +0200 (CEST)","from EUR04-HE1-obe.outbound.protection.outlook.com\n\t(mail-he1eur04on060d.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f400:fe0d::60d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EDE34604A3\n\tfor ;\n\tWed, 4 May 2022 11:20:38 +0200 (CEST)","from PA4PR04MB9367.eurprd04.prod.outlook.com (2603:10a6:102:2aa::7)\n\tby VI1PR04MB7181.eurprd04.prod.outlook.com (2603:10a6:800:12a::24)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25;\n\tWed, 4 May 2022 09:20:36 +0000","from PA4PR04MB9367.eurprd04.prod.outlook.com\n\t([fe80::28d3:b4fa:2319:83fb]) by\n\tPA4PR04MB9367.eurprd04.prod.outlook.com\n\t([fe80::28d3:b4fa:2319:83fb%5]) with mapi id 15.20.5206.025;\n\tWed, 4 May 2022 09:20:36 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651656040;\n\tbh=r4y6vnHJ6s1iHWyMHj0gM3Ok/VYX0+Fne4M9KpR201g=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=S42p+NR6qHZjoq79LDTRJ4pKvUQu+hpKSRwb4m6sNfvvnq+Z6u3TEzeapBmEuDm67\n\tYwwfJqhsyf2RvARIWuNr3oxq058r39vX2uR/k5pzEqpjdcLWHn/Lalp3a09PWZ3+xH\n\t1gaOrh++DTVBXcPNUQm2DYpnjbHhcxDxw3GYNbl6BoS3eDi6G79OFvwr+x9KgueEaC\n\tWYYu2TY2S6FZj17tyElpu4X8kKbpAPvkYXpRlr0GIH22pobw8rsQJ8rTbEnWxKJB6c\n\tBn3FL7nPtMppLSOG1Iolz5LKIDRUMWvpNL4fqryA1Wu+92lvvcL5OozTA688UjhYyQ\n\tgaZVbPlwWCB3g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cherrycloud.onmicrosoft.com; s=selector2-cherrycloud-onmicrosoft-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=vxEoUtsPd0yWo9fmPThMyY+BJuraiCt6ElgOg8J8V0U=;\n\tb=YntH07/MJ7WOZMEprcSifPDPJyNFPW37/3zqsK+SaigZmcWbFla5xOfSKxw2peBg5EIbmezHbIH4Z2yvS+Ip2i5tt3BbbnRejOardbD8AvAIE5YUtvJMbjID8c+OEZ+lHCM0c8wF2rthGN7chzSLPRiq43HIU7yP3y8RNnrHW7M="],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=cherrycloud.onmicrosoft.com\n\theader.i=@cherrycloud.onmicrosoft.com header.b=\"YntH07/M\"; \n\tdkim-atps=neutral","dkim=none (message not signed) header.d=none;\n\tdmarc=none action=none header.from=theobroma-systems.com; "],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=BdUQa0BWY7ZUNxcZyJawEcYc+BTdnifh1y4y4KSczy6Qk/e+xIPz+jb1FR2cI1ePJLm7Gca+qiNDt6rMXbBv80yRaait9bzfYQ/I8z5onqwJC1eLwehOiCg6ibhcfIVvBvhvOAm518K6eUIkTgAlql1WOFq5PmSYva0XKevfXLL2bw6E/AuS55yO/YrNvbfMuC4iZK8C0GtEHe9JhBVqKrCKx+Mf+F8GF4vm5tdOA+JdWgN+7hSHbr0r0y9UduSx7Rl3vXerhZsI3pP53wPGahfeTm7LWxsqJaHUqvxHdL7QI/GsmgGWzNTrMOWsG1ZMzjHbXFyQxDvURcB3urs8IA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=vxEoUtsPd0yWo9fmPThMyY+BJuraiCt6ElgOg8J8V0U=;\n\tb=JTRB0XWboZKrAMaE8DeyTP8zlkWN39+WWJJI0Qf4VdtTw65+zo31Mi5IV6lCHTW8HwbVHRfJ8H1mzNxK+EoVjkeojnMJj6MJqs8t1cmBypwLKs7fAUKhmTQlppb2xlqzPFUiO2kbO41dpBKQgPEjh62GmKUevNS2nhPV6w57dW51Uj/cUPQ5Ido2URS3R606JCMWfD86g5TkErGNnyk0k3nMuTNrndS4mRDi7SzSQW8PwI5UgWKNPMDdkPeXHKcWWvWm9D5l+sihkbALibLtVtFRva6zQ59G7T/RjbEptv6iZ402nXa5o5kCANLwQAltPFYs39S85Y1tQ4yJF3k/rg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=theobroma-systems.com; dmarc=pass action=none\n\theader.from=theobroma-systems.com;\n\tdkim=pass header.d=theobroma-systems.com; \n\tarc=none","Message-ID":"","Date":"Wed, 4 May 2022 11:20:35 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.8.0","Content-Language":"en-US","To":"Jacopo Mondi ,\n\tQuentin Schulz ","References":"<20220503163038.1174462-1-foss+libcamera@0leil.net>\n\t<20220503163038.1174462-2-foss+libcamera@0leil.net>\n\t<20220504071142.dnk5ksak6nbunikj@uno.localdomain>","In-Reply-To":"<20220504071142.dnk5ksak6nbunikj@uno.localdomain>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"AS8P189CA0022.EURP189.PROD.OUTLOOK.COM\n\t(2603:10a6:20b:31f::14) To PA4PR04MB9367.eurprd04.prod.outlook.com\n\t(2603:10a6:102:2aa::7)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"9cad71a7-1f07-4dd6-7524-08da2daf5923","X-MS-TrafficTypeDiagnostic":"VI1PR04MB7181:EE_","X-Microsoft-Antispam-PRVS":"","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;","X-Microsoft-Antispam-Message-Info":"MDkaRYzRyEK3805JzO+NLzq7PbUTTDTJekOc5Z35RuIo7Qm9s0xGboy2omABP+RWKfg6zzCBRcUUhDhH5X94tzBkPcEsGKarp/V2ePhuFXf8VNlI4nmxHzv/palA01Km1CeRiJ4u6vZMBYZZkxIkHhx5sqsUnoBqnv83Jt3Yuisr0eNM0o7B/1v5aQNsO1D4Vqj8sUy7AwNt++GBWzuqyc4mdKOQVQXZtxplza06vHSRL0Nf9H7gw1JbkPGG5ROE3I1LWDrRhiLElG86vBtStuaFiNXtBsbFt3ALm7C/NbfIQTX20BKENByKBagxjkNT/WTFEsCskO5pblbD820om8o+evkq88aOFvvPNBdn0Jc/xxTGw8pfdrHw0G7MOzcLu0RQUdE77YKJJvAVH13yePnBtVuJ+e5rg3auJntpmuxMIwfD7RmbAnEOKlfIGSGDlUnxx+qTWOTcsk0raHIEpWJqedtF3sLKAxilmPR5PmknXoj2l+7yrrI73wTDMrVebC9VLZg0EDssGxN67sxvRA4S64iCSVBTCiqkDDrVhtoSVSKbkrPsmO/lsaMhnPWwsnIZ3tyVEc7lbTtSHBTNAyCUSxBdYjMOIkQdzan+K0o7M5UFGhw9fXDNuhSCvqtL6FlQZUSV5pIIO9RFkaLMqSwBAqI/3CusziA3FePMioIilaTfcSimsUI+EBpKB2IVyHhqZwT1zsPC8d9nfFAQDOuNbYl/UMtd6eO5SBYuk1pggaBkt2kz3chWn7lc1PIo+JfBUd+0lcdV0f+t/8Kz4+N/SLrqigzTh8MMD8t/7PMg9MDFAK/PhsQ0zVM+McNZ","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:PA4PR04MB9367.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230001)(366004)(4326008)(2616005)(8936002)(186003)(5660300002)(86362001)(53546011)(83380400001)(44832011)(31696002)(6506007)(38100700002)(6486002)(966005)(26005)(6512007)(36756003)(31686004)(110136005)(8676002)(508600001)(2906002)(316002)(66556008)(66946007)(66476007)(43740500002)(45980500001);\n\tDIR:OUT; SFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?G+bw7QSPZFsPa7QtNOiX2CH5s?=\n\t=?utf-8?q?jNTzWc43/fUyOpaHb0dVzpIzKobKxDCpAphyf5gD6zG6KY8RuvnORWh8?=\n\t=?utf-8?q?JJm8lQxiPVvPE1muCzFn3/SitcGh8wlb1I7VYRJmcpwJMroHdMIeHraN?=\n\t=?utf-8?q?s8SQmeAf95/qWf6LbzY1IJs6srOWhZZPltz3OrTMo5fGPBBAP0J99Gk/?=\n\t=?utf-8?q?Cp2Zru0SDsBQdcIOfZAhxCg/R7Rblcb/Q1bBAmNmrhxSouwgTDoIuGRG?=\n\t=?utf-8?q?SmFmLCf6QJuSt6CDYRTtcyF+NI7BvL+GJNbqUGwYdKQWiDnbW2rrTuGK?=\n\t=?utf-8?q?kmS87nNlIa6AZf6o5d+QsdLdK1sMQDeGD8/6TbhgOPLerhjvE2mPmuGy?=\n\t=?utf-8?q?YgnzYa4NgBtn4ZHAt43QRboQ+Xwx0oZ2cVTCmC2FYW1RJPQ8DMGZuDzB?=\n\t=?utf-8?q?gsDY9G21elnuVRTzn7Wo2KSoNwsAuBBrC8PybLiGY5KxsJJ0Li+5kF/r?=\n\t=?utf-8?q?a2MXALfQxUq1ixNqUfdnyyWs1PEuyS/MSApkzdYcfFaeUldaDGjN5rKG?=\n\t=?utf-8?q?ooZp9S6bcdMsDoG0PbohjUArRX48ruHnGwhS9HKbf3DwgQCd++8PvBuG?=\n\t=?utf-8?q?naSPk4113LEHqVUx3cu73fBDSu/8i1KXNJ3HJs7QriV19TM0VI9Gkc/x?=\n\t=?utf-8?q?rZseAUQ7IHmh8gTDS+ZPvrAh3Or0YdsXdL+rUj8gR9Awn70KJn47rNPc?=\n\t=?utf-8?q?bj7qe00y/CGS0JmLnX+L3lduN9GAHgFq1hzvYFrvG7z3s3v1vuEj4CFA?=\n\t=?utf-8?q?8DHKaMaUz48Z7QNgSIDY2hYGsRTfclULw9drK/SOjnifi5sfc0IhcEqY?=\n\t=?utf-8?q?lqpC44tXPMDz2bZ0FtC3+YIWA6f+ndBhYPOG3xFIeZl44VaeOK8Dr/9G?=\n\t=?utf-8?q?Q2g8gVcMmthIx4QVujpYlyGL9PGWSTqOGdPIZQrYV15B0S7AEd4sid70?=\n\t=?utf-8?q?u+eudIGRZ2SsCE8XqUGqBcQpksmVPMjm2/MdA4rYRYmLe0llNgIwfFV+?=\n\t=?utf-8?q?csINTvgu1pl2aTa8Y3RIrAVrYGwd0fZ9jbcgQdI7/ia+brL9rsVVzkxC?=\n\t=?utf-8?q?0WAAaWVNd/qcV2snac4rZFaztu2MrV1jN9GBIaSpVKOPfcua7ov5EOGF?=\n\t=?utf-8?q?o7PuIgt7w4t/Y193IktBWZ6mWmrJLhvNRfE9yY82PvhkiOCxAAPrtnri?=\n\t=?utf-8?q?G1FcqWAZ36qDTugd+nlB6MlfNcrKeyLIXWhUxdeGoXznvsGmVGW8znVv?=\n\t=?utf-8?q?HoCAlHMJtY4mF5DHGyLE9ffe151DNsMfVCSRuZE4qWitYFztmUApv+EH?=\n\t=?utf-8?q?scVYo/TdKlUuL2iZNnqRdU90oxRm/qlUifdP8mRJsU5FQtAdnfsjBadt?=\n\t=?utf-8?q?9mce/LjfxtuT6GKLY7wUJHx8LaxE2fTV470w9Iay8WYds6GpFAoFZ4hf?=\n\t=?utf-8?q?tLjHs1RmwHiIPOS099Adj4Z1laN5muFKCeoIP6vw4beYh6wVXkw4qHv5?=\n\t=?utf-8?q?ogqV8h6MpO1J4JjHSFS1z4NxeimDt/qKdbO78fc2A/D/6o0j6fR8MCgg?=\n\t=?utf-8?q?mJ+YqbAxWYkZX/SbzkG5Wesn2QeznwgZlnai/QzoOyQ3yHvkfpjGIERc?=\n\t=?utf-8?q?WUYhXt0X36wDiytiDVaWBtHTKe6z8o8b1Wi969lglRb5FsJT2acWot6A?=\n\t=?utf-8?q?5Rb8uykUERIgiJGpthFgggklfxyvS0JulBeuuhsVUsmpz5UNe1Sh/dlp?=\n\t=?utf-8?q?WeyqBA7X2x6OmkvUvZEJDYe67Sg1JGqOJ9RT7n14HytiWMPUEfwOYDC5?=\n\t=?utf-8?q?ALy/wMe7DnP6CQ5SMLnQxCQZk1KFQGN1S66HLc35i/paEv6CnLRpEODi?=\n\t=?utf-8?q?QzxtfTsgYk3tGSlMguwRNgmQB+nZa9f?=","X-OriginatorOrg":"theobroma-systems.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"9cad71a7-1f07-4dd6-7524-08da2daf5923","X-MS-Exchange-CrossTenant-AuthSource":"PA4PR04MB9367.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"04 May 2022 09:20:36.5150\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"5e0e1b52-21b5-4e7b-83bb-514ec460677e","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"TjEVvEcVSxSa4JCCdHx4Nb0B3C5Dk8WR0R95TsJMy7lEdKLDyuyLT97XoNRCm+Pwp8l9dLtmquEJCk2vtt1eMPzh6ZGWIh2cb8yj6NJkCE7R06oD0jGVkTxZ0q7lXT3A","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR04MB7181","Subject":"Re: [libcamera-devel] [PATCH 2/3] Documentation: fix typos","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Quentin Schulz via libcamera-devel\n\t","Reply-To":"Quentin Schulz ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22843,"web_url":"https://patchwork.libcamera.org/comment/22843/","msgid":"<165165734009.4076486.4446716306670471217@Monstersaurus>","date":"2022-05-04T09:42:20","subject":"Re: [libcamera-devel] [PATCH 2/3] Documentation: fix typos","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi via libcamera-devel (2022-05-04 08:11:42)\n> Hi Quentin\n> \n> On Tue, May 03, 2022 at 06:30:37PM +0200, Quentin Schulz via libcamera-devel wrote:\n> > From: Quentin Schulz \n> >\n> > A few typos made it to the docs, so let's fix them.\n> >\n> > Cc: Quentin Schulz \n> > Signed-off-by: Quentin Schulz \n> > ---\n> > Documentation/guides/introduction.rst | 2 +-\n> > Documentation/guides/pipeline-handler.rst | 28 +++++++++++------------\n> > 2 files changed, 15 insertions(+), 15 deletions(-)\n> >\n> > diff --git a/Documentation/guides/introduction.rst b/Documentation/guides/introduction.rst\n> > index d080679f..07f66881 100644\n> > --- a/Documentation/guides/introduction.rst\n> > +++ b/Documentation/guides/introduction.rst\n> > @@ -221,7 +221,7 @@ Camera Device\n> > of producing one or more image streams, and provides the API to interact with\n> > the underlying device.\n> >\n> > - If a system has multiple instances of the same hardware attached, each has it's\n> > + If a system has multiple instances of the same hardware attached, each has its\n> \n> ack\n> \n> > own instance of the camera class.\n> >\n> > The API exposes full control of the device to upper layers of libcamera through\n> > diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> > index a7208f57..989b0163 100644\n> > --- a/Documentation/guides/pipeline-handler.rst\n> > +++ b/Documentation/guides/pipeline-handler.rst\n> > @@ -75,7 +75,7 @@ Prerequisite knowledge: libcamera architecture\n> > ----------------------------------------------\n> >\n> > A pipeline handler makes use of the following libcamera classes to realize the\n> > -functionalities descibed above. Below is a brief overview of each of those:\n> > +functionalities described above. Below is a brief overview of each of those:\n> \n> ack\n> \n> >\n> > .. TODO: (All) Convert to sphinx refs\n> > .. TODO: (MediaDevice) Reference to the Media Device API (possibly with versioning requirements)\n> > @@ -405,7 +405,7 @@ Creating camera devices\n> > If the pipeline handler successfully matches with the system it is running on,\n> > it can proceed to initialization, by creating all the required instances of the\n> > ``V4L2VideoDevice``, ``V4L2Subdevice`` and ``CameraSensor`` hardware abstraction\n> > -classes. If the Pipeline handler supports an ISP, it can then also Initialise\n> > +classes. If the Pipeline handler supports an ISP, it can then also initialise\n> > the IPA module before proceeding to the creation of the Camera devices.\n> >\n> > An image ``Stream`` represents a sequence of images and data of known size and\n> > @@ -687,8 +687,8 @@ and validated to adjust it to a supported configuration. This may involve\n> > adjusting the formats or image sizes or alignments for example to match the\n> > capabilities of the device.\n> >\n> > -Applications may choose to repeat validation stages, adjusting paramters until a\n> > -set of validated StreamConfigurations are returned that is acceptable for the\n> > +Applications may choose to repeat validation stages, adjusting parameters until\n> > +a set of validated StreamConfigurations are returned that is acceptable for the\n> \n> ack\n> \n> > applications needs. When the pipeline handler receives a valid camera\n> > configuration it can use the image stream configurations to apply settings to\n> > the hardware devices.\n> > @@ -765,11 +765,11 @@ example (with only one stream), the pipeline handler always returns the same\n> > configuration, inferred from the underlying V4L2VideoDevice.\n> >\n> > How it does this is shown below, but examination of the more full-featured\n> > -pipelines for IPU3, RKISP1 and RaspberryPi are recommend to explore more\n> > +pipelines for IPU3, RKISP1 and RaspberryPi are recommended to explore more\n> \n> ack\n> \n> > complex examples.\n> >\n> > To generate a ``StreamConfiguration``, you need a list of pixel formats and\n> > -frame sizes which supported outputs of the stream. You can fetch a map of the\n> > +frame sizes supported by outputs of the stream. You can fetch a map of the\n> \n> I think what was meant is\n> \n> To generate a ``StreamConfiguration``, you need a list of pixel formats and\n> frame sizes which are supported as outputs of the stream. You can fetch a map of the\n\nYes, I'd go with this one. It's describing how a single\nStreamConfiguration should be constructed. And they are not supported by\noutputs, they 'are' the output.\n\n\n> > ``V4LPixelFormat`` and ``SizeRange`` supported by the underlying output device,\n> > but the pipeline handler needs to convert this to a ``libcamera::PixelFormat``\n> > type to pass to applications. We do this here using ``std::transform`` to\n> > @@ -811,9 +811,9 @@ Continue adding the following code to support this:\n> > StreamConfiguration cfg(formats);\n> >\n> > As well as a list of supported StreamFormats, the StreamConfiguration is also\n> > -expected to provide an initialised default configuration. This may be arbitrary,\n> > -but depending on use case you may which to select an output that matches the\n> > -Sensor output, or prefer a pixelformat which might provide higher performance on\n> > +expected to provide an initialised default configuration. This may be arbitrary,\n> \n> ack\n\nI can't actually see any change in that line which is added here?\n\n> \n> > +but depending on use case you may wish to select an output that matches the\n> \n> 'wish' or either simply 'want'\n\nI expect the original intent was wish - but I don't mind wish or want.\n\n> \n> > +Sensor output, or prefer a pixelFormat which might provide higher performance on\n> \n> I would rather use ``PixelFormat`` as the term indicates a libcamera\n> a type\n\n\nYes, PixelFormat is better here than both pixelformat and pixelFormat.\n\n> \n> > the hardware. The bufferCount represents the number of buffers required to\n> > support functional continuous processing on this stream.\n> >\n> > @@ -826,7 +826,7 @@ support functional continuous processing on this stream.\n> > Finally add each ``StreamConfiguration`` generated to the\n> > ``CameraConfiguration``, and ensure that it has been validated before returning\n> > it to the application. With only a single supported stream, this code adds only\n> > -a single StreamConfiguration however a StreamConfiguration should be added for\n> > +a single StreamConfiguration. However a StreamConfiguration should be added for\n> > each supported role in a device that can handle more streams.\n> \n> ack\n> \n> >\n> > Add the following code to complete the implementation of\n> > @@ -841,7 +841,7 @@ Add the following code to complete the implementation of\n> > return config;\n> >\n> > To validate a camera configuration, a pipeline handler must implement the\n> > -`CameraConfiguration::validate()`_ function in it's derived class to inspect all\n> > +`CameraConfiguration::validate()`_ function in its derived class to inspect all\n> \n> ack\n> \n> > the stream configuration associated to it, make any adjustments required to make\n> > the configuration valid, and return the validation status.\n> >\n> > @@ -1372,9 +1372,9 @@ classes documentation.\n> > .. _libcamera Signal and Slot: http://libcamera.org/api-html/classlibcamera_1_1Signal.html#details\n> >\n> > In order to notify applications about the availability of new frames and data,\n> > -the ``Camera`` device exposes two ``Signals`` which applications can connect to\n> > -be notified of frame completion events. The ``bufferComplete`` signal serves to\n> > -report to applications the completion event of a single ``Stream`` part of a\n> > +the ``Camera`` device exposes two ``Signals`` to which applications can connect\n> \n> not sure the 'to' is required. Native speakers ?\n\nI'm not 100% sure of the grammar rules there but I actually like the\nextra 'to'.\n\nSignals are 'connected to' something, so I could imagine this could\n(/should) read:\n\n\"which applications can connect to - to be notified\"\n\nHaving the first 'to' early still makes sense, and prevents the double\n'to to'.\n\n> However, all minor comments, if you agree they can be addressed when\n> applying\n> \n> Reviewed-by: Jacopo Mondi \n\n\nReviewed-by: Kieran Bingham \n\n\n\n> \n> Thanks\n> j\n> \n> > +to be notified of frame completion events. The ``bufferComplete`` signal serves\n> > +to report to applications the completion event of a single ``Stream`` part of a\n> > ``Request``, while the ``requestComplete`` signal notifies the completion of all\n> > the ``Streams`` and data submitted as part of a request. This mechanism allows\n> > implementation of partial request completion, which allows an application to\n> > --\n> > 2.35.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C209C3256\n\tfor ;\n\tWed, 4 May 2022 09:42:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E933965641;\n\tWed, 4 May 2022 11:42:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C76FB604A3\n\tfor ;\n\tWed, 4 May 2022 11:42:22 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2CE73E5;\n\tWed, 4 May 2022 11:42:22 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651657343;\n\tbh=SQV02r6frtgoLAeYQ6njfpdxSsFl55RpI4hjE4FlqSc=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=SjewxSd9iiwtMKcX7AII0yfW+UcvgJcTd5E+Do1pHEVf0Sw1YeqYzTB9OigoVHLXo\n\t8nSS7GxNZn0fTUvgZQJmfH5/NBY26FXLJqAhKoFbXZzovTAuYUO/hVDo2z/MuGHQrB\n\t1eZMky9E/5BALuGc0Ydfyawbd1AbVSi7DP3bH1ZTwjCLRWz1gJ9Xss8snAlVfR1MHZ\n\t3MWjMkCnF0/pY/bT/amPiZM3r686+7z+u3WTQw0dxQA5x1kBf4Oe0iuxgTPRExj3dq\n\tndQ9gLGc/6myToinOLnfi3DHsBNofg9+TNOs6W4wR4xh9FzowZ8czzzpU/IGWsSM9K\n\tF3LyL0UpgrpGw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651657342;\n\tbh=SQV02r6frtgoLAeYQ6njfpdxSsFl55RpI4hjE4FlqSc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=jhJZpIzm0fKwXflMEyPDzm/E8T/u2E0U+erJwmMay7QmhQ1ceK8/HBPui8AGslEAe\n\tg0ypsGDitbAkU5U3p5GrrkMJHGlEmef/kLWhKKxhBU/fq47jq7XV4Y6VaZiG8MDTYH\n\tS5VL0ETj8rgHzU5HRteZ/f8WuwXnQECPP8q5uAj4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jhJZpIzm\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220504071142.dnk5ksak6nbunikj@uno.localdomain>","References":"<20220503163038.1174462-1-foss+libcamera@0leil.net>\n\t<20220503163038.1174462-2-foss+libcamera@0leil.net>\n\t<20220504071142.dnk5ksak6nbunikj@uno.localdomain>","To":"Jacopo Mondi , Jacopo Mondi via libcamera-devel\n\t, \n\tQuentin Schulz ","Date":"Wed, 04 May 2022 10:42:20 +0100","Message-ID":"<165165734009.4076486.4446716306670471217@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 2/3] Documentation: fix typos","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22845,"web_url":"https://patchwork.libcamera.org/comment/22845/","msgid":"","date":"2022-05-04T09:56:22","subject":"Re: [libcamera-devel] [PATCH 2/3] Documentation: fix typos","submitter":{"id":121,"url":"https://patchwork.libcamera.org/api/people/121/","name":"Quentin Schulz","email":"quentin.schulz@theobroma-systems.com"},"content":"Hi Kieran,\n\nOn 5/4/22 11:42, Kieran Bingham via libcamera-devel wrote:\n> Quoting Jacopo Mondi via libcamera-devel (2022-05-04 08:11:42)\n>> Hi Quentin\n>>\n>> On Tue, May 03, 2022 at 06:30:37PM +0200, Quentin Schulz via libcamera-devel wrote:\n>>> From: Quentin Schulz \n>>>\n>>> A few typos made it to the docs, so let's fix them.\n>>>\n>>> Cc: Quentin Schulz \n>>> Signed-off-by: Quentin Schulz \n>>> ---\n[...]\n>>> ``V4LPixelFormat`` and ``SizeRange`` supported by the underlying output device,\n>>> but the pipeline handler needs to convert this to a ``libcamera::PixelFormat``\n>>> type to pass to applications. We do this here using ``std::transform`` to\n>>> @@ -811,9 +811,9 @@ Continue adding the following code to support this:\n>>> StreamConfiguration cfg(formats);\n>>>\n>>> As well as a list of supported StreamFormats, the StreamConfiguration is also\n>>> -expected to provide an initialised default configuration. This may be arbitrary,\n>>> -but depending on use case you may which to select an output that matches the\n>>> -Sensor output, or prefer a pixelformat which might provide higher performance on\n>>> +expected to provide an initialised default configuration. This may be arbitrary,\n>>\n>> ack\n> \n> I can't actually see any change in that line which is added here?\n> \n\nMmmm. Don't know what Jacopo did to the git diff but the patch has the \ntypo in the original file :)\n\ns/initialsed/initialised/\n\ns/which/wish/\n\nCheers,\nQuentin","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2B0F1C3256\n\tfor ;\n\tWed, 4 May 2022 09:56:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 752BA65641;\n\tWed, 4 May 2022 11:56:27 +0200 (CEST)","from EUR02-HE1-obe.outbound.protection.outlook.com\n\t(mail-he1eur02on0625.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f400:fe05::625])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31B67604A3\n\tfor ;\n\tWed, 4 May 2022 11:56:26 +0200 (CEST)","from PA4PR04MB9367.eurprd04.prod.outlook.com (2603:10a6:102:2aa::7)\n\tby PAXPR04MB8224.eurprd04.prod.outlook.com (2603:10a6:102:1cb::23)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25;\n\tWed, 4 May 2022 09:56:24 +0000","from PA4PR04MB9367.eurprd04.prod.outlook.com\n\t([fe80::28d3:b4fa:2319:83fb]) by\n\tPA4PR04MB9367.eurprd04.prod.outlook.com\n\t([fe80::28d3:b4fa:2319:83fb%5]) with mapi id 15.20.5206.025;\n\tWed, 4 May 2022 09:56:24 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651658187;\n\tbh=ZK+6GaKCmEK2BtkZzBLnYk/4CGJXtgen/65RXRhshLA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Xn+lQS7rGYEn/X8AAfAH/cd9KdNmqgoy7JHIBE1AOnmLVpTv7NWW6Ns16qLR6XB3o\n\to6V6xLwaDwekqN/aTLykRImDqyM1QARvoiqmTLoBfITRhqtcpnuzrTaj+ZdqqHB503\n\tvb7E0lMRJmnosKzLe1GEwe1dd/1O4JAtCIzY0uB7wGt8nXkMwiXIDD8ysOiLNeZ8V4\n\tHvixzmRCiXiXVKgOm4Dd8RBX3LwuU8m7mtja/wkIcHUlusx6jnNIQJKGAAIUFYGXQn\n\tzkPxXyNTfOxfQsM75gDWklHS8M432ffualZLKC/o2y+bPrVU/UVl6GGMBa4CkaSvG2\n\te/gCxZVHOVwtw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cherrycloud.onmicrosoft.com; s=selector2-cherrycloud-onmicrosoft-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=BLlk7bj+mZdEVDKURId1/S1hIB1Lrzv9AfmQEMemlBk=;\n\tb=p2mowcwdh39uYTmKf/SJLTp+ZqZAdeheiIHMM1of4DFHr5ZOLIgxdQnjqd8bk2nZj/nCoLyvEzFVAVya0vUGOLAVikuPJnxwdB59I0+wXoi5lhUCCwIasDYm3C2lS75iDUSNCjtKlAKAuvShJDAgeiRMzpLEiHKg5DKxpS3+A7A="],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=cherrycloud.onmicrosoft.com\n\theader.i=@cherrycloud.onmicrosoft.com header.b=\"p2mowcwd\"; \n\tdkim-atps=neutral","dkim=none (message not signed) header.d=none;\n\tdmarc=none action=none header.from=theobroma-systems.com; "],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=l5qrvZSvShAMmy6OcE2MznlTNwqm0G/xj/Q7oyj3WVWmMs7xAIhKV8MXkqRaoF3VkHQlMXbL2Y1hrR/BF1q9D8/Li+5DaPawIyg0bclL2j9bVtmZ6GHkv3wnRqZAHTrH1YZDpL5kEzUQlaQCx6Rtv5ap0YszXIbU3Nfkoum4y1H9vjgdNQZCsWiS3rLq9W4VBQmYSsgjJZCx8JqrMA6bD+GtBFuXbP9cxn36v2934EqmrXrXj0gAZZJC06TmS/3TfvhyYi3+ym2PVaRyTyYlFHjlKJ7+gF/4zgLGmIzTSlytbjYqjKSPy9iZqkf+/CmESee28qZfiefb/kviVYf1rg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=BLlk7bj+mZdEVDKURId1/S1hIB1Lrzv9AfmQEMemlBk=;\n\tb=WeYoh/6htCWsxo3kUJ5zXJnrYVEbnJKUwKlvd/OwypxDv3zjiqwZ940GT/Ny+BCL5LLQSvHglFlx8+FLPvQBNNbb4Jk9FX9mYAAHst0GQO1IokOF74i8FfKGI9oGOChX+k7Z1KI7sWCG57LjnpL0j8CNXd/uaPR7H4/gDyJLxYZE90XdqCxyULnAJnH3H2zj25PwxcRFN7cZZ6R5Vd8uAtc8eMe3r2r1hav7landUh0xyzAo4pO5A6//SfGoCG53NE4Kpepp2/vLB4DzJWYD2kN6A92TNHhYDbLi4zhUUJc5KIwz2SBHHnVF/N54jDza1vJDtZY9BKVDoPc+4NrujA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=theobroma-systems.com; dmarc=pass action=none\n\theader.from=theobroma-systems.com;\n\tdkim=pass header.d=theobroma-systems.com; \n\tarc=none","Message-ID":"","Date":"Wed, 4 May 2022 11:56:22 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.8.0","Content-Language":"en-US","To":"Kieran Bingham ,\n\tJacopo Mondi , Jacopo Mondi via libcamera-devel\n\t, \n\tQuentin Schulz ","References":"<20220503163038.1174462-1-foss+libcamera@0leil.net>\n\t<20220503163038.1174462-2-foss+libcamera@0leil.net>\n\t<20220504071142.dnk5ksak6nbunikj@uno.localdomain>\n\t<165165734009.4076486.4446716306670471217@Monstersaurus>","In-Reply-To":"<165165734009.4076486.4446716306670471217@Monstersaurus>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"AM6PR04CA0020.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:92::33) To PA4PR04MB9367.eurprd04.prod.outlook.com\n\t(2603:10a6:102:2aa::7)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"d5b2f7b4-babb-4005-466e-08da2db45929","X-MS-TrafficTypeDiagnostic":"PAXPR04MB8224:EE_","X-Microsoft-Antispam-PRVS":"","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;","X-Microsoft-Antispam-Message-Info":"ruxe577ZGTp7Eu8sy0AP64QgfuXaV97qbkbSBC4J4LsQZgkdQGUZwCdz69DcEOv0MwZuiDLC4j/4FbQ6Ibx03wX5TkhJADEx0LGI82+0qTaMeKUeAAHVZEd5Ttk2tDnQYIDcrrTMHwkOAnKunRGWlXJ8rmV6Zqf4CXTJmrUBcJ2OfScnVBfnDyQpSUiSuZwbel2+FzXnzlnEVfFtvxYQWkntRuCV+yuBOSq6zpG7RccL3I86uOZP6TaQ56+6Du8+2Pz92jWm6j6IXsjfPZ90x+MAGnP1KbyxxIj1lvSDzuJQzeSqDxvnlD5OeGoHjKoXS9eiv8ZpcNlT+H7mKUYKibclzS4bkdaqsy87p/YqsshocdYtr9daUp6obEi7U+9swr5ffQVksULrtl6v5t5o7G96IfmPOWnnf8AeLEwK147tNqaNzP5oNh6xlYYCgckLpJwaTH3y28cxJYyS+dydDM9yvtSboYwuxObC8tb4/SkBq99/4nkyb7iAgoygy26hw8iGyBQF+0Zwd2NSX7kRlWYU6h23c39SKp6hvs+p4S/p2t3ANffBa8j+JbEa1ZwhijUfvEaODvk+TEvVViIfH5hMoKFldF/u4PJeVHwJgHvMBswnDUEpmHBbO/gob75sQoSnUQ7leOVZQ9zSrEwiw/lPPfrR7cwjHqTLdMe48kg+5i4ps2+gl4dy9O6+3wSxu+BFX2Nwz39n+benZDeJ9LwEx/JCOfJyaKtmF9xfwMw=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:PA4PR04MB9367.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230001)(366004)(110136005)(36756003)(8936002)(66946007)(44832011)(316002)(86362001)(31696002)(2906002)(26005)(53546011)(6506007)(66476007)(66556008)(6512007)(8676002)(31686004)(508600001)(2616005)(186003)(6486002)(5660300002)(38100700002)(43740500002)(45980500001);\n\tDIR:OUT; SFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?YeZZT4wuZdv0V6BplUZIe5a8N?=\n\t=?utf-8?q?3SrVJyq9r00Vg0ng4mvtkw/PkJx7xpuJ/SCuaMRVwUPz+e4kwFoXBYSV?=\n\t=?utf-8?q?jEaGiumclNVJGu6L0dTMOBPnrIa1WjOx3eEykCgMshQZl+HPBz59aCd2?=\n\t=?utf-8?q?nGHcJXT1h6Q36rxmDrpoI4dHARebxZntNNo8FPsHG7oX6kq57CmBixNa?=\n\t=?utf-8?q?QwNywzvQkx+/1Z1HQH0SGDN9LZMm4gewG7TrB4BdRDgQGfNuJP6zA4iL?=\n\t=?utf-8?q?iHN2zMU9TPFljnFct2ToS1U6HASxBVVlVdnOK2Xhceo8+S8Csvla1Ywc?=\n\t=?utf-8?q?AXplyUVS7yWKwUrvUVzXScKhagA6V5Q5L2MgE46IKlXPt+5PMTs5uWjz?=\n\t=?utf-8?q?uAGNPhDbxDzw0r4UtnpVbwjWvfHScbPV+TRv50UlHgvi0ygGhafBWC78?=\n\t=?utf-8?q?pPNrMRwHD7wS2szxctcE8ByMl2gDZIHbMfmco6e2x4WETtZu0GcAISLm?=\n\t=?utf-8?q?4sXWoAh52XCHcCTEnyMisCyDID9IzS+vWUQlyOas4H4kBaqiNmO7bGhY?=\n\t=?utf-8?q?houEKsfXsZeqVzg2c0UblWamo9zmVE3w87aq0yBvSj1xYexLWtwhZ++Z?=\n\t=?utf-8?q?Snbn0sFc6v2SgBS2YmyPZU+wPX4sQL4wssm/N6k8oarl1z5dSzanbJdH?=\n\t=?utf-8?q?Cx2v84liaiwCeNvSYUJsYCTPCDC8DEINhi1B+sqWpZkbpozAQm/g8ztP?=\n\t=?utf-8?q?0d0J2PF60HiT0nkVmkzj43TGr9nKZwtPSJIbh0jXx5SsPgrHKtF98VAh?=\n\t=?utf-8?q?cD780oCYtFsNBVgHtwAmff/NVmkBI7ILrCeMyINlaLrnBvApUmg2ld45?=\n\t=?utf-8?q?JdlrARp1RtXWDPlHIbSJg14wicb/JTPaij8i3OrzgpbenzX9clsv4Dpn?=\n\t=?utf-8?q?rK0cnmwTHBgwORvV1yVRC7/XjKI8LsZqC4jDzd1liztTYWu2E1XAT8py?=\n\t=?utf-8?q?5EipCrVtJJoiuWHWWFbNBe9NDnNO9Qzl3iaOkVLEMf1ui5UZPwCwZvZ4?=\n\t=?utf-8?q?Qn77qXovmeBr88wBshxRpVXsb01I7ASsu+17PRHkHWRNx+CS+P1eBnIh?=\n\t=?utf-8?q?IjQ7PSI9vL+wCa0dZbYOqQThNYbMoqDOLl49ICNsRQWg5MJECWydUecF?=\n\t=?utf-8?q?rB1kSt0aIrJCYbLpKTLbEw8DnFeiKZdWWmyoa4ep/n5wAAsyX7+1P/Y8?=\n\t=?utf-8?q?Wu3bgpOmj+RrVNmK2DWE05WBTkccbMXrjNt+/ctxGRuIcLJqm0/CFoU8?=\n\t=?utf-8?q?H2M/K2N76/IKre44Z8HYukM9vXCHrbJbQbA/vzmAeS4DLhBdOVjMTHBX?=\n\t=?utf-8?q?Cs1OeBPRq9fejvCv57wG9T7VSC0alL9uqjzGCo4N/qOqo8C1CdnHG2Y/?=\n\t=?utf-8?q?CW9s13fIKyeao65irBUIGk4BNgXW98ah7k1kd+zsy76M/wrUZqCK/nGs?=\n\t=?utf-8?q?LPaKJXYgAHu7kxouccr5KywGBSCqIUfOG7dSCLkuo3EFes8PZIfFxWQF?=\n\t=?utf-8?q?NKE+10J28Co+0v7eLZ9n6rvZQF+CdwhXjQT2gBeYFlwqMAOEEtPh5JrY?=\n\t=?utf-8?q?MtoPJGDSy1oqsWXQGeq8/AqD/YuLMfP5wz0Q9DWDkvFrUOeHZ9fCsVxJ?=\n\t=?utf-8?q?xFyV/oUiBcwkzmD2TDhwVjVn6jfsaI/1+jB3PefaAfB1+La4X+ckjcau?=\n\t=?utf-8?q?4oFn0LcppEYIpspHi74G3UAk89N6QILQViud3qD1lzzb9XzzGY6bUNIU?=\n\t=?utf-8?q?+F4Fr7N8MnCEBQmSVt8dpUJ2kK3zXu3ab0dlIcmkEP047sEVCNOE/VxY?=\n\t=?utf-8?q?6LTZqJxlc+rAXnLwuGEs0500JsFqcOtYDZ7Jg9aMv31So6AKghATBJQI?=\n\t=?utf-8?q?yGZm+B1sxkPueSGde6bUnV+Piic2tJO?=","X-OriginatorOrg":"theobroma-systems.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"d5b2f7b4-babb-4005-466e-08da2db45929","X-MS-Exchange-CrossTenant-AuthSource":"PA4PR04MB9367.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"04 May 2022 09:56:24.0524\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"5e0e1b52-21b5-4e7b-83bb-514ec460677e","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"D5qoWV6Ni0lRMdbWHCjKW8RGSXZT4wzRwKsCTeSy4+LG2JKTn9ETmFT0+VlO4f0hw6QE8Jmn6Zjt1md1Ot5D/c57ewp3RYnPXI7hoxxz+NtY69bD1TgiulmvYpLmzwyX","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PAXPR04MB8224","Subject":"Re: [libcamera-devel] [PATCH 2/3] Documentation: fix typos","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Quentin Schulz via libcamera-devel\n\t","Reply-To":"Quentin Schulz ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22847,"web_url":"https://patchwork.libcamera.org/comment/22847/","msgid":"<20220504101355.sbnnfhu62aefr3yf@uno.localdomain>","date":"2022-05-04T10:13:55","subject":"Re: [libcamera-devel] [PATCH 2/3] Documentation: fix typos","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Wed, May 04, 2022 at 11:56:22AM +0200, Quentin Schulz wrote:\n> Hi Kieran,\n>\n> On 5/4/22 11:42, Kieran Bingham via libcamera-devel wrote:\n> > Quoting Jacopo Mondi via libcamera-devel (2022-05-04 08:11:42)\n> > > Hi Quentin\n> > >\n> > > On Tue, May 03, 2022 at 06:30:37PM +0200, Quentin Schulz via libcamera-devel wrote:\n> > > > From: Quentin Schulz \n> > > >\n> > > > A few typos made it to the docs, so let's fix them.\n> > > >\n> > > > Cc: Quentin Schulz \n> > > > Signed-off-by: Quentin Schulz \n> > > > ---\n> [...]\n> > > > ``V4LPixelFormat`` and ``SizeRange`` supported by the underlying output device,\n> > > > but the pipeline handler needs to convert this to a ``libcamera::PixelFormat``\n> > > > type to pass to applications. We do this here using ``std::transform`` to\n> > > > @@ -811,9 +811,9 @@ Continue adding the following code to support this:\n> > > > StreamConfiguration cfg(formats);\n> > > >\n> > > > As well as a list of supported StreamFormats, the StreamConfiguration is also\n> > > > -expected to provide an initialised default configuration. This may be arbitrary,\n> > > > -but depending on use case you may which to select an output that matches the\n> > > > -Sensor output, or prefer a pixelformat which might provide higher performance on\n> > > > +expected to provide an initialised default configuration. This may be arbitrary,\n> > >\n> > > ack\n> >\n> > I can't actually see any change in that line which is added here?\n> >\n>\n> Mmmm. Don't know what Jacopo did to the git diff but the patch has the typo\n> in the original file :)\n\nUps my bad\n\nTo verify documentation changes like this one I simply search in vi\nfor the whole phrase, typing it it until one of the two lines differ.\n\nI might have changed the first part to check if anything else had been\nmodified, sorry\n\n>\n> s/initialsed/initialised/\n>\n> s/which/wish/\n>\n> Cheers,\n> Quentin","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9AE32C3256\n\tfor ;\n\tWed, 4 May 2022 10:13:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 65E2965645;\n\tWed, 4 May 2022 12:13:59 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::223])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AEAC6563C\n\tfor ;\n\tWed, 4 May 2022 12:13:58 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 65A186000A;\n\tWed, 4 May 2022 10:13:57 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651659239;\n\tbh=chfkWU9F5pSokB9zK3/mFz8GI4aBnIs/ltqGfgi7zwE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=zMntPJdr66H0HDy9Xpu7z7uAz2yi6k2iSJjHb+vAV1sRcuex5qcVVaugj4sPiHBhu\n\tp08+JJVN+Qz1AZNvmt8mGp1JrneS6OEoBgp+Q7qIGWNLSqGak/MFXY1XENlrDrsVvS\n\tiLylpXP4PiE6ayou8NB3VvsphsQgjWJWlHQW5TVGouLg5TA5NYcWUVN/ebuoSMWbs+\n\tAef5N6R8AXfMJz5TJoEkjFdo0Zu2q2WvqLb4p8GnISVje/p1lC6blyAiIRShiVbjdE\n\tb1g7rBZnGy4nbHRQLWobPYmPJYtYx84iR/7GrTUhB7r9Hi2M/wzUJ5yPCTK5jI1QsG\n\teoI4fZ4plUMwg==","Date":"Wed, 4 May 2022 12:13:55 +0200","To":"Quentin Schulz ","Message-ID":"<20220504101355.sbnnfhu62aefr3yf@uno.localdomain>","References":"<20220503163038.1174462-1-foss+libcamera@0leil.net>\n\t<20220503163038.1174462-2-foss+libcamera@0leil.net>\n\t<20220504071142.dnk5ksak6nbunikj@uno.localdomain>\n\t<165165734009.4076486.4446716306670471217@Monstersaurus>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 2/3] Documentation: fix typos","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]