[{"id":22828,"web_url":"https://patchwork.libcamera.org/comment/22828/","msgid":"<20220504061718.eclwaahl6qwfan36@uno.localdomain>","date":"2022-05-04T06:17:18","subject":"Re: [libcamera-devel] [PATCH 2/2] libipa: camera_sensor_helper: Add\n\tOV5675 helper","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Quentin\n\nOn Tue, May 03, 2022 at 05:57:25PM +0200, Quentin Schulz via libcamera-devel wrote:\n> From: Quentin Schulz \n>\n> The OV5675 is an OmniVision sensor with a linear gain model, expressed\n> in 1/128 steps.\n>\n\nLikewise, no datasheet, but patch looks good\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> Cc: Quentin Schulz \n> Signed-off-by: Quentin Schulz \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index c098e48c..0f156137 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -429,6 +429,17 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov5670\", CameraSensorHelperOv5670)\n>\n> +class CameraSensorHelperOv5675 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperOv5675()\n> +\t{\n> +\t\tgainType_ = AnalogueGainLinear;\n> +\t\tgainConstants_.linear = { 1, 0, 0, 128 };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov5675\", CameraSensorHelperOv5675)\n> +\n> class CameraSensorHelperOv5693 : public CameraSensorHelper\n> {\n> public:\n> --\n> 2.35.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 322B0C0F2A\n\tfor ;\n\tWed, 4 May 2022 06:17:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D880565641;\n\tWed, 4 May 2022 08:17:21 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 774F960424\n\tfor ;\n\tWed, 4 May 2022 08:17:20 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id DABBDC000D;\n\tWed, 4 May 2022 06:17:19 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651645041;\n\tbh=JA9mecTdFG0oPOChASD1nFMSXr092XWr5F8kxmcnEto=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Vyf7nsqhP8s7qw/aqlbdzIF5ETKRD7FpKClMp94EGs+okBtRmI++FK563SHcFQynH\n\tWvgvXDFAr3LotW3YpSNA6oUWDowZUtr9ogGjaw7Wjaj00nUNceoHi4ewn/VWR0uzab\n\tJ8swaFbAnqPmn/zxJHL3smTj3v1xWM0xVgNU2UxqPYGTFF3cvbRNqNae+DdRWT5sGx\n\tAKGnOwGv15VA0HsR0WFtapOJ/o/w1fTfXqIHhqmsAT98PHrcY9AmuLHOJj4VV4D+j1\n\tW0Dh+4XQdg6dDv1bpC93peKGRG5Vdc7DM8daflOWorESQS4GB0Nt+UNDYSIzZ5u65o\n\tPV6mH4MqHVo+Q==","Date":"Wed, 4 May 2022 08:17:18 +0200","To":"Quentin Schulz ","Message-ID":"<20220504061718.eclwaahl6qwfan36@uno.localdomain>","References":"<20220503155725.1168826-1-foss+libcamera@0leil.net>\n\t<20220503155725.1168826-2-foss+libcamera@0leil.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220503155725.1168826-2-foss+libcamera@0leil.net>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libipa: camera_sensor_helper: Add\n\tOV5675 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22955,"web_url":"https://patchwork.libcamera.org/comment/22955/","msgid":"<165229760438.2416244.15553320084396036199@Monstersaurus>","date":"2022-05-11T19:33:24","subject":"Re: [libcamera-devel] [PATCH 2/2] libipa: camera_sensor_helper: Add\n\tOV5675 helper","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi via libcamera-devel (2022-05-04 07:17:18)\n> Hi Quentin\n> \n> On Tue, May 03, 2022 at 05:57:25PM +0200, Quentin Schulz via libcamera-devel wrote:\n> > From: Quentin Schulz \n> >\n> > The OV5675 is an OmniVision sensor with a linear gain model, expressed\n> > in 1/128 steps.\n> >\n> \n> Likewise, no datasheet, but patch looks good\n> Reviewed-by: Jacopo Mondi \n> \n\nSame, the brief doesn't have enough information to say one way or\nanother here, but I think this looks suitable to get started.\n\nReviewed-by: Kieran Bingham \n\n> Thanks\n> j\n> \n> > Cc: Quentin Schulz \n> > Signed-off-by: Quentin Schulz \n> > ---\n> > src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> > 1 file changed, 11 insertions(+)\n> >\n> > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> > index c098e48c..0f156137 100644\n> > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > @@ -429,6 +429,17 @@ public:\n> > };\n> > REGISTER_CAMERA_SENSOR_HELPER(\"ov5670\", CameraSensorHelperOv5670)\n> >\n> > +class CameraSensorHelperOv5675 : public CameraSensorHelper\n> > +{\n> > +public:\n> > + CameraSensorHelperOv5675()\n> > + {\n> > + gainType_ = AnalogueGainLinear;\n> > + gainConstants_.linear = { 1, 0, 0, 128 };\n> > + }\n> > +};\n> > +REGISTER_CAMERA_SENSOR_HELPER(\"ov5675\", CameraSensorHelperOv5675)\n> > +\n> > class CameraSensorHelperOv5693 : public CameraSensorHelper\n> > {\n> > public:\n> > --\n> > 2.35.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17D52C3256\n\tfor ;\n\tWed, 11 May 2022 19:33:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 76CB26565A;\n\tWed, 11 May 2022 21:33:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27C8960421\n\tfor ;\n\tWed, 11 May 2022 21:33:27 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A3096A1D;\n\tWed, 11 May 2022 21:33:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652297609;\n\tbh=bfqXC6YzuEhtyfRbs+feV1yKgP8Yfr2U5gRq7J1MFY8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=bJ8GkGOWXaW3IWPCF1nmYuqWb2jUOkON10IZ2fTe7ldkeFovo1xvMl0gLRD6P7J6m\n\tEjP6ngv4Zj5TZFB0pw5BdCIjpMNnE7d9cQXaF/ZFsakkDlJaM5ZGQ6ZQSX+KJ6OPWI\n\tMGMGCLkiK618fAFdlZ+rXlR0QIb+xvd+SwqYE0092+jEiOjHJbuL/okWJFRapdv63Q\n\t1UjIwuEMVK+QP1w0kQBaw6QoqwLtXs1DgOvg1KIIx9miRS2ZfKnz2Sk3NwWtMwhsKH\n\tX75hlhqXy/DYkS1xalXqcQ3rRb6hw253ll4hsvbFymb68yOFchZUvKa+XDJEGVcGqN\n\tNDdb60EeqgIeA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652297606;\n\tbh=bfqXC6YzuEhtyfRbs+feV1yKgP8Yfr2U5gRq7J1MFY8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=B88ioBTWv7RCs5C2+alry67UKa6d+zYLP2lDIXayTf2zRtPIatMzyVCYvhHfO4F14\n\tCia6rnA5Rj5pse30TVz9f1yvBHSB6DZp/ksOM5fMTHrkr74glWf+gFsI4aCQab1qi6\n\t5jIDgURsCqNssEMvqCohBkyXVisyCnWzEVTIneQs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"B88ioBTW\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220504061718.eclwaahl6qwfan36@uno.localdomain>","References":"<20220503155725.1168826-1-foss+libcamera@0leil.net>\n\t<20220503155725.1168826-2-foss+libcamera@0leil.net>\n\t<20220504061718.eclwaahl6qwfan36@uno.localdomain>","To":"Jacopo Mondi , Jacopo Mondi via libcamera-devel\n\t, \n\tQuentin Schulz ","Date":"Wed, 11 May 2022 20:33:24 +0100","Message-ID":"<165229760438.2416244.15553320084396036199@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 2/2] libipa: camera_sensor_helper: Add\n\tOV5675 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]