[{"id":22827,"web_url":"https://patchwork.libcamera.org/comment/22827/","msgid":"<20220504061554.e2ivxgvafy2je6wm@uno.localdomain>","date":"2022-05-04T06:15:54","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Add\n\tOV5675 sensor properties","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Quentin,\n\nOn Tue, May 03, 2022 at 05:57:24PM +0200, Quentin Schulz via libcamera-devel wrote:\n> From: Quentin Schulz \n>\n> Add an entry to the sensor properties for OmniVision OV5675. Only the\n> first test pattern is included as the others that are exposed by the\n> kernel aren't supported by libcamera control yet.\n>\n> Cc: Quentin Schulz \n> Signed-off-by: Quentin Schulz \n\nDon't have a datasheet here, but the patch looks good.\n\nReviewed-by: Jacopo Mondi \n\nLooking at the driver these three additional test patterns are\navailable\n\n\t\"Top-Bottom Darker Color Bar\",\n\t\"Right-Left Darker Color Bar\",\n\t\"Bottom-Top Darker Color Bar\"\n\nI can see at least 4 other mainline drivers which features the same\ntest patterns, it might be worth adding them to the list of values\nsupported by the TestPatternMode control.\n\nThanks\n j\n\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 7a349012..235edca1 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -123,6 +123,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"ov5675\", {\n> +\t\t\t.unitCellSize = { 1120, 1120 },\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n> +\t\t\t},\n> +\t\t} },\n> \t\t{ \"ov5693\", {\n> \t\t\t.unitCellSize = { 1400, 1400 },\n> \t\t\t.testPatternModes = {\n> --\n> 2.35.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C20CC0F2A\n\tfor ;\n\tWed, 4 May 2022 06:16:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58E1660424;\n\tWed, 4 May 2022 08:15:59 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32A6660424\n\tfor ;\n\tWed, 4 May 2022 08:15:57 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id A48FE24000D;\n\tWed, 4 May 2022 06:15:56 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651644959;\n\tbh=gGJMyTQrRJ/Xzk7eU2rzJ3huXB3vBOnV7FMQ00DhaMU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=W7zH9SFfmbKkSdHyM+PCSe+LS/4U2npssv1GFAnXxDvAGq/S5J/HpayLonrpagjri\n\ti8EzjSQqfuF1mlCy2yFpUoQBBXPHB/VrsIwpss/KzA3ZJaXb4mCNaLfrnljDLnNxTh\n\tAo4MMoMTq8TywsE6aJUnY7sOVhGd3rVkeuYjPhee0zMyb2rCRTilNLwgfcee0y10vN\n\tbWUYEa5grYlGifDEylmhMELT59oen0UM7qiRnIHNyBq8Lfv5ulv3XF6hCirJbQlWfw\n\t7NjxOCW4EAacEEe3LQC/ABRLF70PyF1sgvFGNewiEiwxzHdlIY6HZDQ/YyMeVHATX7\n\tiNjwL1ru/SNLA==","Date":"Wed, 4 May 2022 08:15:54 +0200","To":"Quentin Schulz ","Message-ID":"<20220504061554.e2ivxgvafy2je6wm@uno.localdomain>","References":"<20220503155725.1168826-1-foss+libcamera@0leil.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220503155725.1168826-1-foss+libcamera@0leil.net>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Add\n\tOV5675 sensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22837,"web_url":"https://patchwork.libcamera.org/comment/22837/","msgid":"<4b9b1147-55d2-34ee-2ead-bfe1d0bf27f5@theobroma-systems.com>","date":"2022-05-04T09:06:32","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Add\n\tOV5675 sensor properties","submitter":{"id":121,"url":"https://patchwork.libcamera.org/api/people/121/","name":"Quentin Schulz","email":"quentin.schulz@theobroma-systems.com"},"content":"Hi Jacopo,\n\nOn 5/4/22 08:15, Jacopo Mondi via libcamera-devel wrote:\n> Hi Quentin,\n> \n> On Tue, May 03, 2022 at 05:57:24PM +0200, Quentin Schulz via libcamera-devel wrote:\n>> From: Quentin Schulz \n>>\n>> Add an entry to the sensor properties for OmniVision OV5675. Only the\n>> first test pattern is included as the others that are exposed by the\n>> kernel aren't supported by libcamera control yet.\n>>\n>> Cc: Quentin Schulz \n>> Signed-off-by: Quentin Schulz \n> \n> Don't have a datasheet here, but the patch looks good.\n> \n\nhttps://www.ovt.com/wp-content/uploads/2022/01/OV5675-PB-v1.2-WEB.pdf\n\nProduct brief includes the unit cell size (but not much more unfortunately).\n\n> Reviewed-by: Jacopo Mondi \n> \n> Looking at the driver these three additional test patterns are\n> available\n> \n> \t\"Top-Bottom Darker Color Bar\",\n> \t\"Right-Left Darker Color Bar\",\n> \t\"Bottom-Top Darker Color Bar\"\n> \n> I can see at least 4 other mainline drivers which features the same\n> test patterns, it might be worth adding them to the list of values\n> supported by the TestPatternMode control.\n> \n\nYes, 4 other OmniVision sensors seem to support this (maybe more if the \ndrivers didn't include all test patterns).\n\nI'm not planning to work on this right now. So if anyone feels like \nworking on it, feel free to do so.\n\nCheers,\nQuentin\n\n> Thanks\n> j\n> \n>> ---\n>> src/libcamera/camera_sensor_properties.cpp | 7 +++++++\n>> 1 file changed, 7 insertions(+)\n>>\n>> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n>> index 7a349012..235edca1 100644\n>> --- a/src/libcamera/camera_sensor_properties.cpp\n>> +++ b/src/libcamera/camera_sensor_properties.cpp\n>> @@ -123,6 +123,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n>> \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n>> \t\t\t},\n>> \t\t} },\n>> +\t\t{ \"ov5675\", {\n>> +\t\t\t.unitCellSize = { 1120, 1120 },\n>> +\t\t\t.testPatternModes = {\n>> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n>> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n>> +\t\t\t},\n>> +\t\t} },\n>> \t\t{ \"ov5693\", {\n>> \t\t\t.unitCellSize = { 1400, 1400 },\n>> \t\t\t.testPatternModes = {\n>> --\n>> 2.35.1\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E19D1C3256\n\tfor ;\n\tWed, 4 May 2022 09:06:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B37165645;\n\tWed, 4 May 2022 11:06:36 +0200 (CEST)","from EUR04-HE1-obe.outbound.protection.outlook.com\n\t(mail-he1eur04on0627.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f400:fe0d::627])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC9FF65641\n\tfor ;\n\tWed, 4 May 2022 11:06:34 +0200 (CEST)","from PA4PR04MB9367.eurprd04.prod.outlook.com (2603:10a6:102:2aa::7)\n\tby AM8PR04MB7985.eurprd04.prod.outlook.com (2603:10a6:20b:234::10)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25;\n\tWed, 4 May 2022 09:06:33 +0000","from PA4PR04MB9367.eurprd04.prod.outlook.com\n\t([fe80::28d3:b4fa:2319:83fb]) by\n\tPA4PR04MB9367.eurprd04.prod.outlook.com\n\t([fe80::28d3:b4fa:2319:83fb%5]) with mapi id 15.20.5206.025;\n\tWed, 4 May 2022 09:06:33 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651655196;\n\tbh=Sn2t9vYBLFtePcN4rjWUmKUKyhRPsc8OLj9jeDifjgo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=zh96BM9+sjulBtBVm/FaLI3O/qfadToIa3myGosMkAGu9vPOCQxla01ZNcTt0/c67\n\tsvrNJrnCIAVqwS31O7dNi2bUD+NT6UedBrcXb16qjXuCxKZZvyU+fLTeLkWKSN3xUM\n\tatOOJFlACDJ3+SC6SN3z/pa6eWqGSXN54YHLUqAf+a+MVUOOqypN+Mmo98Q5eQzu6H\n\tFuB5RZAbKZbQjdvydBIVPUastZXwPk6pgsTU8kWY2Bb94Eg+zsEsFoIwwDWuKjq2pf\n\tm3f1q9VpzlYdLPlJr/WZUbM/E/JQV/IeOogFKlvLmzCdoE/SZEkkqix4OOqlXV1JFR\n\tjb7Rlk3DiBqUw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cherrycloud.onmicrosoft.com; s=selector2-cherrycloud-onmicrosoft-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=W5GwHJIU/ko917Qyhd2dlYfUREGQfXZB5kigM9Ugt5s=;\n\tb=SrKT9uKV3CO8t1avCHqtr7bvd/OI02Nt1m8FZQBx1U8qK+oMAPNK0iHrfm70thozXm/eJS6UrZRcgs1oPv33XVKSD5CRCu2xOe2WBq4ldq43keylXRWWG5DwzNQzoRjYiUBe44YH2TFFB9yFvjOs23CjuYqVJUNn0SVBvy5vbGI="],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=cherrycloud.onmicrosoft.com\n\theader.i=@cherrycloud.onmicrosoft.com header.b=\"SrKT9uKV\"; \n\tdkim-atps=neutral","dkim=none (message not signed) header.d=none;\n\tdmarc=none action=none header.from=theobroma-systems.com; "],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=midZP2MEtRbIv9ZvAOdcYICu/c0nB1HNCqmpp99fkpLk3X3VqZyNC4H02zkyf4YG/F/DztEOyyNeOTOJ0VexJXQtDPVmonLJTthU+TzJ0ohbRLFfmI7ZBHGwQ1KMoIm/pUxNznwl/V5kiBph1pPH2ZeZp5frLdfGxWMA/HpPctRpRGCF7/jMVHPSbpx2XBUjOF0/D6bMideku6WQdbjJ/YWzTuLvxbqbets7xKDwDwcAG1xpoVT4pUQ2dEIe3xQ8hhHuuU5MK/+72mI0ttiLaUo9TvT2WQqdE5o+DG6zH5QeNewkxtxvjwwvepWSq+c21TtvcEb9pfkkiqRZ6jSXDg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=W5GwHJIU/ko917Qyhd2dlYfUREGQfXZB5kigM9Ugt5s=;\n\tb=TFmc+axL6zLKHmrH38hmywITjEkEVul0zz6wiV/ockppits8JssbBdsBQRUv0YXjW+rLMTiG7h+L9x8P3tC8MONCZ9Z6cNtx+KK4/khEJ88pjLITHr+WSWPTrohP2xGcCgOlmBcBGftMtANBDjhAW/Phn6WxFHiH6sxgi/waldZsUkyar3QXqbN5uFz2MlqHBplCRyxVbKB5aSr8lYd+Ip20Eq3yxhHuqsu96YDJKFvWBQSQKGPh0Tf81Qu2EtLg3heFJnKTOqKpvY8x0WcQ0PplS6hGTrvaekBB9ouec0mIHTBp0dctLmt8ykTeJM/EcvRJvgMJwsEWqE5DFlv6QA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=theobroma-systems.com; dmarc=pass action=none\n\theader.from=theobroma-systems.com;\n\tdkim=pass header.d=theobroma-systems.com; \n\tarc=none","Message-ID":"<4b9b1147-55d2-34ee-2ead-bfe1d0bf27f5@theobroma-systems.com>","Date":"Wed, 4 May 2022 11:06:32 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.8.0","Content-Language":"en-US","To":"Jacopo Mondi ,\n\tQuentin Schulz ","References":"<20220503155725.1168826-1-foss+libcamera@0leil.net>\n\t<20220504061554.e2ivxgvafy2je6wm@uno.localdomain>","In-Reply-To":"<20220504061554.e2ivxgvafy2je6wm@uno.localdomain>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"AM5PR0601CA0050.eurprd06.prod.outlook.com\n\t(2603:10a6:206::15) To PA4PR04MB9367.eurprd04.prod.outlook.com\n\t(2603:10a6:102:2aa::7)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"f2664429-5c55-4f57-0622-08da2dad628d","X-MS-TrafficTypeDiagnostic":"AM8PR04MB7985:EE_","X-Microsoft-Antispam-PRVS":"","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;","X-Microsoft-Antispam-Message-Info":"LGe55MZOcUHkMUMbibJYeI1uvtiNfOiR296Q6EvuSrBaxYNrnf9fsK6rqGrmAJ7LgTNJmZyee6xPU3w/S49rjsYzJ1XNyCIFPHQjj8JjwEBIUv6cdTfbah8nRXLCS0hiGmTaK6PPhGEYeRFzuSF9bDrcFTiC9pmZ2GTznSgC67xbl8zpzdwxBzlF3pyuXc5YTnN26evpeRWLyxAa8y9uV2LPqWDxzIOVaqupUHLGfsxFwL1rkygdT/yMVA4yuSLXpykiAIkqncPetitJai6fzjacZby+eg1o9MrFUwhzqE323somYl6DHI6gtMpOjZiS3wQ1VIZj25liXOdCPmuL/H8HczA6wZr9RujKH87JSeQFlz8BfRco9DYE7OqXUE7wTubFJI0Np8lm4MB01do2nDO3keslrAhWf1DCsBpQ3PdwVfn3rscxpLgbyUQFGQitCxA4HV/MZk5mOcqseT3wEEW5/DaIq7JoKDnWU6Mdib29DE9vMbWnp/H2/Yz49FeSIbAyrB1wLG4DC6jRxNMVqkRyWdHPtsbHC79PGjoexnbnY9j62sk3b5mPDVzmkK30MuKItwwDj+nrfB6wR6SPZUnZKWzfUI6cdFt1MFaPsUi2PoIRqzNqVhoJ1v9xcgW0Uc96iF5ssPNMkqb54BLF3UGm22haDIAgl9iXFAu8esBmKCwdAV6C6uzLW5tfZoB1w4Ulq2kHCmG7bxqkMFtvN7v3EKWnWtTgTm1CPLcRFvSf3j/GaLApoI0XfuKQi+iJWhP8dTHilDb5mYhiy89amT4uZJ+IsMtsVQlefhEcEHewPOrV1FTIbbXJNENSniUtc7hWxhdfZpOkotlT7EnTTjxZSg+2o+axDdD/RmHpSZbzbm4kFur1DvpDiLXd+drD","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:PA4PR04MB9367.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230001)(366004)(8676002)(4326008)(66476007)(66556008)(66946007)(26005)(31696002)(2906002)(8936002)(38100700002)(5660300002)(86362001)(6512007)(966005)(316002)(6506007)(6486002)(44832011)(53546011)(508600001)(186003)(36756003)(31686004)(110136005)(2616005)(15398625002)(45980500001)(43620500001)(43740500002);\n\tDIR:OUT; SFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?/gbTRH0VPG7BrBTZxaNrXtAFe?=\n\t=?utf-8?q?GsbUnpZmbsIPw9Dwy11JZ9mMy+Nehe9igc/ooldRt1kVNgWoPh+Kgtiz?=\n\t=?utf-8?q?nFEhVpSsA1Wg/KpGWjLTPlA+be6OQmbXCfoKuUnr8G+hrmaqe4uM3AnC?=\n\t=?utf-8?q?7tQbRqmWdhyqGWdB8V3SsDsrD8UZY3esHm9ZcSpDIOq3F6JLFhUVhvC6?=\n\t=?utf-8?q?zFYp4S+nqQf5GwUgfqmc0GJv0T6q/iY7ydd3ByQVpkBg2hNAVLVvTdnQ?=\n\t=?utf-8?q?hCRpbL4BBWd+Le5QL9cUIK20uSAVnrtv3TUokLlnvRlbeBgvdWiEiwYv?=\n\t=?utf-8?q?+QASNEzVHakcELFe2WoZmW+6eMmaEIKYbGiE8YyBmSNjp1C0GH8iYFf9?=\n\t=?utf-8?q?f/NknGz0T2Ys4hoSlO8jcdIy9IpEnl7C+/2VFtCbPZKxYqMIWG7oeL0Q?=\n\t=?utf-8?q?VS8OVBJOPqbXTyTemQzQBV7SxgnPwe5FBstbD6u+UfgfofzhtsKjOPVS?=\n\t=?utf-8?q?m0716QTi3FspEZckMS4iBsYvsfWOS3UXgnBahd4NAHUp/qbe9vVg8KsX?=\n\t=?utf-8?q?mWzY8qpZ7mL4nD91d5EIqmUjL02ZkIRtryet/txIGSq1zAe5LNDSDvLs?=\n\t=?utf-8?q?wcUQhx442LIKZH5zJqavB8xJ0bzGTpFPWLzVsnuwYjvGvjMLfVw5W8Lv?=\n\t=?utf-8?q?o0WPHAvs+zsw8Slv/Eg9phW30pGXcZod/vEmcCso4jvvHN+HkZ/g1ua/?=\n\t=?utf-8?q?hlGULknipKDsl4eq4FTw7oew7OZHnxerkkFyoe+2G+yuhoPgWotLSIjB?=\n\t=?utf-8?q?0dUFqLW6vMfgTT67GBp6ucMlGQgf0X+M3hvZOhtlhx61qIe9vPixk5u9?=\n\t=?utf-8?q?G0YDj8AMm9CYQQnq7+lnmD/gsW6U6WLi8gVGLGuEfv9OVcaHRRLzYDb1?=\n\t=?utf-8?q?QYvNXuJ1puQYdHX0NEK9Y+/J3ywxdTsyEaGLVHmoKFxgVDzJNAqnSuOu?=\n\t=?utf-8?q?TmwdsEznMyWK6W3nsuBz60D8u6OD9GwY+KlJZZlsa8sXlsGBQ8tWdYHa?=\n\t=?utf-8?q?+WAwbh3xPpHHUMepd5atZhAd7Au/Ndkh+sdSHPRxLMCrzDJnwGk5T+U+?=\n\t=?utf-8?q?gQ6G/LjyGkO6gvnnLHacMpTlfFaCBKbTjk3uXsTrTU1cyenZk5ReuqKw?=\n\t=?utf-8?q?823d54L2WALYfrfgcArcRqQYX2Pi7oGmyEoF7wvuVd98sXVB13qeiOh8?=\n\t=?utf-8?q?9R9HVGvBBN1pM50UfjEpTnHzdVvzHq/TNjoyeUPEkBfHVwfn1z8BtJLd?=\n\t=?utf-8?q?tTVDCO+DRwFMlrTvJshmRUube3nVXS+7JSU2BBNEa+WE8IY+FaIs86eV?=\n\t=?utf-8?q?X1ZE2m52itUOGEwO+ukBWeYoNpYezLQ3xj/3qdPa2MSdmO9ns0dDMs7u?=\n\t=?utf-8?q?pAfIk3201K8PpS8BpEGFaI/FQen7LR4OUZAYLL9LTgpGjvWqxcQvnje5?=\n\t=?utf-8?q?1k4mDtX5+DysL1et7bLb5gqBkMPpoVA/qACfrEMKQKOpIoDXWZIZ9x/n?=\n\t=?utf-8?q?AUAsk2JPwRTeMcxiseD2FOcYUAiOn6Yq1x5Vf2CO16pGlF1VsnLKOc0p?=\n\t=?utf-8?q?kkTHqGFwLeKvhScWk3AD5jSdzhhm12Vxhc+x4V4ayZqy9E1/yVo4hBdc?=\n\t=?utf-8?q?2Cv6wVm0/79D351p4C1axkT9t4FkVmGdkdIM49FF83Jmd2caMFnvh5iC?=\n\t=?utf-8?q?THtY0SGB31rZJCeWuH+tg/pSU4jaKBln9+PBIP6q9xvrqR+9DQigkU8E?=\n\t=?utf-8?q?npY4Zd6NyKtC1L1KAZD+wdsETZgOt8A0lFO5DHs8KahL6aU3w9k/C4eh?=\n\t=?utf-8?q?0uL8TZMdrEMMoOyrkPvlxEm7nZ80lm9k72ALtyjvsX4a2NTu6eKeAetc?=\n\t=?utf-8?q?4JjqnDCgZ1UReo97JrI7eQeDT9LNhS7?=","X-OriginatorOrg":"theobroma-systems.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"f2664429-5c55-4f57-0622-08da2dad628d","X-MS-Exchange-CrossTenant-AuthSource":"PA4PR04MB9367.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"04 May 2022 09:06:33.4691\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"5e0e1b52-21b5-4e7b-83bb-514ec460677e","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"f3AoIrgaC2qcAb+qODibP4QzHNx2zN+0zrP57QoDgP3sWvsEz1KxCi2IAsvZxNJcXI/fUnLuWLLoMqOFNztKgpiVPHyNrwCksc4Pyq5l0w8GShyPtTdLXQEBGcOnNBhK","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM8PR04MB7985","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Add\n\tOV5675 sensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Quentin Schulz via libcamera-devel\n\t","Reply-To":"Quentin Schulz ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22954,"web_url":"https://patchwork.libcamera.org/comment/22954/","msgid":"<165229738243.2416244.16485941678586935444@Monstersaurus>","date":"2022-05-11T19:29:42","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Add\n\tOV5675 sensor properties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Quentin Schulz via libcamera-devel (2022-05-03 16:57:24)\n> From: Quentin Schulz \n> \n> Add an entry to the sensor properties for OmniVision OV5675. Only the\n> first test pattern is included as the others that are exposed by the\n> kernel aren't supported by libcamera control yet.\n> \n> Cc: Quentin Schulz \n> Signed-off-by: Quentin Schulz \n> ---\n> src/libcamera/camera_sensor_properties.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 7a349012..235edca1 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -123,6 +123,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> { controls::draft::TestPatternModeColorBars, 1 },\n> },\n> } },\n> + { \"ov5675\", {\n> + .unitCellSize = { 1120, 1120 },\n\nChecks out.\n\n\n> + .testPatternModes = {\n> + { controls::draft::TestPatternModeOff, 0 },\n> + { controls::draft::TestPatternModeColorBars, 1 },\n\nLooks reasonable to start.\n\nReviewed-by: Kieran Bingham \n\n> + },\n> + } },\n> { \"ov5693\", {\n> .unitCellSize = { 1400, 1400 },\n> .testPatternModes = {\n> -- \n> 2.35.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D8EDC0F2A\n\tfor ;\n\tWed, 11 May 2022 19:29:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 931E86565A;\n\tWed, 11 May 2022 21:29:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1F7D60421\n\tfor ;\n\tWed, 11 May 2022 21:29:44 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E4DCA1D;\n\tWed, 11 May 2022 21:29:44 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652297386;\n\tbh=kbghjDEpGu+m+Gxzo76wxxneQD6Bl9j8Znd10NSNE/I=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=F/tRJ49vTbgtciUFPhbehmH05mapTX0RUD3O8CEQNKLcF+srlqGg4kH2s+6gRMuv1\n\tYKE88YvZJxFoGYvN4wEB9WuMGowY2vCtG8Ge4iuYc8kbJ717STlgppzdhKX4rBMjw/\n\tduXiHX6pw2WLOLKCxY7h/MDmpjCOQ+zwefmKyQiORLhpP/J6SklgLymVXf4cKqcd7T\n\tFxTaxHAE/RfiVx7hGUA9rRilOFK/6GkMObvghP9hxvkz7N9TQUUsmc/C8DBOBCYtix\n\tTV8sZTHdf1VW19ik192RiQFh9KsDP9uq9ufBc2McCM+Iq9nOODjTea9xqQd/NQhneU\n\tCXVJPtKN61chA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652297384;\n\tbh=kbghjDEpGu+m+Gxzo76wxxneQD6Bl9j8Znd10NSNE/I=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=wJt1k14dSAaszsX+GlIFcyxAUClS+bOaWjbpgTyKgGHjctlZRZa8V5Im0Z6Hw/gLq\n\tdAxpf7O657yh5KFloXDCWTuxXwYsQljDGtak5Yax007b72UGthW19DKtdsV++nQfqa\n\tSX9BrPfRBJP1CZSjftHA30OPzfTtdOlbvM6RVY7Q="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"wJt1k14d\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220503155725.1168826-1-foss+libcamera@0leil.net>","References":"<20220503155725.1168826-1-foss+libcamera@0leil.net>","To":"Quentin Schulz ,\n\tQuentin Schulz via libcamera-devel ","Date":"Wed, 11 May 2022 20:29:42 +0100","Message-ID":"<165229738243.2416244.16485941678586935444@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Add\n\tOV5675 sensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]