[{"id":22833,"web_url":"https://patchwork.libcamera.org/comment/22833/","msgid":"<165165448624.4076486.9797423721617779751@Monstersaurus>","date":"2022-05-04T08:54:46","subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: geometry: Add missing\n\tostream header in geometry.h","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-04-29 22:23:44)\n> Commit c730dc74795d (\"libcamera: geometry: Add operator<< for classes in\n> geometry\") added usage of std::ostream in geometry.h but forget to\n> include the corresponding header. Fix it to avoid future compilation\n> breakages if indirect inclusions are changed.\n> \n> Fixes: c730dc74795d (\"libcamera: geometry: Add operator<< for classes in geometry\")\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/geometry.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\n> index d4a144bcd42a..d7fdbe708e6d 100644\n> --- a/include/libcamera/geometry.h\n> +++ b/include/libcamera/geometry.h\n> @@ -8,6 +8,7 @@\n> #pragma once\n> \n> #include \n> +#include \n> #include \n> \n> #include \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EABAEC0F2A\n\tfor ;\n\tWed, 4 May 2022 08:54:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39DCC604A3;\n\tWed, 4 May 2022 10:54:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94661604A3\n\tfor ;\n\tWed, 4 May 2022 10:54:48 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 30490E5;\n\tWed, 4 May 2022 10:54:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651654490;\n\tbh=wNT74WXQ51GRDaBA8Z7crX6h8w46zIgfPNJ4f0QE9aQ=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=cz0caEiqJFGt3UFW1zUUiJRyfHVtyfQcMlIYSnq2c+1lx6ou4m8ItdS4YoJyY2Ncc\n\tNx7DFR0h9MLD6FNA3Nk+eDkUDiAgTG6CH20Fa1Pay5B/7c2NwLOCKCelkkvpMGZ7LT\n\tw3wfcPnCBvb81IAl58j/yDknpvXbwV+7mFaY+ep2tV6oOqWrzUL8bw6t9ipDUKYFHw\n\tfLFkeh9KBCSKUq5g3Fe+7SFsTO8qUdVD/Zx0uUeN212FSEyhvhE1WeAev8V/yvA1Zx\n\tzXrXnOTyrWJIvobECI8Hk3teYpZnPGJdPbg5I+dcr5P+9h9RrhPHnbQ1GMauhkvoeR\n\t1cHGlcwj1CmWQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651654488;\n\tbh=wNT74WXQ51GRDaBA8Z7crX6h8w46zIgfPNJ4f0QE9aQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Ssn+ZfGXXuoZR31bx5WxxZ5NyLSgzD6Jn737nYLMOnbr1gWvfZ3D7+3evIr7qH3BJ\n\taePPoZSRYsB6U0iEJnILZiU3LrcsWoZhrsDYmWZk1kMPWCo+M6G1OvveBDBLBe+kvl\n\tOT/1dxAK/Ny4VFA67MgGJNVsOfUBkANfxOwnwX2s="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ssn+ZfGX\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220429212348.18063-2-laurent.pinchart@ideasonboard.com>","References":"<20220429212348.18063-1-laurent.pinchart@ideasonboard.com>\n\t<20220429212348.18063-2-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 04 May 2022 09:54:46 +0100","Message-ID":"<165165448624.4076486.9797423721617779751@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: geometry: Add missing\n\tostream header in geometry.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]