[{"id":22815,"web_url":"https://patchwork.libcamera.org/comment/22815/","msgid":"<165122836705.4076486.8165310709796461364@Monstersaurus>","date":"2022-04-29T10:32:47","subject":"Re: [libcamera-devel] [PATCH] libcamera: Replace toString with\n\toperator<<() for geometry classes","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-04-29 02:04:41)\n> Now that geometry classes implement the stream formatting operator<<(),\n> use it instead of the toString() function.\n\nSeems pretty clear and straightforward.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  src/android/camera_capabilities.cpp           |  6 +++---\n>  src/android/camera_device.cpp                 |  2 +-\n>  src/android/yuv/post_processor_yuv.cpp        |  4 ++--\n>  src/cam/camera_session.cpp                    |  3 +--\n>  src/cam/kms_sink.cpp                          |  4 +---\n>  src/libcamera/camera_sensor.cpp               |  4 ++--\n>  src/libcamera/pipeline/ipu3/imgu.cpp          | 19 +++++++++----------\n>  .../pipeline/raspberrypi/raspberrypi.cpp      |  2 +-\n>  src/libcamera/pipeline/rkisp1/rkisp1.cpp      |  6 +++---\n>  src/libcamera/pipeline/simple/converter.cpp   |  2 +-\n>  src/libcamera/pipeline/simple/simple.cpp      |  8 ++++----\n>  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  3 +--\n>  src/libcamera/pipeline/vimc/vimc.cpp          |  2 +-\n>  src/libcamera/v4l2_subdevice.cpp              |  2 +-\n>  src/libcamera/v4l2_videodevice.cpp            |  2 +-\n>  test/camera-sensor.cpp                        |  3 +--\n>  test/geometry.cpp                             |  4 +---\n>  test/stream/stream_formats.cpp                |  4 ++--\n>  18 files changed, 36 insertions(+), 44 deletions(-)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 55d651f38870..e06a517d84b8 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -487,7 +487,7 @@ int CameraCapabilities::initializeStreamConfigurations()\n>          * JPEG encoder requirements into account (alignment and aspect ratio).\n>          */\n>         const Size maxRes = cfg.size;\n> -       LOG(HAL, Debug) << \"Maximum supported resolution: \" << maxRes.toString();\n> +       LOG(HAL, Debug) << \"Maximum supported resolution: \" << maxRes;\n>  \n>         /*\n>          * Build the list of supported image resolutions.\n> @@ -729,7 +729,7 @@ int CameraCapabilities::initializeStreamConfigurations()\n>  \n>         LOG(HAL, Debug) << \"Collected stream configuration map: \";\n>         for (const auto &entry : streamConfigurations_)\n> -               LOG(HAL, Debug) << \"{ \" << entry.resolution.toString() << \" - \"\n> +               LOG(HAL, Debug) << \"{ \" << entry.resolution << \" - \"\n>                                 << utils::hex(entry.androidFormat) << \" }\";\n>  \n>         return 0;\n> @@ -1321,7 +1321,7 @@ int CameraCapabilities::initializeStaticMetadata()\n>  \n>                 LOG(HAL, Debug)\n>                         << \"Output Stream: \" << utils::hex(entry.androidFormat)\n> -                       << \" (\" << entry.resolution.toString() << \")[\"\n> +                       << \" (\" << entry.resolution << \")[\"\n>                         << entry.minFrameDurationNsec << \"]\"\n>                         << \"@\" << fps;\n>         }\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 00d484716045..f7ec95eb720e 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -925,7 +925,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>                 ss << i << \" - (\" << camera3Stream->width << \"x\"\n>                    << camera3Stream->height << \")\"\n>                    << \"[\" << utils::hex(camera3Stream->format) << \"] -> \"\n> -                  << \"(\" << cameraStream->configuration().size.toString() << \")[\"\n> +                  << \"(\" << cameraStream->configuration().size << \")[\"\n>                    << cameraStream->configuration().pixelFormat.toString() << \"]\";\n>  \n>                 /*\n> diff --git a/src/android/yuv/post_processor_yuv.cpp b/src/android/yuv/post_processor_yuv.cpp\n> index 9f88392476f1..513c6ef86153 100644\n> --- a/src/android/yuv/post_processor_yuv.cpp\n> +++ b/src/android/yuv/post_processor_yuv.cpp\n> @@ -34,8 +34,8 @@ int PostProcessorYuv::configure(const StreamConfiguration &inCfg,\n>  \n>         if (inCfg.size < outCfg.size) {\n>                 LOG(YUV, Error) << \"Up-scaling is not supported\"\n> -                               << \" (from \" << inCfg.size.toString()\n> -                               << \" to \" << outCfg.size.toString() << \")\";\n> +                               << \" (from \" << inCfg.size\n> +                               << \" to \" << outCfg.size << \")\";\n>                 return -EINVAL;\n>         }\n>  \n> diff --git a/src/cam/camera_session.cpp b/src/cam/camera_session.cpp\n> index 0428b5386537..bacb42561560 100644\n> --- a/src/cam/camera_session.cpp\n> +++ b/src/cam/camera_session.cpp\n> @@ -150,8 +150,7 @@ void CameraSession::infoConfiguration() const\n>                                   << std::endl;\n>  \n>                         for (const Size &size : formats.sizes(pixelformat))\n> -                               std::cout << \"  - \" << size.toString()\n> -                                         << std::endl;\n> +                               std::cout << \"  - \" << size << std::endl;\n>                 }\n>  \n>                 index++;\n> diff --git a/src/cam/kms_sink.cpp b/src/cam/kms_sink.cpp\n> index da579846fd8e..29be5623cb17 100644\n> --- a/src/cam/kms_sink.cpp\n> +++ b/src/cam/kms_sink.cpp\n> @@ -119,9 +119,7 @@ int KMSSink::configure(const libcamera::CameraConfiguration &config)\n>                                                       mode.vdisplay == cfg.size.height;\n>                                        });\n>         if (iter == modes.end()) {\n> -               std::cerr\n> -                       << \"No mode matching \" << cfg.size.toString()\n> -                       << std::endl;\n> +               std::cerr << \"No mode matching \" << cfg.size << std::endl;\n>                 return -EINVAL;\n>         }\n>  \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index eaa2da6bad32..4bb2066f0fd4 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -238,7 +238,7 @@ int CameraSensor::validateSensorDriver()\n>  \n>                 LOG(CameraSensor, Warning)\n>                         << \"The PixelArraySize property has been defaulted to \"\n> -                       << pixelArraySize_.toString();\n> +                       << pixelArraySize_;\n>                 err = -EINVAL;\n>         } else {\n>                 pixelArraySize_ = rect.size();\n> @@ -249,7 +249,7 @@ int CameraSensor::validateSensorDriver()\n>                 activeArea_ = Rectangle(pixelArraySize_);\n>                 LOG(CameraSensor, Warning)\n>                         << \"The PixelArrayActiveAreas property has been defaulted to \"\n> -                       << activeArea_.toString();\n> +                       << activeArea_;\n>                 err = -EINVAL;\n>         }\n>  \n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index e5bbc3829c68..3ac997cc1acf 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -386,9 +386,9 @@ ImgUDevice::PipeConfig ImgUDevice::calculatePipeConfig(Pipe *pipe)\n>         pipeConfigs.clear();\n>  \n>         LOG(IPU3, Debug) << \"Calculating pipe configuration for: \";\n> -       LOG(IPU3, Debug) << \"input: \" << pipe->input.toString();\n> -       LOG(IPU3, Debug) << \"main: \" << pipe->main.toString();\n> -       LOG(IPU3, Debug) << \"vf: \" << pipe->viewfinder.toString();\n> +       LOG(IPU3, Debug) << \"input: \" << pipe->input;\n> +       LOG(IPU3, Debug) << \"main: \" << pipe->main;\n> +       LOG(IPU3, Debug) << \"vf: \" << pipe->viewfinder;\n>  \n>         const Size &in = pipe->input;\n>  \n> @@ -397,8 +397,7 @@ ImgUDevice::PipeConfig ImgUDevice::calculatePipeConfig(Pipe *pipe)\n>          * See https://bugs.libcamera.org/show_bug.cgi?id=32\n>          */\n>         if (in.width < ImgUDevice::kIFMaxCropWidth || in.height < ImgUDevice::kIFMaxCropHeight) {\n> -               LOG(IPU3, Error) << \"Input resolution \" << in.toString()\n> -                                << \" not supported\";\n> +               LOG(IPU3, Error) << \"Input resolution \" << in << \" not supported\";\n>                 return {};\n>         }\n>  \n> @@ -460,9 +459,9 @@ ImgUDevice::PipeConfig ImgUDevice::calculatePipeConfig(Pipe *pipe)\n>         }\n>  \n>         LOG(IPU3, Debug) << \"Computed pipe configuration: \";\n> -       LOG(IPU3, Debug) << \"IF: \" << pipeConfigs[bestIndex].iif.toString();\n> -       LOG(IPU3, Debug) << \"BDS: \" << pipeConfigs[bestIndex].bds.toString();\n> -       LOG(IPU3, Debug) << \"GDC: \" << pipeConfigs[bestIndex].gdc.toString();\n> +       LOG(IPU3, Debug) << \"IF: \" << pipeConfigs[bestIndex].iif;\n> +       LOG(IPU3, Debug) << \"BDS: \" << pipeConfigs[bestIndex].bds;\n> +       LOG(IPU3, Debug) << \"GDC: \" << pipeConfigs[bestIndex].gdc;\n>  \n>         return pipeConfigs[bestIndex];\n>  }\n> @@ -496,13 +495,13 @@ int ImgUDevice::configure(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputF\n>         ret = imgu_->setSelection(PAD_INPUT, V4L2_SEL_TGT_CROP, &iif);\n>         if (ret)\n>                 return ret;\n> -       LOG(IPU3, Debug) << \"ImgU IF rectangle = \" << iif.toString();\n> +       LOG(IPU3, Debug) << \"ImgU IF rectangle = \" << iif;\n>  \n>         Rectangle bds{ 0, 0, pipeConfig.bds };\n>         ret = imgu_->setSelection(PAD_INPUT, V4L2_SEL_TGT_COMPOSE, &bds);\n>         if (ret)\n>                 return ret;\n> -       LOG(IPU3, Debug) << \"ImgU BDS rectangle = \" << bds.toString();\n> +       LOG(IPU3, Debug) << \"ImgU BDS rectangle = \" << bds;\n>  \n>         V4L2SubdeviceFormat gdcFormat = {};\n>         gdcFormat.mbus_code = MEDIA_BUS_FMT_FIXED;\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index acc0becaa5c0..d8c709b7a503 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -166,7 +166,7 @@ V4L2SubdeviceFormat findBestFormat(const SensorFormats &formatsMap, const Size &\n>                                 bestFormat.size = size;\n>                         }\n>  \n> -                       LOG(RPI, Debug) << \"Format: \" << size.toString()\n> +                       LOG(RPI, Debug) << \"Format: \" << size\n>                                         << \" fmt \" << format.toString()\n>                                         << \" Score: \" << score\n>                                         << \" (best \" << bestScore << \")\";\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 1624e2ecc5a0..1c53495c97cc 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -592,13 +592,13 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n>  \n>         LOG(RkISP1, Debug)\n>                 << \"ISP input pad configured with \" << format.toString()\n> -               << \" crop \" << rect.toString();\n> +               << \" crop \" << rect;\n>  \n>         /* YUYV8_2X8 is required on the ISP source path pad for YUV output. */\n>         format.mbus_code = MEDIA_BUS_FMT_YUYV8_2X8;\n>         LOG(RkISP1, Debug)\n>                 << \"Configuring ISP output pad with \" << format.toString()\n> -               << \" crop \" << rect.toString();\n> +               << \" crop \" << rect;\n>  \n>         ret = isp_->setSelection(2, V4L2_SEL_TGT_CROP, &rect);\n>         if (ret < 0)\n> @@ -610,7 +610,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n>  \n>         LOG(RkISP1, Debug)\n>                 << \"ISP output pad configured with \" << format.toString()\n> -               << \" crop \" << rect.toString();\n> +               << \" crop \" << rect;\n>  \n>         std::map<unsigned int, IPAStream> streamConfig;\n>  \n> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> index 9cbc6ee30ce4..ee8376dea1e0 100644\n> --- a/src/libcamera/pipeline/simple/converter.cpp\n> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> @@ -65,7 +65,7 @@ int SimpleConverter::Stream::configure(const StreamConfiguration &inputCfg,\n>             format.planes[0].bpl != inputCfg.stride) {\n>                 LOG(SimplePipeline, Error)\n>                         << \"Input format not supported (requested \"\n> -                       << inputCfg.size.toString() << \"-\" << videoFormat.toString()\n> +                       << inputCfg.size << \"-\" << videoFormat.toString()\n>                         << \", got \" << format.toString() << \")\";\n>                 return -EINVAL;\n>         }\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index ece821bfe978..e76bf01261b0 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -474,7 +474,7 @@ int SimpleCameraData::init()\n>                         video_->formats(format.mbus_code);\n>  \n>                 LOG(SimplePipeline, Debug)\n> -                       << \"Adding configuration for \" << format.size.toString()\n> +                       << \"Adding configuration for \" << format.size\n>                         << \" in pixel formats [ \"\n>                         << utils::join(videoFormats, \", \",\n>                                        [](const auto &f) {\n> @@ -808,8 +808,8 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n>  \n>                 if (!pipeConfig_->outputSizes.contains(cfg.size)) {\n>                         LOG(SimplePipeline, Debug)\n> -                               << \"Adjusting size from \" << cfg.size.toString()\n> -                               << \" to \" << pipeConfig_->captureSize.toString();\n> +                               << \"Adjusting size from \" << cfg.size\n> +                               << \" to \" << pipeConfig_->captureSize;\n>                         cfg.size = pipeConfig_->captureSize;\n>                         status = Adjusted;\n>                 }\n> @@ -939,7 +939,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n>             captureFormat.size != pipeConfig->captureSize) {\n>                 LOG(SimplePipeline, Error)\n>                         << \"Unable to configure capture in \"\n> -                       << pipeConfig->captureSize.toString() << \"-\"\n> +                       << pipeConfig->captureSize << \"-\"\n>                         << videoFormat.toString();\n>                 return -EINVAL;\n>         }\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 40654a0bc40c..e5a79417f923 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -143,8 +143,7 @@ CameraConfiguration::Status UVCCameraConfiguration::validate()\n>  \n>         if (cfg.size != size) {\n>                 LOG(UVC, Debug)\n> -                       << \"Adjusting size from \" << size.toString()\n> -                       << \" to \" << cfg.size.toString();\n> +                       << \"Adjusting size from \" << size << \" to \" << cfg.size;\n>                 status = Adjusted;\n>         }\n>  \n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index c3e33ecf048c..3db0ffe58c39 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -164,7 +164,7 @@ CameraConfiguration::Status VimcCameraConfiguration::validate()\n>  \n>         if (cfg.size != size) {\n>                 LOG(VIMC, Debug)\n> -                       << \"Adjusting size to \" << cfg.size.toString();\n> +                       << \"Adjusting size to \" << cfg.size;\n>                 status = Adjusted;\n>         }\n>  \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index fa216e85fde9..d5ae460571d8 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -191,7 +191,7 @@ const std::map<uint32_t, V4L2SubdeviceFormatInfo> formatInfoMap = {\n>  const std::string V4L2SubdeviceFormat::toString() const\n>  {\n>         std::stringstream mbus;\n> -       mbus << size.toString() << \"-\";\n> +       mbus << size << \"-\";\n>  \n>         const auto it = formatInfoMap.find(mbus_code);\n>  \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 05d3273ebb58..5ba866ad71bb 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -433,7 +433,7 @@ bool V4L2BufferCache::Entry::operator==(const FrameBuffer &buffer) const\n>  const std::string V4L2DeviceFormat::toString() const\n>  {\n>         std::stringstream ss;\n> -       ss << size.toString() << \"-\" << fourcc.toString();\n> +       ss << size << \"-\" << fourcc.toString();\n>         return ss.str();\n>  }\n>  \n> diff --git a/test/camera-sensor.cpp b/test/camera-sensor.cpp\n> index 372ee4aff69b..9b06a60e7695 100644\n> --- a/test/camera-sensor.cpp\n> +++ b/test/camera-sensor.cpp\n> @@ -86,8 +86,7 @@ protected:\n>  \n>                 const Size &resolution = sensor_->resolution();\n>                 if (resolution != Size(4096, 2160)) {\n> -                       cerr << \"Incorrect sensor resolution \"\n> -                            << resolution.toString() << endl;\n> +                       cerr << \"Incorrect sensor resolution \" << resolution << endl;\n>                         return TestFail;\n>                 }\n>  \n> diff --git a/test/geometry.cpp b/test/geometry.cpp\n> index 5125692496b3..008d51eac0dd 100644\n> --- a/test/geometry.cpp\n> +++ b/test/geometry.cpp\n> @@ -25,9 +25,7 @@ protected:\n>                 bool result = op(lhs, rhs);\n>  \n>                 if (result != expect) {\n> -                       cout << lhs.toString()\n> -                            << opName << \" \"\n> -                            << rhs.toString()\n> +                       cout << lhs << opName << \" \" << rhs\n>                              << \"test failed\" << std::endl;\n>                         return false;\n>                 }\n> diff --git a/test/stream/stream_formats.cpp b/test/stream/stream_formats.cpp\n> index 9353d0085e19..99fa0385e961 100644\n> --- a/test/stream/stream_formats.cpp\n> +++ b/test/stream/stream_formats.cpp\n> @@ -40,10 +40,10 @@ protected:\n>                         cout << \"Failed \" << name << endl;\n>                         cout << \"Sizes to test:\" << endl;\n>                         for (Size &size : test)\n> -                               cout << size.toString() << endl;\n> +                               cout << size << endl;\n>                         cout << \"Valid sizes:\" << endl;\n>                         for (Size &size : valid)\n> -                               cout << size.toString() << endl;\n> +                               cout << size << endl;\n>  \n>                         return TestFail;\n>                 }\n> \n> base-commit: dc7fc90573b99bbc6d21a25a741891471d68f274\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 540C4C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 29 Apr 2022 10:32:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FBEA65643;\n\tFri, 29 Apr 2022 12:32:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 906A96042F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Apr 2022 12:32:49 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0DD01488;\n\tFri, 29 Apr 2022 12:32:49 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651228371;\n\tbh=Z5XfpOqcR7vS6+Ubv2f8KzrffMPCvSvHklNB2hT1Sm0=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=SZYWz1jidhJVUg1sQ83DWaR7IVzT47oknvialQVOp9A4muDCI24t1Zvff6piuuhda\n\t4JgkGNz5aAgzrUqGQ6ZUePiKbqN3uycttL3EaSMGkIQYHD9CQxbduOa0jL/6Hp5+mX\n\tmZbUFswJgwbj/ZemxbOXMCvVVflTH2Wexbd5aMIUB5CnBFYJlRLNYifjQgdzEE0jgf\n\tjNgDv19wAqq5rJKS+gsMTlQPRThjabZsA+UIVUVNFNkk8gASo6Bhkoog8WCd+Rdcq7\n\tvDR4uKYvIHbFBVU6ZU4TFY/LwPPzka9kNjB69SruZJbGzNvalW9zm1s/McsDn4EYKQ\n\tYisPrlc4UyhjA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651228369;\n\tbh=Z5XfpOqcR7vS6+Ubv2f8KzrffMPCvSvHklNB2hT1Sm0=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=vIz9yaKNP1HGvIx+MVA7tkxTItcEzpk17IbDZIX0452zCtDtObb21c6sQhbkMF97Y\n\tEBRYrwts1Wk4yIsR9iq7kOFc0jgIbOx8vd0T5g3CbiSR//NefoebuF8SJn82P0scd8\n\tWopOMFXGkJ8BVV0YB7hRSxtCNKUfIAEeFe8ND00I="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vIz9yaKN\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220429010441.27110-1-laurent.pinchart@ideasonboard.com>","References":"<20220429010441.27110-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 29 Apr 2022 11:32:47 +0100","Message-ID":"<165122836705.4076486.8165310709796461364@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Replace toString with\n\toperator<<() for geometry classes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]