{"id":15743,"url":"https://patchwork.libcamera.org/api/patches/15743/?format=json","web_url":"https://patchwork.libcamera.org/patch/15743/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220428095544.2795980-2-chenghaoyang@chromium.org>","date":"2022-04-28T09:55:39","name":"[libcamera-devel,v4,1/6] Allow inheritance of FrameBuffer","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d78749ed8f4bce5d76dcf6ebd520776e9ce97bdb","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15743/mbox/","series":[{"id":3081,"url":"https://patchwork.libcamera.org/api/series/3081/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3081","date":"2022-04-28T09:55:38","name":"Add CrOS JEA implementation","version":4,"mbox":"https://patchwork.libcamera.org/series/3081/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15743/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15743/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A452C3256\n\tfor ;\n\tThu, 28 Apr 2022 09:55:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BA1BB65643;\n\tThu, 28 Apr 2022 11:55:58 +0200 (CEST)","from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com\n\t[IPv6:2607:f8b0:4864:20::102c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD3CB65644\n\tfor ;\n\tThu, 28 Apr 2022 11:55:56 +0200 (CEST)","by mail-pj1-x102c.google.com with SMTP id iq10so3881067pjb.0\n\tfor ;\n\tThu, 28 Apr 2022 02:55:56 -0700 (PDT)","from chenghaoyang.c.googlers.com.com\n\t(93.135.240.35.bc.googleusercontent.com. [35.240.135.93])\n\tby smtp.gmail.com with ESMTPSA id\n\tx6-20020a17090a46c600b001d960eaed66sm5861256pjg.42.2022.04.28.02.55.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 28 Apr 2022 02:55:54 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651139758;\n\tbh=MnBw0VtZLV0ChWN6qy6mMftHZPzprQwTde4XzfFIWcg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=AVJA4L1xf6u5OL7I423+Pq6gE5zbZWp+UrcWzRcZ9dSJE5J0gowrvzoBl/JjtM/NM\n\tRieCITwHtyrSwL0NcbxszZxEuQHi0PPSvXsCTk/AWcAiFGWkNRizY0hKOZXpRjUlc8\n\t0s73WDK5YfdIjq2AcSvJ2b8RRWSYqnuB45tuDN5iZPdHKLiK9S9cBsHyjC+j+RprOD\n\txxkGljxCK1yzb1354FQs8TewL4d/6Dye98PY3dFmjunSTt28eyu9aHxiJuD9WgLgpo\n\tlnw3VOUprEra8G+AGsqPtd+fzkSJujXQMy7P1zcFwZ31cxGQdZilNaYtZYXPIJGAoO\n\t2W1JpKFi+Qxng==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=cVxSlUD1nSICClAUJNcDweoWDMkgJCpn5sWDanPVMlQ=;\n\tb=dJF4+nFzOyqEngD4inUZqBvn+4SUsu+J7OLKw1sVBG4aaAwyP/urpGh3iLwInDKm2b\n\tA0ECkKx8lxzdi8Uf5Oil7zd5CgwXtGlA/xAI0Izsf75gmC8B8NQf1xomWDMU4TOG9g+l\n\tyZq1Zo8m4e1iHJD7XerFdSCkvN2Sw6Is71Bw8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"dJF4+nFz\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=cVxSlUD1nSICClAUJNcDweoWDMkgJCpn5sWDanPVMlQ=;\n\tb=p9gMxG/sG0fo7MhwxPtTWAMdmYSjA5qkaWzMNFi15NtIRNMHt5LONxliPU8Lnim8AM\n\t4/D7PeYgUxZINhqqdVNyyEWvpi4lPjwRNCNMgOkScMi/zZVfdppNUNP1zSzHnUIM3fkE\n\trUndBWNbXWsBkxw350M7b3CbmEBJLggoCt48+93+iM3jfWStgltFa2X4dmZps31hiizM\n\t5kzWN9bvKdMmVD1fShmzBiu26rP1QnYtM2Rhc6iLAHaRYJoBDPjqkVYnpC0YUQqr9lp1\n\tRtxR1dnj+/Qq49ZPVDGyt+ejTNDGCdSl7bkN5Td6S+FskZvvT+ZmTqaEFOTopWe7fBE2\n\t2XLQ==","X-Gm-Message-State":"AOAM533waLoFt0vj+GZiBnb2nmSO91qoVa1a3bFnyfXSlgc/k6j1iY8g\n\tMCKb5qtHbTm//y/tvBdzDNCF4YiJPykR2SRh","X-Google-Smtp-Source":"ABdhPJwhwbC3jn/35JVwXCcVYZigVX4zZVAYNq54JY1+2brhoajnXM3bn60Ro4LL9ynVCOBSofOsXQ==","X-Received":"by 2002:a17:90b:4a09:b0:1d2:de49:9be8 with SMTP id\n\tkk9-20020a17090b4a0900b001d2de499be8mr49564956pjb.68.1651139754965; \n\tThu, 28 Apr 2022 02:55:54 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 28 Apr 2022 09:55:39 +0000","Message-Id":"<20220428095544.2795980-2-chenghaoyang@chromium.org>","X-Mailer":"git-send-email 2.36.0.rc2.479.g8af0fa9b8e-goog","In-Reply-To":"<20220428095544.2795980-1-chenghaoyang@chromium.org>","References":"<20220428095544.2795980-1-chenghaoyang@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 1/6] Allow inheritance of FrameBuffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Harvey Yang via libcamera-devel ","Reply-To":"Harvey Yang ","Cc":"Harvey Yang ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"To add buffer_handle_t access in android, this patch allows inheritance\nof FrameBuffer to add a derived class in android.\n\nSigned-off-by: Harvey Yang \n---\n include/libcamera/framebuffer.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex 3b1118d1..e6c769b4 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -46,7 +46,7 @@ private:\n \tstd::vector planes_;\n };\n \n-class FrameBuffer final : public Extensible\n+class FrameBuffer : public Extensible\n {\n \tLIBCAMERA_DECLARE_PRIVATE()\n \n@@ -61,6 +61,7 @@ public:\n \tFrameBuffer(const std::vector &planes, unsigned int cookie = 0);\n \tFrameBuffer(std::unique_ptr d,\n \t\t const std::vector &planes, unsigned int cookie = 0);\n+\tvirtual ~FrameBuffer() {}\n \n \tconst std::vector &planes() const { return planes_; }\n \tRequest *request() const;\n","prefixes":["libcamera-devel","v4","1/6"]}