{"id":15734,"url":"https://patchwork.libcamera.org/api/patches/15734/?format=json","web_url":"https://patchwork.libcamera.org/patch/15734/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220427151302.607431-1-hanlinchen@chromium.org>","date":"2022-04-27T15:13:02","name":"[libcamera-devel,v2] android: camera_capabilities: Add (1600x1200) and (1280x960) resolutions","commit_ref":"f32eb2689bd30b87120f9cc6bfbbc313572ff674","pull_url":null,"state":"accepted","archived":false,"hash":"d01ca4ed61f895cad7f0c29e6192a47a69b39733","submitter":{"id":98,"url":"https://patchwork.libcamera.org/api/people/98/?format=json","name":"Hanlin Chen","email":"hanlinchen@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15734/mbox/","series":[{"id":3077,"url":"https://patchwork.libcamera.org/api/series/3077/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3077","date":"2022-04-27T15:13:02","name":"[libcamera-devel,v2] android: camera_capabilities: Add (1600x1200) and (1280x960) resolutions","version":2,"mbox":"https://patchwork.libcamera.org/series/3077/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15734/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15734/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BB35C0F2A\n\tfor ;\n\tWed, 27 Apr 2022 15:13:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4F7B65644;\n\tWed, 27 Apr 2022 17:13:09 +0200 (CEST)","from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com\n\t[IPv6:2607:f8b0:4864:20::1032])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7D886042F\n\tfor ;\n\tWed, 27 Apr 2022 17:13:07 +0200 (CEST)","by mail-pj1-x1032.google.com with SMTP id\n\td23-20020a17090a115700b001d2bde6c234so3983219pje.1\n\tfor ;\n\tWed, 27 Apr 2022 08:13:07 -0700 (PDT)","from localhost ([2401:fa00:1:17:47e:a9de:8ea1:3876])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\td15-20020a630e0f000000b003a408836badsm16435781pgl.45.2022.04.27.08.13.04\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 27 Apr 2022 08:13:05 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651072389;\n\tbh=GSaeV5ftMrIdl4xHAlIkv+/xA/5RjKyEmgoYpoqwhcQ=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=lWQMGrrKuBFQ7/x0yTBCFb+z/7LITtAaY9pTtqBo4SD9kZj1C8o5wljVUNneKm5ko\n\t8s2LYYqFc/IttYxHPbqe660NuLnZORCac2gJoNDiWCDivmTg6yhTo91PD8pZvyxSUt\n\t5DY47TcXnhe37LjO0/c1t3m6zcvK91fFrtq6xOnllijurgdg++1p7tXD7/25aTffey\n\tPJLYoKeQymqIWWxkz1qJWm62AiohAaS3Djzdxwz8/PfRXBgq7NApjwwurAaXc3lSxK\n\tvJ7P/bgcNdE568X+SYGGxCnBo3jALsMaZmMzo4p/UKr8jnMOwineYSiN/4JVGqylPo\n\tgVoNf9kyPlpMA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=HOAURnb2YRFx2HOQVBOHr15bReHazB1JFUroddOIZxw=;\n\tb=EuWn7ioc+pe2rWBI5RuOobI1H0PrE6D8jrrI+Tg6srfshc935FY4pLiMviTnZ9YpeK\n\tJkdZRP+Nwl/jvONcvQg63unyHDuv2NZhhTQKCRFtIayUBd2nLAmnyv6wZhpd2dsAFWYM\n\tiWowUCnt0MdlolTAHnpZcN8byl0IB7osL6F7E="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"EuWn7ioc\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=HOAURnb2YRFx2HOQVBOHr15bReHazB1JFUroddOIZxw=;\n\tb=jadSlcosy/iVr1ruf0FW0Pc6ukkpmb3zjCGJYs8JflFCFEudBrckuer7WBtCSceh9r\n\tY+r6kFXdWDwUtX3TfYbPlvaIwLhJIlZbeE7aPz4MP8/EVgeE1vGuTCwJEOXxymj00b9p\n\t24TNUtLU4MDb28hLzOoxrZirs13Xr89KnTcwnxZ2ARRYy9PFfnA1afZtcbb91zGGV8MH\n\tsISctxXAieBN14fAMEQwHLf0jSWwcbPOfEG9pbs0gqDCA3+jvVqHzlOX6dU/KsfhUApE\n\tohELb+oQc1pXkj6UMx0/tt2ZZMgksj7PLKxRsdsxTfy3QHRy5Z1mvPFRIViQOynai9EO\n\tToxA==","X-Gm-Message-State":"AOAM5303WK/BRCjgZAQDeE2uGm8TozHyKl58yo5IMpSmojT/QqObnPEr\n\t8mhk93X8w5ON60rNezuZjIiRqQECnG4gNw==","X-Google-Smtp-Source":"ABdhPJy52vaoONv1t2VmsI0SxmIgPdis6LDyMoXYvoPCdesEjkyok2gQxKQAyQR33EBfjg+VQ6/Org==","X-Received":"by 2002:a17:90a:1944:b0:1d9:7cf8:5457 with SMTP id\n\t4-20020a17090a194400b001d97cf85457mr17298553pjh.112.1651072386077; \n\tWed, 27 Apr 2022 08:13:06 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 27 Apr 2022 23:13:02 +0800","Message-Id":"<20220427151302.607431-1-hanlinchen@chromium.org>","X-Mailer":"git-send-email 2.36.0.rc2.479.g8af0fa9b8e-goog","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2] android: camera_capabilities: Add\n\t(1600x1200) and (1280x960) resolutions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Han-Lin Chen via libcamera-devel ","Reply-To":"Han-Lin Chen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Although resolutions (1600x1200) and (1280x960) are not mandatory to be\nsupported by the Android Camera3 specification, they are commonly used\nby Android devices as viewfinder streams for 4:3 still capture.\n\nAdd them into stream resolution candidates.\n\nSigned-off-by: Han-Lin Chen \nReviewed-by: Jacopo Mondi \nReviewed-by: Kieran Bingham \n---\n src/android/camera_capabilities.cpp | 15 +++++++++++----\n 1 file changed, 11 insertions(+), 4 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex ee17cdc7..649f84d3 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -31,13 +31,20 @@ namespace {\n \n /*\n * \\var camera3Resolutions\n- * \\brief The list of image resolutions defined as mandatory to be supported by\n- * the Android Camera3 specification\n+ * \\brief The list of image resolutions commonly supported by Android\n+ *\n+ * The following are defined as mandatory to be supported by the Android\n+ * Camera3 specification: (320x240), (640x480), (1280x720), (1920x1080).\n+ *\n+ * The following 4:3 resolutions are defined as optional, but commonly\n+ * supported by Android devices: (1280x960), (1600x1200).\n */\n const std::vector camera3Resolutions = {\n \t{ 320, 240 },\n \t{ 640, 480 },\n \t{ 1280, 720 },\n+\t{ 1280, 960 },\n+\t{ 1600, 1200 },\n \t{ 1920, 1080 }\n };\n \n@@ -492,8 +499,8 @@ int CameraCapabilities::initializeStreamConfigurations()\n \t/*\n \t * Build the list of supported image resolutions.\n \t *\n-\t * The resolutions listed in camera3Resolution are mandatory to be\n-\t * supported, up to the camera maximum resolution.\n+\t * The resolutions listed in camera3Resolution are supported, up to the\n+\t * camera maximum resolution.\n \t *\n \t * Augment the list by adding resolutions calculated from the camera\n \t * maximum one.\n","prefixes":["libcamera-devel","v2"]}