[{"id":2092,"web_url":"https://patchwork.libcamera.org/comment/2092/","msgid":"<20190701214249.GA9228@bigcity.dyn.berto.se>","date":"2019-07-01T21:42:49","subject":"Re: [libcamera-devel] [PATCH] test: timer: Add dynamically\n\tallocated timer test","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-07-01 23:27:12 +0300, Laurent Pinchart wrote:\n> Timers should be automatically stopped and unregistered when deleted.\n> Add a test to verify this is the case.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\nWill you push this together with the timer fix or should I?\n\n> ---\n> test/timer.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/test/timer.cpp b/test/timer.cpp\n> index 41c132bd1ab2..addebce3c784 100644\n> --- a/test/timer.cpp\n> +++ b/test/timer.cpp\n> @@ -152,6 +152,17 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\t/*\n> +\t\t * Test that dynamically allocated timers are stopped when\n> +\t\t * deleted. This will result in a crash on failure.\n> +\t\t */\n> +\t\tManagedTimer *dyntimer = new ManagedTimer();\n> +\t\tdyntimer->start(100);\n> +\t\tdelete dyntimer;\n> +\n> +\t\ttimer.start(200);\n> +\t\tdispatcher->processEvents();\n> +\n> \t\treturn TestPass;\n> \t}\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 043566157D\n\tfor ;\n\tMon, 1 Jul 2019 23:42:52 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id 136so9789240lfa.8\n\tfor ;\n\tMon, 01 Jul 2019 14:42:51 -0700 (PDT)","from localhost (customer-145-14-112-32.stosn.net. [145.14.112.32])\n\tby smtp.gmail.com with ESMTPSA id\n\tp87sm3421123ljp.50.2019.07.01.14.42.50\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 01 Jul 2019 14:42:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=0LSmt1iCrCVa1jSgcAUcbEe8rvioJz7WtpsQ1qQ1/3o=;\n\tb=wtA+G6zr0eLEbwtgDfPhRba5GWIKKP2Em9YnjcSUpSD0UsxLq0rskOYsQVq18rjMfV\n\tXS+I4lIT1u6dJW/OmsRCQvd/8drFmdnNj5So8sJ8/QN4Wn3L17BZh6+Dga9wFhpkncp2\n\tuDd6mnNBR4ztdOaUegjBJFBiLawT1l0RU2MgfoOWsb+A6R91KrZRk9q4HWdafcdUwy1N\n\t8QZpHwyRLSeQYGJPeSwxAOXFfZoBg1Gxyhq9OjRnCthEstl6uQFgntgNhEkpClGa3n7H\n\tyjcTK7TcS/19qBOm0GvyzSMhjOPDc50EprUl9bmu6DXcAhd6Q/WsFJJ2s42Vo3+rbQ/U\n\t7n2A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=0LSmt1iCrCVa1jSgcAUcbEe8rvioJz7WtpsQ1qQ1/3o=;\n\tb=Hps0iKr8vgY/n+BHF/buxWu8DaWtH7d7i5axyuwA29JMjiQfy430HA0Rh4eLLygwgg\n\tMfFxA1JWYPAJIQOwGis8EmZEoQRIRaqUmYyDeEuwX6L5UxLIGyzztVCrY8/vIDmq0Wct\n\t0b3TYd80Iwnydn8lTBig9rJC5XTSoB1SR3gte34yNBdol4OPHG07Ad1dTZeozuXl1N2o\n\td8qHe3VjMbgMWDt9/gmkRRAIiM2b755gxf5ck+usw5Ccnq4GcOXksspXrEp8q88AauP+\n\t7tdnvPgHT/Aq2fGqznGvv0C8H6wYLgq+vYbh0HS0Lb97RmvCdbh0mdY4oKWZrvZC5taw\n\tJoBA==","X-Gm-Message-State":"APjAAAWjO2Fw+RAHU0XS00ioI/BxlVVzfDDcM/vpPJ4yjFi//mGEbJeT\n\tyoNjvsyhpj0fHgkvt5n6MEtOvWT3uGg=","X-Google-Smtp-Source":"APXvYqxFn6Dmo17ntMNOaFzvTQ4xF6hjvpkYzleLAp45cE7eM5lh/if7QSWr5Wt3RyiRXOQU6Y2+2g==","X-Received":"by 2002:ac2:44a4:: with SMTP id c4mr8478031lfm.116.1562017370918;\n\tMon, 01 Jul 2019 14:42:50 -0700 (PDT)","Date":"Mon, 1 Jul 2019 23:42:49 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190701214249.GA9228@bigcity.dyn.berto.se>","References":"<20190630162514.20522-2-niklas.soderlund@ragnatech.se>\n\t<20190701202712.29332-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190701202712.29332-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH] test: timer: Add dynamically\n\tallocated timer test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 01 Jul 2019 21:42:52 -0000"}}]