{"id":1573,"url":"https://patchwork.libcamera.org/api/patches/1573/?format=json","web_url":"https://patchwork.libcamera.org/patch/1573/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190701202712.29332-1-laurent.pinchart@ideasonboard.com>","date":"2019-07-01T20:27:12","name":"[libcamera-devel] test: timer: Add dynamically allocated timer test","commit_ref":"3952d49d8db15eb0788817f97b4de9eadd036324","pull_url":null,"state":"accepted","archived":false,"hash":"75047a3559e106fc53e8a09e3e69f925d56dad9e","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1573/mbox/","series":[{"id":387,"url":"https://patchwork.libcamera.org/api/series/387/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=387","date":"2019-07-01T20:27:12","name":"[libcamera-devel] test: timer: Add dynamically allocated timer test","version":1,"mbox":"https://patchwork.libcamera.org/series/387/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1573/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1573/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E415F6157C\n\tfor ;\n\tMon, 1 Jul 2019 22:27:34 +0200 (CEST)","from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B450524\n\tfor ;\n\tMon, 1 Jul 2019 22:27:34 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562012854;\n\tbh=fM71fx+NHBOPQHI/uQAMpVBlx7z4A+jP1Czo2qBSoA4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=qN+a3C7DJfGqfbohFl2cTgUXZfI3L+KqyIVm4quUZxtRGUZAD/fEYZNpVaMjFVSBg\n\tPJbcwf+Cg7kVpGfkxRdMSudC5BRbSeFSMsNUVhjcm211fQg4OAPKh20HIrbtwJVYKm\n\tcomKXsrnz3oyqx1Smhl2l8pI5tuJJIN0NlEvWrm0=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 1 Jul 2019 23:27:12 +0300","Message-Id":"<20190701202712.29332-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190630162514.20522-2-niklas.soderlund@ragnatech.se>","References":"<20190630162514.20522-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] test: timer: Add dynamically allocated\n\ttimer test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 01 Jul 2019 20:27:35 -0000"},"content":"Timers should be automatically stopped and unregistered when deleted.\nAdd a test to verify this is the case.\n\nSigned-off-by: Laurent Pinchart \n---\n test/timer.cpp | 11 +++++++++++\n 1 file changed, 11 insertions(+)","diff":"diff --git a/test/timer.cpp b/test/timer.cpp\nindex 41c132bd1ab2..addebce3c784 100644\n--- a/test/timer.cpp\n+++ b/test/timer.cpp\n@@ -152,6 +152,17 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n+\t\t/*\n+\t\t * Test that dynamically allocated timers are stopped when\n+\t\t * deleted. This will result in a crash on failure.\n+\t\t */\n+\t\tManagedTimer *dyntimer = new ManagedTimer();\n+\t\tdyntimer->start(100);\n+\t\tdelete dyntimer;\n+\n+\t\ttimer.start(200);\n+\t\tdispatcher->processEvents();\n+\n \t\treturn TestPass;\n \t}\n \n","prefixes":["libcamera-devel"]}