[{"id":22796,"web_url":"https://patchwork.libcamera.org/comment/22796/","msgid":"<20220426144408.phhevhperofo3x23@uno.localdomain>","date":"2022-04-26T14:44:08","subject":"Re: [libcamera-devel] [PATCH] android: camera_capabilities: Add\n\t(1600x1200) and (1280x960) resolutions","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Han-Lin\n\nOn Tue, Apr 26, 2022 at 08:14:16PM +0800, Han-Lin Chen via libcamera-devel wrote:\n> Although resolutions (1600x1200) and (1280x960) are not mandatory to be\n> supported by the Android Camera3 specification, they are commonly used\n> by Android devices as viewfinder streams for 4:3 still capture.\n>\n> Add them into stream resolution candidates.\n\nFine by me. I was concerned by very low-end devices that might not be\ncapable of producing those resolutions, but seems like there is no\nenforcement on any resolution being mandatory when we build the\ncameraResolutions list in initializeStreamConfigurations().\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Han-Lin Chen \n> ---\n> src/android/camera_capabilities.cpp | 15 +++++++++++----\n> 1 file changed, 11 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 5242055c..e0f23c87 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -31,13 +31,20 @@ namespace {\n>\n> /*\n> * \\var camera3Resolutions\n> - * \\brief The list of image resolutions defined as mandatory to be supported by\n> - * the Android Camera3 specification\n> + * \\brief The list of image resolutions commonly supported by Android\n> + *\n> + * The following are defined as mandatory to be supported by the Android\n> + * Camera3 specification: (320x240), (640x480), (1280x720), (1920x1080).\n> + *\n> + * The following 4:3 resolutions are defined as optional, but commonly\n> + * supported by Android devices: (1280x960), (1600x1200).\n> */\n> const std::vector camera3Resolutions = {\n> \t{ 320, 240 },\n> \t{ 640, 480 },\n> \t{ 1280, 720 },\n> +\t{ 1280, 960 },\n> +\t{ 1600, 1200 },\n> \t{ 1920, 1080 }\n> };\n>\n> @@ -492,8 +499,8 @@ int CameraCapabilities::initializeStreamConfigurations()\n> \t/*\n> \t * Build the list of supported image resolutions.\n> \t *\n> -\t * The resolutions listed in camera3Resolution are mandatory to be\n> -\t * supported, up to the camera maximum resolution.\n> +\t * The resolutions listed in camera3Resolution are to be supported,\n> +\t * up to the camera maximum resolution.\n> \t *\n> \t * Augment the list by adding resolutions calculated from the camera\n> \t * maximum one.\n> --\n> 2.36.0.rc2.479.g8af0fa9b8e-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83D4AC3256\n\tfor ;\n\tTue, 26 Apr 2022 14:44:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D922565642;\n\tTue, 26 Apr 2022 16:44:10 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2451C60431\n\tfor ;\n\tTue, 26 Apr 2022 16:44:10 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 9D47A24000E;\n\tTue, 26 Apr 2022 14:44:09 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650984250;\n\tbh=gevGYF+cw+9YtsG9SuphMV6nywQI5scZKSqqgpJ7Ng0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=DzI6pdGAeRxP6qieVf0EAO5RaBAAEJxR7qlNIO6KTm+3rU0qODIRGwBOcA3AKYAdZ\n\tXeS8sQytVahtiR4KLPUlyj3aN0p2C68Nl82K8dJZJYd8I/9P4B2NZ4A/w6OJXuIjsd\n\ta9yv6YyI8vQb003fcpL6IPOnC0yYdqqMxlhhYgViuRa3hVqkRgru8RJOVfSTBDzn/r\n\t8pp4fo/Z/Y1VJZrlTjq9QOx7XSYTjIM9OVcW5kWalHNSD+STrvNXwzsZB+pqweztPp\n\tx1tvgPUpakCpy1Uzhs6ED4FUPID3WN/imZPN4YCx6Dx4irZPtc8Yv1p5Bb0ZiFufKt\n\tfo/qbS+AgDnXQ==","Date":"Tue, 26 Apr 2022 16:44:08 +0200","To":"Han-Lin Chen ","Message-ID":"<20220426144408.phhevhperofo3x23@uno.localdomain>","References":"<20220426121416.754053-1-hanlinchen@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220426121416.754053-1-hanlinchen@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH] android: camera_capabilities: Add\n\t(1600x1200) and (1280x960) resolutions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22804,"web_url":"https://patchwork.libcamera.org/comment/22804/","msgid":"<165106352332.4076486.8300938481885128483@Monstersaurus>","date":"2022-04-27T12:45:23","subject":"Re: [libcamera-devel] [PATCH] android: camera_capabilities: Add\n\t(1600x1200) and (1280x960) resolutions","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Han-Lin Chen via libcamera-devel (2022-04-26 13:14:16)\n> Although resolutions (1600x1200) and (1280x960) are not mandatory to be\n> supported by the Android Camera3 specification, they are commonly used\n> by Android devices as viewfinder streams for 4:3 still capture.\n> \n> Add them into stream resolution candidates.\n> \n> Signed-off-by: Han-Lin Chen \n> ---\n> src/android/camera_capabilities.cpp | 15 +++++++++++----\n> 1 file changed, 11 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 5242055c..e0f23c87 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -31,13 +31,20 @@ namespace {\n> \n> /*\n> * \\var camera3Resolutions\n> - * \\brief The list of image resolutions defined as mandatory to be supported by\n> - * the Android Camera3 specification\n> + * \\brief The list of image resolutions commonly supported by Android\n> + *\n> + * The following are defined as mandatory to be supported by the Android\n> + * Camera3 specification: (320x240), (640x480), (1280x720), (1920x1080).\n> + *\n> + * The following 4:3 resolutions are defined as optional, but commonly\n> + * supported by Android devices: (1280x960), (1600x1200).\n> */\n> const std::vector camera3Resolutions = {\n> { 320, 240 },\n> { 640, 480 },\n> { 1280, 720 },\n> + { 1280, 960 },\n> + { 1600, 1200 },\n> { 1920, 1080 }\n> };\n> \n> @@ -492,8 +499,8 @@ int CameraCapabilities::initializeStreamConfigurations()\n> /*\n> * Build the list of supported image resolutions.\n> *\n> - * The resolutions listed in camera3Resolution are mandatory to be\n> - * supported, up to the camera maximum resolution.\n> + * The resolutions listed in camera3Resolution are to be supported,\n> + * up to the camera maximum resolution.\n\n'are to be supported' suggests that they are not yet supported. Perhaps\nthis should now read \"are supported\".\n\nBut other than that, this seems reasonable to me.\n\nReviewed-by: Kieran Bingham \n\n> *\n> * Augment the list by adding resolutions calculated from the camera\n> * maximum one.\n> -- \n> 2.36.0.rc2.479.g8af0fa9b8e-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 71D29C0F2A\n\tfor ;\n\tWed, 27 Apr 2022 12:45:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B472065642;\n\tWed, 27 Apr 2022 14:45:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 516F76042D\n\tfor ;\n\tWed, 27 Apr 2022 14:45:26 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C3B4F30B;\n\tWed, 27 Apr 2022 14:45:25 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651063527;\n\tbh=23lA4B2eebJjaLiHPk9aHleyFKf3YKSh0RXx0zj2DU4=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=dQ5yhsjJ2bHQDkPtNqT0mwf6yb+ntov8ft/rP1yKAV0jg0misjTaJMyjcLllFJJ+d\n\tSVYiH2qDoaDbnuS3lTB+ANZxURp0k9JaNiqpxgFchQs+nG4iMy3QIbQLxZHsQqRGnr\n\tzeMZA/E+J63zQTLm9JrFIosaJWHnX6QwA/13/ybTQxi8jLADVSZYmBcDNCm0m8kr4O\n\t0++z0o8xzR121AGN/GnNloVVH+f/02OB3Y0X0NGPJYf+47bCpi+ooMzcczf7qm0TaR\n\t2vKEAMcXolZzyoJIhzZJSCzj6+abJE2CdTEMvzPxtnjaoTHPAnbmX8EhK43FJjnWkG\n\tvOIAalPDGsOqg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651063525;\n\tbh=23lA4B2eebJjaLiHPk9aHleyFKf3YKSh0RXx0zj2DU4=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=f5xpaD9wbS/bVlleNHbmM9y6urph/DKI1w42XPYVdouF5OIoMIi792ylKDALNM0dE\n\t9TjPUBOEwDZ0WqHaZX+f7G0hzPXG7BoUDoRgyfrBVfxEstE2iYN3cKuXcMe8m7WMJJ\n\tjdTl/Hz1w/KtWPAdSQuNqnMkPbehxSUqu+w8JcAg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"f5xpaD9w\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220426121416.754053-1-hanlinchen@chromium.org>","References":"<20220426121416.754053-1-hanlinchen@chromium.org>","To":"Han-Lin Chen ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 27 Apr 2022 13:45:23 +0100","Message-ID":"<165106352332.4076486.8300938481885128483@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] android: camera_capabilities: Add\n\t(1600x1200) and (1280x960) resolutions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]