{"id":15729,"url":"https://patchwork.libcamera.org/api/patches/15729/?format=json","web_url":"https://patchwork.libcamera.org/patch/15729/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220426121416.754053-1-hanlinchen@chromium.org>","date":"2022-04-26T12:14:16","name":"[libcamera-devel] android: camera_capabilities: Add (1600x1200) and (1280x960) resolutions","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"24b55ed6d145a887b0f210e14f32b5be99a60220","submitter":{"id":98,"url":"https://patchwork.libcamera.org/api/people/98/?format=json","name":"Hanlin Chen","email":"hanlinchen@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15729/mbox/","series":[{"id":3074,"url":"https://patchwork.libcamera.org/api/series/3074/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3074","date":"2022-04-26T12:14:16","name":"[libcamera-devel] android: camera_capabilities: Add (1600x1200) and (1280x960) resolutions","version":1,"mbox":"https://patchwork.libcamera.org/series/3074/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15729/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15729/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E69CAC0F2A\n\tfor ;\n\tTue, 26 Apr 2022 12:14:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F48C65642;\n\tTue, 26 Apr 2022 14:14:22 +0200 (CEST)","from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com\n\t[IPv6:2607:f8b0:4864:20::62c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8755060431\n\tfor ;\n\tTue, 26 Apr 2022 14:14:21 +0200 (CEST)","by mail-pl1-x62c.google.com with SMTP id c23so30029163plo.0\n\tfor ;\n\tTue, 26 Apr 2022 05:14:21 -0700 (PDT)","from localhost ([2401:fa00:1:17:255:33c4:eb32:373b])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\tz9-20020a630a49000000b003ab2bfdc919sm6835178pgk.39.2022.04.26.05.14.18\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 26 Apr 2022 05:14:19 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650975262;\n\tbh=kzmupxKf6FQ3j3UgTiLU+EmtNLErGnW6iM7W9MzQf2w=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=dcw4elwKmHUJ5fi45N10VtYDDV0f5ZdbRKfJHRpvI1G0CQpmkIiefFgoSt2VhZLSq\n\tI/tRZkoiJIpdfyx6bTvkyspoCPNGW6OQy8X3G9xGBms8XwvyEABXxPGSXlDn1txwL+\n\tzzhDuuL0xBEoYpP5J7vczPCTZuIyVzyTt6vkyIBxkAxoppHtiMBiIG31XQlkhn5CR6\n\tnoEP+uz6GtrUsVID7/xbt1+DJKUwYw3ySFqqbSfsbsSOfu75n3IeVKeNgNCqz4wtAl\n\t3/+emCTmsZ00b/Cx5phiH/K2+eA5lYhfr9sKI9ThZRWAie77CojdKAFekmWLBXbG2h\n\tAIOfkPqS6JElQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=9XR6025k4SgZnE6anVDlgnkMbJdVvDycxdSRKHaaonc=;\n\tb=ROY0XvwTPqd0AviMZ9aAXXLHokilGYYchvj9eSdX7UFeLEHPJmWMpizJWYwXX1Vdc9\n\tHoLaRUGMKyXAPKOxjTAsCGhJ7B4PEFOzugK2gP5GjP/1XXya2Ju95yxUj49nMbXU06Hi\n\tYnDtxj2CEa6ma9a97CA6oYumJxrvxzGU1TaQQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"ROY0XvwT\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=9XR6025k4SgZnE6anVDlgnkMbJdVvDycxdSRKHaaonc=;\n\tb=Tlps14s3klAmA2zKuVIGQpVeRupO2LnqaIoZa4mu/Gj050JRamvRVwcaR9icV0jfBt\n\tpeLYZ4lwlAPvPVL/JtNoRcSWUnVbiWiyqkAvPm22QMjDeuoiIfrvIV3wsWhKA8UNLcvm\n\tEKnFO5b37bSRLj2MAQJp+pxnEgA8dIoRhEnrWZecg/Yg7ob8XGnwQ5d4sfW3Rx1e4SEs\n\tkJTqlnybdKQO/Bc0qbtbp8Endpc9p075ULWprlHvI8qwm3a0Vg9+HjetefkZv/dEDK7n\n\tRDgi4LR5cFd+I+Zyya/Wg+ZF5J7iGOsFkqsIyy15IL6mwXfGzfOTVFW+jN4Yk7kgd+Yh\n\td4vQ==","X-Gm-Message-State":"AOAM531fx1ZsTJs//JxXJLAVvqPUoBQYRYLWdcqmWIb2+TZlEJ5JyYt9\n\tfW1GqcuOsiVQDytb2CfxmiLNMyyLfa3vWg==","X-Google-Smtp-Source":"ABdhPJwVVaxRSxUwcGUGal0mAkTGLbVYCfkHngG56SKxenLYR38zlZ5ONNo/bk07EsIbetgQU4zM8w==","X-Received":"by 2002:a17:903:2d1:b0:156:7ceb:b56f with SMTP id\n\ts17-20020a17090302d100b001567cebb56fmr23230255plk.11.1650975259588; \n\tTue, 26 Apr 2022 05:14:19 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 26 Apr 2022 20:14:16 +0800","Message-Id":"<20220426121416.754053-1-hanlinchen@chromium.org>","X-Mailer":"git-send-email 2.36.0.rc2.479.g8af0fa9b8e-goog","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] android: camera_capabilities: Add\n\t(1600x1200) and (1280x960) resolutions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Han-Lin Chen via libcamera-devel ","Reply-To":"Han-Lin Chen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Although resolutions (1600x1200) and (1280x960) are not mandatory to be\nsupported by the Android Camera3 specification, they are commonly used\nby Android devices as viewfinder streams for 4:3 still capture.\n\nAdd them into stream resolution candidates.\n\nSigned-off-by: Han-Lin Chen \n---\n src/android/camera_capabilities.cpp | 15 +++++++++++----\n 1 file changed, 11 insertions(+), 4 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 5242055c..e0f23c87 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -31,13 +31,20 @@ namespace {\n \n /*\n * \\var camera3Resolutions\n- * \\brief The list of image resolutions defined as mandatory to be supported by\n- * the Android Camera3 specification\n+ * \\brief The list of image resolutions commonly supported by Android\n+ *\n+ * The following are defined as mandatory to be supported by the Android\n+ * Camera3 specification: (320x240), (640x480), (1280x720), (1920x1080).\n+ *\n+ * The following 4:3 resolutions are defined as optional, but commonly\n+ * supported by Android devices: (1280x960), (1600x1200).\n */\n const std::vector camera3Resolutions = {\n \t{ 320, 240 },\n \t{ 640, 480 },\n \t{ 1280, 720 },\n+\t{ 1280, 960 },\n+\t{ 1600, 1200 },\n \t{ 1920, 1080 }\n };\n \n@@ -492,8 +499,8 @@ int CameraCapabilities::initializeStreamConfigurations()\n \t/*\n \t * Build the list of supported image resolutions.\n \t *\n-\t * The resolutions listed in camera3Resolution are mandatory to be\n-\t * supported, up to the camera maximum resolution.\n+\t * The resolutions listed in camera3Resolution are to be supported,\n+\t * up to the camera maximum resolution.\n \t *\n \t * Augment the list by adding resolutions calculated from the camera\n \t * maximum one.\n","prefixes":["libcamera-devel"]}