[{"id":213,"web_url":"https://patchwork.libcamera.org/comment/213/","msgid":"<20190106162722.GI11987@bigcity.dyn.berto.se>","date":"2019-01-06T16:27:22","subject":"Re: [libcamera-devel] [PATCH 08/11] test: Rename list test to\n\tlist-cameras","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-01-06 04:33:25 +0200, Laurent Pinchart wrote:\n> The list test generates a list binary in the test directory, which\n> conflicts with the C++ std::list header of the same name. The binary\n> gets included instead of the header file, breaking compilation.\n> \n> Rename the test to avoid this.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> test/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/test/meson.build b/test/meson.build\n> index 184a7eeb5e27..638e8d51c131 100644\n> --- a/test/meson.build\n> +++ b/test/meson.build\n> @@ -3,7 +3,7 @@ subdir('libtest')\n> subdir('media_device')\n> \n> public_tests = [\n> - ['list', 'list.cpp'],\n> + ['list-cameras', 'list.cpp'],\n\nI would rename the cpp file as well to match the binary name. With this \nfixed\n\nReviewed-by: Niklas Söderlund \n\n> ]\n> \n> internal_tests = [\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0298F60B2C\n\tfor ;\n\tSun, 6 Jan 2019 17:27:23 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id v1-v6so36208054ljd.0\n\tfor ;\n\tSun, 06 Jan 2019 08:27:23 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\te14-v6sm13500540ljl.43.2019.01.06.08.27.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 06 Jan 2019 08:27:22 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=9xcryWaxWyIopjlLx/pVaTqCTDV8doNrsdhLAhLxaNI=;\n\tb=Y7LsnVfSv5C+bWxib8XYUuB8GxPFO0teo6jSOnJdwCcdxbB1yaCOXP47GU+pyWYqPU\n\tci6SEF9uVLuWPcWfRzUdjwrUC0hO3bqo7VdEQWEqvVIPVS6EZJRh5xPXLwtRcWzIcc7b\n\tYls4gbCkCjIOmMFnhnD/9jby8nQ0WTE+64VEwPa6gu+nHA415IdTz9e+tkxkMvvvRh7+\n\tpHGHGDYjQKtdcqabJrbNKZmv/3aXafOsql8az32QgUYfC6T4r8gl8+ZAuvjpqjkDvdBW\n\tS6yl3nNv4i2FMHMPqh1pUj9b4t9EkfJAnwEX2o1rDvdrhqLZNL1vSZ2nJ1bGQ0WXJSBH\n\tkMwQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=9xcryWaxWyIopjlLx/pVaTqCTDV8doNrsdhLAhLxaNI=;\n\tb=ryuaa+IHNsO0ACoPn3VHWK8jjsB1Vz9umPfgaRRtJu2p5jh8KCFi6JDtmtFAzkUzcZ\n\tDUtgsycsyeYXOX4ObUuu/xnmpAbx4PSKKHXnURL9wU4Kq+HyoWIzdEej2PP5NvVDlYx5\n\tmLKVF67fRC+6DqxtjMfZfGIfDZ9jfDjLYDaUVE5C2x3Q7QzuLzZ4eLJfvJfsZ/GTtE0d\n\tn5kLQTE+d9ffWjHprgKZppAWG3QstjHMO9QRcUGUf91yONaTP2Tl/Iii9lIaU6lZGIbq\n\tNAzF0HhKDBY1IM1uxHaTpovkJDKf5qIyw15s4vpnZg092sCzEmqAzBUlPhtlHjltF5Hl\n\t2EYg==","X-Gm-Message-State":"AJcUukfCFr7VMsR9wo0h4CB+ydSThyMN+r9e9slcBxjrw85kkZiCn/+C\n\t5Ye3xsVHJEKmEV/UNt9UUMWWug==","X-Google-Smtp-Source":"AFSGD/UjSem+OV4PRpdUge7vVCZA9WYX8LlN80e42mIrKEPzWb5G4w98569aNm8KMC4BNkPq7m2Rqg==","X-Received":"by 2002:a2e:458b:: with SMTP id\n\ts133-v6mr31700780lja.170.1546792043317; \n\tSun, 06 Jan 2019 08:27:23 -0800 (PST)","Date":"Sun, 6 Jan 2019 17:27:22 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190106162722.GI11987@bigcity.dyn.berto.se>","References":"<20190106023328.10989-1-laurent.pinchart@ideasonboard.com>\n\t<20190106023328.10989-8-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190106023328.10989-8-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 08/11] test: Rename list test to\n\tlist-cameras","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 06 Jan 2019 16:27:24 -0000"}}]