[{"id":22775,"web_url":"https://patchwork.libcamera.org/comment/22775/","msgid":"","date":"2022-04-24T23:04:29","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: Test sensor's ability\n\tto discover ancillary devices","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Yunke,\n\nThank you for the patch.\n\nOn Thu, Apr 21, 2022 at 06:53:20PM +0900, Yunke Cao via libcamera-devel wrote:\n> \n> Use vimc lens to test sensor's ability to discover ancillary lens.\n> \n> Tested with/without the recent kernel patch for vimc lens:\n> https://lore.kernel.org/linux-media/20220415023855.2568366-1-yunkec@google.com/\n> \n> Signed-off-by: Yunke Cao \n> ---\n> Changelog since v1:\n> - Dont fail test when lens is not present.\n> - Remove lens from dm.\n> - Tested on both kernels with/without the vimc lens patch.\n> \n> src/libcamera/camera_sensor.cpp | 5 +++++\n> test/camera-sensor.cpp | 12 ++++++++++++\n> 2 files changed, 17 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index eaa2da6b..fe366267 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -152,6 +152,11 @@ int CameraSensor::init()\n> \t */\n> \tif (entity_->device()->driver() == \"vimc\") {\n> \t\tinitVimcDefaultProperties();\n> +\n> +\t\tret = discoverAncillaryDevices();\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n\nI would move this after initProperties() to keep the same order as for\nregular (non-vimc) sensors.\n\n> +\n> \t\treturn initProperties();\n> \t}\n> \n> diff --git a/test/camera-sensor.cpp b/test/camera-sensor.cpp\n> index 372ee4af..d1bb639a 100644\n> --- a/test/camera-sensor.cpp\n> +++ b/test/camera-sensor.cpp\n> @@ -12,6 +12,7 @@\n> \n> #include \n> \n> +#include \"libcamera/internal/camera_lens.h\"\n> #include \"libcamera/internal/camera_sensor.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/media_device.h\"\n> @@ -57,6 +58,11 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\tlens_ = sensor_->focusLens();\n> +\t\tif (lens_) {\n> +\t\t\tcout << \"Found lens\" << endl;\n\nNitpicking, I'd write \"Found lens controller\" as we're dealing with the\nlens controller, not the lens itself.\n\n> +\t\t}\n\nNo need for curly braces around a single statement.\n\nOther than that, the patch looks good.\n\n> +\n> \t\treturn TestPass;\n> \t}\n> \n> @@ -104,6 +110,11 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\tif (lens_ && lens_->setFocusPosition(10)) {\n> +\t\t\tcerr << \"Failed to set lens focus position\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\treturn TestPass;\n> \t}\n> \n> @@ -116,6 +127,7 @@ private:\n> \tstd::unique_ptr enumerator_;\n> \tstd::shared_ptr media_;\n> \tCameraSensor *sensor_;\n> +\tCameraLens *lens_;\n> };\n> \n> TEST_REGISTER(CameraSensorTest)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2BEF4C0F1B\n\tfor ;\n\tSun, 24 Apr 2022 23:04:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5958F65644;\n\tMon, 25 Apr 2022 01:04:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C93E6563A\n\tfor ;\n\tMon, 25 Apr 2022 01:04:30 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B8AD2822;\n\tMon, 25 Apr 2022 01:04:29 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650841472;\n\tbh=nt5fQBqLfwetstKHpnlVo9+hCvYydodtvyh4gV84M14=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=1WtVoBmCGOo7G09/e8LPrgP6jHBzYLtY8ra39t2+z4Fa53J7zuqbbOF/uuX/8Onlr\n\tM0ad3LUdspf2mJNp6dUwZYmbst6wUVt9URs+ACFQ2HuaxsRknkDqxoiIVrc/B8wxAG\n\t6kAsjiFBLSu60udWaiL5L17aoexsihq6nkfkTW34IcQhM7bJX5C7GLOF5tnuZNjm7/\n\tHTsbvfCvMvcjPzKSnaclIBaFVt/NvDyXXSiyFZOySeY/U/QjvuzYPVy9MxsSM7YtTO\n\thSApukit+uqMPNP6fakVG2upReaqcq2DQRHVNI1ANZcLOc/0jo7aZ7D/0jkcPQCXLD\n\tNqM6P6wHju+MQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1650841469;\n\tbh=nt5fQBqLfwetstKHpnlVo9+hCvYydodtvyh4gV84M14=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qQXNOH40OnTIOTcgPgCJS7uN4jmSNRbn6H03RwMdjOAQ5xmtEzS3BXJyUwLFeBZIA\n\tCs6dmzStV+4gnf71VDbL0BK2FEO+fG8Zo+FVgUGkrW0Pk7dRRnBPpQ3Vw6HmXjCo2b\n\t+pWroJDfMs6sw6dcRSx5nPR4O8t++Krtf6WkmmbY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"qQXNOH40\"; dkim-atps=neutral","Date":"Mon, 25 Apr 2022 02:04:29 +0300","To":"Yunke Cao ","Message-ID":"","References":"<165052542462.3002092.9959330002688816513@Monstersaurus>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: Test sensor's ability\n\tto discover ancillary devices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Tomasz Figa , libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22780,"web_url":"https://patchwork.libcamera.org/comment/22780/","msgid":"<368ddf73-1e8e-2009-2cd2-a85aae4a6a6e@ideasonboard.com>","date":"2022-04-25T09:07:58","subject":"Re: [libcamera-devel] [PATCH v3] libcamera: Test sensor's ability\n\tto discover ancillary devices","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Yunke,\n\nOn 25/04/2022 04:00, Yunke Cao wrote:\n> Use vimc lens to test sensor's ability to discover ancillary lens.\n> \n> Tested with the recent kernel patch for vimc lens:\n> https://lore.kernel.org/linux-media/20220415023855.2568366-1-yunkec@google.com/\n> \n> Signed-off-by: Yunke Cao \n> ---\n> Changelog since v2:\n> - Flip the order of initProperties and discoverAncillaryDevices.\n> - Fix log string.\n> \n> Changelog since v1:\n> - Dont fail test when lens is not present.\n> - Remove lens from dm.\n> - Tested on both kernels with/without the vimc lens patch.\n> \n> src/libcamera/camera_sensor.cpp | 7 ++++++-\n> test/camera-sensor.cpp | 12 ++++++++++++\n> 2 files changed, 18 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index eaa2da6b..c56b8a60 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -152,7 +152,12 @@ int CameraSensor::init()\n> \t */\n> \tif (entity_->device()->driver() == \"vimc\") {\n> \t\tinitVimcDefaultProperties();\n> -\t\treturn initProperties();\n> +\n> +\t\tret = initProperties();\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n> +\n> +\t\treturn discoverAncillaryDevices();\n> \t}\n> \n> \t/* Get the color filter array pattern (only for RAW sensors). */\n> diff --git a/test/camera-sensor.cpp b/test/camera-sensor.cpp\n> index 372ee4af..4473ca19 100644\n> --- a/test/camera-sensor.cpp\n> +++ b/test/camera-sensor.cpp\n> @@ -12,6 +12,7 @@\n> \n> #include \n> \n> +#include \"libcamera/internal/camera_lens.h\"\n> #include \"libcamera/internal/camera_sensor.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/media_device.h\"\n> @@ -57,6 +58,11 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\tlens_ = sensor_->focusLens();\n> +\t\tif (lens_) {\n> +\t\t\tcout << \"Found lens controller\" << endl;\n> +\t\t}\n\nStill don't need the curly braces, but they don't break the code so:\n\nReviewed-by: Kieran Bingham \n\nAnd I'll let Laurent decide if he removes them while applying.\n\n\n> +\n> \t\treturn TestPass;\n> \t}\n> \n> @@ -104,6 +110,11 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\tif (lens_ && lens_->setFocusPosition(10)) {\n> +\t\t\tcerr << \"Failed to set lens focus position\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\treturn TestPass;\n> \t}\n> \n> @@ -116,6 +127,7 @@ private:\n> \tstd::unique_ptr enumerator_;\n> \tstd::shared_ptr media_;\n> \tCameraSensor *sensor_;\n> +\tCameraLens *lens_;\n> };\n> \n> TEST_REGISTER(CameraSensorTest)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 791C6C3256\n\tfor ;\n\tMon, 25 Apr 2022 09:07:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D4BAD65644;\n\tMon, 25 Apr 2022 11:07:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 89C3665640\n\tfor ;\n\tMon, 25 Apr 2022 11:07:50 +0200 (CEST)","from [192.168.0.103] (unknown [178.237.134.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6CBB230B;\n\tMon, 25 Apr 2022 11:07:49 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650877672;\n\tbh=vDy5f/OpUeeRqcwH2NxvXqoy3OGd9yt+MogKGB+sMPI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=zW/wOBOLySiRpCJ+//axSaWD2+2RiO85k9s0tvV87huDYnntbQgBc1KQ+uPLsGMLO\n\tNV3Nb/IrbexVSA4mCGooH8h8TTIyrnN7Kcr56J43h8IoG2wQBoPg5OjF719D4d3VeH\n\tS7jpRAZJ6u3yDQvBF5D88W17hPwV05sa4B/GXV2u6DgJ2D4REk3OW76xk3T57DcEpA\n\twQ4fPGao745rjA8lOAapoKOWIR4DUOy1nXfqcWdHo/CGG2OAM4sWlVAMeQQKcDxYJV\n\t7yHlG+vBjlbcQ9aOpqvbLU92LySZj8lIX1MXITYMea7YHmwui/h+gvnz6brw1XFE21\n\t66ijLRa7rDMOw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1650877669;\n\tbh=vDy5f/OpUeeRqcwH2NxvXqoy3OGd9yt+MogKGB+sMPI=;\n\th=Date:From:Subject:To:Cc:References:In-Reply-To:From;\n\tb=vMMVIggXQU/ZdLOReRp293wOwglPKB+ioCdJT/DbhgB5L4HZrio41S2TdUSXPsGWv\n\teko0HiwftDsHkKOvHwzHlb/k8xu8OgPIGoQLX7HlbxQ2B8iEcNX/jWlvQ8NP8P7Oye\n\tKs+QyzEU9LN/W8ZH13b207ECSBnqRfqOKj0crnfM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vMMVIggX\"; dkim-atps=neutral","Message-ID":"<368ddf73-1e8e-2009-2cd2-a85aae4a6a6e@ideasonboard.com>","Date":"Mon, 25 Apr 2022 11:07:58 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.7.0","Content-Language":"en-GB","To":"Yunke Cao ,\n\tLaurent Pinchart ","References":"\n\t<20220425020011.3623514-1-yunkec@google.com>","In-Reply-To":"<20220425020011.3623514-1-yunkec@google.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3] libcamera: Test sensor's ability\n\tto discover ancillary devices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Tomasz Figa , libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22784,"web_url":"https://patchwork.libcamera.org/comment/22784/","msgid":"<165089668262.3204481.628234005550777241@Monstersaurus>","date":"2022-04-25T14:24:42","subject":"Re: [libcamera-devel] [PATCH v4] libcamera: Test sensor's ability\n\tto discover ancillary devices","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Yunke Cao (2022-04-25 10:27:10)\n> Use vimc lens to test sensor's ability to discover ancillary lens.\n> \n> Tested with the recent kernel patch for vimc lens:\n> https://lore.kernel.org/linux-media/20220415023855.2568366-1-yunkec@google.com/\n> \n> Signed-off-by: Yunke Cao \n\nYou can collect RB tags here when they are given to you for new versions\ntoo.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> Changelog since v3:\n> - Remove unnecessary brace. Sorry! Kept forgetting this.\n> \n> Changelog since v2:\n> - Flip the order of initProperties and discoverAncillaryDevices.\n> - Fix log string.\n> \n> Changelog since v1:\n> - Dont fail test when lens is not present.\n> - Remove lens from dm.\n> - Tested on both kernels with/without the vimc lens patch.\n> \n> src/libcamera/camera_sensor.cpp | 7 ++++++-\n> test/camera-sensor.cpp | 11 +++++++++++\n> 2 files changed, 17 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index eaa2da6b..c56b8a60 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -152,7 +152,12 @@ int CameraSensor::init()\n> */\n> if (entity_->device()->driver() == \"vimc\") {\n> initVimcDefaultProperties();\n> - return initProperties();\n> +\n> + ret = initProperties();\n> + if (ret)\n> + return ret;\n> +\n> + return discoverAncillaryDevices();\n> }\n> \n> /* Get the color filter array pattern (only for RAW sensors). */\n> diff --git a/test/camera-sensor.cpp b/test/camera-sensor.cpp\n> index 372ee4af..dc99ab33 100644\n> --- a/test/camera-sensor.cpp\n> +++ b/test/camera-sensor.cpp\n> @@ -12,6 +12,7 @@\n> \n> #include \n> \n> +#include \"libcamera/internal/camera_lens.h\"\n> #include \"libcamera/internal/camera_sensor.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/media_device.h\"\n> @@ -57,6 +58,10 @@ protected:\n> return TestFail;\n> }\n> \n> + lens_ = sensor_->focusLens();\n> + if (lens_)\n> + cout << \"Found lens controller\" << endl;\n> +\n> return TestPass;\n> }\n> \n> @@ -104,6 +109,11 @@ protected:\n> return TestFail;\n> }\n> \n> + if (lens_ && lens_->setFocusPosition(10)) {\n> + cerr << \"Failed to set lens focus position\" << endl;\n> + return TestFail;\n> + }\n> +\n> return TestPass;\n> }\n> \n> @@ -116,6 +126,7 @@ private:\n> std::unique_ptr enumerator_;\n> std::shared_ptr media_;\n> CameraSensor *sensor_;\n> + CameraLens *lens_;\n> };\n> \n> TEST_REGISTER(CameraSensorTest)\n> -- \n> 2.36.0.rc2.479.g8af0fa9b8e-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E817C0F1B\n\tfor ;\n\tMon, 25 Apr 2022 14:24:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 84A4B604A9;\n\tMon, 25 Apr 2022 16:24:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC6AA6042F\n\tfor ;\n\tMon, 25 Apr 2022 16:24:46 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF80330B;\n\tMon, 25 Apr 2022 16:24:44 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650896688;\n\tbh=E9bb+uVS+lyGZU0hrWoULJ2H+P0ocGDRv6RGnGBWVsU=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=KnUbj6dQNZtmIg5oGNnAqpRoyN7DNlllDe6Lr9qk92LlDY91z/5cJI61n2e0LLm2V\n\tbkcBcoTJDuhElqCfT26Uau/KUM3l04ti/ahkbgRpJybsKfBKdUNYeuFHlOSkiFitp/\n\tun+fzpQ7PeslFAYcoH7gyNtQ3C3I0JL1OZzz6T43YVbXbra3v2FIH5ZpyWDw3Py7oP\n\tA0qtHqtlwfRkDnnyj7oxAOqGQ/q6CiCB0XeTCFrpbnoUaFAmqtzDKK9gUW2aIwkI7W\n\tMMbxZd7nMrWbOjVkRvmbhhVTdBXuVHVpZTSjRCQODefCIm3RFWIIzh7ach4IVa/Ehi\n\trNzMtIht65OyA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1650896685;\n\tbh=E9bb+uVS+lyGZU0hrWoULJ2H+P0ocGDRv6RGnGBWVsU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=eXX4XMJ+PaXSie6j7I+qYPyn2R+8iKq9qvYkUJqxvOTNe4TgmNczpVyBd7BRitOCt\n\tq+OYc10EDnRwb4wf5U1ErXBCAjFGpJzwLd7xlQE6+p1lJJ/OXP+ZHCZF/ag/F1xpDw\n\teFQ2CVDsK0E1EXgM9TrogzXT7SM4QD3gipQQELfY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"eXX4XMJ+\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220425092710.213699-1-yunkec@google.com>","References":"<368ddf73-1e8e-2009-2cd2-a85aae4a6a6e@ideasonboard.com>\n\t<20220425092710.213699-1-yunkec@google.com>","To":"Laurent Pinchart ,\n\tYunke Cao ","Date":"Mon, 25 Apr 2022 15:24:42 +0100","Message-ID":"<165089668262.3204481.628234005550777241@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v4] libcamera: Test sensor's ability\n\tto discover ancillary devices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Tomasz Figa , libcamera-devel@lists.libcamera.org,\n\tYunke Cao ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25776,"web_url":"https://patchwork.libcamera.org/comment/25776/","msgid":"<166818545680.50677.10741735743184676565@Monstersaurus>","date":"2022-11-11T16:50:56","subject":"Re: [libcamera-devel] [PATCH v4] libcamera: Test sensor's ability\n\tto discover ancillary devices","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2022-04-25 15:24:42)\n> Quoting Yunke Cao (2022-04-25 10:27:10)\n> > Use vimc lens to test sensor's ability to discover ancillary lens.\n> > \n> > Tested with the recent kernel patch for vimc lens:\n> > https://lore.kernel.org/linux-media/20220415023855.2568366-1-yunkec@google.com/\n> > \n> > Signed-off-by: Yunke Cao \n> \n> You can collect RB tags here when they are given to you for new versions\n> too.\n> \n> Reviewed-by: Kieran Bingham \n\nArgh, and because this was posted as a reply to the original - the tags\ndidn't propogate to the correct version in patchwork either. This has\nresulted in it slipping through without being applied while it already\ncould have.\n\nI'll try to apply / collect this now.\n--\nKieran\n\n\n\n> \n> > ---\n> > Changelog since v3:\n> > - Remove unnecessary brace. Sorry! Kept forgetting this.\n> > \n> > Changelog since v2:\n> > - Flip the order of initProperties and discoverAncillaryDevices.\n> > - Fix log string.\n> > \n> > Changelog since v1:\n> > - Dont fail test when lens is not present.\n> > - Remove lens from dm.\n> > - Tested on both kernels with/without the vimc lens patch.\n> > \n> > src/libcamera/camera_sensor.cpp | 7 ++++++-\n> > test/camera-sensor.cpp | 11 +++++++++++\n> > 2 files changed, 17 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > index eaa2da6b..c56b8a60 100644\n> > --- a/src/libcamera/camera_sensor.cpp\n> > +++ b/src/libcamera/camera_sensor.cpp\n> > @@ -152,7 +152,12 @@ int CameraSensor::init()\n> > */\n> > if (entity_->device()->driver() == \"vimc\") {\n> > initVimcDefaultProperties();\n> > - return initProperties();\n> > +\n> > + ret = initProperties();\n> > + if (ret)\n> > + return ret;\n> > +\n> > + return discoverAncillaryDevices();\n> > }\n> > \n> > /* Get the color filter array pattern (only for RAW sensors). */\n> > diff --git a/test/camera-sensor.cpp b/test/camera-sensor.cpp\n> > index 372ee4af..dc99ab33 100644\n> > --- a/test/camera-sensor.cpp\n> > +++ b/test/camera-sensor.cpp\n> > @@ -12,6 +12,7 @@\n> > \n> > #include \n> > \n> > +#include \"libcamera/internal/camera_lens.h\"\n> > #include \"libcamera/internal/camera_sensor.h\"\n> > #include \"libcamera/internal/device_enumerator.h\"\n> > #include \"libcamera/internal/media_device.h\"\n> > @@ -57,6 +58,10 @@ protected:\n> > return TestFail;\n> > }\n> > \n> > + lens_ = sensor_->focusLens();\n> > + if (lens_)\n> > + cout << \"Found lens controller\" << endl;\n> > +\n> > return TestPass;\n> > }\n> > \n> > @@ -104,6 +109,11 @@ protected:\n> > return TestFail;\n> > }\n> > \n> > + if (lens_ && lens_->setFocusPosition(10)) {\n> > + cerr << \"Failed to set lens focus position\" << endl;\n> > + return TestFail;\n> > + }\n> > +\n> > return TestPass;\n> > }\n> > \n> > @@ -116,6 +126,7 @@ private:\n> > std::unique_ptr enumerator_;\n> > std::shared_ptr media_;\n> > CameraSensor *sensor_;\n> > + CameraLens *lens_;\n> > };\n> > \n> > TEST_REGISTER(CameraSensorTest)\n> > -- \n> > 2.36.0.rc2.479.g8af0fa9b8e-goog\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CD6FBE08B\n\tfor ;\n\tFri, 11 Nov 2022 16:51:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C4326307E;\n\tFri, 11 Nov 2022 17:51:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FA3561F3D\n\tfor ;\n\tFri, 11 Nov 2022 17:50:59 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B72CC32A;\n\tFri, 11 Nov 2022 17:50:58 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668185461;\n\tbh=49adOgxEADYVs4U5M33oK2Oimg90HHCyZ/9EqYYBejc=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=uDr3h6GBCPF2lVvC+i/Mu4k1jAtKRMLXqF/kJWuMLByaBpwln1Y4Fdmjqfs9GOs+E\n\tznNKBqGG5Uv1htAoAhsWnU8JG6gaJBqnXAqIqXBertwr6Jxv6Ye7ESTSD/UquiGnCm\n\tILDJezggtDXuBhibm6jdPtBQjNRetCOkvX6C75h8LIJYvPAL6rY5uIKmqRRdSUHPZk\n\tdsfDxNYESUTvGfe4/+tLy/N1TXfDNENnev4NnmDh0JycFuv+QTP/udSbtWhUL2UQ4A\n\tz2UsRgkrs/1462Etbz7Zdna1df29MoDE2hB5LbSMAXZxLlQbGPhiGtoouls770Nsgc\n\tZ86UQTc/bN3QA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1668185458;\n\tbh=49adOgxEADYVs4U5M33oK2Oimg90HHCyZ/9EqYYBejc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=aEssBB/yo2j/qZVGTBq8zrkRfYazQGU+flbw3Ry9silfnJznEUA0nSExXWiB0Tmqa\n\ts0hgk69GSv6pwlOoHXdOefJx1LgTdF2iMArRiN1mcNfC4gzmcPg2xECnLcGp0GslIU\n\tggr30sd0ke8/a3kRAP1hO23E3cF7ai02xVv652gk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"aEssBB/y\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<165089668262.3204481.628234005550777241@Monstersaurus>","References":"<368ddf73-1e8e-2009-2cd2-a85aae4a6a6e@ideasonboard.com>\n\t<20220425092710.213699-1-yunkec@google.com>\n\t<165089668262.3204481.628234005550777241@Monstersaurus>","To":"Laurent Pinchart ,\n\tYunke Cao ","Date":"Fri, 11 Nov 2022 16:50:56 +0000","Message-ID":"<166818545680.50677.10741735743184676565@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v4] libcamera: Test sensor's ability\n\tto discover ancillary devices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Tomasz Figa , libcamera-devel@lists.libcamera.org,\n\tYunke Cao ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25792,"web_url":"https://patchwork.libcamera.org/comment/25792/","msgid":"","date":"2022-11-14T16:59:58","subject":"Re: [libcamera-devel] [PATCH v4] libcamera: Test sensor's ability\n\tto discover ancillary devices","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Nov 11, 2022 at 04:50:56PM +0000, Kieran Bingham wrote:\n> Quoting Kieran Bingham (2022-04-25 15:24:42)\n> > Quoting Yunke Cao (2022-04-25 10:27:10)\n> > > Use vimc lens to test sensor's ability to discover ancillary lens.\n> > > \n> > > Tested with the recent kernel patch for vimc lens:\n> > > https://lore.kernel.org/linux-media/20220415023855.2568366-1-yunkec@google.com/\n> > > \n> > > Signed-off-by: Yunke Cao \n> > \n> > You can collect RB tags here when they are given to you for new versions\n> > too.\n> > \n> > Reviewed-by: Kieran Bingham \n> \n> Argh, and because this was posted as a reply to the original - the tags\n> didn't propogate to the correct version in patchwork either. This has\n> resulted in it slipping through without being applied while it already\n> could have.\n> \n> I'll try to apply / collect this now.\n\nIf it can help,\n\nReviewed-by: Laurent Pinchart \n\n> > > ---\n> > > Changelog since v3:\n> > > - Remove unnecessary brace. Sorry! Kept forgetting this.\n> > > \n> > > Changelog since v2:\n> > > - Flip the order of initProperties and discoverAncillaryDevices.\n> > > - Fix log string.\n> > > \n> > > Changelog since v1:\n> > > - Dont fail test when lens is not present.\n> > > - Remove lens from dm.\n> > > - Tested on both kernels with/without the vimc lens patch.\n> > > \n> > > src/libcamera/camera_sensor.cpp | 7 ++++++-\n> > > test/camera-sensor.cpp | 11 +++++++++++\n> > > 2 files changed, 17 insertions(+), 1 deletion(-)\n> > > \n> > > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > > index eaa2da6b..c56b8a60 100644\n> > > --- a/src/libcamera/camera_sensor.cpp\n> > > +++ b/src/libcamera/camera_sensor.cpp\n> > > @@ -152,7 +152,12 @@ int CameraSensor::init()\n> > > */\n> > > if (entity_->device()->driver() == \"vimc\") {\n> > > initVimcDefaultProperties();\n> > > - return initProperties();\n> > > +\n> > > + ret = initProperties();\n> > > + if (ret)\n> > > + return ret;\n> > > +\n> > > + return discoverAncillaryDevices();\n> > > }\n> > > \n> > > /* Get the color filter array pattern (only for RAW sensors). */\n> > > diff --git a/test/camera-sensor.cpp b/test/camera-sensor.cpp\n> > > index 372ee4af..dc99ab33 100644\n> > > --- a/test/camera-sensor.cpp\n> > > +++ b/test/camera-sensor.cpp\n> > > @@ -12,6 +12,7 @@\n> > > \n> > > #include \n> > > \n> > > +#include \"libcamera/internal/camera_lens.h\"\n> > > #include \"libcamera/internal/camera_sensor.h\"\n> > > #include \"libcamera/internal/device_enumerator.h\"\n> > > #include \"libcamera/internal/media_device.h\"\n> > > @@ -57,6 +58,10 @@ protected:\n> > > return TestFail;\n> > > }\n> > > \n> > > + lens_ = sensor_->focusLens();\n> > > + if (lens_)\n> > > + cout << \"Found lens controller\" << endl;\n> > > +\n> > > return TestPass;\n> > > }\n> > > \n> > > @@ -104,6 +109,11 @@ protected:\n> > > return TestFail;\n> > > }\n> > > \n> > > + if (lens_ && lens_->setFocusPosition(10)) {\n> > > + cerr << \"Failed to set lens focus position\" << endl;\n> > > + return TestFail;\n> > > + }\n> > > +\n> > > return TestPass;\n> > > }\n> > > \n> > > @@ -116,6 +126,7 @@ private:\n> > > std::unique_ptr enumerator_;\n> > > std::shared_ptr media_;\n> > > CameraSensor *sensor_;\n> > > + CameraLens *lens_;\n> > > };\n> > > \n> > > TEST_REGISTER(CameraSensorTest)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A86C2BD16B\n\tfor ;\n\tMon, 14 Nov 2022 17:00:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EB3CC63089;\n\tMon, 14 Nov 2022 18:00:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5CB5361F3B\n\tfor ;\n\tMon, 14 Nov 2022 18:00:21 +0100 (CET)","from pendragon.ideasonboard.com (unknown [46.183.103.8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B166891;\n\tMon, 14 Nov 2022 18:00:20 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668445222;\n\tbh=dsjCzKyf0hcbYtkybGvRzIulcM9wO+kmj0fpKZncUAE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=RMhKUPkYYKauIVANqGWsobyAtDYazIcWAwFpzKpz9z/0X8Qvtgq4CiAKKmsr4tj2g\n\tMK7FDowNUw97l4YcoFlkJE1AxJ3O8WmrIwB9ZU3YS4Y99bEJGMVj9f3MH2KTeOwy4E\n\t2EQrSCQ/ez3hxhNkIJiTPCUBmyP0fkQzQRCjkYZhiPe8sQI9w7MY04qzkuPZahj2hJ\n\t2LaCvJyy9QdP2BM/pMMYrzUCoXekLSrfNY/Xs/704+duc0TpzsPzGO64Ljvrf/HrlG\n\tp7bg0hTOYDIP6mQcWSs+y2jSA9rP8NI//8XVuS9UY6l1sBxrB8yp/dTKOz8ApSttyQ\n\tGbrqTFXi+zniQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1668445220;\n\tbh=dsjCzKyf0hcbYtkybGvRzIulcM9wO+kmj0fpKZncUAE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XJlGnYCxvMypx6YTcKVmwDKOCQ/lzPhES3Y6P3EcKoxPJxXwykUfksMRbA+XqgZPJ\n\t2huXmi1CFb/ivGWFqla3wPPcsO7GtTo8j/D5uOtkeFVluQxxnPJoeLVcmYi6R2cPJi\n\tL8568OUNhZY1NrtJBEqsJwCUQ845cqabz7tUUESc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XJlGnYCx\"; dkim-atps=neutral","Date":"Mon, 14 Nov 2022 18:59:58 +0200","To":"Kieran Bingham ","Message-ID":"","References":"<368ddf73-1e8e-2009-2cd2-a85aae4a6a6e@ideasonboard.com>\n\t<20220425092710.213699-1-yunkec@google.com>\n\t<165089668262.3204481.628234005550777241@Monstersaurus>\n\t<166818545680.50677.10741735743184676565@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166818545680.50677.10741735743184676565@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v4] libcamera: Test sensor's ability\n\tto discover ancillary devices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Tomasz Figa , libcamera-devel@lists.libcamera.org,\n\tYunke Cao ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]