[{"id":2111,"web_url":"https://patchwork.libcamera.org/comment/2111/","msgid":"<20190702002545.GL9228@bigcity.dyn.berto.se>","date":"2019-07-02T00:25:45","subject":"Re: [libcamera-devel] [PATCH v4 10/13] libcamera: test: Add\n\tControlValue test","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your patch.\n\nOn 2019-07-01 23:15:01 +0300, Laurent Pinchart wrote:\n> From: Kieran Bingham \n> \n> Add initial basic testing for the new ControlValue class.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> test/controls/control_value.cpp | 69 +++++++++++++++++++++++++++++++++\n> test/controls/meson.build | 11 ++++++\n> test/meson.build | 1 +\n> 3 files changed, 81 insertions(+)\n> create mode 100644 test/controls/control_value.cpp\n> create mode 100644 test/controls/meson.build\n> \n> diff --git a/test/controls/control_value.cpp b/test/controls/control_value.cpp\n> new file mode 100644\n> index 000000000000..778efe5c115f\n> --- /dev/null\n> +++ b/test/controls/control_value.cpp\n> @@ -0,0 +1,69 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2019, Google Inc.\n> + *\n> + * control_value.cpp - ControlValue tests\n> + */\n> +\n> +#include \n> +\n> +#include \n> +\n> +#include \"test.h\"\n> +\n> +using namespace std;\n> +using namespace libcamera;\n> +\n> +class ControlValueTest : public Test\n> +{\n> +protected:\n> +\tint run()\n> +\t{\n> +\t\tControlValue integer(1234);\n> +\t\tControlValue boolean(true);\n> +\n> +\t\t/* Just a string conversion output test... no validation */\n> +\t\tcout << \"Int: \" << integer.toString()\n> +\t\t << \" Bool: \" << boolean.toString()\n> +\t\t << endl;\n> +\n> +\t\tif (integer.getInt() != 1234) {\n> +\t\t\tcerr << \"Failed to get Integer\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (boolean.getBool() != true) {\n> +\t\t\tcerr << \"Failed to get Boolean\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\t/* Test an uninitialised value, and updating it. */\n> +\n> +\t\tControlValue value;\n> +\t\tif (!value.isNone()) {\n> +\t\t\tcerr << \"Empty value is non-null\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tvalue.set(true);\n> +\t\tif (value.isNone()) {\n> +\t\t\tcerr << \"Failed to set an empty object\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (value.getBool() != true) {\n> +\t\t\tcerr << \"Failed to get Booleans\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tvalue.set(10);\n> +\t\tif (value.getInt() != 10) {\n> +\t\t\tcerr << \"Failed to get Integer\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\treturn TestPass;\n> +\t}\n> +};\n> +\n> +TEST_REGISTER(ControlValueTest)\n> diff --git a/test/controls/meson.build b/test/controls/meson.build\n> new file mode 100644\n> index 000000000000..1161864d9949\n> --- /dev/null\n> +++ b/test/controls/meson.build\n> @@ -0,0 +1,11 @@\n> +control_tests = [\n> + [ 'control_value', 'control_value.cpp' ],\n> +]\n> +\n> +foreach t : control_tests\n> + exe = executable(t[0], t[1],\n> + dependencies : libcamera_dep,\n> + link_with : test_libraries,\n> + include_directories : test_includes_internal)\n> + test(t[0], exe, suite : 'controls', is_parallel : false)\n> +endforeach\n> diff --git a/test/meson.build b/test/meson.build\n> index c36ac2479636..fea2485cbb34 100644\n> --- a/test/meson.build\n> +++ b/test/meson.build\n> @@ -1,6 +1,7 @@\n> subdir('libtest')\n> \n> subdir('camera')\n> +subdir('controls')\n> subdir('ipa')\n> subdir('media_device')\n> subdir('pipeline')\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 144AA60C2B\n\tfor ;\n\tTue, 2 Jul 2019 02:25:47 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id k18so15031757ljc.11\n\tfor ;\n\tMon, 01 Jul 2019 17:25:47 -0700 (PDT)","from localhost (customer-145-14-112-32.stosn.net. [145.14.112.32])\n\tby smtp.gmail.com with ESMTPSA id\n\tz12sm2748714lfe.2.2019.07.01.17.25.45\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 01 Jul 2019 17:25:46 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=dEN/1NzLfvYEwWPPEQE3wzMf7kFsduJ+aG9si14XtTM=;\n\tb=FWddfblKPi/Awn1KUCmVo+EI+Mux2beoI22eMgpM0xH2Nwafhr+STjYNdMm3stX6NQ\n\tgJcTHyQMD03RMm/3WFrBKMk4FYkrtl9jGsVvoQU7MoNzPcWmGwdvaikY5jgeYWc/BCyu\n\tOL/oj+oLNiK+kmVIn9YeuN+fs6jfIRSKNRmlIjOG+g9MmdqfcHRKJO7RJgBIZbLPXeav\n\tlzOZ2FEArsk59vOH/Ml1H7YtBCQqaPp57g7dc6XQMvsUgS2ZnTyaW/+7DJlgSz2kQDb+\n\tfrUcIgQ9AVHJm1EicxM3kdeu79EW7HkTD8hwd2Gd6FFfjISez8LQ7hDSWBWgTD2G2Eja\n\t3ezg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=dEN/1NzLfvYEwWPPEQE3wzMf7kFsduJ+aG9si14XtTM=;\n\tb=DCmYQ/ndAyBoNVQna1LmtV/cxrXhVTShKjp+ZMaACtyjEcKq5g0YwQwSganDXObZA1\n\tvECAqH8GPwChu0ewnfoMY+irRilomu0YPTdi/823a6lr+tlXBl7NdHmz+zLBH1iHUm2F\n\ta4W5ZkIrwpE6Z1fvLwj7qRUpOFZncIXfItcKd2tFmXIDW9rVQbTIEYQfp8ESZvlPHfTL\n\tuG1Lv3A8UhZrm0TYERHmD7qoVgCA62K03CzPhEw73kSuSEs/GPBcebMN55G2xnsYxg7v\n\t9YwtuJQgJW8mUfNiUa1sNr2rKiShf0CQdBpYXgVTWJ7CeVNf8QJsuAaYRjvPX+YbmK9P\n\tnjjA==","X-Gm-Message-State":"APjAAAW19AS0B2n9eUducxbhFH0hLRYqFqlsxQK6HFuEJMTNxjHE/4Nf\n\tHR1DnPxGY2+RFj+rMB1HQC5QSZoA7W0=","X-Google-Smtp-Source":"APXvYqw5k/UZd1sijkG5iLRoPWxcEdkAgCnwvbfdFXO09nKci6m3mjdY4YXXHnqey+Q5FCTUg18Y9Q==","X-Received":"by 2002:a2e:8559:: with SMTP id\n\tu25mr15573158ljj.224.1562027146595; \n\tMon, 01 Jul 2019 17:25:46 -0700 (PDT)","Date":"Tue, 2 Jul 2019 02:25:45 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190702002545.GL9228@bigcity.dyn.berto.se>","References":"<20190701201504.28487-1-laurent.pinchart@ideasonboard.com>\n\t<20190701201504.28487-11-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190701201504.28487-11-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v4 10/13] libcamera: test: Add\n\tControlValue test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Jul 2019 00:25:47 -0000"}}]