[{"id":22736,"web_url":"https://patchwork.libcamera.org/comment/22736/","msgid":"<Yl602Q/YdAE3W2xS@pendragon.ideasonboard.com>","date":"2022-04-19T13:10:49","subject":"Re: [libcamera-devel] [PATCH v3 2/2] libcamera: correct the string\n\trepresentation of Rectangle","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Han-Lin,\n\nOn Tue, Apr 19, 2022 at 08:42:20PM +0800, Han-Lin Chen via libcamera-devel wrote:\n> Change the string representation of class Rectangle from\n> \"(top x left)/width x height\" to \"(top, left)/width x height\".\n\nGood catch !\n\n> Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org>\n> ---\n>  src/libcamera/geometry.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index da08045e..e00333cf 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -841,7 +841,7 @@ bool operator==(const Rectangle &lhs, const Rectangle &rhs)\n>   */\n>  std::ostream &operator<<(std::ostream &out, const Rectangle &r)\n>  {\n> -\tout << \"(\" << r.x << \"x\" << r.y << \")/\" << r.width << \"x\" << r.height;\n> +\tout << \"(\" << r.x << \", \" << r.y << \")/\" << r.width << \"x\" << r.height;\n\nI'd remove the space after the comma. With that,\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nI can fix when applying.\n\n>  \treturn out;\n>  }\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B5A5C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Apr 2022 13:10:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 740C865642;\n\tTue, 19 Apr 2022 15:10:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE8316563C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Apr 2022 15:10:46 +0200 (CEST)","from pendragon.ideasonboard.com (smb-adp01.hotspot.hub-one.net\n\t[94.199.126.50])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F37D25B;\n\tTue, 19 Apr 2022 15:10:46 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650373847;\n\tbh=8IjoW209MRTsTtIhJ/6JnL7vPh5TIwJ4VvVl00Ry4Uo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ppL/sDKuuNQAcgxyOS/O6t0w4LVMDpOGc5noiCB47uYLAoMPaVrnn7R7WZItY4izm\n\ttJWX/af9zvEK2zxGFwb4u0WtbXymiYtJxgJt6eSB4mPqXRqjtr/66npSbyYoAGQMpN\n\tJvTrhpG0oF5nKP8hkWEhCgUKoTagOpCyPLPu6G2w/f93iOGdZFTXAc6K+NP0hGXOCi\n\t1aDMbldwHoflgf9vFqR8Vn50tlam9KdgLAs2LHiOd39IYmgEh/vJ4VuKjYcfuzDGlG\n\t1rWinjejZnxtzNghAEqUfxSl4SrtGisK7Qla6MsjKR7JdPpx4S6NSrwDegl8yICh0I\n\tfGnvw8OrTgdSQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1650373846;\n\tbh=8IjoW209MRTsTtIhJ/6JnL7vPh5TIwJ4VvVl00Ry4Uo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Y3lA6slR3VX5Ej0YcfrCoKikaaVqFrLubLgA6m9BcXm6yz9VGgborFmMCEL22heN/\n\tBC3DovSIbCqyR0mHVZ4ZzUZ+1mw6wNTQ1ee8u6tIUcliOY3Mm5PBjimvIKu95otSWO\n\t8T1RCKaqIQAF3bvxmeh8DhGzFgBKDeF+Ypz0tats="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Y3lA6slR\"; dkim-atps=neutral","Date":"Tue, 19 Apr 2022 16:10:49 +0300","To":"Han-Lin Chen <hanlinchen@chromium.org>","Message-ID":"<Yl602Q/YdAE3W2xS@pendragon.ideasonboard.com>","References":"<20220419124220.1877877-1-hanlinchen@chromium.org>\n\t<20220419124220.1877877-2-hanlinchen@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220419124220.1877877-2-hanlinchen@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v3 2/2] libcamera: correct the string\n\trepresentation of Rectangle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":22737,"web_url":"https://patchwork.libcamera.org/comment/22737/","msgid":"<Yl61WD9l4/RGKyXJ@pendragon.ideasonboard.com>","date":"2022-04-19T13:12:56","subject":"Re: [libcamera-devel] [PATCH v3 2/2] libcamera: correct the string\n\trepresentation of Rectangle","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Apr 19, 2022 at 04:10:49PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Hi Han-Lin,\n> \n> On Tue, Apr 19, 2022 at 08:42:20PM +0800, Han-Lin Chen via libcamera-devel wrote:\n> > Change the string representation of class Rectangle from\n> > \"(top x left)/width x height\" to \"(top, left)/width x height\".\n> \n> Good catch !\n> \n> > Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org>\n> > ---\n> >  src/libcamera/geometry.cpp | 2 +-\n> >  1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> > index da08045e..e00333cf 100644\n> > --- a/src/libcamera/geometry.cpp\n> > +++ b/src/libcamera/geometry.cpp\n> > @@ -841,7 +841,7 @@ bool operator==(const Rectangle &lhs, const Rectangle &rhs)\n> >   */\n> >  std::ostream &operator<<(std::ostream &out, const Rectangle &r)\n> >  {\n> > -\tout << \"(\" << r.x << \"x\" << r.y << \")/\" << r.width << \"x\" << r.height;\n> > +\tout << \"(\" << r.x << \", \" << r.y << \")/\" << r.width << \"x\" << r.height;\n> \n> I'd remove the space after the comma. With that,\n\nActually the Point class has the same issue. Let's keep it as-is here\nand fix both on top.\n\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> I can fix when applying.\n> \n> >  \treturn out;\n> >  }\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18351C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Apr 2022 13:12:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A05865642;\n\tTue, 19 Apr 2022 15:12:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5CDE6563C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Apr 2022 15:12:53 +0200 (CEST)","from pendragon.ideasonboard.com (smb-adp01.hotspot.hub-one.net\n\t[94.199.126.50])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 690B225B;\n\tTue, 19 Apr 2022 15:12:53 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650373975;\n\tbh=jQf6Q3f72JU+Szyqsg0cMSk0bX+mPNKzNr9xr+XAcyU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=iIzfnvdJtXDE+B0/UYMt8gh0nq0KV+Ur1/G+DOGxWyCn0+5rDGEy+mS1Ht0RJKCNu\n\th+RTZ1pElbmXJEq73lkVMkKt5aaZFPPySZHhHrcME9CK5TTHmNIrweMw9wf4HRHyer\n\tfSBTkXhOyWkDK0A2+/ZX5l/ayg7RFtqo7NW9LtHf78ArefebCLHe4KlLJCz1eemFyW\n\tKIhCA3P16dC1latxMz7XplGCZf/8lVl0wT+2utN7ZKhSthg9yGt0jn1KtV/ggqVg7C\n\tnh0rlFICL7blfxyv0bA9vZS/wcTIc6bPBNtc69eElPcGqWD+ArEhW2h5zJi5izaXfS\n\tvzfCDEYTeMiKQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1650373973;\n\tbh=jQf6Q3f72JU+Szyqsg0cMSk0bX+mPNKzNr9xr+XAcyU=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=viejfGCR8zVfSk7Wl6zfN7no510hxFXUPG4pEO4/PFInUb0NFjrHyd3Z2D1Iwyw2q\n\tsQ8uEG3zFj+dZwvab+kKSiKxtcUckQctpmwIJ6RMRzxd0noDHTdTT3WatvuqCJLvKg\n\tPFANxhi4ClUvcJk/ErGtIGWZySbmThQpXvtdKL8g="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"viejfGCR\"; dkim-atps=neutral","Date":"Tue, 19 Apr 2022 16:12:56 +0300","To":"Han-Lin Chen <hanlinchen@chromium.org>,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<Yl61WD9l4/RGKyXJ@pendragon.ideasonboard.com>","References":"<20220419124220.1877877-1-hanlinchen@chromium.org>\n\t<20220419124220.1877877-2-hanlinchen@chromium.org>\n\t<Yl602Q/YdAE3W2xS@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<Yl602Q/YdAE3W2xS@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/2] libcamera: correct the string\n\trepresentation of Rectangle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":22738,"web_url":"https://patchwork.libcamera.org/comment/22738/","msgid":"<165037642231.2548121.8164377950874875075@Monstersaurus>","date":"2022-04-19T13:53:42","subject":"Re: [libcamera-devel] [PATCH v3 2/2] libcamera: correct the string\n\trepresentation of Rectangle","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-04-19 14:12:56)\n> On Tue, Apr 19, 2022 at 04:10:49PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > Hi Han-Lin,\n> > \n> > On Tue, Apr 19, 2022 at 08:42:20PM +0800, Han-Lin Chen via libcamera-devel wrote:\n> > > Change the string representation of class Rectangle from\n> > > \"(top x left)/width x height\" to \"(top, left)/width x height\".\n> > \n> > Good catch !\n> > \n> > > Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org>\n> > > ---\n> > >  src/libcamera/geometry.cpp | 2 +-\n> > >  1 file changed, 1 insertion(+), 1 deletion(-)\n> > > \n> > > diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> > > index da08045e..e00333cf 100644\n> > > --- a/src/libcamera/geometry.cpp\n> > > +++ b/src/libcamera/geometry.cpp\n> > > @@ -841,7 +841,7 @@ bool operator==(const Rectangle &lhs, const Rectangle &rhs)\n> > >   */\n> > >  std::ostream &operator<<(std::ostream &out, const Rectangle &r)\n> > >  {\n> > > -   out << \"(\" << r.x << \"x\" << r.y << \")/\" << r.width << \"x\" << r.height;\n> > > +   out << \"(\" << r.x << \", \" << r.y << \")/\" << r.width << \"x\" << r.height;\n> > \n> > I'd remove the space after the comma. With that,\n> \n> Actually the Point class has the same issue. Let's keep it as-is here\n> and fix both on top.\n> \n> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> > \n> > I can fix when applying.\n> > \n> > >     return out;\n> > >  }\n> > >  \n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92A05C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Apr 2022 13:53:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E1FDE6563D;\n\tTue, 19 Apr 2022 15:53:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 468546563C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Apr 2022 15:53:45 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF78125B;\n\tTue, 19 Apr 2022 15:53:44 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650376426;\n\tbh=z/+siaflGFq2V9JAmivUjkhhD19AyrIbB7SzGgMY1qA=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=IWwoVIvmTlktIJ9NJKGSOlq5a3RnvO9jwwuAbEGT+y3dQqUXq88L6T+gA7RYsqxI9\n\tuqBgUrNjQM70+dZDtIxiV9bgGCeeiEywUX1GEzXqbrVU6fPigpO9yIIDyRL7WN5G39\n\tqQEf3kJa0prGehmYAwNWlVdmhbDY6OGq/On+i+3u0MUgAXSbne87Q7tld7kvhE8RTo\n\tr1HhNcKPqglSy8f3DOCigGYTlzCHpvkE0PXkOormmcvLbIR+jHwj9gaqQ65HCoO37S\n\teuEtn81C2uLgUe0aled3OA+oErMq5hngBcNcp7373GvH5qe42jFt4Sa24n2MC2QRQv\n\tUpyqGQuGeDC6A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1650376424;\n\tbh=z/+siaflGFq2V9JAmivUjkhhD19AyrIbB7SzGgMY1qA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=e8NVfOiqe5Jcfw8Rx1TRwT+0sa151jdaQ+2FgNXdHowKlz3zx/4rOuxnYlwhK3Xir\n\tID6yurNjEpHC1su2ZzqBQBVDd50SK5dbxqhFUB2yOnnRFGv7SLUWWeuhltLe3WJkfl\n\tTQssvYNLP9QNgPz9eDJElRRPT9olRBjbUZg5nnpA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"e8NVfOiq\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<Yl61WD9l4/RGKyXJ@pendragon.ideasonboard.com>","References":"<20220419124220.1877877-1-hanlinchen@chromium.org>\n\t<20220419124220.1877877-2-hanlinchen@chromium.org>\n\t<Yl602Q/YdAE3W2xS@pendragon.ideasonboard.com>\n\t<Yl61WD9l4/RGKyXJ@pendragon.ideasonboard.com>","To":"Han-Lin Chen <hanlinchen@chromium.org>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 19 Apr 2022 14:53:42 +0100","Message-ID":"<165037642231.2548121.8164377950874875075@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 2/2] libcamera: correct the string\n\trepresentation of Rectangle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":22756,"web_url":"https://patchwork.libcamera.org/comment/22756/","msgid":"<20220420061310.GB3237525@pyrite.rasen.tech>","date":"2022-04-20T06:13:10","subject":"Re: [libcamera-devel] [PATCH v3 2/2] libcamera: correct the string\n\trepresentation of Rectangle","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Han-Lin,\n\nOn Tue, Apr 19, 2022 at 08:42:20PM +0800, Han-Lin Chen via libcamera-devel wrote:\n> Change the string representation of class Rectangle from\n> \"(top x left)/width x height\" to \"(top, left)/width x height\".\n> \n> Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org>\n\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n> ---\n>  src/libcamera/geometry.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index da08045e..e00333cf 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -841,7 +841,7 @@ bool operator==(const Rectangle &lhs, const Rectangle &rhs)\n>   */\n>  std::ostream &operator<<(std::ostream &out, const Rectangle &r)\n>  {\n> -\tout << \"(\" << r.x << \"x\" << r.y << \")/\" << r.width << \"x\" << r.height;\n> +\tout << \"(\" << r.x << \", \" << r.y << \")/\" << r.width << \"x\" << r.height;\n>  \treturn out;\n>  }\n>  \n> -- \n> 2.36.0.rc0.470.gd361397f0d-goog\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99C64C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 20 Apr 2022 06:13:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DB1465645;\n\tWed, 20 Apr 2022 08:13:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7344F6563F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 20 Apr 2022 08:13:17 +0200 (CEST)","from pyrite.rasen.tech (softbank114048062035.bbtec.net\n\t[114.48.62.35])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0594425B;\n\tWed, 20 Apr 2022 08:13:15 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650435198;\n\tbh=dD3e2IbPmsJWvkxI+bh0cALKxKjkVIbCUqf8n3EKQro=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=R6pTECaLZWX2QdKx8Vw8gScvj8BXfxnq9egBigSlVhojxvzzzim3+JdE6ZTfz94Zh\n\t17S+NuA48bwh6dzCE0P2Mm8IklEJw22pkl2rC53U5FHmG1JzozXSFDDuyPWkOB2DhR\n\tiBp3dgvIcYi0w6CNvuudGg5y1lPYt/6wgPD2tU62QswqNivBIZ1r5Hx5pWB1oeH9ds\n\tZ6A/qg8vtjWmG4ZQhfnAIqBsu7yNcOTG5eu4zRpfdJrJ+QTFJ8FA7U3JaFUYIjg2wV\n\t0ii88lHTDIUo0+vluGZpQ5Tq06GNapnO4bdEjjqj0uciywI2LrQmf1L/JKRK+51gUI\n\t4hInvknPAuU4A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1650435197;\n\tbh=dD3e2IbPmsJWvkxI+bh0cALKxKjkVIbCUqf8n3EKQro=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tHw+/fjiRciT0V88uQCdOZBQOR5MenblV37DhNDyKifu856IoX37wShA5BQxTPxKD\n\tLCBf37ZvVXMzHnBg03gGzv8EA7wnxObtGY87c3e1AzdzS1qbueBkIy5cCgqoGpH8go\n\twwyVsJOxlulSIBv7FIV7wZDV65RSY0L/yIfsjZVc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tHw+/fji\"; dkim-atps=neutral","Date":"Wed, 20 Apr 2022 15:13:10 +0900","To":"Han-Lin Chen <hanlinchen@chromium.org>","Message-ID":"<20220420061310.GB3237525@pyrite.rasen.tech>","References":"<20220419124220.1877877-1-hanlinchen@chromium.org>\n\t<20220419124220.1877877-2-hanlinchen@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220419124220.1877877-2-hanlinchen@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v3 2/2] libcamera: correct the string\n\trepresentation of Rectangle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]