{"id":15685,"url":"https://patchwork.libcamera.org/api/patches/15685/?format=json","web_url":"https://patchwork.libcamera.org/patch/15685/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220419124220.1877877-2-hanlinchen@chromium.org>","date":"2022-04-19T12:42:20","name":"[libcamera-devel,v3,2/2] libcamera: correct the string representation of Rectangle","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"79bf41810be53417fbe4e662f8e15046720dd690","submitter":{"id":98,"url":"https://patchwork.libcamera.org/api/people/98/?format=json","name":"Hanlin Chen","email":"hanlinchen@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15685/mbox/","series":[{"id":3058,"url":"https://patchwork.libcamera.org/api/series/3058/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3058","date":"2022-04-19T12:42:19","name":"[libcamera-devel,v3,1/2] libcamera: Add operator<< for classes in geometry","version":3,"mbox":"https://patchwork.libcamera.org/series/3058/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15685/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15685/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54704C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Apr 2022 12:42:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 196576563D;\n\tTue, 19 Apr 2022 14:42:31 +0200 (CEST)","from mail-pl1-x636.google.com (mail-pl1-x636.google.com\n\t[IPv6:2607:f8b0:4864:20::636])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B3776563D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Apr 2022 14:42:29 +0200 (CEST)","by mail-pl1-x636.google.com with SMTP id n18so15631641plg.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Apr 2022 05:42:29 -0700 (PDT)","from localhost ([2401:fa00:1:17:4ede:fa5e:4144:1dec])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\t96-20020a17090a09e900b001cb62ee05besm19682789pjo.55.2022.04.19.05.42.26\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 19 Apr 2022 05:42:27 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650372151;\n\tbh=GnUToFRsalgnIk2d8jhuDJHVeRd9SCZtB/4535fLoBo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=4PdRq36lFsMbrUewSRaud/eESPHC13n5mqs1Qadhq7wEbHEU/y46EyyLEuN7db3Dv\n\tu9nADuLsyFPr+qaJhVCpeKwwd9vXC1IkEl4Sku5n5ilCUx4zIie2aqVxpVthZWOaAm\n\tF6rm1k713/LZnHU0keVNHoj7CzBQ8ZbccYItYXKib37Pkt83zdy7lCfPBqlVmRevjS\n\tUkmygvSa6c7ASokZJ4zQIPzhqiKIbc5L1h8bTnnkiUEU5Gxx+pqp1q02WA+bs31XY8\n\tw4c3vH7pAMdofsxB8px4OW0Xaxxar7+rQZtFeLPljFJYm/XxZwRc2b++8kyEm7Ef69\n\tfYsIdxtvNSK1Q==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=scw51YVqi4jrkxHTgyXesQdq6yqpX+vW3fLLFA/09WE=;\n\tb=GKwFwWaYi1qEr6Eled4ysieuUTvNUbKBRIl9KUS1AWuHLSDcooUtP4RIEMgXytvwuq\n\tDhD04EfiV63jncU4jAP5tAIYzi+zsl+sNNUyrcf2ng5Hzp9Qn6UZftYDfgjvTF6L4NKd\n\tSpyhjE4WdGwlFdG9Q1j68OdpW+LI3N0czx9l0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"GKwFwWaY\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=scw51YVqi4jrkxHTgyXesQdq6yqpX+vW3fLLFA/09WE=;\n\tb=HZNJFIi5CZM0NwxmP9tzQj8n1n35FG7kKUJM9IP7JWUupnFzhOWV1TyP/U1dNRMjkZ\n\t7qBSrLRC8tcCFM+YOd639XRqwxgpygfAuIG6UzD1ioMTxgw7Y9Oew2MJnJ8czJmUYSs4\n\tDOfI8VDjv1Kqtbq1wrW73Rimb+iDyJ8I96dY3/4NYqYljZuVeNec2YP2610/CHuqG7ap\n\tSo3/9z0CMVPt3hyZ3vlp7jidt/pnuy0I+hebr1SryR4O56frniH3a26ieFH3y9TKtUZd\n\t1be7ICjhtaPnY4O4frS86h4xnxGzjlAqoSPbRu/xV6ZiR9ol+31H9yuw6/UIJg7AAITm\n\tF0cw==","X-Gm-Message-State":"AOAM5314N1kvFSiUiDvP7o940eFuR5vGKqTjR5X9igAVWmWH8/TXo/zx\n\tlyJh+INR7a7tCn1fRv5renOg/UZHrMBk6g==","X-Google-Smtp-Source":"ABdhPJxLY8UO057yudhsSexYDgfUN4Xmpv4L25qrvd0AUpIwwL2aDABHlRFp48UyIgmKpQbURkX63Q==","X-Received":"by 2002:a17:902:778a:b0:158:da0f:f299 with SMTP id\n\to10-20020a170902778a00b00158da0ff299mr15253542pll.29.1650372147886; \n\tTue, 19 Apr 2022 05:42:27 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 19 Apr 2022 20:42:20 +0800","Message-Id":"<20220419124220.1877877-2-hanlinchen@chromium.org>","X-Mailer":"git-send-email 2.36.0.rc0.470.gd361397f0d-goog","In-Reply-To":"<20220419124220.1877877-1-hanlinchen@chromium.org>","References":"<20220419124220.1877877-1-hanlinchen@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 2/2] libcamera: correct the string\n\trepresentation of Rectangle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Han-Lin Chen via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Han-Lin Chen <hanlinchen@chromium.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Change the string representation of class Rectangle from\n\"(top x left)/width x height\" to \"(top, left)/width x height\".\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\n---\n src/libcamera/geometry.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\nindex da08045e..e00333cf 100644\n--- a/src/libcamera/geometry.cpp\n+++ b/src/libcamera/geometry.cpp\n@@ -841,7 +841,7 @@ bool operator==(const Rectangle &lhs, const Rectangle &rhs)\n  */\n std::ostream &operator<<(std::ostream &out, const Rectangle &r)\n {\n-\tout << \"(\" << r.x << \"x\" << r.y << \")/\" << r.width << \"x\" << r.height;\n+\tout << \"(\" << r.x << \", \" << r.y << \")/\" << r.width << \"x\" << r.height;\n \treturn out;\n }\n \n","prefixes":["libcamera-devel","v3","2/2"]}