[{"id":22712,"web_url":"https://patchwork.libcamera.org/comment/22712/","msgid":"<164996344148.22830.11949464896125565477@Monstersaurus>","date":"2022-04-14T19:10:41","subject":"Re: [libcamera-devel] [PATCH] Fix spelling error","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Rishikesh,\n\nQuoting Rishikesh Donadkar via libcamera-devel (2022-04-14 19:57:12)\n> From: RISHI27-dot \n\nThis looks like you need to configure your git author\n\n git config --global author.name \"Rishikesh Donadkar\"\n\nAnd you should add a signed-off by tag on patches you create.\nI usually do that by adding a '-s' when I commit\n\n git commit -s -m \"Documentation: Fix spelling error\"\n\nPatch titles should have a prefix (in this case 'Documentation') showing\nwhere the commit is making changes before the brief summary.\n\nAnd ideally - the commit message should say something too, in this case.\n\n\"The introduction incorrectly spells the word Compatibility. Fix it\"\n\nI know this is a trivial patch that doesn't really need much\nexplanation, but it's good to get in the habit for all your patches.\n\n--\nKieran\n\n\n> \n> ---\n> Documentation/guides/introduction.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/guides/introduction.rst b/Documentation/guides/introduction.rst\n> index 21880ce7..a4671a07 100644\n> --- a/Documentation/guides/introduction.rst\n> +++ b/Documentation/guides/introduction.rst\n> @@ -67,7 +67,7 @@ through an adaptation layer integrating libcamera into a larger framework.\n> Adaptation Layer |\n> / +--------------+ +--------------+ | +--------------+\n> | | V4L2 | | gstreamer | | | Android |\n> - | | Compatability| | element | | | Camera |\n> + | | Compatibility| | element | | | Camera |\n\nFor the change itself,\n\n\nReviewed-by: Kieran Bingham \n\n\nYou can add that to your next iteration of the patch above your\nSigned-off-by: tag.\n\n\n\n> | | (preload) | |(libcamerasrc)| | | HAL |\n> \\ +--------------+ +--------------+ | +--------------+\n> |\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 708DCC3256\n\tfor ;\n\tThu, 14 Apr 2022 19:10:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 26B2865646;\n\tThu, 14 Apr 2022 21:10:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE71C65640\n\tfor ;\n\tThu, 14 Apr 2022 21:10:44 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C983494;\n\tThu, 14 Apr 2022 21:10:44 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649963447;\n\tbh=Bm3zmHNHEP2tZ1jpeENS0kqIwASsvrvVKaGM8ebXzis=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=F1IXmkNHROVrp6Td4vYXxIVdlERl4XI9wgXSiG9chbvNCpMwU8tYIcLDURWqr6ytf\n\t1JT4Jqh1rUja4s39hIC3oqGRJs1m613Pg7NeaLwc04QdDA0GWsPj8xFrX6/bzspLhJ\n\tjjhWvSi0FOaEdXHyifUivXyTlbkvcwOB/lQY7sQfG4lEkWFiOP2AU+yWketAsABKHh\n\tRtwEw/a4sUXOXFHMpXgtbpGP4fe+IiLeorUpyJhpX32qqSmliT0AbjOoI0lSYZYiue\n\tWN5agTj6HcwVe7zSolHHT2Md4M6V9JcrhTP7403q43G/sgRodoJsT5GuujEr+r2Gol\n\th16en3nHu9MLw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649963444;\n\tbh=Bm3zmHNHEP2tZ1jpeENS0kqIwASsvrvVKaGM8ebXzis=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=kznkds0cgE5lRLFOmp1+6wT2v/V0NGaV/f3r+VOGSZSe/DPnMkJfe/RaDN39FbnCC\n\tKS5v0xG7v1t+d7nzPZAZd8aAYMUYu0yCiXAL2BCpliwODekKzDvJf8r5cjpmoR8bnv\n\tzlwFV8rTQYnRPJb44fF6pUg4UGGCu77HS3K0Ytl0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kznkds0c\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220414185712.64053-1-rishikeshdonadkar@gmail.com>","References":"<20220414185712.64053-1-rishikeshdonadkar@gmail.com>","To":"Rishikesh Donadkar ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 14 Apr 2022 20:10:41 +0100","Message-ID":"<164996344148.22830.11949464896125565477@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] Fix spelling error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"RISHI27-dot ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22713,"web_url":"https://patchwork.libcamera.org/comment/22713/","msgid":"<164996395234.22830.9731753235012666376@Monstersaurus>","date":"2022-04-14T19:19:12","subject":"Re: [libcamera-devel] [PATCH] Fix spelling error","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2022-04-14 20:10:41)\n> Hi Rishikesh,\n> \n> Quoting Rishikesh Donadkar via libcamera-devel (2022-04-14 19:57:12)\n> > From: RISHI27-dot \n> \n> This looks like you need to configure your git author\n> \n> git config --global author.name \"Rishikesh Donadkar\"\n\nI think your e-mail address needs fixing too - as I have had an\n'Undelivered mail returned to sender' from this reply.\n\nIt looks like your author.email is set with a typo.\n\n--\nKieran\n\n\n> \n> And you should add a signed-off by tag on patches you create.\n> I usually do that by adding a '-s' when I commit\n> \n> git commit -s -m \"Documentation: Fix spelling error\"\n> \n> Patch titles should have a prefix (in this case 'Documentation') showing\n> where the commit is making changes before the brief summary.\n> \n> And ideally - the commit message should say something too, in this case.\n> \n> \"The introduction incorrectly spells the word Compatibility. Fix it\"\n> \n> I know this is a trivial patch that doesn't really need much\n> explanation, but it's good to get in the habit for all your patches.\n> \n> --\n> Kieran\n> \n> \n> > \n> > ---\n> > Documentation/guides/introduction.rst | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/Documentation/guides/introduction.rst b/Documentation/guides/introduction.rst\n> > index 21880ce7..a4671a07 100644\n> > --- a/Documentation/guides/introduction.rst\n> > +++ b/Documentation/guides/introduction.rst\n> > @@ -67,7 +67,7 @@ through an adaptation layer integrating libcamera into a larger framework.\n> > Adaptation Layer |\n> > / +--------------+ +--------------+ | +--------------+\n> > | | V4L2 | | gstreamer | | | Android |\n> > - | | Compatability| | element | | | Camera |\n> > + | | Compatibility| | element | | | Camera |\n> \n> For the change itself,\n> \n> \n> Reviewed-by: Kieran Bingham \n> \n> \n> You can add that to your next iteration of the patch above your\n> Signed-off-by: tag.\n> \n> \n> \n> > | | (preload) | |(libcamerasrc)| | | HAL |\n> > \\ +--------------+ +--------------+ | +--------------+\n> > |\n> > -- \n> > 2.25.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D86C4C0F1B\n\tfor ;\n\tThu, 14 Apr 2022 19:19:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4041165641;\n\tThu, 14 Apr 2022 21:19:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B034465640\n\tfor ;\n\tThu, 14 Apr 2022 21:19:15 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 40143494;\n\tThu, 14 Apr 2022 21:19:15 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649963957;\n\tbh=wir0anOvMcquPUGxCr44kvMjF2bRGqKAKYRVyMM9RLA=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Xg/HLmBKkof44jltkwVMTMddKLgcnngU3M0aty9dFKxz0N9v3mAAvk8YHWCpr5lwu\n\tS18RSgBOLeEs6F9pl46d5TI2U5tpYPi+YAmzqgZVMxUbHa3eyleMFNECrhWhJlmaAk\n\teTApv301OuQxVyHoYugVSg/ihdIOT8lpHkGBDdRxFIjYxojOS/Mu16YmT1aY9J+MA/\n\t9oaiZVey9Z1gBHViNYuAizGbEUMfPROxQ3aNE2NtGOqgmUJU018Gr2Yh5kNeg0cGQm\n\t1wv2DwFOubpd2wmSrCBhphlKYOtFKTlUDGf3A1G9J1I1daXLlC8zopb6eFQbs6MUnp\n\tVWEOcSQPzC3wg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649963955;\n\tbh=wir0anOvMcquPUGxCr44kvMjF2bRGqKAKYRVyMM9RLA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=pm4zn/xljI73jyU/ix06uTtmokFh/6a0ecLDC6FeFs3vAL5Sx0trWgRU05XSmlEww\n\tCk9Zdptwn+RKgr2CUwqvdNHH3nIMXka85KBBgzbFMOWi4bUUA3Gww1tkOR1NpkEK2Y\n\tK++Q+x9kryAbfSQj8KP1wZVJHfzVrkMjRKE9wTJY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"pm4zn/xl\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<164996344148.22830.11949464896125565477@Monstersaurus>","References":"<20220414185712.64053-1-rishikeshdonadkar@gmail.com>\n\t<164996344148.22830.11949464896125565477@Monstersaurus>","To":"Rishikesh Donadkar ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 14 Apr 2022 20:19:12 +0100","Message-ID":"<164996395234.22830.9731753235012666376@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] Fix spelling error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]