[{"id":22708,"web_url":"https://patchwork.libcamera.org/comment/22708/","msgid":"<164992681760.22830.1845820298254903188@Monstersaurus>","date":"2022-04-14T09:00:17","subject":"Re: [libcamera-devel] [RFC v1 3/5] ipa: ipu3: Variables to hold the\n\tmaximum VCM steps","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kate Hsuan via libcamera-devel (2022-04-14 08:43:40)\n> They are used to place the maximum VCM steps.\n> \n> Signed-off-by: Kate Hsuan\n> ---\n> include/libcamera/ipa/core.mojom | 2 ++\n> src/ipa/ipu3/ipa_context.h | 1 +\n> 2 files changed, 3 insertions(+)\n> \n> diff --git a/include/libcamera/ipa/core.mojom b/include/libcamera/ipa/core.mojom\n> index 74f3339e..5378ec0c 100644\n> --- a/include/libcamera/ipa/core.mojom\n> +++ b/include/libcamera/ipa/core.mojom\n> @@ -221,6 +221,8 @@ struct IPACameraSensorInfo {\n> \n> uint32 minFrameLength;\n> uint32 maxFrameLength;\n> +\n> + uint32 maxVcmSteps;\n> };\n> \n> /**\n> diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\n> index 103498ef..3b8aa621 100644\n> --- a/src/ipa/ipu3/ipa_context.h\n> +++ b/src/ipa/ipu3/ipa_context.h\n> @@ -27,6 +27,7 @@ struct IPASessionConfiguration {\n> \n> struct {\n> ipu3_uapi_grid_config afGrid;\n> + int32_t maxVcmSteps;\n\nuint32_t, but the field may not be needed anyway.\n\n> } af;\n> \n> struct {\n> -- \n> 2.35.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D67ABC0F1B\n\tfor ;\n\tThu, 14 Apr 2022 09:00:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 991756564A;\n\tThu, 14 Apr 2022 11:00:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59FC8604B6\n\tfor ;\n\tThu, 14 Apr 2022 11:00:20 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 182BD25B;\n\tThu, 14 Apr 2022 11:00:20 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649926822;\n\tbh=2tdoZ3ID0LGqthGXDz7k8E35V4AsxxaljvsTB1ybKXk=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=UeYdWwW1Ejc8o2WKa4sxqYF/MJ8MCqb+VzrbnC6XIjn6Wzw6Rr1STi9p/BevOCrja\n\t48iXZaj3UOeR6G3hnZESsb+fA+vmIc8+TuY5q+YiW/hYb41MA8FWigV1J97VGBZ3ny\n\t8ojm81aQhkiICClXVZie2bLpGyJKFmDJO/Ic/5wnP0cNt/gywgIGQWgM14tv0nnmOH\n\tvhdwZBI6Y5lOwHUpznVNVjo1rmqM3rRBRqpLITJPZIYEFwWdNqDDIYn2zdW6g2Xr22\n\t54iMSuljzeZZvgEOZ6lByJ9MIzwayXCTzYDq/LYjxu+YWQXBJFN+0ix3Erdl4yF00F\n\tIhV2is8wiyb2A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649926820;\n\tbh=2tdoZ3ID0LGqthGXDz7k8E35V4AsxxaljvsTB1ybKXk=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Md9om5hICVn+C5pJCM2PLVrKy9MmxALy4LKR4p0qG7eumKKwinuPMvN1Yg1r/IlIK\n\tJb5Ewm5q6pBsAD89/FhktC3nQJqPJqhxqKunDCQReFpF6b6Z4EdQmN5Ep3NSjtqNS0\n\tL6jYIxWdqJasq844vI4wZPb/FpmMyHobb+0A3aM8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Md9om5hI\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220414074342.7455-4-hpa@redhat.com>","References":"<20220414074342.7455-1-hpa@redhat.com>\n\t<20220414074342.7455-4-hpa@redhat.com>","To":"Kate Hsuan ,\n\tlibcamera devel ","Date":"Thu, 14 Apr 2022 10:00:17 +0100","Message-ID":"<164992681760.22830.1845820298254903188@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [RFC v1 3/5] ipa: ipu3: Variables to hold the\n\tmaximum VCM steps","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]