{"id":15664,"url":"https://patchwork.libcamera.org/api/patches/15664/?format=json","web_url":"https://patchwork.libcamera.org/patch/15664/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220413074353.13147-1-hpa@redhat.com>","date":"2022-04-13T07:43:53","name":"[libcamera-devel,v1] ipa: ipu3: af: A not initialized frame ignore counter fixing","commit_ref":"0111feb04b4e2442519d3dbdcd572b573e750316","pull_url":null,"state":"accepted","archived":false,"hash":"3e8a36949220a7e57f8344b89c2b4f719a6a067b","submitter":{"id":105,"url":"https://patchwork.libcamera.org/api/people/105/?format=json","name":"Kate Hsuan","email":"hpa@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15664/mbox/","series":[{"id":3049,"url":"https://patchwork.libcamera.org/api/series/3049/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3049","date":"2022-04-13T07:43:53","name":"[libcamera-devel,v1] ipa: ipu3: af: A not initialized frame ignore counter fixing","version":1,"mbox":"https://patchwork.libcamera.org/series/3049/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15664/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15664/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 925E7C3256\n\tfor ;\n\tWed, 13 Apr 2022 07:44:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D91D65644;\n\tWed, 13 Apr 2022 09:44:06 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A7F5604B3\n\tfor ;\n\tWed, 13 Apr 2022 09:44:05 +0200 (CEST)","from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n\t[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-34-Ro2-M2p9MPKm-oJci-7YyQ-1; Wed, 13 Apr 2022 03:44:02 -0400","from smtp.corp.redhat.com\n\t(int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1CA27804195\n\tfor ;\n\tWed, 13 Apr 2022 07:44:02 +0000 (UTC)","from fedora.redhat.com (unknown [10.39.194.133])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7645E42B925;\n\tWed, 13 Apr 2022 07:43:59 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649835846;\n\tbh=dBiMZV3k56Dn9enXmHnmqPsDcIiwWVZwchnuR//9SEQ=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=QO8x34S7IuNSRIxHSf7IjXPdVtYj79obR9llmaCRKUVdA8GzjZWDj2P7ApbZvcGGp\n\t/JF0p8DzKvBEH/BITh0ulWLpBpBJTnzQ5QtpiBOLjH/tE7uog/H50HoAwwoXHqQmy+\n\tELrJDpcton2h4YOyIrGj3VXMVW+jZQOhj447lmbdenUFf4hok5FETRThha+0w6kS+b\n\ta5+BDRqK8BUV/iWdALw/lsgUROnOGbBdcER+5ba4d+txVj2QfEDDf6Fexs9T/7YM0J\n\tU5OXNiy5HNuKAOl8gojhspu403PB1jEZ7BemlKj1zIkIGZvKBCFg2wjP5ESphw8n/+\n\t8jWBqTSvtBEwg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1649835844;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=AFv5vxaePNTIqBLGtESy2zXBs9+ci/TnETOTe2XWoT4=;\n\tb=aD/+kTkRXsQn+BeYbNHkFJRks7WrU/k6t2i0haBFK5ccNVtOr/KPKtq6rSW7qZoI1gTjGZ\n\triDBJmawrzisLyw4jEQbiJGIZ8KtvEB2IcQqeubcnkXVezpIPv5bOeQr4c8LGayVbRIdfl\n\tZ2uVaA5cyXZnkOwmRtBX8/8PcK+r6Bw="],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"aD/+kTkR\"; \n\tdkim-atps=neutral","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hpa@redhat.com"],"X-MC-Unique":"Ro2-M2p9MPKm-oJci-7YyQ-1","To":"libcamera devel ","Date":"Wed, 13 Apr 2022 15:43:53 +0800","Message-Id":"<20220413074353.13147-1-hpa@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 2.85 on 10.11.54.9","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","Subject":"[libcamera-devel] [PATCH v1] ipa: ipu3: af: A not initialized frame\n\tignore counter fixing","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kate Hsuan via libcamera-devel ","Reply-To":"Kate Hsuan ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A not initialized frame ignore counter (ignoreCounter_) makes the AF\nfunction not work since the ignore counter may start from a random\nnegative number. The counter was set to kIgnoreFrame when AF is in\nprepare stage.\n\nSigned-off-by: Kate Hsuan\n---\n src/ipa/ipu3/algorithms/af.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\nindex addf98af..f700b01f 100644\n--- a/src/ipa/ipu3/algorithms/af.cpp\n+++ b/src/ipa/ipu3/algorithms/af.cpp\n@@ -181,6 +181,9 @@ int Af::configure(IPAContext &context, const IPAConfigInfo &configInfo)\n \t/* Initial max focus step */\n \tmaxStep_ = kMaxFocusSteps;\n \n+\t/* Initial frame ignore counter */\n+\tafIgnoreFrameReset();\n+\n \t/* Initial focus value */\n \tcontext.frameContext.af.focus = 0;\n \t/* Maximum variance of the AF statistics */\n","prefixes":["libcamera-devel","v1"]}