[{"id":2108,"web_url":"https://patchwork.libcamera.org/comment/2108/","msgid":"<20190702001702.GI9228@bigcity.dyn.berto.se>","date":"2019-07-02T00:17:02","subject":"Re: [libcamera-devel] [PATCH v4 07/13] libcamera: controls: Add a\n\tset of initial controls","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nOn 2019-07-01 23:14:58 +0300, Laurent Pinchart wrote:\n> Add an initial set of controls to demonstrate how controls are defined.\n> \n> Proper documentation for each control is missing.\n\nThis could be improved moving forward, defining controls we know we need \neven with sparse documentation allows us to move forward.\n\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/control_ids.h | 6 +++++\n> src/libcamera/controls.cpp | 42 +++++++++++++++++++++++++++++++++\n> 2 files changed, 48 insertions(+)\n> \n> diff --git a/include/libcamera/control_ids.h b/include/libcamera/control_ids.h\n> index d0e700da9844..75b6a2d5cafe 100644\n> --- a/include/libcamera/control_ids.h\n> +++ b/include/libcamera/control_ids.h\n> @@ -13,6 +13,12 @@\n> namespace libcamera {\n> \n> enum ControlId {\n> +\tAwbEnable,\n> +\tBrightness,\n> +\tContrast,\n> +\tSaturation,\n> +\tManualExposure,\n> +\tManualGain,\n> };\n> \n> } /* namespace libcamera */\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 42a2f8990bf6..d9fbd46d81c9 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -186,6 +186,48 @@ std::string ControlValue::toString() const\n> * \\brief Numerical control ID\n> */\n> \n> +/**\n> + * \\var AwbEnable\n> + * ControlType: Bool\n> + *\n> + * Enables or disables the AWB. See also \\a libcamera::ControlId::ManualGain\n> + */\n> +\n> +/**\n> + * \\var Brightness\n> + * ControlType: Integer\n> + *\n> + * Specify a fixed brightness parameter.\n> + */\n> +\n> +/**\n> + * \\var Contrast\n> + * ControlType: Integer\n> + *\n> + * Specify a fixed constrast parameter.\n> + */\n> +\n> +/**\n> + * \\var Saturation\n> + * ControlType: Integer\n> + *\n> + * Specify a fixed saturation parameter.\n> + */\n> +\n> +/**\n> + * \\var ManualExposure\n> + * ControlType: Integer\n> + *\n> + * Specify a fixed exposure time in milli-seconds\n> + */\n> +\n> +/**\n> + * \\var ManualGain\n> + * ControlType: Integer\n> + *\n> + * Specify a fixed gain parameter\n> + */\n> +\n> /**\n> * \\struct ControlIdentifier\n> * \\brief Describe a ControlId with control specific constant meta-data\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A00F360C2B\n\tfor ;\n\tTue, 2 Jul 2019 02:17:03 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id h10so15059853ljg.0\n\tfor ;\n\tMon, 01 Jul 2019 17:17:03 -0700 (PDT)","from localhost (customer-145-14-112-32.stosn.net. [145.14.112.32])\n\tby smtp.gmail.com with ESMTPSA id\n\te13sm3493905ljg.102.2019.07.01.17.17.02\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 01 Jul 2019 17:17:02 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=syyYG7r23JfWyUWZdznmCXVBRM/ligJyDD3w8fe0R4E=;\n\tb=VR86i8WbjXGA4byHtMDknQ+KmW7Mec4INIC+3KPtQ0KUmSRVXtH4Yc8kcDZNBBGXyO\n\tRwxVqZjpKheqQvJX3AljEzPPS5D8ElVSugUtRJuvxHoVPEVw6b4G/WSLvZ2P59xA6c18\n\trnLW28IggtxXuhu1W2Alu5i15Uh8hBJNTpQKtJU+IAqlvuSnJ650GUZvIT56JGSm3rUB\n\t6F4oXv1PGc80YAawZCObnheWWSIXrvao956LYNNn55QQn4aVOT6HOzY+dVbuFEHIcDJ1\n\tdro89Ks2L8kjVyDQNWH1MEdn+ffFM9Cl3R1GU03CdWLKpx9RoPos5XLgePY/F2PMNIta\n\tfV9g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=syyYG7r23JfWyUWZdznmCXVBRM/ligJyDD3w8fe0R4E=;\n\tb=ot3WPRmWS6Q8MYSXp0ZeQ4J8SLSk7pbZfFp9VmbwQoS70JxLKmglRHSrvs9lUJqUAI\n\tYP924XeASzpTFYXGlLtKpR6OogcoFpBDek/0B0tymkeLtXUncEnxM9YbhH/vuiaKqhf/\n\tAb+5E5asrh5Bf8m5wQDZUiwbmP0akPZHVlcm+JLJIEEUlxQQ+jNv2hzqfncysK3xA7Uj\n\tP8rmvAijRBgdR6oTczlOsNeMV4k+gLH50pko5jE87IsHyf2ZAMCFSI19eGKFik2hieai\n\tiRhBTBiHOcrYPrKlnTt0r62vr6y48tNEO0aAzOfT2DS7NqTjHH9+8IgeaR05UXibObNx\n\txGbA==","X-Gm-Message-State":"APjAAAUeuBZaeVz2L5E0DJkX0BThychhnwaX0FYBHKR7seEBZ8IEVISF\n\t6kIlwju2KZ2SeM6T4eSB+XdHVLYkRWQ=","X-Google-Smtp-Source":"APXvYqxXGcjWcxV34LBHkSLS3uvt1PajCdgYWkSsdLEMrFNlMVYT2Fsd52OARVwafuD2ZtgOAusGNQ==","X-Received":"by 2002:a2e:124c:: with SMTP id\n\tt73mr15389167lje.190.1562026623166; \n\tMon, 01 Jul 2019 17:17:03 -0700 (PDT)","Date":"Tue, 2 Jul 2019 02:17:02 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190702001702.GI9228@bigcity.dyn.berto.se>","References":"<20190701201504.28487-1-laurent.pinchart@ideasonboard.com>\n\t<20190701201504.28487-8-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190701201504.28487-8-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v4 07/13] libcamera: controls: Add a\n\tset of initial controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Jul 2019 00:17:03 -0000"}},{"id":2119,"web_url":"https://patchwork.libcamera.org/comment/2119/","msgid":"","date":"2019-07-02T07:50:30","subject":"Re: [libcamera-devel] [PATCH v4 07/13] libcamera: controls: Add a\n\tset of initial controls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 02/07/2019 01:17, Niklas Söderlund wrote:\n> Hi Laurent,\n> \n> On 2019-07-01 23:14:58 +0300, Laurent Pinchart wrote:\n>> Add an initial set of controls to demonstrate how controls are defined.\n>>\n>> Proper documentation for each control is missing.\n> \n> This could be improved moving forward, defining controls we know we need \n> even with sparse documentation allows us to move forward.\n\nI agree here, I agree that we want lots of documentation for controls -\nbut I don't think now is the right time to write lots of verboseness on\nthings that we do not yet have nailed down. It's better to get these\nenums in and actually develop.\n\nWe will have lots of controls to add, so once we get in the flow of how\nthey all come together adding the documentation will come more naturally.\n\nReviewed-by: Kieran Bingham \n\n\n> \n>>\n>> Signed-off-by: Laurent Pinchart \n> \n> Reviewed-by: Niklas Söderlund \n> \n>> ---\n>> include/libcamera/control_ids.h | 6 +++++\n>> src/libcamera/controls.cpp | 42 +++++++++++++++++++++++++++++++++\n>> 2 files changed, 48 insertions(+)\n>>\n>> diff --git a/include/libcamera/control_ids.h b/include/libcamera/control_ids.h\n>> index d0e700da9844..75b6a2d5cafe 100644\n>> --- a/include/libcamera/control_ids.h\n>> +++ b/include/libcamera/control_ids.h\n>> @@ -13,6 +13,12 @@\n>> namespace libcamera {\n>> \n>> enum ControlId {\n>> +\tAwbEnable,\n>> +\tBrightness,\n>> +\tContrast,\n>> +\tSaturation,\n>> +\tManualExposure,\n>> +\tManualGain,\n>> };\n>> \n>> } /* namespace libcamera */\n>> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n>> index 42a2f8990bf6..d9fbd46d81c9 100644\n>> --- a/src/libcamera/controls.cpp\n>> +++ b/src/libcamera/controls.cpp\n>> @@ -186,6 +186,48 @@ std::string ControlValue::toString() const\n>> * \\brief Numerical control ID\n>> */\n>> \n>> +/**\n>> + * \\var AwbEnable\n>> + * ControlType: Bool\n>> + *\n>> + * Enables or disables the AWB. See also \\a libcamera::ControlId::ManualGain\n>> + */\n>> +\n>> +/**\n>> + * \\var Brightness\n>> + * ControlType: Integer\n>> + *\n>> + * Specify a fixed brightness parameter.\n>> + */\n>> +\n>> +/**\n>> + * \\var Contrast\n>> + * ControlType: Integer\n>> + *\n>> + * Specify a fixed constrast parameter.\n>> + */\n>> +\n>> +/**\n>> + * \\var Saturation\n>> + * ControlType: Integer\n>> + *\n>> + * Specify a fixed saturation parameter.\n>> + */\n>> +\n>> +/**\n>> + * \\var ManualExposure\n>> + * ControlType: Integer\n>> + *\n>> + * Specify a fixed exposure time in milli-seconds\n>> + */\n>> +\n>> +/**\n>> + * \\var ManualGain\n>> + * ControlType: Integer\n>> + *\n>> + * Specify a fixed gain parameter\n>> + */\n>> +\n>> /**\n>> * \\struct ControlIdentifier\n>> * \\brief Describe a ControlId with control specific constant meta-data\n>> -- \n>> Regards,\n>>\n>> Laurent Pinchart\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A6EAA60C01\n\tfor ;\n\tTue, 2 Jul 2019 09:50:33 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E42392C6;\n\tTue, 2 Jul 2019 09:50:32 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562053833;\n\tbh=u9IN5sXOVFoBj2aqpLpl4Dx0A0GzB+u3Y2ZyZR2tby4=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=Wr2ynwk1NcV7N2PE1b66eoyCr/6gkqO8LudU6NouHzA6eUlK+b396AdOWIwk49Qi8\n\tplGm6T+sQv9oJh4pjDBmgcdPLJYSEh/npz4HAWou2KiRm5spj/Xl+d5N1Gj+rDVp6G\n\t4NrzR2r6X3ShLw/7oo3j2ZZVjEpb6eXBiTauTTeY=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tLaurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20190701201504.28487-1-laurent.pinchart@ideasonboard.com>\n\t<20190701201504.28487-8-laurent.pinchart@ideasonboard.com>\n\t<20190702001702.GI9228@bigcity.dyn.berto.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 2 Jul 2019 08:50:30 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.0","MIME-Version":"1.0","In-Reply-To":"<20190702001702.GI9228@bigcity.dyn.berto.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v4 07/13] libcamera: controls: Add a\n\tset of initial controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Jul 2019 07:50:33 -0000"}}]