[{"id":22671,"web_url":"https://patchwork.libcamera.org/comment/22671/","msgid":"<164941822262.3968198.4322603256859586971@Monstersaurus>","date":"2022-04-08T11:43:42","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: vimc: Establish logical\n\torder of operations","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain via libcamera-devel (2022-04-08 11:54:38)\n> It is preferred that the interface definition should represent\n> the logical order in which the operations will be called.\n> \n> The patch has no functional changes.\n> \n> Signed-off-by: Umang Jain \n\nIf this is the ordering used by IPU3 and RKISP then certainly.\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/ipa/vimc.mojom | 2 +-\n> src/ipa/vimc/vimc.cpp | 12 ++++++------\n> 2 files changed, 7 insertions(+), 7 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/vimc.mojom b/include/libcamera/ipa/vimc.mojom\n> index e5ac3609..cdc03ffb 100644\n> --- a/include/libcamera/ipa/vimc.mojom\n> +++ b/include/libcamera/ipa/vimc.mojom\n> @@ -30,6 +30,7 @@ interface IPAVimcInterface {\n> mapBuffers(array buffers);\n> unmapBuffers(array ids);\n> \n> + [async] queueRequest(uint32 frame, libcamera.ControlList controls);\n> /*\n> * The vimc driver doesn't use parameters buffers. To maximize coverage\n> * of unit tests that rely on the VIMC pipeline handler, we still define\n> @@ -37,7 +38,6 @@ interface IPAVimcInterface {\n> * handle parameters at runtime.\n> */\n> [async] fillParams(uint32 frame, uint32 bufferId);\n> - [async] queueRequest(uint32 frame, libcamera.ControlList controls);\n> };\n> \n> interface IPAVimcEventInterface {\n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index 315302c6..a62e72b0 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -43,8 +43,8 @@ public:\n> void mapBuffers(const std::vector &buffers) override;\n> void unmapBuffers(const std::vector &ids) override;\n> \n> - void fillParams(uint32_t frame, uint32_t bufferId) override;\n> void queueRequest(uint32_t frame, const ControlList &controls) override;\n> + void fillParams(uint32_t frame, uint32_t bufferId) override;\n> \n> private:\n> void initTrace();\n> @@ -129,6 +129,11 @@ void IPAVimc::unmapBuffers(const std::vector &ids)\n> }\n> }\n> \n> +void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame,\n> + [[maybe_unused]] const ControlList &controls)\n> +{\n> +}\n> +\n> void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId)\n> {\n> auto it = buffers_.find(bufferId);\n> @@ -140,11 +145,6 @@ void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId)\n> paramsFilled.emit(bufferId);\n> }\n> \n> -void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame,\n> - [[maybe_unused]] const ControlList &controls)\n> -{\n> -}\n> -\n> void IPAVimc::initTrace()\n> {\n> struct stat fifoStat;\n> -- \n> 2.31.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B132EC3256\n\tfor ;\n\tFri, 8 Apr 2022 11:43:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6AE1F65640;\n\tFri, 8 Apr 2022 13:43:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73A0E604BA\n\tfor ;\n\tFri, 8 Apr 2022 13:43:45 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A656486;\n\tFri, 8 Apr 2022 13:43:45 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649418227;\n\tbh=ytsCcex2ZFgx1CZwkr0piJo/Z21yVqZiXyBL2JPYYls=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=K+BoNQV3VcqS0tVDrxwbud+zWiiLuQKO2UFpx7pzgUTst46ve2u/aqg+xIuhJpppm\n\tYoOYNEenfBR3yHiwbN+KWsPjlCco+wHsZMk0nQdhQKtNB283nRKKgQYDH1GDz3inYU\n\tp8FmcWV5Y8nBSiEGWnBG+44y0LHsqwhD5WZzq66CZjLqA73/ii3N3JlJ3lROem2utb\n\tYfiES5gUjTwxGrkw4lSs7ZM6BLK6hMxFTOr/LL1Ngm2YhjnLR6cgT/sxxdhdGWBP6I\n\tQDanC8A5AHfN8g3uebspoLMGzux/Yf7J+RD2E+r1umZoYdY9AS2x/EdLiPj9cmncar\n\txwZbNC5dRBz3g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649418225;\n\tbh=ytsCcex2ZFgx1CZwkr0piJo/Z21yVqZiXyBL2JPYYls=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Bm8AtV5PKJ3AGHajxcTfzUbabsixmAaMMkk1f8HbUEFhX+hOnk6i1CkX6Sci0YEeU\n\tgUwcS93ZFZzzwMrfit1M9SrJODeuDwn57J4iHSOGQ8RIL2XEVznHbRFx3SPudxEkPb\n\t7t0mNXWOb5RoYF0sFPqnCJTERrbbw5cvUmU6Om+8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Bm8AtV5P\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220408105439.144182-2-umang.jain@ideasonboard.com>","References":"<20220408105439.144182-1-umang.jain@ideasonboard.com>\n\t<20220408105439.144182-2-umang.jain@ideasonboard.com>","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 08 Apr 2022 12:43:42 +0100","Message-ID":"<164941822262.3968198.4322603256859586971@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: vimc: Establish logical\n\torder of operations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]