{"id":15659,"url":"https://patchwork.libcamera.org/api/patches/15659/?format=json","web_url":"https://patchwork.libcamera.org/patch/15659/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220408105439.144182-2-umang.jain@ideasonboard.com>","date":"2022-04-08T10:54:38","name":"[libcamera-devel,1/2] ipa: vimc: Establish logical order of operations","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"159c16a9f94122fbbddc96f15e4b26ab7e427442","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15659/mbox/","series":[{"id":3046,"url":"https://patchwork.libcamera.org/api/series/3046/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3046","date":"2022-04-08T10:54:37","name":"VIMC IPA nitpicks","version":1,"mbox":"https://patchwork.libcamera.org/series/3046/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15659/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15659/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB4F0C3260\n\tfor ;\n\tFri, 8 Apr 2022 10:54:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7ADF565641;\n\tFri, 8 Apr 2022 12:54:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1C8065640\n\tfor ;\n\tFri, 8 Apr 2022 12:54:49 +0200 (CEST)","from perceval.ideasonboard.com (unknown [27.57.186.178])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BCF39499;\n\tFri, 8 Apr 2022 12:54:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649415291;\n\tbh=16RTJpVFXa8IWys/5ynUQcpwASj3qYWNZxSeYsJhrhI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=sn1uvLY5zb5IwiFsy5NJkD2ZTOLsKFUuW2vajKs1EoPrvKgXCxNaRefEX1D+g6vra\n\tQJbRfu/313R0lGPb0bGBxMI+Bvy0DFyKI1/MbKo0lIWIDu0OnTUDh2f7s5WFzmUOU+\n\tn+FCvw1cm2XQxf1G3sj5ZOKt6liOPqJHBKu/uuzhnbrKRS5wGGsBAdQ+Mc77LCov7n\n\tkTdGaOK/S+bgwkiwnpa6qL4WHmVuUXGahbtdazY7hLb8jSh9LE87ZjpNscbSpeNOeF\n\tYYYsAf2EdEErV625r8MfwtC93GuQU9nbdQYsNuAjhiV5/u6zHsMtupwFbg4ijSUL/M\n\tfZX8fMIHMwfSw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649415289;\n\tbh=16RTJpVFXa8IWys/5ynUQcpwASj3qYWNZxSeYsJhrhI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VcYxtLSz94GrMzbGDg80L/lajvKYMdCgynV6ftr1K7PIEZHgL6J+MVbjJFCk3hC8x\n\tH+xT/LzC+xhIGvc+ElO4mnHRLeGwc92LD/Sz0+6jTRA9zLHtyers2Vrcj77ndVHZSk\n\tL0tdXRAIss6NOmSEdagiSTtblaCayWbQ1kvOpZmI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VcYxtLSz\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 8 Apr 2022 16:24:38 +0530","Message-Id":"<20220408105439.144182-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20220408105439.144182-1-umang.jain@ideasonboard.com>","References":"<20220408105439.144182-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] ipa: vimc: Establish logical order of\n\toperations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"It is preferred that the interface definition should represent\nthe logical order in which the operations will be called.\n\nThe patch has no functional changes.\n\nSigned-off-by: Umang Jain \n---\n include/libcamera/ipa/vimc.mojom | 2 +-\n src/ipa/vimc/vimc.cpp | 12 ++++++------\n 2 files changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/include/libcamera/ipa/vimc.mojom b/include/libcamera/ipa/vimc.mojom\nindex e5ac3609..cdc03ffb 100644\n--- a/include/libcamera/ipa/vimc.mojom\n+++ b/include/libcamera/ipa/vimc.mojom\n@@ -30,6 +30,7 @@ interface IPAVimcInterface {\n \tmapBuffers(array buffers);\n \tunmapBuffers(array ids);\n \n+\t[async] queueRequest(uint32 frame, libcamera.ControlList controls);\n \t/*\n \t * The vimc driver doesn't use parameters buffers. To maximize coverage\n \t * of unit tests that rely on the VIMC pipeline handler, we still define\n@@ -37,7 +38,6 @@ interface IPAVimcInterface {\n \t * handle parameters at runtime.\n \t */\n \t[async] fillParams(uint32 frame, uint32 bufferId);\n-\t[async] queueRequest(uint32 frame, libcamera.ControlList controls);\n };\n \n interface IPAVimcEventInterface {\ndiff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\nindex 315302c6..a62e72b0 100644\n--- a/src/ipa/vimc/vimc.cpp\n+++ b/src/ipa/vimc/vimc.cpp\n@@ -43,8 +43,8 @@ public:\n \tvoid mapBuffers(const std::vector &buffers) override;\n \tvoid unmapBuffers(const std::vector &ids) override;\n \n-\tvoid fillParams(uint32_t frame, uint32_t bufferId) override;\n \tvoid queueRequest(uint32_t frame, const ControlList &controls) override;\n+\tvoid fillParams(uint32_t frame, uint32_t bufferId) override;\n \n private:\n \tvoid initTrace();\n@@ -129,6 +129,11 @@ void IPAVimc::unmapBuffers(const std::vector &ids)\n \t}\n }\n \n+void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame,\n+\t\t\t [[maybe_unused]] const ControlList &controls)\n+{\n+}\n+\n void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId)\n {\n \tauto it = buffers_.find(bufferId);\n@@ -140,11 +145,6 @@ void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId)\n \tparamsFilled.emit(bufferId);\n }\n \n-void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame,\n-\t\t\t [[maybe_unused]] const ControlList &controls)\n-{\n-}\n-\n void IPAVimc::initTrace()\n {\n \tstruct stat fifoStat;\n","prefixes":["libcamera-devel","1/2"]}