[{"id":2107,"web_url":"https://patchwork.libcamera.org/comment/2107/","msgid":"<20190702001536.GH9228@bigcity.dyn.berto.se>","date":"2019-07-02T00:15:36","subject":"Re: [libcamera-devel] [PATCH v4 06/13] libcamera: request: Add a\n\tControlList","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2019-07-01 23:14:57 +0300, Laurent Pinchart wrote:\n> From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> Provide a ControlList on request objects to facilitate setting controls.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n> Changes since v3:\n> \n> - Don't clear controls when the request completes\n> - Fixed include ordering\n> ---\n>  include/libcamera/request.h |  3 +++\n>  src/libcamera/request.cpp   | 12 +++++++++++-\n>  2 files changed, 14 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 58de6f00a554..a93468d7c8b7 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -10,6 +10,7 @@\n>  #include <map>\n>  #include <unordered_set>\n>  \n> +#include <libcamera/controls.h>\n>  #include <libcamera/signal.h>\n>  \n>  namespace libcamera {\n> @@ -32,6 +33,7 @@ public:\n>  \tRequest(const Request &) = delete;\n>  \tRequest &operator=(const Request &) = delete;\n>  \n> +\tControlList &controls() { return controls_; }\n>  \tconst std::map<Stream *, Buffer *> &buffers() const { return bufferMap_; }\n>  \tint setBuffers(const std::map<Stream *, Buffer *> &streamMap);\n>  \tBuffer *findBuffer(Stream *stream) const;\n> @@ -50,6 +52,7 @@ private:\n>  \tbool completeBuffer(Buffer *buffer);\n>  \n>  \tCamera *camera_;\n> +\tControlList controls_;\n>  \tstd::map<Stream *, Buffer *> bufferMap_;\n>  \tstd::unordered_set<Buffer *> pending_;\n>  \n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index fa3ee46da440..e749e41baa42 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -48,10 +48,20 @@ LOG_DEFINE_CATEGORY(Request)\n>   * \\param[in] camera The camera that creates the request\n>   */\n>  Request::Request(Camera *camera)\n> -\t: camera_(camera), status_(RequestPending)\n> +\t: camera_(camera), controls_(camera), status_(RequestPending)\n>  {\n>  }\n>  \n> +/**\n> + * \\fn Request::controls()\n> + * \\brief Retrieve the request's ControlList\n> + *\n> + * Return a reference to the ControlList that stores all the controls relevant\n> + * to this request.\n> + *\n> + * \\return A reference to the ControlList in this request\n> + */\n> +\n>  /**\n>   * \\fn Request::buffers()\n>   * \\brief Retrieve the request's streams to buffers map\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 117C560C2B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  2 Jul 2019 02:15:38 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id a9so10025119lff.7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 01 Jul 2019 17:15:38 -0700 (PDT)","from localhost (customer-145-14-112-32.stosn.net. [145.14.112.32])\n\tby smtp.gmail.com with ESMTPSA id\n\tr2sm2762073lfi.51.2019.07.01.17.15.36\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 01 Jul 2019 17:15:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=Hw6uDrE6EtYNd8VzJ6x1/Tv8SbX7u29SuVvyklIykUk=;\n\tb=S4xBu6iRfApm+Vhg7Lprjy0s9NilqkkBnry+snbWYiYXVMojsiHURX0S97eu2U4KoO\n\t3pibckUzIV4a2yIpswL47aVXYpntUup65aNOVzNoDJqDNqtQNTqtrRFEzQr8ZPGk0lOp\n\t0sXvrpJesZXqU2RXx/aFnwaiRJRUP+PGOaJIiI+Pjz1egYUTrVTKPQSpu7sjoydO8HpB\n\thAYwINmQLKex+Gk0u89VTGuZOIf8MrMCGARAm3oOMscqsZAQ+AgSrE27daogNPwuRJcQ\n\tYx8vkWkqezSexdAkmQLcZ9zHfj9i0AFZg0OFYamZw0YEv81RFaKp5dm5FSihpqz+0HvJ\n\tKAFw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=Hw6uDrE6EtYNd8VzJ6x1/Tv8SbX7u29SuVvyklIykUk=;\n\tb=GjfJvXb87h1YvLo9aDHmQT20XyBBsfQHFxrSpYyQiyyGoDFYjQ28l4fGUYxzilHmZE\n\tpfOg6cms4/cOCvlkUxCIYrh4lhDQLoHINknyWBWo800gx9w9A68JqBCIylqmx69oBgE3\n\taSbl1Zo49CXAzdwBGeS/YAV2dLo59wFY6l08l1dgyqphicHRYSBHXbJh+UFPHs+hkSxp\n\t/bvqaAYvrPQaLDwqvfp5cO7s7d34tECEJsgEHHJInx8HZ103QCpZHw1+6S7zVHuhehqu\n\tHHeop9OE/H7EOl21GIgUjOTI2vefrdgVxhi5p8kRDwMo64+CARwOLhIuiUPn9pAS1iiS\n\t9DIA==","X-Gm-Message-State":"APjAAAVsKskD0JjgzjRdbz4OAk27B5sEwKr1+zgF/oleVxE8RmezwepE\n\tykN36PPqoVHnWHCFys9nHcvOF1Zp3GU=","X-Google-Smtp-Source":"APXvYqz+p6KU0hJihtRWilvGN5Eyz7FF0c/jM8VMfiVTX6Ku4LeeKHbhme2gmuJsJBG8nkgc6t4hxg==","X-Received":"by 2002:a19:c78b:: with SMTP id\n\tx133mr12624180lff.85.1562026537557; \n\tMon, 01 Jul 2019 17:15:37 -0700 (PDT)","Date":"Tue, 2 Jul 2019 02:15:36 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190702001536.GH9228@bigcity.dyn.berto.se>","References":"<20190701201504.28487-1-laurent.pinchart@ideasonboard.com>\n\t<20190701201504.28487-7-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190701201504.28487-7-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v4 06/13] libcamera: request: Add a\n\tControlList","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 02 Jul 2019 00:15:38 -0000"}},{"id":2120,"web_url":"https://patchwork.libcamera.org/comment/2120/","msgid":"<27375b8c-719b-f405-5521-fffd4f45e1e4@ideasonboard.com>","date":"2019-07-02T07:55:49","subject":"Re: [libcamera-devel] [PATCH v4 06/13] libcamera: request: Add a\n\tControlList","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 01/07/2019 21:14, Laurent Pinchart wrote:\n> From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> Provide a ControlList on request objects to facilitate setting controls.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> ---\n> Changes since v3:\n> \n> - Don't clear controls when the request completes\n> - Fixed include ordering\n> ---\n>  include/libcamera/request.h |  3 +++\n>  src/libcamera/request.cpp   | 12 +++++++++++-\n>  2 files changed, 14 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 58de6f00a554..a93468d7c8b7 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -10,6 +10,7 @@\n>  #include <map>\n>  #include <unordered_set>\n>  \n> +#include <libcamera/controls.h>\n>  #include <libcamera/signal.h>\n>  \n>  namespace libcamera {\n> @@ -32,6 +33,7 @@ public:\n>  \tRequest(const Request &) = delete;\n>  \tRequest &operator=(const Request &) = delete;\n>  \n> +\tControlList &controls() { return controls_; }\n>  \tconst std::map<Stream *, Buffer *> &buffers() const { return bufferMap_; }\n>  \tint setBuffers(const std::map<Stream *, Buffer *> &streamMap);\n>  \tBuffer *findBuffer(Stream *stream) const;\n> @@ -50,6 +52,7 @@ private:\n>  \tbool completeBuffer(Buffer *buffer);\n>  \n>  \tCamera *camera_;\n> +\tControlList controls_;\n>  \tstd::map<Stream *, Buffer *> bufferMap_;\n>  \tstd::unordered_set<Buffer *> pending_;\n>  \n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index fa3ee46da440..e749e41baa42 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -48,10 +48,20 @@ LOG_DEFINE_CATEGORY(Request)\n>   * \\param[in] camera The camera that creates the request\n>   */\n>  Request::Request(Camera *camera)\n> -\t: camera_(camera), status_(RequestPending)\n> +\t: camera_(camera), controls_(camera), status_(RequestPending)\n>  {\n>  }\n>  \n> +/**\n> + * \\fn Request::controls()\n> + * \\brief Retrieve the request's ControlList\n> + *\n> + * Return a reference to the ControlList that stores all the controls relevant\n> + * to this request.\n> + *\n\n\nHow about extending this with the following::\n  <quoted to preserve formatting due to thunderbird>\n\n> + * Controls can be updated directly in this list using the [] operator, or a\n> + * pre-defined ControlList can be merged into this request using the update()\n> + * operation.\n> + *\n> + * Only controls which are supported by the Camera to which this request will be\n> + * submitted should be configured in the Requests ControlList. Configuration for\n> + * unsupported controls may be ignored or cause undefined behaviour.\n> + *\n\n\n--\nKieran\n\n\n\n> + * \\return A reference to the ControlList in this request\n> + */\n> +\n>  /**\n>   * \\fn Request::buffers()\n>   * \\brief Retrieve the request's streams to buffers map\n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1082660C01\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  2 Jul 2019 09:55:53 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 77A882C6;\n\tTue,  2 Jul 2019 09:55:52 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562054152;\n\tbh=Ersk61bIAVb/Y8xPCJGpdB2fmDahIrEICXmXLzxQV3o=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=sX8K5pJVo+1AghULW3X2LL/b7hats5GJVeepj3ETxAIlj2K1ADw86qE2hw/a/bVJz\n\tiuUxPQRFuYv4XkU7OTGaPHTYc70vgqDJmMWuNc7NH9wN/YDTgHcn04ltKsB2mhpyDy\n\tuLsbsECFzfZdtbpLM6wdmH9WZhqK4+6yqgJwowFo=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190701201504.28487-1-laurent.pinchart@ideasonboard.com>\n\t<20190701201504.28487-7-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<27375b8c-719b-f405-5521-fffd4f45e1e4@ideasonboard.com>","Date":"Tue, 2 Jul 2019 08:55:49 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.0","MIME-Version":"1.0","In-Reply-To":"<20190701201504.28487-7-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v4 06/13] libcamera: request: Add a\n\tControlList","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 02 Jul 2019 07:55:53 -0000"}}]