[{"id":22642,"web_url":"https://patchwork.libcamera.org/comment/22642/","msgid":"<20220407111511.GI3237525@pyrite.rasen.tech>","date":"2022-04-07T11:15:11","subject":"Re: [libcamera-devel] [PATCH 1/3] test: v4l2_videodevice:\n\tdequeue_watchdog: Log message on failures","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn Thu, Apr 07, 2022 at 11:37:17AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Failing a test without an error message makes it difficult to debug\n> issues. Add a message when buffer allocation fails.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> test/v4l2_videodevice/dequeue_watchdog.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/test/v4l2_videodevice/dequeue_watchdog.cpp b/test/v4l2_videodevice/dequeue_watchdog.cpp\n> index 0cb4de6f81a0..2282e3958c03 100644\n> --- a/test/v4l2_videodevice/dequeue_watchdog.cpp\n> +++ b/test/v4l2_videodevice/dequeue_watchdog.cpp\n> @@ -33,8 +33,10 @@ protected:\n> \t\tTimer timeout;\n> \n> \t\tint ret = capture_->allocateBuffers(bufferCount, &buffers_);\n> -\t\tif (ret < 0)\n> +\t\tif (ret < 0) {\n> +\t\t\tstd::cout << \"Failed to allocate buffers\" << std::endl;\n> \t\t\treturn TestFail;\n> +\t\t}\n> \n> \t\tcapture_->dequeueTimeout.connect(this, &DequeueWatchdogTest::barkCounter);\n> \t\tcapture_->setDequeueTimeout(5ms);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5A65C0F1B\n\tfor ;\n\tThu, 7 Apr 2022 11:15:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93EB865642;\n\tThu, 7 Apr 2022 13:15:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF7E26563F\n\tfor ;\n\tThu, 7 Apr 2022 13:15:18 +0200 (CEST)","from pyrite.rasen.tech (softbank036240056250.bbtec.net\n\t[36.240.56.250])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EA85499;\n\tThu, 7 Apr 2022 13:15:17 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649330120;\n\tbh=5YoPZLBauv94S9wWSg55gkJw93B19J18YB64GMGnbBE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=nTZ65kgzJ2YcsK6/9lQcblGgy9/IyMYUp96tisztxEGgCO0Le3qA2kbnkRqlRQS/D\n\tGYDPjY8ggfvK+ny5S5Tzv9vFD3vTwlRp85yCXhJBFCCdQ9a+3bCEQsbXyD0hRT6H+k\n\tKU23zQkczsx2YVCU3iaTffQNfte4yXtdPnMcnzw5pl4zir2Q1LCEt3051Shzr2IvCS\n\tisJyi1toKcTay79ShiX+RCcO1xcUCt6hSzSBYlkYKOR+jM76Xzx/OfeoP4pH9HxrSV\n\ts/WcGWEgbDUp4dx/4jnTo2hfgQDw8MlVS21fVjvbywcm+Payr/ghVjVb2vNDrwrIqx\n\ti6k/jAkuwL63g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649330118;\n\tbh=5YoPZLBauv94S9wWSg55gkJw93B19J18YB64GMGnbBE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LTCNrny1RvX5pbKq8W8yPIIGSjqqQzo0SMuRXRlnMnPMJDy82nMMJtqbb/QCd7dXg\n\tZmewCYNIUlGjcuz7FXS2a/uH/xM8xJw49zgpwIVQgxbPaziG1rX0RCXhJ/kJm35yqP\n\t+X0b7EY8tdsmD84TVzrsVr+qgNM3yD7HNky//7Hc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"LTCNrny1\"; dkim-atps=neutral","Date":"Thu, 7 Apr 2022 20:15:11 +0900","To":"Laurent Pinchart ","Message-ID":"<20220407111511.GI3237525@pyrite.rasen.tech>","References":"<20220407083719.21631-1-laurent.pinchart@ideasonboard.com>\n\t<20220407083719.21631-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220407083719.21631-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] test: v4l2_videodevice:\n\tdequeue_watchdog: Log message on failures","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]