{"id":15647,"url":"https://patchwork.libcamera.org/api/patches/15647/?format=json","web_url":"https://patchwork.libcamera.org/patch/15647/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220407083719.21631-2-laurent.pinchart@ideasonboard.com>","date":"2022-04-07T08:37:17","name":"[libcamera-devel,1/3] test: v4l2_videodevice: dequeue_watchdog: Log message on failures","commit_ref":"dd76f8e11b0f7ad5fa5d51ff8e26727536db948f","pull_url":null,"state":"accepted","archived":false,"hash":"15a0a84adda03a516009be671c22578ea7b4350b","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15647/mbox/","series":[{"id":3042,"url":"https://patchwork.libcamera.org/api/series/3042/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3042","date":"2022-04-07T08:37:16","name":"test: Fix dequeue_watchdog test failure when running the whole test suite","version":1,"mbox":"https://patchwork.libcamera.org/series/3042/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15647/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15647/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6449C0F1B\n\tfor ;\n\tThu, 7 Apr 2022 08:37:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 721AD6563E;\n\tThu, 7 Apr 2022 10:37:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A7E06563E\n\tfor ;\n\tThu, 7 Apr 2022 10:37:26 +0200 (CEST)","from localhost.localdomain (117.145-247-81.adsl-dyn.isp.belgacom.be\n\t[81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1BAA2883\n\tfor ;\n\tThu, 7 Apr 2022 10:37:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649320649;\n\tbh=fi/9yKryU+uYgr2qXqKJWw9UtagfjacSp2NxJOxQgpA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ixD63K+ES3lOLFbb2/zn6Oj73WwBhOg+cSk1WToyMq5fp09L4bGnDHdMzDhzpLF+k\n\tSbBsX+plQfsmxBOkQjX+czTh0Epa1gVtTdPY1FNVqPf2S8YdVV86pcRxCatKn5xOkb\n\toZxy6VKh9xKj/VNjhIuFjOmgEtCGMEUlqOqUZIy3/JeAx2Y4zcdgg3TB3RWVRvJ2Iy\n\tFfCJb/C7lytdGPr1QB6QkiK0m+oEMvDVqRpvPnGh0y8wgV8tsw0cPbnXrjxi+AwV5D\n\tCLi4+kl9XR9zGYkpR4ELvHivaWaNKvMfqirNwe/uvO2b/0BObQy/oXR7NXHWO4tlWf\n\tAsdlJh3wPUk8Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649320646;\n\tbh=fi/9yKryU+uYgr2qXqKJWw9UtagfjacSp2NxJOxQgpA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=YiMoM+G2B+FK5f62YbxiidfkTNADN5RboFXtXwXo5D8JRcA2rCIm1YZnbWQwsXbXk\n\ta3lAE+d04/BWL87eudg8J8Pw9OXtOt8/fusEA4JMFRX/9ctpBxU/geuRuDZsEsOlYv\n\tbzephUlpzmt3IGV2WptFfJmVQr0c6ygE/oBTZTlE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YiMoM+G2\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 7 Apr 2022 11:37:17 +0300","Message-Id":"<20220407083719.21631-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220407083719.21631-1-laurent.pinchart@ideasonboard.com>","References":"<20220407083719.21631-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/3] test: v4l2_videodevice:\n\tdequeue_watchdog: Log message on failures","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Failing a test without an error message makes it difficult to debug\nissues. Add a message when buffer allocation fails.\n\nSigned-off-by: Laurent Pinchart \n---\n test/v4l2_videodevice/dequeue_watchdog.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/test/v4l2_videodevice/dequeue_watchdog.cpp b/test/v4l2_videodevice/dequeue_watchdog.cpp\nindex 0cb4de6f81a0..2282e3958c03 100644\n--- a/test/v4l2_videodevice/dequeue_watchdog.cpp\n+++ b/test/v4l2_videodevice/dequeue_watchdog.cpp\n@@ -33,8 +33,10 @@ protected:\n \t\tTimer timeout;\n \n \t\tint ret = capture_->allocateBuffers(bufferCount, &buffers_);\n-\t\tif (ret < 0)\n+\t\tif (ret < 0) {\n+\t\t\tstd::cout << \"Failed to allocate buffers\" << std::endl;\n \t\t\treturn TestFail;\n+\t\t}\n \n \t\tcapture_->dequeueTimeout.connect(this, &DequeueWatchdogTest::barkCounter);\n \t\tcapture_->setDequeueTimeout(5ms);\n","prefixes":["libcamera-devel","1/3"]}