[{"id":22637,"web_url":"https://patchwork.libcamera.org/comment/22637/","msgid":"","date":"2022-04-07T07:22:29","subject":"Re: [libcamera-devel] [PATCH v1.1] libcamera: v4l2_videodevice: Fix\n\tuninitialised watchdogDuration_","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Thu, Apr 07, 2022 at 09:24:09AM +0530, Umang Jain wrote:\n> Initialise the watchdogDuration_ member to 0ms before it is used\n> in rest of the code base. Failing to do so, spews out log warnings\n> regarding dequeue timer being expired.\n> \n> Fixes: 16f3d2de50ff (\"libcamera: v4l2_videodevice: Add a dequeue timer\")\n> Signed-off-by: Umang Jain \n> Reviewed-by: Naushir Patuck \n> Reviewed-by: Laurent Pinchart \n> ---\n> - Rebased over \"libcamera: base: utils: Add missing constructor for\n> Duration\"\n> ---\n> src/libcamera/v4l2_videodevice.cpp | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 634ac4a5..87976fb2 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -39,6 +39,8 @@\n> \n> namespace libcamera {\n> \n> +using namespace std::literals::chrono_literals;\n> +\n\nYou can drop this now. I'll apply the patch with this change removed.\n\n> LOG_DECLARE_CATEGORY(V4L2)\n> \n> /**\n> @@ -520,7 +522,8 @@ const std::string V4L2DeviceFormat::toString() const\n> */\n> V4L2VideoDevice::V4L2VideoDevice(const std::string &deviceNode)\n> \t: V4L2Device(deviceNode), formatInfo_(nullptr), cache_(nullptr),\n> -\t fdBufferNotifier_(nullptr), state_(State::Stopped)\n> +\t fdBufferNotifier_(nullptr), state_(State::Stopped),\n> +\t watchdogDuration_(0.0)\n> {\n> \t/*\n> \t * We default to an MMAP based CAPTURE video device, however this will","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CDE14C0F1B\n\tfor ;\n\tThu, 7 Apr 2022 07:22:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F3A56563E;\n\tThu, 7 Apr 2022 09:22:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4A1961FBB\n\tfor ;\n\tThu, 7 Apr 2022 09:22:33 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 38460499;\n\tThu, 7 Apr 2022 09:22:33 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649316155;\n\tbh=UGqDLhgC4klRdvDXpmx1AOIWQXFCc8IPOLf3uhJpn5s=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2x8EdNRH0bxqCIad9Pi2UU9tCHPANQmiHdQyY3qqT5AH+ln0sC0b4f+p6lFHu7irD\n\t3qTjktZWq+5O0gq2h1nPjM2l50t9IZEqga7gRZoxzpskUIBUYIW+VJ+SOggyxZvCTI\n\tsTytru7A65OV23NF1A89Na5MGOw2w8fWGJfgsF0rntJgJuBzJ+1zyhdQV4VNoMHNwj\n\t0OZw8AGyoIPBsMFqBLhhQW4chE1HerSgn2K2rPy5+PSoQDrT7pDnsAMI4O9Snwp/xv\n\tPxgG7L3W3+/2giwllVEDeQK18rzlXjhC6VmepxyTAEgExwwxY3wJx4/yYMQvLwsZu0\n\ttQIgO5/4VOpIw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649316153;\n\tbh=UGqDLhgC4klRdvDXpmx1AOIWQXFCc8IPOLf3uhJpn5s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NJQA0z62tGmFsunYVmm7h8BDoV0cuPzRElJsxRrbJRVER5mx7AlwTLxPoCH9tvUKM\n\tmuY6X4bDHTy3FwhsKGw3kGcFq9wfykim7qJbEZLkVIky3fy1twjh5wNuB5j/VGX3u/\n\tbTngbq70dYO8PyElKznd0WVrrajBmMeZ0hzBy0aQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NJQA0z62\"; dkim-atps=neutral","Date":"Thu, 7 Apr 2022 10:22:29 +0300","To":"Umang Jain ","Message-ID":"","References":"<20220406144553.193858-1-umang.jain@ideasonboard.com>\n\t<20220407035409.226233-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220407035409.226233-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1.1] libcamera: v4l2_videodevice: Fix\n\tuninitialised watchdogDuration_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]