{"id":15645,"url":"https://patchwork.libcamera.org/api/patches/15645/?format=json","web_url":"https://patchwork.libcamera.org/patch/15645/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220407035409.226233-1-umang.jain@ideasonboard.com>","date":"2022-04-07T03:54:09","name":"[libcamera-devel,v1.1] libcamera: v4l2_videodevice: Fix uninitialised watchdogDuration_","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"34b32c8b89433afc25706642e491392979e0f067","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15645/mbox/","series":[{"id":3041,"url":"https://patchwork.libcamera.org/api/series/3041/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3041","date":"2022-04-07T03:54:09","name":"[libcamera-devel,v1.1] libcamera: v4l2_videodevice: Fix uninitialised watchdogDuration_","version":1,"mbox":"https://patchwork.libcamera.org/series/3041/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15645/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15645/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDA79C3256\n\tfor ;\n\tThu, 7 Apr 2022 03:54:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 23EDF65642;\n\tThu, 7 Apr 2022 05:54:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C845604B5\n\tfor ;\n\tThu, 7 Apr 2022 05:54:29 +0200 (CEST)","from perceval.ideasonboard.com (unknown [27.57.186.178])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A98830C;\n\tThu, 7 Apr 2022 05:54:27 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649303671;\n\tbh=W6n0r9wR+Y5exH+LYn0ebECnZfe2YWnYAGVHuV5v54M=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=S5Ww80TVkpxwgE/wsPAJucAViB+UqkIw2pHFKyRMbcwW+FbkXIpZ5s01iVD/uipn3\n\tI/VrAXLYWUO6ySommdJRkiFmrSLlD7Ok5snVOG/YFdk5p1zEX/KZ2rfDYAlIT+k0j8\n\tuiHp0GBiiFnzqmGSpJQG3RbukY2m62JNCaoVZ9DC8hv2ek1E38kkDm39fYLVL2nGHc\n\tF4G4jhkFcp7ZiNs3o40FDAan8vB7xknuZ/nWVpyDwlriAskmv9RZTbkN1oU2E/ntPM\n\ti4utuB17hI2+NnIsxiCdat/pCorpZRUaHsW5mCaFQK0Ltl05Zb7g9GXYyB9YVnwAFK\n\tfmhIUW5hA1O6w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649303668;\n\tbh=W6n0r9wR+Y5exH+LYn0ebECnZfe2YWnYAGVHuV5v54M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=o1YurKjNSGcaLOWTOSqEQxYsw6sajZXhC8gFmx9i/WhlvN7CYT5qL/t1fWEjNMvEJ\n\tIOL7vQiLv5DDUsNdJnTUeMfv2jkrV0Yqg/QSQhUc3lYGFxG/yL6neNGZjZJK4lNeN6\n\tNoe1yd0kDpCgcWh72p5kZiBfSZLSeERuIdWzHwLI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"o1YurKjN\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 7 Apr 2022 09:24:09 +0530","Message-Id":"<20220407035409.226233-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20220406144553.193858-1-umang.jain@ideasonboard.com>","References":"<20220406144553.193858-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1.1] libcamera: v4l2_videodevice: Fix\n\tuninitialised watchdogDuration_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Initialise the watchdogDuration_ member to 0ms before it is used\nin rest of the code base. Failing to do so, spews out log warnings\nregarding dequeue timer being expired.\n\nFixes: 16f3d2de50ff (\"libcamera: v4l2_videodevice: Add a dequeue timer\")\nSigned-off-by: Umang Jain \nReviewed-by: Naushir Patuck \nReviewed-by: Laurent Pinchart \n---\n- Rebased over \"libcamera: base: utils: Add missing constructor for\n Duration\"\n---\n src/libcamera/v4l2_videodevice.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 634ac4a5..87976fb2 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -39,6 +39,8 @@\n \n namespace libcamera {\n \n+using namespace std::literals::chrono_literals;\n+\n LOG_DECLARE_CATEGORY(V4L2)\n \n /**\n@@ -520,7 +522,8 @@ const std::string V4L2DeviceFormat::toString() const\n */\n V4L2VideoDevice::V4L2VideoDevice(const std::string &deviceNode)\n \t: V4L2Device(deviceNode), formatInfo_(nullptr), cache_(nullptr),\n-\t fdBufferNotifier_(nullptr), state_(State::Stopped)\n+\t fdBufferNotifier_(nullptr), state_(State::Stopped),\n+\t watchdogDuration_(0.0)\n {\n \t/*\n \t * We default to an MMAP based CAPTURE video device, however this will\n","prefixes":["libcamera-devel","v1.1"]}