[{"id":22632,"web_url":"https://patchwork.libcamera.org/comment/22632/","msgid":"<5f56771d-3147-fe6b-9cbc-331ce0d48291@ideasonboard.com>","date":"2022-04-06T18:05:01","subject":"Re: [libcamera-devel] [PATCH] libcamera: base: utils: Add missing\n\tconstructor for Duration","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 4/6/22 20:48, Laurent Pinchart via libcamera-devel wrote:\n> The Duration class is missing the equivalent to the\n> std::chrono::duration constructor that takes a number of ticks expressed\n> as a scalar. Fix it, which allows initializing a Duration instance to 0\n> or 0.0.\n\n\nyay,\n\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> include/libcamera/base/utils.h | 6 ++++++\n> src/libcamera/base/utils.cpp | 9 +++++++++\n> 2 files changed, 15 insertions(+)\n>\n> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> index 9ab18101cf27..cfff05836de7 100644\n> --- a/include/libcamera/base/utils.h\n> +++ b/include/libcamera/base/utils.h\n> @@ -327,6 +327,12 @@ class Duration : public std::chrono::duration\n> public:\n> \tDuration() = default;\n> \n> +\ttemplate\n> +\tconstexpr explicit Duration(const Rep &r)\n> +\t\t: BaseDuration(r)\n> +\t{\n> +\t}\n> +\n> \ttemplate\n> \tconstexpr Duration(const std::chrono::duration &d)\n> \t\t: BaseDuration(d)\n> diff --git a/src/libcamera/base/utils.cpp b/src/libcamera/base/utils.cpp\n> index 8cf8a5b2c104..6a307940448e 100644\n> --- a/src/libcamera/base/utils.cpp\n> +++ b/src/libcamera/base/utils.cpp\n> @@ -406,6 +406,15 @@ std::string toAscii(const std::string &str)\n> * duration in nanoseconds with double precision\n> */\n> \n> +/**\n> + * \\fn Duration::Duration(const Rep &r)\n> + * \\brief Construct a Duration with \\a r ticks\n> + * \\param[in] r The number of ticks\n> + *\n> + * The constructed \\a Duration object is internally represented in double\n> + * precision with \\a r nanoseconds ticks.\n> + */\n> +\n> /**\n> * \\fn Duration::Duration(const std::chrono::duration &d)\n> * \\brief Construct a Duration by converting an arbitrary std::chrono::duration","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2F82C3256\n\tfor ;\n\tWed, 6 Apr 2022 18:05:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0753265642;\n\tWed, 6 Apr 2022 20:05:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED355604B8\n\tfor ;\n\tWed, 6 Apr 2022 20:05:07 +0200 (CEST)","from [192.168.1.110] (unknown [27.57.186.178])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D66FF482;\n\tWed, 6 Apr 2022 20:05:06 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649268309;\n\tbh=Als3tTSAcPdHurRy5BR6JdAjTe+b+HJZ6BySvZfX/KU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=rQs1jxdu1lGnB0mzT9DEZ/6XZMh3izlA2eyGxDImtyACvVdTv3xWEWIyCIVh0mN+D\n\tN2a/as6IWzQYjmMhqv/K+ZIARBqs+Xfxat8Vsa2pC+TvaYtOuUlB1RgR0eHjji74Vn\n\tSzS1Z9xrlOOaI0BR1/QR33KMxP26MoKLlV/wYNlkysU8WcrI4OkbSvG+BNMLCEJxg/\n\tZkk+ihnJjRX3CEYGBKKk0iHiZ9qTs8JOYvrLe4BTxNRycI3AVNl51oJFPOujjp4VEh\n\twPdMA9cBF4IQ3MK4x18a6f6ZhnnxkuR7gnSGVAHL/0AmsatSkFhVk8tQ7buk43mVOR\n\ti8Nd/yh/nbXfg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649268307;\n\tbh=Als3tTSAcPdHurRy5BR6JdAjTe+b+HJZ6BySvZfX/KU=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=stislH+piICs7o5nPaZdgJRbZZPqCxpcaU+c8XQaT2SnO/bg0LRgiBVH6QWgIN8FL\n\tGXWGdHK7z5Mok8D7MFF/sg2GPKZnsz1jAivgh0Lnqt6/EZZFmjOypCdBGcmJwp3Lg6\n\tX4O0bYH89uy+ZjgrkyYSL+qikDnZCzHW1PtcrBxU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"stislH+p\"; dkim-atps=neutral","Message-ID":"<5f56771d-3147-fe6b-9cbc-331ce0d48291@ideasonboard.com>","Date":"Wed, 6 Apr 2022 23:35:01 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220406151833.1176-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220406151833.1176-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: base: utils: Add missing\n\tconstructor for Duration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22635,"web_url":"https://patchwork.libcamera.org/comment/22635/","msgid":"<164927160334.4051137.5348754025233490441@Monstersaurus>","date":"2022-04-06T19:00:03","subject":"Re: [libcamera-devel] [PATCH] libcamera: base: utils: Add missing\n\tconstructor for Duration","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-04-06 16:18:33)\n> The Duration class is missing the equivalent to the\n> std::chrono::duration constructor that takes a number of ticks expressed\n> as a scalar. Fix it, which allows initializing a Duration instance to 0\n> or 0.0.\n> \n\nSounds good. 0ms 0s and 0years are all the same when initialising so 0\nand 0.0 seems good to me ;-)\n\n\nReviewed-by: Kieran Bingham \n\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/base/utils.h | 6 ++++++\n> src/libcamera/base/utils.cpp | 9 +++++++++\n> 2 files changed, 15 insertions(+)\n> \n> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> index 9ab18101cf27..cfff05836de7 100644\n> --- a/include/libcamera/base/utils.h\n> +++ b/include/libcamera/base/utils.h\n> @@ -327,6 +327,12 @@ class Duration : public std::chrono::duration\n> public:\n> Duration() = default;\n> \n> + template\n> + constexpr explicit Duration(const Rep &r)\n> + : BaseDuration(r)\n> + {\n> + }\n> +\n> template\n> constexpr Duration(const std::chrono::duration &d)\n> : BaseDuration(d)\n> diff --git a/src/libcamera/base/utils.cpp b/src/libcamera/base/utils.cpp\n> index 8cf8a5b2c104..6a307940448e 100644\n> --- a/src/libcamera/base/utils.cpp\n> +++ b/src/libcamera/base/utils.cpp\n> @@ -406,6 +406,15 @@ std::string toAscii(const std::string &str)\n> * duration in nanoseconds with double precision\n> */\n> \n> +/**\n> + * \\fn Duration::Duration(const Rep &r)\n> + * \\brief Construct a Duration with \\a r ticks\n> + * \\param[in] r The number of ticks\n> + *\n> + * The constructed \\a Duration object is internally represented in double\n> + * precision with \\a r nanoseconds ticks.\n> + */\n> +\n> /**\n> * \\fn Duration::Duration(const std::chrono::duration &d)\n> * \\brief Construct a Duration by converting an arbitrary std::chrono::duration\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09814C0F1B\n\tfor ;\n\tWed, 6 Apr 2022 19:00:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 60837633A4;\n\tWed, 6 Apr 2022 21:00:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C113604B8\n\tfor ;\n\tWed, 6 Apr 2022 21:00:06 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 140E5482;\n\tWed, 6 Apr 2022 21:00:06 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649271608;\n\tbh=vmLaT5cezPDVn/5hzTZSxT490+L0Ur9hGDze+MjJj7w=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=0RNXoX9XlhwGGCO3btlzoPtMqAuUpNYlYqGpeB/gNQ07tyXlUaZceoPm20w2PURFS\n\t+voeScmlwqKPAEVUrO9/MkK63Y5prU0ZGVHVapDWO0AOnJXUcquWU9nVvqma95mR4C\n\tSmssXdnyFzorq/joNqPPgwGcIFK0LYW1aTg94ltvuNb+35Hf9qPx6O9O3xpMFI0dGU\n\tFsOgnPUApJT5bnJylBcAXPpJX4hdDI8s9R38FIwSJ8Gl+q0vjM9INgCYC4K32tcCrj\n\tO2EJ53CG33R4POk8YKi2T3qTyqlQW6j5wNYGPsbMEqDh665VJkTWAElXr/v61wTMUT\n\topnuHQbWJ2TrQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649271606;\n\tbh=vmLaT5cezPDVn/5hzTZSxT490+L0Ur9hGDze+MjJj7w=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=WEH6xjIWhX4AnUC7ltnLOVyOwvbgToW5Vhu8WbwxU1Df5/ENEh8JEvj7aXYO0sNDR\n\ttkiXXRraT5SM0xdNoISCsgN9HKW1hTqIcxKP5CNgPBvbuispJCFZRlj58D8x29+kC/\n\tkgM7jUlPi23KO/H4dtPTEiymkZ/1u1UefLiPyvv8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WEH6xjIW\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220406151833.1176-1-laurent.pinchart@ideasonboard.com>","References":"<20220406151833.1176-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 06 Apr 2022 20:00:03 +0100","Message-ID":"<164927160334.4051137.5348754025233490441@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: base: utils: Add missing\n\tconstructor for Duration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]