[{"id":22622,"web_url":"https://patchwork.libcamera.org/comment/22622/","msgid":"","date":"2022-04-06T12:42:31","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Fix typo\n\tin a comment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Wed, Apr 06, 2022 at 01:38:05PM +0100, Naushir Patuck via libcamera-devel wrote:\n> s/prevetn/prevent/\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/v4l2_videodevice.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 0830be80c553..98671509fe02 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1715,7 +1715,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer()\n> \t * not find it in the queuedBuffers_ list.\n> \t *\n> \t * Whilst this kernel bug has been fixed in mainline, ensure that we\n> -\t * safely ingore buffers which are unexpected to prevetn crashes on\n> +\t * safely ingore buffers which are unexpected to prevent crashes on\n\nWhile at it, s/ingore/ignore/ ? :-) I'll fix that locally.\n\nReviewed-by: Laurent Pinchart \n\n> \t * older kernels.\n> \t */\n> \tauto it = queuedBuffers_.find(buf.index);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27DA8C3256\n\tfor ;\n\tWed, 6 Apr 2022 12:42:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6EE9F65643;\n\tWed, 6 Apr 2022 14:42:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C065D604B8\n\tfor ;\n\tWed, 6 Apr 2022 14:42:35 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 62ADE482;\n\tWed, 6 Apr 2022 14:42:35 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649248957;\n\tbh=6c7OuVGtwr4jDDE4ok8HWPJ+yVJITYX8z+EPWMDY6oo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=LynJwdyEhRqMs6XatrKkjJzU5MqMRgQlLa8BJ6STbfoLGftAF7rv4YrU8fV7ZYZy6\n\tqiVg1NmAqg9nlGmrMNbbwmn14G5Yk/zXuvlR691V7g9Gzc63elZNsIsUftQD1lrQVU\n\teRJ6A7IeWmIZpjMjKWI7oD9MXxJIJpu/0t7gsUxmgj/W83oTMn40KLAz+iv4xiYmWX\n\t4oec3v92p5+XrAfN0VbXVS6rFoRQW5xYlKccAtqvcroovxAPGePwHIY1Gd+/vZLopm\n\tl2R7S5kSut4HWcRn5Uedxs5DQAtpNFQEX83Q/78MdGo8pkqDXAwDzpVMvdSznlMn33\n\tzDAcm/Kfj8XFQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649248955;\n\tbh=6c7OuVGtwr4jDDE4ok8HWPJ+yVJITYX8z+EPWMDY6oo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=r+AMDIFlrVpgNXUhbM4ePgaa1e6mwCktlO24hdHbJR+xSelu6WZ8JbJ3o7/NrUSy3\n\tQOYPTcg0L59Waatv3WSCFCusmqKDGAb8emGrzEsFQwR/7p59tVAQxDBEU3ARj1/Gz2\n\tn+kGuE2HQMfbFvNQavHXgTxHAY7llkquxb4FHBc8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"r+AMDIFl\"; dkim-atps=neutral","Date":"Wed, 6 Apr 2022 15:42:31 +0300","To":"Naushir Patuck ","Message-ID":"","References":"<20220406123805.4045928-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220406123805.4045928-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Fix typo\n\tin a comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22623,"web_url":"https://patchwork.libcamera.org/comment/22623/","msgid":"","date":"2022-04-06T12:45:29","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Fix typo\n\tin a comment","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Wed, 6 Apr 2022 at 13:42, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Wed, Apr 06, 2022 at 01:38:05PM +0100, Naushir Patuck via\n> libcamera-devel wrote:\n> > s/prevetn/prevent/\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/libcamera/v4l2_videodevice.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/v4l2_videodevice.cpp\n> b/src/libcamera/v4l2_videodevice.cpp\n> > index 0830be80c553..98671509fe02 100644\n> > --- a/src/libcamera/v4l2_videodevice.cpp\n> > +++ b/src/libcamera/v4l2_videodevice.cpp\n> > @@ -1715,7 +1715,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer()\n> > * not find it in the queuedBuffers_ list.\n> > *\n> > * Whilst this kernel bug has been fixed in mainline, ensure that\n> we\n> > - * safely ingore buffers which are unexpected to prevetn crashes on\n> > + * safely ingore buffers which are unexpected to prevent crashes on\n>\n> While at it, s/ingore/ignore/ ? :-) I'll fix that locally.\n>\n\nHaha, I can't believe I missed that!\n\n\n>\n> Reviewed-by: Laurent Pinchart \n>\n> > * older kernels.\n> > */\n> > auto it = queuedBuffers_.find(buf.index);\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA60FC0F1B\n\tfor ;\n\tWed, 6 Apr 2022 12:45:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C7F365643;\n\tWed, 6 Apr 2022 14:45:47 +0200 (CEST)","from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 723FD604B8\n\tfor ;\n\tWed, 6 Apr 2022 14:45:46 +0200 (CEST)","by mail-lj1-x22b.google.com with SMTP id g24so3038078lja.7\n\tfor ;\n\tWed, 06 Apr 2022 05:45:46 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649249147;\n\tbh=STWFHBSRRWk5tt43DDK5yZC01u9EyRbK3ANM0sFsW5U=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=u2O3qbrct6/hrEdIaFk+PBtnnjtljHAiseVXjK30NSPFoiQ1XTATz9q9gbPwQVsWs\n\tjwTrgfUf08w6iNqmksBTYckjEYWy38YpNDRKGp0uwa1OLtyDNqNSwO2+cdm6sYYKG+\n\t9MSBRBGVWNIqCrUz7eaG3tQcAZy2a4+l+nMzu5bLPtZve2RE3PRx3alULLWGHi8hHq\n\tAyZu9DXZqEoSk+P2xgMqzm0IVIfcdu4tih6qGlB1VzrjMftmsDh5pBp7xeu0e3AlfA\n\tGJo361GrVBtK5GDIC62/TVo4QzcvSSXT5VNantK03ehIUczdEjYTqyjZPHhX3ZSUr3\n\tfjqlKHxjVB0KA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=m4mYMnqRWZE7y7IKjpFS7dM42KrLglpoX3hHw8vj9Z4=;\n\tb=cJMrpK7B2eE2l3uCwOfGXlgatY6lpP6P8Nr93rq1kXSWib3UqDuopqQRD233RrI8rY\n\ttYSIxjR/HwZ4OeL9xUqNNbkkYvoT3R5fS+/jmHX1R6s07RRrUTfUW1lAFRgI+lgoWIfc\n\trX3okQEOUVRXn3lKu+TUg/GRyHFZAOj9qXWZHDbyY2etCuSLmDldpLxf8nkeXmqm5FDn\n\t8MjuWy3tk4zJkM3qdFDRg5MnHmovV97JuPBD3cSNw0W08ZMPFZTuZ+bNk0cmkJ9kU0/L\n\tD+1XKUhA0q6RCMXi9trc3PlrUcmAbUFQXxtIWt23dI8e/ZiBqOm2u7ftgORmdHHj/Ns+\n\tOeog=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"cJMrpK7B\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=m4mYMnqRWZE7y7IKjpFS7dM42KrLglpoX3hHw8vj9Z4=;\n\tb=B08XJX494L8WwqYEej9upZD4ZgdMTNu6ZmhEXIbYkvUBU3RRS6WdeEBTZvyhfdcCHi\n\tfr3D9O6ZcqzCOr6XxeOTF5vI23PZpfQzG1F/4R4cGzQcjpP2hLXyipApU2KRB9k4MYUG\n\tsJkAL1DGPnvNIj4TRQPkW6B7enPFVEplgot4fC9f0O/Dh383aX5zfV/Uj2Mcqcaa6Jn6\n\t48RDe5cEPi86loBkSicvJh8AykQKhXw4OmILpzKLRkyyHAMBNTuQ5KQnnZEARapCiu7A\n\t2t7J3U73m9tLeHq3VYwUOqhZxYXSHnxGebd9qE01Q52JYT4XF/Bi3BgzAvHW78fKBCW1\n\tA5og==","X-Gm-Message-State":"AOAM530B8xOCOPX5D9F4KwBFv/l17YHurH9x7TpgbwUu4Z2MbKhfDfeC\n\thc2YJgnihaSCUugcToOh7zz5sgrd18wvxySSQwwVs+hgmWc=","X-Google-Smtp-Source":"ABdhPJzcDfRO/PN/eQB0uniNqQA4AKcxsWB6l8WrmOnqd8xhCo2QpI/LaOc8xmrd44o+baQUOpbFe1ARbTQ/J678lko=","X-Received":"by 2002:a2e:a54d:0:b0:249:8dd1:9da1 with SMTP id\n\te13-20020a2ea54d000000b002498dd19da1mr5305736ljn.372.1649249145749;\n\tWed, 06 Apr 2022 05:45:45 -0700 (PDT)","MIME-Version":"1.0","References":"<20220406123805.4045928-1-naush@raspberrypi.com>\n\t","In-Reply-To":"","Date":"Wed, 6 Apr 2022 13:45:29 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"0000000000007a964305dbfbbddc\"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Fix typo\n\tin a comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22625,"web_url":"https://patchwork.libcamera.org/comment/22625/","msgid":"","date":"2022-04-06T13:02:33","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Fix typo\n\tin a comment","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hello,\n\nOn 4/6/22 18:12, Laurent Pinchart via libcamera-devel wrote:\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Wed, Apr 06, 2022 at 01:38:05PM +0100, Naushir Patuck via libcamera-devel wrote:\n>> s/prevetn/prevent/\n>>\n>> Signed-off-by: Naushir Patuck \n>> ---\n>> src/libcamera/v4l2_videodevice.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n>> index 0830be80c553..98671509fe02 100644\n>> --- a/src/libcamera/v4l2_videodevice.cpp\n>> +++ b/src/libcamera/v4l2_videodevice.cpp\n>> @@ -1715,7 +1715,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer()\n>> \t * not find it in the queuedBuffers_ list.\n>> \t *\n>> \t * Whilst this kernel bug has been fixed in mainline, ensure that we\n>> -\t * safely ingore buffers which are unexpected to prevetn crashes on\n>> +\t * safely ingore buffers which are unexpected to prevent crashes on\n> While at it, s/ingore/ignore/ ? :-) I'll fix that locally.\n>\n> Reviewed-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n>\n>> \t * older kernels.\n>> \t */\n>> \tauto it = queuedBuffers_.find(buf.index);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2B4E1C3256\n\tfor ;\n\tWed, 6 Apr 2022 13:02:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6CF765643;\n\tWed, 6 Apr 2022 15:02:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA449604B8\n\tfor ;\n\tWed, 6 Apr 2022 15:02:38 +0200 (CEST)","from [192.168.1.110] (unknown [27.57.186.178])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8487F482;\n\tWed, 6 Apr 2022 15:02:37 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649250159;\n\tbh=HovoKTZP9f7+wdMX7pt9eEFqRzoobTyhVAx88yyVnTg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=y+UJ8jkJMFR5yAuecQh7epJAkTCR+p1HIpDVoKTLCmZPcrGyxRcYVPPE4S4afT6c4\n\tEW1P+A3LmPDASYnYGOEyf9wmf9Hjugjn0rrRoTm+fKJWqnUBD5zAfwAOHYYiqoVrPB\n\tq/8zNpuQ0abt4iaTzjXl67JrkOA/jw9MYB+7fG5drth5IM2Tfpjj6cT4kZ7JepFC4Y\n\tHdXrKgsLvIKpmJQ8rEkbbCcqqeaVCRHrJC68PzO8Vk8UcQYNmqeERnnX3iQ2oOSag3\n\t9lrq16XgIjnr5fo94yu2c86Dqo6BeafgHLmekmNY6FD8LebkBiuTHPWq7WwRYZf9bK\n\tmcYVuWJuruk2Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649250158;\n\tbh=HovoKTZP9f7+wdMX7pt9eEFqRzoobTyhVAx88yyVnTg=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=lFHtZIMIMIcBGEBMCUr0kKqSsNSWoJ07cf2wykT2JrSVA6K4LN7foiGbi0uvk0OeF\n\tbtcG2Id3lf79g3DF61hPQU3NBzJ+Zc/qRL7k2sLD/SdWWUkn1bRPWcnaEb1QQSqM92\n\tie0qnuaosVH6KRRrOzsbqsmz9CjNWb1vAMptqSWw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lFHtZIMI\"; dkim-atps=neutral","Message-ID":"","Date":"Wed, 6 Apr 2022 18:32:33 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tNaushir Patuck ","References":"<20220406123805.4045928-1-naush@raspberrypi.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Fix typo\n\tin a comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]