[{"id":22619,"web_url":"https://patchwork.libcamera.org/comment/22619/","msgid":"","date":"2022-04-06T12:15:29","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Drop const\n\ton the return value of sizes()","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent\n\nOn 4/6/22 17:23, Laurent Pinchart via libcamera-devel wrote:\n> The sizes() function returns a value, not a reference. There's no need\n> for it to be const.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/internal/camera_sensor.h | 2 +-\n> src/libcamera/camera_sensor.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index 7fb4ededb4a4..b9f4d7867854 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -43,7 +43,7 @@ public:\n> \tconst std::string &id() const { return id_; }\n> \tconst MediaEntity *entity() const { return entity_; }\n> \tconst std::vector &mbusCodes() const { return mbusCodes_; }\n> -\tconst std::vector sizes(unsigned int mbusCode) const;\n> +\tstd::vector sizes(unsigned int mbusCode) const;\n\n\nDoesn't this enable the caller to modify the vector returned by the \nfunction? I guess we don't want that, hence it's returned value has been \nconst in the first place?\n\n> \tSize resolution() const;\n> \tconst std::vector &testPatternModes() const\n> \t{\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 8b4406fe8aed..eaa2da6bad32 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -526,7 +526,7 @@ int CameraSensor::discoverAncillaryDevices()\n> *\n> * \\return The supported frame sizes for \\a mbusCode sorted in increasing order\n> */\n> -const std::vector CameraSensor::sizes(unsigned int mbusCode) const\n> +std::vector CameraSensor::sizes(unsigned int mbusCode) const\n> {\n> \tstd::vector sizes;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA8C1C0F1B\n\tfor ;\n\tWed, 6 Apr 2022 12:15:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 319F765647;\n\tWed, 6 Apr 2022 14:15:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9268D6563F\n\tfor ;\n\tWed, 6 Apr 2022 14:15:34 +0200 (CEST)","from [192.168.1.110] (unknown [27.57.186.178])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 836B8482;\n\tWed, 6 Apr 2022 14:15:33 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649247336;\n\tbh=h9KfDX5qFRjSfYTUTcsKQiIS7XbGOsNNvsPAd+FZ5WU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=irlA5b86HsGBN8fWuPnwiODeYGa4TXL6wOoZKImHKOyGEeVHm620y9K08vvjVvz/T\n\tOXcmEbyd+9/+HHoq4fbX4VcaOfRd/hti1XjJxRMVsylCXesDwrbyW+4n2m2cy+ccC6\n\tI8cdwy+qWVHE2oDjb0amRA7j75g6AEyzGVqF0xH/apnV/GqLFwfiHSky6BqnCwvIJd\n\t6LJbNmrXYT1l58OyWEqEkzfYIn6rl9bLQd4NyyYGwrUttaqu/XHF5Yas7CLELp1Nvg\n\t8Vb8LvSYfcFfFxescIllMiQchuZHfnzOOXaro81NYhQEKNOKePhbh3KOMJbNS273pI\n\tlmNCsv5//ROuw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649247334;\n\tbh=h9KfDX5qFRjSfYTUTcsKQiIS7XbGOsNNvsPAd+FZ5WU=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=AZ81xR0WQLcbkumUm2PaXD+mPqMVLPenSyN1ouhwPdHSRPaxPhX39+/HsaA+PFVvF\n\tNK7kl+ajmCKYzIu3v/oAB6M3gFwbd+MmKNQHe8XyTvoSNZlygr+hjtFKjNASw7iBDi\n\tOOQv7FFe10HiFHf3knGCwtCNcy9iAg/oUaGvp/5k="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AZ81xR0W\"; dkim-atps=neutral","Message-ID":"","Date":"Wed, 6 Apr 2022 17:45:29 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220406115301.4750-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220406115301.4750-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Drop const\n\ton the return value of sizes()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22621,"web_url":"https://patchwork.libcamera.org/comment/22621/","msgid":"","date":"2022-04-06T12:24:53","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Drop const\n\ton the return value of sizes()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nOn Wed, Apr 06, 2022 at 05:45:29PM +0530, Umang Jain wrote:\n> On 4/6/22 17:23, Laurent Pinchart via libcamera-devel wrote:\n> > The sizes() function returns a value, not a reference. There's no need\n> > for it to be const.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > include/libcamera/internal/camera_sensor.h | 2 +-\n> > src/libcamera/camera_sensor.cpp | 2 +-\n> > 2 files changed, 2 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> > index 7fb4ededb4a4..b9f4d7867854 100644\n> > --- a/include/libcamera/internal/camera_sensor.h\n> > +++ b/include/libcamera/internal/camera_sensor.h\n> > @@ -43,7 +43,7 @@ public:\n> > \tconst std::string &id() const { return id_; }\n> > \tconst MediaEntity *entity() const { return entity_; }\n> > \tconst std::vector &mbusCodes() const { return mbusCodes_; }\n> > -\tconst std::vector sizes(unsigned int mbusCode) const;\n> > +\tstd::vector sizes(unsigned int mbusCode) const;\n> \n> \n> Doesn't this enable the caller to modify the vector returned by the \n> function? I guess we don't want that, hence it's returned value has been \n> const in the first place?\n\nIt does, but that's not a problem, because the function returns a vector\nby value, not by reference. The caller gets a copy.\n\n> > \tSize resolution() const;\n> > \tconst std::vector &testPatternModes() const\n> > \t{\n> > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > index 8b4406fe8aed..eaa2da6bad32 100644\n> > --- a/src/libcamera/camera_sensor.cpp\n> > +++ b/src/libcamera/camera_sensor.cpp\n> > @@ -526,7 +526,7 @@ int CameraSensor::discoverAncillaryDevices()\n> > *\n> > * \\return The supported frame sizes for \\a mbusCode sorted in increasing order\n> > */\n> > -const std::vector CameraSensor::sizes(unsigned int mbusCode) const\n> > +std::vector CameraSensor::sizes(unsigned int mbusCode) const\n> > {\n> > \tstd::vector sizes;\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D257C3256\n\tfor ;\n\tWed, 6 Apr 2022 12:24:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D431565643;\n\tWed, 6 Apr 2022 14:24:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 042A66563F\n\tfor ;\n\tWed, 6 Apr 2022 14:24:57 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF77E482;\n\tWed, 6 Apr 2022 14:24:56 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649247898;\n\tbh=06Y+evz7KrRbJDZ2wo1QhqzIHiMUaB5Sgq0OQG0dZv0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=reVwN+js6YUY+pFYhLBGnrP1Xw7tNr7n4Ep7hwyichhLyEtWdt/DN6uGYTmT144NS\n\tQIdGJHljQmBbwnGzrpyhcH6cUTulObgQ2GMbHRLRNqjeXUl2hr/Rr/QLIei9WnTAcI\n\tIPEIeFBYbEZB4SULtnsAt1y2W9pxnCNLj9N2nz57v1Q42lm6V8HuRbPCeqoCI31VaG\n\tR+e/mwfu9Xq+MDfQbnoIm49x8PMxOOYyxFGXpCUEJ8fSn5/ekKRrD/cUJW8tGWAcLi\n\tTpMDf165y4F6iQlacTLefahcZxAUOaV9rYCt2+Ys9Q5Ftf/YLvy+Ca/uSwFs0zbIzx\n\thdui6c9BEQ/7g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649247896;\n\tbh=06Y+evz7KrRbJDZ2wo1QhqzIHiMUaB5Sgq0OQG0dZv0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=I8S3bOQ0RcWBIQ4nqyib++7BfIEEBJrCnH9uBhJ3LWTH0qoLw2vazJ8zu76qBXvxl\n\tRnKYVcWecuGk32synelN9nGYLuhSwja9SbP+HErRrzYCPCXxYCjuLcuWnD7WN84h8T\n\t8gIdFhgub2moNTq/P7LV0kowwWErsu1PAMRCyh3Y="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"I8S3bOQ0\"; dkim-atps=neutral","Date":"Wed, 6 Apr 2022 15:24:53 +0300","To":"Umang Jain ","Message-ID":"","References":"<20220406115301.4750-1-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Drop const\n\ton the return value of sizes()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22624,"web_url":"https://patchwork.libcamera.org/comment/22624/","msgid":"","date":"2022-04-06T13:01:39","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Drop const\n\ton the return value of sizes()","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi,\n\nOn 4/6/22 17:54, Laurent Pinchart wrote:\n> Hi Umang,\n>\n> On Wed, Apr 06, 2022 at 05:45:29PM +0530, Umang Jain wrote:\n>> On 4/6/22 17:23, Laurent Pinchart via libcamera-devel wrote:\n>>> The sizes() function returns a value, not a reference. There's no need\n>>> for it to be const.\n>>>\n>>> Signed-off-by: Laurent Pinchart \n>>> ---\n>>> include/libcamera/internal/camera_sensor.h | 2 +-\n>>> src/libcamera/camera_sensor.cpp | 2 +-\n>>> 2 files changed, 2 insertions(+), 2 deletions(-)\n>>>\n>>> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n>>> index 7fb4ededb4a4..b9f4d7867854 100644\n>>> --- a/include/libcamera/internal/camera_sensor.h\n>>> +++ b/include/libcamera/internal/camera_sensor.h\n>>> @@ -43,7 +43,7 @@ public:\n>>> \tconst std::string &id() const { return id_; }\n>>> \tconst MediaEntity *entity() const { return entity_; }\n>>> \tconst std::vector &mbusCodes() const { return mbusCodes_; }\n>>> -\tconst std::vector sizes(unsigned int mbusCode) const;\n>>> +\tstd::vector sizes(unsigned int mbusCode) const;\n>>\n>> Doesn't this enable the caller to modify the vector returned by the\n>> function? I guess we don't want that, hence it's returned value has been\n>> const in the first place?\n> It does, but that's not a problem, because the function returns a vector\n> by value, not by reference. The caller gets a copy.\n\n\nOkay.  Then I guess it upto the caller to decide whether or not, to \ntreat the returned copy as const or not.\nFor e.g in CIO2Device::getSensorFormat()\n\n     const auto sizes = sensor_->sizes(code);\n\nHence\n\n     Reviewed-by: Umang Jain \n\n>\n>>> \tSize resolution() const;\n>>> \tconst std::vector &testPatternModes() const\n>>> \t{\n>>> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n>>> index 8b4406fe8aed..eaa2da6bad32 100644\n>>> --- a/src/libcamera/camera_sensor.cpp\n>>> +++ b/src/libcamera/camera_sensor.cpp\n>>> @@ -526,7 +526,7 @@ int CameraSensor::discoverAncillaryDevices()\n>>> *\n>>> * \\return The supported frame sizes for \\a mbusCode sorted in increasing order\n>>> */\n>>> -const std::vector CameraSensor::sizes(unsigned int mbusCode) const\n>>> +std::vector CameraSensor::sizes(unsigned int mbusCode) const\n>>> {\n>>> \tstd::vector sizes;\n>>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 099B2C3256\n\tfor ;\n\tWed, 6 Apr 2022 13:01:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E161965643;\n\tWed, 6 Apr 2022 15:01:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA8EA604B8\n\tfor ;\n\tWed, 6 Apr 2022 15:01:46 +0200 (CEST)","from [192.168.1.110] (unknown [27.57.186.178])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E1E8A482;\n\tWed, 6 Apr 2022 15:01:45 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649250107;\n\tbh=4sanvLL8vVn6fTTJ1sdw69DKu7XZWwLU4gO9CXGgAIM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MTun7/BcaCV8h7FCe7ZzDsbpMnd4jzC5K4cdVRtJlNgyWq+LXxVLB5HOCY5X1CZGd\n\t0ySqyhYU1Jbm8IyCcauKWVeB3ecHlW3Md272wyhDBAIlftGLo3JElYmeva67EotN7E\n\t4+XaMpA5aE4mXq6zvDzIaKisnNzyUVatnu/F8SSygg9s3+XsAexofX+LZDGRdJGA6N\n\t+IpjjG3iiLQUpOnE0mqAY1gcqpljnJgUjqb5sQYWSh+2vBGwpZfnDJm6dzzpexvYj0\n\tCACMeRKcovRoBZgFereBheffWTrWYT9Ijsb0ZRfvM495WhhVcH5IORskU+Z/vaErR1\n\tJH3m+a1kFPuZA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649250106;\n\tbh=4sanvLL8vVn6fTTJ1sdw69DKu7XZWwLU4gO9CXGgAIM=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=jxcvz00Dzd5mda9Y6sZoQdu6lKmvcg1kN7Aw9cPaAKnkXfjV+p3+M9X4nd3kfF974\n\tcBzbzfPMcBOM8WgsudUN4HdgnG94Koif/dXza7/HfB5QlS7o7GXAdtQSedYjifS1YJ\n\tOk0cQnUfGr9j9kVt+BYP4xnBXMrzfzW7iq8mFPVI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jxcvz00D\"; dkim-atps=neutral","Message-ID":"","Date":"Wed, 6 Apr 2022 18:31:39 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ","References":"<20220406115301.4750-1-laurent.pinchart@ideasonboard.com>\n\t\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Drop const\n\ton the return value of sizes()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22631,"web_url":"https://patchwork.libcamera.org/comment/22631/","msgid":"<20220406172427.sk4r2ib53gylc5so@uno.localdomain>","date":"2022-04-06T17:24:27","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Drop const\n\ton the return value of sizes()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Wed, Apr 06, 2022 at 02:53:01PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The sizes() function returns a value, not a reference. There's no need\n> for it to be const.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/internal/camera_sensor.h | 2 +-\n> src/libcamera/camera_sensor.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index 7fb4ededb4a4..b9f4d7867854 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -43,7 +43,7 @@ public:\n> \tconst std::string &id() const { return id_; }\n> \tconst MediaEntity *entity() const { return entity_; }\n> \tconst std::vector &mbusCodes() const { return mbusCodes_; }\n> -\tconst std::vector sizes(unsigned int mbusCode) const;\n> +\tstd::vector sizes(unsigned int mbusCode) const;\n> \tSize resolution() const;\n> \tconst std::vector &testPatternModes() const\n> \t{\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 8b4406fe8aed..eaa2da6bad32 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -526,7 +526,7 @@ int CameraSensor::discoverAncillaryDevices()\n> *\n> * \\return The supported frame sizes for \\a mbusCode sorted in increasing order\n> */\n> -const std::vector CameraSensor::sizes(unsigned int mbusCode) const\n> +std::vector CameraSensor::sizes(unsigned int mbusCode) const\n> {\n> \tstd::vector sizes;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66DA0C0F1B\n\tfor ;\n\tWed, 6 Apr 2022 17:24:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C2FFD633A4;\n\tWed, 6 Apr 2022 19:24:32 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A13E604B8\n\tfor ;\n\tWed, 6 Apr 2022 19:24:30 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id D6E5C1BF204;\n\tWed, 6 Apr 2022 17:24:29 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649265872;\n\tbh=dGu8wTYHY7ogk9TlwIYeJSPrtx2mdJLRT72y1XQsJJc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=j5OEO/2gjtiHj8Yez5+W9gHR4fdjPREEpiecCLNDdraTwXM5NkPuf9GP19nOajam9\n\tGWXWzFlNOHfpEZeMcLbBZbUgbCn7RLcaoVjtzwN3r1hRa9qGOpeEfhK/ed11nl6Aoa\n\tbldimvB00iwJxC5wmmZskVs+IjjrgavF3IJxs4VjXc+UpkPx2DzOfMMcO2Vsu4j5Cf\n\tOZZAe5NvY5hU5EpkRHwhuhmgeO4Pq07i4ZVB6qRTl0IPfQyWGRhHED53OJV7F1uF+D\n\tH4zJ6GWjxekWVofSrtMj9NT/AS/iuOplaMdLhlgI1z4yQuTAE137C3vxqDR9KqHeyb\n\trSHJ7d9NfdVNA==","Date":"Wed, 6 Apr 2022 19:24:27 +0200","To":"Laurent Pinchart ","Message-ID":"<20220406172427.sk4r2ib53gylc5so@uno.localdomain>","References":"<20220406115301.4750-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220406115301.4750-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Drop const\n\ton the return value of sizes()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]