[{"id":22603,"web_url":"https://patchwork.libcamera.org/comment/22603/","msgid":"<077d6efa-0d91-b499-7d59-9d969c77a00b@ideasonboard.com>","date":"2022-04-06T05:25:24","subject":"Re: [libcamera-devel] [PATCH] Documentation: Briefly document the\n\tmail-based contribution process","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi,\n\nThank you for the patch.\n\nOn 4/5/22 23:44, Laurent Pinchart via libcamera-devel wrote:\n> While familiarity with git is nowadays common, many developers are not\n> familiar with mail-based patch submission. Add a paragraph to the\n> contribution guide to mention that libcamera uses a mail-based process\n> (which seems to have been taken for granted so much that we forgot to\n> say it explicitly), and link to git-send-email.io to help newcomers\n> setup git-send-email.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> Documentation/contributing.rst | 6 ++++++\n> 1 file changed, 6 insertions(+)\n>\n> diff --git a/Documentation/contributing.rst b/Documentation/contributing.rst\n> index b192c3b43153..8f06e3647e5d 100644\n> --- a/Documentation/contributing.rst\n> +++ b/Documentation/contributing.rst\n> @@ -68,6 +68,12 @@ code that is as easy to read, understand and maintain as possible. This is\n> made possible by a set of :ref:`coding-style-guidelines` that all submissions\n> are expected to follow.\n> \n> +The patch submission process for libcamera is similar to the Linux kernel, and\n> +goes through the `libcamera-devel`_ mailing list. If you have no previous\n> +experience with ``git-send-email``, or just trouble configuring it for your\n\n\ns/trouble/have trouble/ maybe?\n\nReviewed-by: Umang Jain \n\n> +e-mail provider, the sourcehut developers have put together a detailed guide\n> +available at https://git-send-email.io/.\n> +\n> Patches submitted to the libcamera project must be certified as suitable for\n> integration into an open source project. As such libcamera follows the same\n> model as utilised by the Linux kernel, and requires the use of 'Signed-off-by:'\n>\n> base-commit: a2aa1b4c4e441b7b2fb40c976489b109c1de0bc4","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8DFD4C0F1B\n\tfor ;\n\tWed, 6 Apr 2022 05:25:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E427565642;\n\tWed, 6 Apr 2022 07:25:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27552604B6\n\tfor ;\n\tWed, 6 Apr 2022 07:25:30 +0200 (CEST)","from [192.168.1.110] (unknown [27.57.186.178])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 14BF1482;\n\tWed, 6 Apr 2022 07:25:28 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649222731;\n\tbh=FXA4vSbSHyD6UZUbM4dFCipzAZIK5qSLesGblNX3BTc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=m+4BaSMcxliY927Rk83EzkWngLygeiacK4WAa66/zDplr8JnggQwspdqo0yyDvigT\n\tYbIkmAq+3BakahazjwKv0PdFSmKsgZXBkjXHky9lWhivTCYAP0Q5Eo0RSEIWOKCH6t\n\tgXzRzeBhd34OjQ1inhvj+uQlyf3BjhqsrvmTlO5u6rDP5p/efxASorHtRAmq5d+2JN\n\tmB38P6LR96gao94niOtcq+H3lXxEGf5l/Km9UVyboXStFAtmWEKHPK46lA/B8Zjl6W\n\tXcOVTjLeE/Sv/kag/EH/PMPqZWr+pdbgb9pT6JxCf3FB0a07dMtH/5ZKyDo28tuaQU\n\tS5WhF9hknKD+g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649222729;\n\tbh=FXA4vSbSHyD6UZUbM4dFCipzAZIK5qSLesGblNX3BTc=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=lSqL52q6P48Kf6MXni1Ab6W9IJ6Y7Qe9ggvC+11xfW3iiMvhz/QdVuo6SNdmczA6r\n\ta7q7Z3m7nVYEKfelOrwvLZfWDXV87ReXJ9KObt9FC6R0D0hkbQh6+jNHswNfwjjxV7\n\tdJ+A/VAyseml8hyESTUzIVoi727UgVgLVVZDZSzs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lSqL52q6\"; dkim-atps=neutral","Message-ID":"<077d6efa-0d91-b499-7d59-9d969c77a00b@ideasonboard.com>","Date":"Wed, 6 Apr 2022 10:55:24 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220405181428.8485-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220405181428.8485-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] Documentation: Briefly document the\n\tmail-based contribution process","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22609,"web_url":"https://patchwork.libcamera.org/comment/22609/","msgid":"<20220406071305.wnrko2sbxatpkwos@uno.localdomain>","date":"2022-04-06T07:13:05","subject":"Re: [libcamera-devel] [PATCH] Documentation: Briefly document the\n\tmail-based contribution process","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"With the issue pointed out by Umang fixed\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\nOn Tue, Apr 05, 2022 at 09:14:28PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> While familiarity with git is nowadays common, many developers are not\n> familiar with mail-based patch submission. Add a paragraph to the\n> contribution guide to mention that libcamera uses a mail-based process\n> (which seems to have been taken for granted so much that we forgot to\n> say it explicitly), and link to git-send-email.io to help newcomers\n> setup git-send-email.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> Documentation/contributing.rst | 6 ++++++\n> 1 file changed, 6 insertions(+)\n>\n> diff --git a/Documentation/contributing.rst b/Documentation/contributing.rst\n> index b192c3b43153..8f06e3647e5d 100644\n> --- a/Documentation/contributing.rst\n> +++ b/Documentation/contributing.rst\n> @@ -68,6 +68,12 @@ code that is as easy to read, understand and maintain as possible. This is\n> made possible by a set of :ref:`coding-style-guidelines` that all submissions\n> are expected to follow.\n>\n> +The patch submission process for libcamera is similar to the Linux kernel, and\n> +goes through the `libcamera-devel`_ mailing list. If you have no previous\n> +experience with ``git-send-email``, or just trouble configuring it for your\n> +e-mail provider, the sourcehut developers have put together a detailed guide\n> +available at https://git-send-email.io/.\n> +\n> Patches submitted to the libcamera project must be certified as suitable for\n> integration into an open source project. As such libcamera follows the same\n> model as utilised by the Linux kernel, and requires the use of 'Signed-off-by:'\n>\n> base-commit: a2aa1b4c4e441b7b2fb40c976489b109c1de0bc4\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8AFEC0F1B\n\tfor ;\n\tWed, 6 Apr 2022 07:13:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 735126563F;\n\tWed, 6 Apr 2022 09:13:09 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03F45604B8\n\tfor ;\n\tWed, 6 Apr 2022 09:13:08 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 3E1A21BF205;\n\tWed, 6 Apr 2022 07:13:06 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649229189;\n\tbh=FadSn9unVR6zXTJfyfRXqwY6e48rWisNqNe2aM6hhBI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=dRl7QU3K2h/LF7o7KiEmIkfp09nJyK1OYl1KY+bviBt3BhsldT/5OJtnHLnLdwoMl\n\tg5tBGxehMdWCc49FOfdlO8ig+7Owg/3KPXeqVVpmZQSuA9spGGe8Foys1jDbfo1BBH\n\tFLaUJzdEnTUkZi9yQZ/rF/xmSLhmdMycmaPxVSnYXADCPb9j6NyVM8Wldj2hx9NAlb\n\t4Koh3edSNf4JmOQ704Oe7MZEO7i/8qaSMf1fJHATWXUyVYuN/KSfuA/fZRrvRyPbyW\n\tsPwKnCBFQC1moN4uodmqLvwl/ZfQr8tj7bYPGvoMBa26Hq0MAyoy3+UjwqAJ+W6PJH\n\thWFcjHyrFtnDg==","Date":"Wed, 6 Apr 2022 09:13:05 +0200","To":"Laurent Pinchart ","Message-ID":"<20220406071305.wnrko2sbxatpkwos@uno.localdomain>","References":"<20220405181428.8485-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220405181428.8485-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] Documentation: Briefly document the\n\tmail-based contribution process","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]