{"id":15616,"url":"https://patchwork.libcamera.org/api/patches/15616/?format=json","web_url":"https://patchwork.libcamera.org/patch/15616/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220405004215.86340-3-Rauch.Christian@gmx.de>","date":"2022-04-05T00:42:12","name":"[libcamera-devel,v2,2/5] generate fixed- and variable-sized Span Controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6d5a8f32289e4d3ce774d9563de0a5e2f0f306d7","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/?format=json","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15616/mbox/","series":[{"id":3028,"url":"https://patchwork.libcamera.org/api/series/3028/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3028","date":"2022-04-05T00:42:10","name":"generate and use fixed-sized Span Control types","version":2,"mbox":"https://patchwork.libcamera.org/series/3028/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15616/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15616/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 379BEC0F1B\n\tfor ;\n\tTue, 5 Apr 2022 00:42:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 72EF665649;\n\tTue, 5 Apr 2022 02:42:25 +0200 (CEST)","from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C642465641\n\tfor ;\n\tTue, 5 Apr 2022 02:42:22 +0200 (CEST)","from localhost.localdomain ([92.10.251.63]) by mail.gmx.net\n\t(mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id\n\t1Mbir8-1o8xg81Vs6-00dEPN; Tue, 05 Apr 2022 02:42:22 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649119345;\n\tbh=xyoNLYvQ00/5n2V0UrTP044WvBSFrAPN/SMgrg6VLqk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=h1K5LbCnPeJDd5JDqqQjfrfyOIzxVoiDZpXubjHQj6y5WXGI1AtwVcKnmskJs8c7W\n\tcPzszrBufoc6Rzbl2tUyUtY9LiTXWkun1cA48UZjqLnlPxS2qfTsMV8Zc4+0TBpp64\n\t59agZ0l0mCVDRVrqRop0RzdYeIjluue1pXN9V7FVdn0+VAuo6cM3BTlbQgqgNGuTGA\n\tpPuEN8OwjajhlY526TQXas5h4vb871S5LXmDsoei4+7HN0IUpy4bkYd7Blsid4Co8G\n\tO7hMzhiysvQserJagMDMzqjL4mVxzyTrtbBJLI4MQBZ49Dp3TJZG0tnyp7Q4MhZBQj\n\tov4WY4FOCHBfg==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1649119342;\n\tbh=xyoNLYvQ00/5n2V0UrTP044WvBSFrAPN/SMgrg6VLqk=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=TWL/TzaAszo1nR91c2q9I58hibkBKZrfmn56sURSmrW03d8K7CE4MyON9dhzl7b1h\n\tP/v+Z66oGI6lyOwA0TVbgVtS0SSbk5GWXzPMSRdYEsP81m0vu/RLZ9jp7Z7ng4VkqV\n\tB0l/dzmST24OTDLr+BUjkBT/z0XP9RG4pyve+kJ0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"TWL/TzaA\"; dkim-atps=neutral","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 5 Apr 2022 01:42:12 +0100","Message-Id":"<20220405004215.86340-3-Rauch.Christian@gmx.de>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220405004215.86340-1-Rauch.Christian@gmx.de>","References":"<20220405004215.86340-1-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:EHpgIaThWfIhYiEjXAlEqfu37Nc9NoHdyeWFtIimzoGjUvxMqQc\n\tOkj9MDB2hg7Hv3DJ54rAIp28Jwmhogg+EIRwUigzfsXeJKv82vErEYnc+ec484W6lfCvdsx\n\t1EfVo9DopxWgQr1RwH63ydCIshO0piHcO1BTfSqDtedqI3Hig5vUxuSKnlPJAY4E9jBr6PE\n\tMDyBf/zmiFq0V5SfMKn+Q==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:NAc2snPw1uE=:Ioj5Y3ih/LGLOQ+ZZFEmsN\n\tzCxBhtMRgEVnu2twdE6H25owfpaVlT26hqTTBdYFquFNXRIT3aWCuEgxMr+WAyq3hexF36IFV\n\t4b6JpIWf33HJKua3Id+0fVsLFs9MlPKNIjglVoHRaxoL5LPW5iZQB685bBgTvkhWtrTNB3VXx\n\tpO/+i01RcAgKaFdg1pioT2pSsCSzdYomZPgIfEmaEBKP9a8TAQNUI36yCVW/2PnU88eayYRMu\n\tNqHQ3czUpP6BKFxfPaInERqfZPf+oNeuA7l20dwxFt+vO8nEMlqoD+n4toPpP1WdOUuwbtpsF\n\tqydNmPJT4qIHTlzvoOR8GF7sHp5jHNA03uWyahS8jv3uYIfbf3uU4RZcySe499gE9E7HScU0Z\n\tOyZeaSncnEW//muZer5LA+dEmwIhFLDX0/mfVQf++en2qOy4WFa9SQQVxPOwjeo6sm+vxbpDv\n\tbi0TYGIeBrwuuyNN71Hx6oryP23qwev6ft7uCJDt+HbSfQZidWgtN8+jkibRvAWr7gDtuB57h\n\tobC6e00s24sjITrtp1TsKNe6xRRwYk1OYEaZq684UOoQSYH/lh2jTuT5K1r3FCHx+w9YsBPm6\n\tek33NXMiqAzf1KVDz5CFT2o5iJQgEcJ6VPm5w9HaCnLjxVDwYUEoU8I0nERCAMNoB5/h2sqFp\n\tRP6Hy3NnxwKN1EQHHLcLcPPI1srfhCGEsej1FA455c1+mZsaRmUzS4tX4nr3ijbyBE2yXZTJp\n\ttbzjUcCjFdOlZulAantJQ69ZV+qYz4Tvch6CVsdtX15aoGGN6jznUXnY7UbTHzrnzS9UMb1vu\n\taM41uWHUUho+pY3AECw1kA9n/2y8dJi6Pya1xQ3eooMC7vXg9VkeP3A8omNbIBXEWlTvvdtfZ\n\tr2NnCW7DO7Ijj9oCznXfCfSd5GgeCkAIOVDpJF+HRN3ZKO2Q4j5CYcD/ZKUkmG/FKU+5DpB3p\n\tFXeYX2if+aW3dm9Kxw+JohrnXlWwfbb08yIc9e1Vnon4W9nGcFyC9+kR/IFiWJvBfj74XjaT/\n\tgskeuPcIPKLBadNpq4MLhd0Jx/O2jlbU31ZYVJxqVvK6u7FH1hDyTpXmJ5kvW/E8jjU8Usgzy\n\tLuxg9MjBumwv4w=","Subject":"[libcamera-devel] [PATCH v2 2/5] generate fixed- and variable-sized\n\tSpan Controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This defines Controls with a 'size' as either variable-sized Span or as\nfixed-sized Span.\n\nSigned-off-by: Christian Rauch \n---\n utils/gen-controls.py | 33 +++++++++++++++++++++++----------\n 1 file changed, 23 insertions(+), 10 deletions(-)\n\n--\n2.25.1","diff":"diff --git a/utils/gen-controls.py b/utils/gen-controls.py\nindex 3f99b5e2..4cadf160 100755\n--- a/utils/gen-controls.py\n+++ b/utils/gen-controls.py\n@@ -7,6 +7,7 @@\n # gen-controls.py - Generate control definitions from YAML\n\n import argparse\n+from math import prod\n import string\n import sys\n import yaml\n@@ -22,6 +23,26 @@ def format_description(description):\n return '\\n'.join([(line and ' * ' or ' *') + line for line in description])\n\n\n+def get_ctrl_type_format(ctrl):\n+ ctrl_type = ctrl['type']\n+ ctrl_size_arr = ctrl.get('size')\n+ ctrl_is_span = ctrl_size_arr is not None\n+ if ctrl_is_span:\n+ ctrl_span_size = prod(ctrl_size_arr) if len(ctrl_size_arr) > 0 else None\n+\n+ if ctrl_type == 'string':\n+ return 'std::string'\n+ elif ctrl_is_span:\n+ if ctrl_span_size:\n+ # fixed-sized Span\n+ return 'Span'.format(ctrl_type, ctrl_span_size)\n+ else:\n+ # variable-sized Span\n+ return 'Span'.format(ctrl_type)\n+ else:\n+ return ctrl_type\n+\n+\n def generate_cpp(controls):\n enum_doc_start_template = string.Template('''/**\n * \\\\enum ${name}Enum\n@@ -50,11 +71,7 @@ ${description}\n name, ctrl = ctrl.popitem()\n id_name = snake_case(name).upper()\n\n- ctrl_type = ctrl['type']\n- if ctrl_type == 'string':\n- ctrl_type = 'std::string'\n- elif ctrl.get('size'):\n- ctrl_type = 'Span' % ctrl_type\n+ ctrl_type = get_ctrl_type_format(ctrl)\n\n info = {\n 'name': name,\n@@ -135,11 +152,7 @@ def generate_h(controls):\n\n ids.append('\\t' + id_name + ' = ' + str(id_value) + ',')\n\n- ctrl_type = ctrl['type']\n- if ctrl_type == 'string':\n- ctrl_type = 'std::string'\n- elif ctrl.get('size'):\n- ctrl_type = 'Span' % ctrl_type\n+ ctrl_type = get_ctrl_type_format(ctrl)\n\n info = {\n 'name': name,\n","prefixes":["libcamera-devel","v2","2/5"]}