[{"id":22542,"web_url":"https://patchwork.libcamera.org/comment/22542/","msgid":"","date":"2022-04-01T09:32:11","subject":"Re: [libcamera-devel] [PATCH v2 1/1] Documentation: guides:\n\tintroduction: Fixed spelling errors","submitter":{"id":85,"url":"https://patchwork.libcamera.org/api/people/85/","name":"Vedant Paranjape","email":"vedantparanjape160201@gmail.com"},"content":"Hello Kunal,\n\nThis patch looks good, except this thing.\n\nOn Fri, Apr 1, 2022 at 2:45 PM Kunal Agarwal\n wrote:\n>\n> Documentation: guides: introduction: Fixed spelling errors\n\nThis shouldn't be there in the commit message, it is the heading.\nPlease remove it and send a v3. Also, this isn't a patch series, so\n1/1 is really not required.\n\nOther than that, everything looks good. You have my R-b tag after you\nfix the nitpicks.\n\n>\n> Fixed two spelling mistakes in introduction.rst\n> This patch has no functional changes.\n>\n> Signed-off-by: Kunal Agarwal \nReviewed-by: Vedant Paranjape \n\n> ---\n> Documentation/guides/introduction.rst | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/guides/introduction.rst b/Documentation/guides/introduction.rst\n> index e2091797..21880ce7 100644\n> --- a/Documentation/guides/introduction.rst\n> +++ b/Documentation/guides/introduction.rst\n> @@ -9,7 +9,7 @@ collectively as V4L2 (`Video for Linux 2`_) and the `Media Controller`_ API\n> which provide an interface to interact and control media devices.\n>\n> Included in this subsystem are drivers for camera sensors, CSI2 (Camera\n> -Serial Interface) recievers, and ISPs (Image Signal Processors)\n> +Serial Interface) receivers, and ISPs (Image Signal Processors)\n>\n> The usage of these drivers to provide a functioning camera stack is a\n> responsibility that lies in userspace which is commonly implemented separately\n> @@ -18,7 +18,7 @@ by vendors without a common architecture or API for application developers.\n> libcamera provides a complete camera stack for Linux based systems to abstract\n> functionality desired by camera application developers and process the\n> configuration of hardware and image control algorithms required to obtain\n> -desireable results from the camera.\n> +desirable results from the camera.\n>\n> .. _Video for Linux 2: https://www.linuxtv.org/downloads/v4l-dvb-apis-new/userspace-api/v4l/v4l2.html\n> .. _Media Controller: https://www.linuxtv.org/downloads/v4l-dvb-apis-new/userspace-api/mediactl/media-controller.html\n> --\n> 2.25.1\n>\n\nRegards,\nVedant Paranjape","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F19DAC0F1B\n\tfor ;\n\tFri, 1 Apr 2022 09:32:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53E3B65633;\n\tFri, 1 Apr 2022 11:32:26 +0200 (CEST)","from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com\n\t[IPv6:2607:f8b0:4864:20::1136])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C44F604B9\n\tfor ;\n\tFri, 1 Apr 2022 11:32:24 +0200 (CEST)","by mail-yw1-x1136.google.com with SMTP id\n\t00721157ae682-2e5e176e1b6so25602067b3.13\n\tfor ;\n\tFri, 01 Apr 2022 02:32:24 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648805546;\n\tbh=FfnVt8lp8xy6J1VZ4sd6luU2NndilovzaugqiooJLoY=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=C7PnPmaIjKgkPdAAf4ui3Shk7vSfSsx3me68y39L+s0cc2iiWCiJc2aczaQiHEPtz\n\tJ7W2eDcNEeJz5j23nRJOtdn1BGOT5/uIkm/oaMNQH+39wx6fleTCakGHRVOz0vghyD\n\tY8Hw1PU5y42QqevJ+JbivW+RjhMWIX7opeD1fOZOS+Xeqnl6S58EsyUWGIbazxO1nD\n\t1sHrr2wEk+Dz00XBkqqEUMzDjb/5gSCz/ULiCf9DwksxXWLWqIIjO7dsinBiYzAjHN\n\tNmpFmOMUBorP4NMHx+sVFetNRD7oDnHqrDmJHkYN4W2DSR95SPUxZ1C9YEdob4H1KK\n\tGwtnyRFC5v6gQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=XJgsQH3mreCvoI8DLlwWWICgk2Y7AGgRukhrUF+pubY=;\n\tb=Huz4xlv6oMsNIFH3YiISCfV1w0Ryg4d5g+8yH5kj1jkNlI9XymdYfv+1z5qXkdmuiM\n\tpCxjHbZoK7dKwJuoCHbHo3kdb/msjF/f2+1o67QgCthl54Y0jgvJZAuAQseoM33wY0cd\n\tkjzAm+OD2/8awytncu1FvcpQ8Te7RhuIImwpeQuxPmLNCcWPY6pudGJuhjAYOSBjpoKS\n\tyidKGUt+ZfYhRdhwLofVAjLy4SYiY5po0KwdczJbO2r6cymC/v4M/5KM7EIl51Sxunbr\n\te64062MuDnrDyZfgqg5qlAq4OsIivtdeCQC7xH+0e40QO+T0o87Z8XS6QerHkJhk+NbF\n\tWICQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Huz4xlv6\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=XJgsQH3mreCvoI8DLlwWWICgk2Y7AGgRukhrUF+pubY=;\n\tb=hFNZvxrMfNSd8qt0gzQO7SWwP7xfxtB2+GpoRyzuoZru7JQfMZdPmzxIVifSF40j7o\n\tQzbmGimMIlGB/KkJS8c6/uKZqQxvn9i1U6XQWMz10XxdilvwePRl2mc+XHaPCFg9BJW6\n\t/KGJM9BuDtNjqdm0yFrF15kTbk9ks5H2yxBokDNPucpWALo2oVDYsJ9V/Bz+CKtg4Z7W\n\tGyabbqpMWpQURKA0c6lZX80HKgwg3Z7TFgB+6oxC+b9WXztF9hFpRMSCBvtKMqoImrN0\n\twiylWE5jZn3olxujIR+y3ZdBjq/xW3GSZpPaqKy9GNghPVW46u6u5x7GaxMImSJDTl5Y\n\tcnfg==","X-Gm-Message-State":"AOAM532pBQp7D7BOrsTQdQ6++t7KeBHvqtbf6y37MzJBT+FTBzHcbzGx\n\t3zit6Gt4eFLpWLjF79o1F6mxnGQuqg07OFfE9mS8IyXZ305mrw==","X-Google-Smtp-Source":"ABdhPJyLJXieMShVBKz7MQhyQDGOooa7MKmlVx0MGNjd3VkduN0z9fO6RSkCKgYyXAXWxPvJcrRL1+NbIYx4cu2bIJg=","X-Received":"by 2002:a81:5743:0:b0:2e5:bcb2:625 with SMTP id\n\tl64-20020a815743000000b002e5bcb20625mr8856332ywb.34.1648805543279;\n\tFri, 01 Apr 2022 02:32:23 -0700 (PDT)","MIME-Version":"1.0","References":"<20220401091359.21194-1-kunalagarwal1072002@gmail.com>","In-Reply-To":"<20220401091359.21194-1-kunalagarwal1072002@gmail.com>","Date":"Fri, 1 Apr 2022 15:02:11 +0530","Message-ID":"","To":"Kunal Agarwal ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 1/1] Documentation: guides:\n\tintroduction: Fixed spelling errors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Vedant Paranjape via libcamera-devel\n\t","Reply-To":"Vedant Paranjape ","Cc":"LibCamera Devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22543,"web_url":"https://patchwork.libcamera.org/comment/22543/","msgid":"<164880556450.15275.6840170069177772039@Monstersaurus>","date":"2022-04-01T09:32:44","subject":"Re: [libcamera-devel] [PATCH v2 1/1] Documentation: guides:\n\tintroduction: Fixed spelling errors","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Kuanl,\n\nQuoting Kunal Agarwal via libcamera-devel (2022-04-01 10:13:59)\n> Documentation: guides: introduction: Fixed spelling errors\n\nHrm ... this appears to be duplicated from the title? Have you added the\nline twice in your commit message?\n\n(Can easily be dropped when applying, but you only need the title once\nin your commit, and git-send-email will put that in the $SUBJECT of the\nemail).\n\nWe normally write subject/commit titles as imperative sentences as in:\n \"Fix spelling throughout the guide\"\n\nrather than in the past tense as if it has already happened. That is\nbecause the patch is itself actioning the command or instruction set out\nby the title.\n\nBut the fixes to the document look ok, and is otherwise fine so:\n\nReviewed-by: Kieran Bingham \n\n> \n> Fixed two spelling mistakes in introduction.rst\n> This patch has no functional changes.\n> \n> Signed-off-by: Kunal Agarwal \n> ---\n> Documentation/guides/introduction.rst | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/Documentation/guides/introduction.rst b/Documentation/guides/introduction.rst\n> index e2091797..21880ce7 100644\n> --- a/Documentation/guides/introduction.rst\n> +++ b/Documentation/guides/introduction.rst\n> @@ -9,7 +9,7 @@ collectively as V4L2 (`Video for Linux 2`_) and the `Media Controller`_ API\n> which provide an interface to interact and control media devices.\n> \n> Included in this subsystem are drivers for camera sensors, CSI2 (Camera\n> -Serial Interface) recievers, and ISPs (Image Signal Processors)\n> +Serial Interface) receivers, and ISPs (Image Signal Processors)\n> \n> The usage of these drivers to provide a functioning camera stack is a\n> responsibility that lies in userspace which is commonly implemented separately\n> @@ -18,7 +18,7 @@ by vendors without a common architecture or API for application developers.\n> libcamera provides a complete camera stack for Linux based systems to abstract\n> functionality desired by camera application developers and process the\n> configuration of hardware and image control algorithms required to obtain\n> -desireable results from the camera.\n> +desirable results from the camera.\n> \n> .. _Video for Linux 2: https://www.linuxtv.org/downloads/v4l-dvb-apis-new/userspace-api/v4l/v4l2.html\n> .. _Media Controller: https://www.linuxtv.org/downloads/v4l-dvb-apis-new/userspace-api/mediactl/media-controller.html\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D8FFC0F1B\n\tfor ;\n\tFri, 1 Apr 2022 09:32:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD70265634;\n\tFri, 1 Apr 2022 11:32:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37A34633A5\n\tfor ;\n\tFri, 1 Apr 2022 11:32:47 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CABFEF8;\n\tFri, 1 Apr 2022 11:32:46 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648805568;\n\tbh=YOHORWitY4yBPjrB2XLv05t9k1NoVf248qo2ESL592U=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=euV5n8IBaLlpP4PPYRU2wMMLhoK6393EqienLf63WBH1LCZ8JttmAn5voffql+rlv\n\tfeaRCEKRcLkc3sCbB2kXcgMtqKEgjq8fVJjXBBvi3eILSN5fK++Bg9oYSQRX/U3EHQ\n\t3UW7WbJ/6T91o6eWkq7FqKfPROOWzXATrpChR050v+ldx+iEWf97w0LXT7UwcFPRPY\n\ttYW2w4NzU+ceA5PiIYWnKSams7ohnXtusJ6ZAa4Q3pSkgtnt6FfQGEItZ8uL4Y/6Zk\n\tyCE3f+IR2p/Lo3O4qsdMZLWTEXEX2sVmTCyHxItScZWzVN5jTk/Rgk29MFkkAfWPBQ\n\tdSBqzg++f+HIA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648805566;\n\tbh=YOHORWitY4yBPjrB2XLv05t9k1NoVf248qo2ESL592U=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=bImWYFFY5dI65b1gqHnBBm7gquelkbiamCFKhcwBs5TwslY/e7XiyaeNbV1D3KpVQ\n\tHPPXG7TyOCCaSu3FUsUY4eyTQj5URgpMwMwg8e8cpWwbP7I9/jJXOE87ujOdi36lfN\n\tjQ6XpL9IKggj1H1whZIxNf5pLkUVknIygGKqZvRo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"bImWYFFY\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220401091359.21194-1-kunalagarwal1072002@gmail.com>","References":"<20220401091359.21194-1-kunalagarwal1072002@gmail.com>","To":"Kunal Agarwal ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 01 Apr 2022 10:32:44 +0100","Message-ID":"<164880556450.15275.6840170069177772039@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 1/1] Documentation: guides:\n\tintroduction: Fixed spelling errors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"vedantparanjape160201@gmail.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]