[{"id":22538,"web_url":"https://patchwork.libcamera.org/comment/22538/","msgid":"","date":"2022-04-01T07:11:39","subject":"Re: [libcamera-devel] [PATCH] Fixed 2 typos","submitter":{"id":85,"url":"https://patchwork.libcamera.org/api/people/85/","name":"Vedant Paranjape","email":"vedantparanjape160201@gmail.com"},"content":"Hello Kunal,\n\nThanks for the patch. There's some issue with the subject and commit\nmessage. The subject line can be something like:\n\nFixed two spelling mistakes in introduction.rst\n\nOn Fri, Apr 1, 2022 at 12:29 PM Kunal Agarwal\n wrote:\n>\n> From: KunalA18 \n>\n\nI don't think this should be a part of the patch.\n\n> Fixed 2 typos in introduction.rst\n\nI think this can be better written,\n\n> Fix spelling mistakes in introduction.rst.\n\nYou can as well add \"This patch has no functional changes.\" at the end.\n\n>\n> Signed-off-by: Kunal Agarwal \n> ---\n> Documentation/guides/introduction.rst | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/guides/introduction.rst b/Documentation/guides/introduction.rst\n> index e2091797..21880ce7 100644\n> --- a/Documentation/guides/introduction.rst\n> +++ b/Documentation/guides/introduction.rst\n> @@ -9,7 +9,7 @@ collectively as V4L2 (`Video for Linux 2`_) and the `Media Controller`_ API\n> which provide an interface to interact and control media devices.\n>\n> Included in this subsystem are drivers for camera sensors, CSI2 (Camera\n> -Serial Interface) recievers, and ISPs (Image Signal Processors)\n> +Serial Interface) receivers, and ISPs (Image Signal Processors)\n>\n> The usage of these drivers to provide a functioning camera stack is a\n> responsibility that lies in userspace which is commonly implemented separately\n> @@ -18,7 +18,7 @@ by vendors without a common architecture or API for application developers.\n> libcamera provides a complete camera stack for Linux based systems to abstract\n> functionality desired by camera application developers and process the\n> configuration of hardware and image control algorithms required to obtain\n> -desireable results from the camera.\n> +desirable results from the camera.\n>\n> .. _Video for Linux 2: https://www.linuxtv.org/downloads/v4l-dvb-apis-new/userspace-api/v4l/v4l2.html\n> .. _Media Controller: https://www.linuxtv.org/downloads/v4l-dvb-apis-new/userspace-api/mediactl/media-controller.html\n> --\n> 2.25.1\n>\n\nRegards,\nVedant Paranjape","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B95D0C3256\n\tfor ;\n\tFri, 1 Apr 2022 07:11:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1644165632;\n\tFri, 1 Apr 2022 09:11:53 +0200 (CEST)","from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com\n\t[IPv6:2607:f8b0:4864:20::b2d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C0D8633A5\n\tfor ;\n\tFri, 1 Apr 2022 09:11:52 +0200 (CEST)","by mail-yb1-xb2d.google.com with SMTP id j2so3561379ybu.0\n\tfor ;\n\tFri, 01 Apr 2022 00:11:51 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648797113;\n\tbh=LxVLfmfYUsHUmUf8zU21pdiMB8pyA2SIAC6wFOrUMuU=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=zNE1VMonXi//IW4LyfRmft9993GpbQtbBsTAtDEpQEFTz5GpLFU5HH4a6noWz9TGF\n\tZ1crmlYSwBoVWJqSfZNoE9DHyxS3ADZuYDKN2/9Icz0IipYJeD94W8p77wsxPGRQBq\n\tNWiHl3rn9/iWoKQ8erjwG+bawXTWsqLHrP5FM091vVQgpSEYzpCWn4E0wXHeyeGz18\n\t0S+Da3jIyWvNIFFAVsgDNRKnWB8A+Hqxr1TSUKcKSZBQuWAuruf0LZdMWl+JNlsRvV\n\t5wmFlBMTXFrn+Rnu2lQZOgbH2DT1aYhReoRES2E1y96SThSxd3GV/asCL2pXgLXdiI\n\t+Ta5FZpikAIGA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=oQxLVDUPXk9+h+d7b8r8KSZ/LpSIrArrznIe9akjtqc=;\n\tb=KYL9Kh8VJzxWHoIBUmbLhHnOGm7qPXMpu/lVK6W72LTp+qhjOaBPztbnIfLVpS4hGv\n\tF906Nql8H3yXSkzdNCAJvcdQMftWpBlL6o/pqC0KcuBv/w7IXFUuvE7WAH5gualSbjzl\n\t0180GzFUSr8eXcxtvy478FdIWSfJdWy6N/OTuGOhyBhFJJuZeiQs/Mj4ITkq2D2/jgRt\n\tchB/Q6/rCegNdgveFJdKTrg3+q+qK14p/MvHZAC6oL13I/ytWKDkEzpGPHqHtkDzq7H8\n\tHJ2t7mHTzUrNviHV83uR6VDrWVPh9VBvmDWikqGGeQWn37TIU/l0pPRw25qjAFHKdU2j\n\txZ0w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KYL9Kh8V\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=oQxLVDUPXk9+h+d7b8r8KSZ/LpSIrArrznIe9akjtqc=;\n\tb=3c9TKZZeNyCSvE9RbI+hRAjMi8Rs8R1TDBzHSlNcxAR7mMPUtqWU3v1exaBOzZsZCl\n\tLVADACwC1BHbEhCcqsY1akMWjeylR4Jbphv1gmWtNN2LELkhI3lYEwhLQJDnkT0bemC8\n\t+WiZLERlkY7PuE8NsEr4MDNirkXO31Sx2blthvJAAXVfsKsnQf1LBL6CaivCViYFOZK5\n\tvMKB+lqq8pdOK2bIbrpSZ4xniwOJlUMtGJ6glNWooaQ/fr1lcGmJ+qUjNKEQ8enjBLof\n\ti/jzABopgtGoBAXDH7ra1LPb1GF1ntkvO2LhoAC/80eFbpmIV5Mxr9/IMResMF4myjau\n\t61KA==","X-Gm-Message-State":"AOAM531gChe7xaNhVNgffnhmEhYKRU8d8/ufWg7VQZ0NxBnqdZKUVare\n\tTZTXKtmmclYhzoHvdL312eMwG+xxd3DsC1eAUag=","X-Google-Smtp-Source":"ABdhPJyW2UrLQ1OmbLHHiTQGYAGHmPkgxSXKBv4aBlCL9BxJgCzZvIQe7I87o+N79lYdvzBqwEyVVKx8v1F4wfWnSWQ=","X-Received":"by 2002:a25:d11:0:b0:634:7393:1392 with SMTP id\n\t17-20020a250d11000000b0063473931392mr7835160ybn.557.1648797110607;\n\tFri, 01 Apr 2022 00:11:50 -0700 (PDT)","MIME-Version":"1.0","References":"<20220401065933.16580-1-kunalagarwal1072002@gmail.com>","In-Reply-To":"<20220401065933.16580-1-kunalagarwal1072002@gmail.com>","Date":"Fri, 1 Apr 2022 12:41:39 +0530","Message-ID":"","To":"Kunal Agarwal ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] Fixed 2 typos","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Vedant Paranjape via libcamera-devel\n\t","Reply-To":"Vedant Paranjape ","Cc":"LibCamera Devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22539,"web_url":"https://patchwork.libcamera.org/comment/22539/","msgid":"<51732de4-e437-be23-85eb-2a4a7dd11d20@ideasonboard.com>","date":"2022-04-01T07:15:31","subject":"Re: [libcamera-devel] [PATCH] Fixed 2 typos","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kunal\n\nThank you for the patch.\n\nOn 4/1/22 12:29, Kunal Agarwal via libcamera-devel wrote:\n> From: KunalA18 \n\n\nIs your git-author-name assigned to KunalA18? It's preferred to use your \nfull-name instead, the same which appears as the sender of this mail. I \nassume the From: line should go-away then.\n\n>\n> Fixed 2 typos in introduction.rst\n\n\nUsually the commit message are written as follows:\n\n  : : ${brief}\n\n${description}\n\nYou can easily check the style of commit messages in the past by using:\n\n     $> git log Documentation/guides/introduction.rst\n\nSo in this case, the commit message should look similar to one in\nhttps://git.linuxtv.org/libcamera.git/commit/?id=030e6f3\n\n\n>\n> Signed-off-by: Kunal Agarwal \n\n\nMeanwhile, the patch looks good to me but I'll hold my R-b tag for now.\n\n> ---\n> Documentation/guides/introduction.rst | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/guides/introduction.rst b/Documentation/guides/introduction.rst\n> index e2091797..21880ce7 100644\n> --- a/Documentation/guides/introduction.rst\n> +++ b/Documentation/guides/introduction.rst\n> @@ -9,7 +9,7 @@ collectively as V4L2 (`Video for Linux 2`_) and the `Media Controller`_ API\n> which provide an interface to interact and control media devices.\n> \n> Included in this subsystem are drivers for camera sensors, CSI2 (Camera\n> -Serial Interface) recievers, and ISPs (Image Signal Processors)\n> +Serial Interface) receivers, and ISPs (Image Signal Processors)\n> \n> The usage of these drivers to provide a functioning camera stack is a\n> responsibility that lies in userspace which is commonly implemented separately\n> @@ -18,7 +18,7 @@ by vendors without a common architecture or API for application developers.\n> libcamera provides a complete camera stack for Linux based systems to abstract\n> functionality desired by camera application developers and process the\n> configuration of hardware and image control algorithms required to obtain\n> -desireable results from the camera.\n> +desirable results from the camera.\n> \n> .. _Video for Linux 2: https://www.linuxtv.org/downloads/v4l-dvb-apis-new/userspace-api/v4l/v4l2.html\n> .. _Media Controller: https://www.linuxtv.org/downloads/v4l-dvb-apis-new/userspace-api/mediactl/media-controller.html","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 91163C0F1B\n\tfor ;\n\tFri, 1 Apr 2022 07:15:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C703665633;\n\tFri, 1 Apr 2022 09:15:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35773604B9\n\tfor ;\n\tFri, 1 Apr 2022 09:15:37 +0200 (CEST)","from [IPV6:2401:4900:1f3e:7c04:a8b2:dad8:ae1a:780] (unknown\n\t[IPv6:2401:4900:1f3e:7c04:a8b2:dad8:ae1a:780])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D61BA2F7;\n\tFri, 1 Apr 2022 09:15:35 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648797338;\n\tbh=JDYXQktp8Qt99qfqIwKKHzybkFDuU5V3ZlamBlr/5Rs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=T4P8I+ZKvRdEGYBYVkIFNKbB/Wrd/nfKQgUQxx8l5cP9mpBXY+JVu3gMwx302fk65\n\t3jsb0XYpL3MunFyN1exWsnf7WdBZgP3y/1qbwVqFUSPY0KzMWkxDEMFWhkgwifXGLw\n\tbYRtxhCjELCM5uIEmDUVnf0xt/v+1Uncphb4zejMwX9aQaTnyoyEtwq5ydcoiR2P/T\n\toMJkLDQ2OBTMNk8wSVLjvTiIjd13hTlPA5H98wRA8VB48AL53MmAtJCsVtm850kOQY\n\te0P/9Yvt0uW6WQzoSTk8k473EtJwoOUjK5/UFzOc7s6y2saCVWaDRdE0CNdZQLSHw3\n\tzKeYopK8V9eEg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648797336;\n\tbh=JDYXQktp8Qt99qfqIwKKHzybkFDuU5V3ZlamBlr/5Rs=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=A90epYJyv0uZptafRmKEWZMMs132skCGlICxoSGS3iwwhlDQBZreYIhjr6Piqw469\n\trccup9oSnLAAyumBL6Lo2jsikrxHTKPNS47MOON2PMutE5UdKjV5jrUiOPY4rvrh7b\n\tSuCQnhVXC2hWhT/Vbh9BztFzCuD8n4b8510T+uvM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"A90epYJy\"; dkim-atps=neutral","Message-ID":"<51732de4-e437-be23-85eb-2a4a7dd11d20@ideasonboard.com>","Date":"Fri, 1 Apr 2022 12:45:31 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Kunal Agarwal ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220401065933.16580-1-kunalagarwal1072002@gmail.com>","In-Reply-To":"<20220401065933.16580-1-kunalagarwal1072002@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] Fixed 2 typos","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"vedantparanjape160201@gmail.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]