[{"id":22550,"web_url":"https://patchwork.libcamera.org/comment/22550/","msgid":"<20220401132840.h3fgxkaccdnfenil@uno.localdomain>","date":"2022-04-01T13:28:40","subject":"Re: [libcamera-devel] [PATCH 1/5] define Span size as shape vector","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Christian,\n\nOn Fri, Apr 01, 2022 at 01:06:12AM +0100, Christian Rauch via libcamera-devel wrote:\n> This follows the convention in other Tensor APIs. Since all tensors are\n> represented as a Span with a single dimension, values provided in 'size'\n> are interpreted as fixed-size Spans, while an empty array (\"[]\") will be\n> interpreted as variable-sized Span.\n>\n\nI like this change!\n\nReviewed-by: Jacopo Mondi \n\n> Signed-off-by: Christian Rauch \n> ---\n> src/libcamera/control_ids.yaml | 2 +-\n> src/libcamera/property_ids.yaml | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 9d4638ae..c3f593a1 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -291,7 +291,7 @@ controls:\n> transformation. The 3x3 matrix is stored in conventional reading\n> order in an array of 9 floating point values.\n>\n> - size: [3x3]\n> + size: [3,3]\n>\n> - ScalerCrop:\n> type: Rectangle\n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 12ecbce5..47c350ed 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -497,7 +497,7 @@ controls:\n>\n> - PixelArrayOpticalBlackRectangles:\n> type: Rectangle\n> - size: [n]\n> + size: []\n> description: |\n> The pixel array region(s) which contain optical black pixels\n> considered valid for calibration purposes.\n> @@ -592,7 +592,7 @@ controls:\n>\n> - PixelArrayActiveAreas:\n> type: Rectangle\n> - size: [n]\n> + size: []\n> description: |\n> The PixelArrayActiveAreas property defines the (possibly multiple and\n> overlapping) portions of the camera sensor readable pixel matrix\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C853C3256\n\tfor ;\n\tFri, 1 Apr 2022 13:28:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 442A265633;\n\tFri, 1 Apr 2022 15:28:44 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96723633A6\n\tfor ;\n\tFri, 1 Apr 2022 15:28:42 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 1B73D2001A;\n\tFri, 1 Apr 2022 13:28:41 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648819724;\n\tbh=vdeumOSW+/Z9QegJwY3Oqu4bDb8cUzb01G3aJ6Zwc/M=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=B7RKEmfU/bbD4CgNU7faPnbEc5M3qnruVPchNY4BVpzZt1IPo5cHtw/1PhPjvd97A\n\tMg8+M6+gFOc6g7gXanHNDH5S/wTbQtaKqtiG5vMR6LHymtMqqf1R9Ly6Yr8Cu44pSF\n\t4x52Jm05g9AI2g7nn5ObAEK7o9Kp2jjOfbEVxBU/9lEHki5WMNmgek0NMoVTg9+y7W\n\tfHETWuLl4nnzozzewb2ksyNGyW3MCo1tvKPF1+8QIDlZVnc3PCeovw5vDPm6Y4r3Tj\n\tqZwchQ7a6vRIC4KELl/lukyQVsVte59xkOTC597tWzkDcyKprXW0XW0bkATaGOdRhp\n\tGz6eZai8IQPXg==","Date":"Fri, 1 Apr 2022 15:28:40 +0200","To":"Christian Rauch ","Message-ID":"<20220401132840.h3fgxkaccdnfenil@uno.localdomain>","References":"<20220401000616.12976-1-Rauch.Christian@gmx.de>\n\t<20220401000616.12976-2-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220401000616.12976-2-Rauch.Christian@gmx.de>","Subject":"Re: [libcamera-devel] [PATCH 1/5] define Span size as shape vector","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]